Re: [Resin-interest] Isapi_dll 3.0.18 vs 3.0.22

2006-12-27 Thread Leland, Robert
I checked out the 3.0 Branch and it appears that the bug that
was introduced in 3.0.19 is still there:

I believe on Line 479 of protocol.cpp

   write_client_buffer(r, s-read_buf + s-read_offset, sublen);
should be

   if (write_client_buffer(r, s-read_buf + s-read_offset,
sublen)  0)
 return -1; 

Otherwise the condition of !r-WriteClient(r-ConnID, buffer, sentlen,
HSE_IO_SYNC)
is not detected as it was in 3.0.18. 

Otherwise write_client_buffer should return void if the return value is
unused !

-Rob 

_
Robert Leland INTEGRITYOne (Formerly PRIZUM)
P: (703) 581-6522   1900 Campus Commons Drive
F: (703) 476-7405Reston, VA 20191
[EMAIL PROTECTED]


BUSINESS CONSULTING | TECHNOLOGY SOLUTIONS | INNOVATION RD

 

 -Original Message-
 From: [EMAIL PROTECTED] 
 [mailto:[EMAIL PROTECTED] On Behalf Of Matt Pangaro
 Sent: Tuesday, December 26, 2006 11:43
 To: General Discussion for the Resin application server
 Subject: Re: [Resin-interest] Isapi_dll 3.0.18 vs 3.0.22
 
 Robert,
 Try out the latest snapshot, if you have an environment in 
 which you can test this. It should turn into a 3.0.23 release 
 very soon, and has a fix for chunked encoding with cached 
 responses. (i.e. it shouldn't be setting the header for 
 chunked encoding.) 3.0.22 also contained some plugin and 
 chunked encoding fixes, but the static file behavior you're 
 seeing is because of the header issue that's fixed in the snaphot.
 
 Please report anything else you do see with the current 
 snapshot so that any fix that might arise from it can be 
 include in .23.
 
 Hope that helps,
 
 Matt Pangaro
 Lokitech  software . strategy . design 
 http://www.lokitech.com m. 1.301.728.6906 f. 1.815.364.0656 
 e. [EMAIL PROTECTED]
 
 
 Leland, Robert wrote:
  On about 50% of our machines using IE 6.0 is not reloading 
  JavaScript/Image files.
  We are running HTTPS/SSL over IIS 6.0 SP2.
  (IE loads the file the first time but when IE Checks to see if the 
  files in its cache are up to date I believe the reload fails)
  
  When we switched to the 3.0.18 version of the ISAPI DLL,
and used either 3.0.21 or 3.0.22 PRO core the application 
 works like 
  a champ !
 
 
 ___
 resin-interest mailing list
 resin-interest@caucho.com
 http://maillist.caucho.com/mailman/listinfo/resin-interest
 

___
resin-interest mailing list
resin-interest@caucho.com
http://maillist.caucho.com/mailman/listinfo/resin-interest


[Resin-interest] Isapi_dll 3.0.18 vs 3.0.22

2006-12-26 Thread Leland, Robert
On about 50% of our machines using IE 6.0 is not reloading
JavaScript/Image files.
We are running HTTPS/SSL over IIS 6.0 SP2.
(IE loads the file the first time but when IE Checks to see if the files
in its cache are up to date
I believe the reload fails)

When we switched to the 3.0.18 version of the ISAPI DLL,
  and used either 3.0.21 or 3.0.22 PRO core the application works like a
champ !

In  protocol.cpp I noticed the return value for 
   write_client_buffer
Is NOT being checked.

This differs from 3.0.18 when that block of code was inline.

I believe on Line 479 of protocol.cpp

write_client_buffer(r, s-read_buf + s-read_offset,
sublen);
should be

if (write_client_buffer(r, s-read_buf + s-read_offset,
sublen)  0)
  return -1; 

Otherwise the condition of !r-WriteClient(r-ConnID, buffer, sentlen,
HSE_IO_SYNC)
is not detected as it was in 3.0.18. 

Also 3.0.18 would cse_close(s, response) in cse_write_response

3.0.21 uses cse_close(s, write) after send_data completes.

These are the differences I see.

I should also mention that there are 14 other production servers from
other
projects here that are using the 3.0.14 ISAPI DLL.

When I heard about that 6 months ago I thought they were asking for
trouble,
And I deployed with the FULL PRO 3.0.18 w/o trouble except the OOM
problem.

Trying to go to 3.0.21/3.0.22 has been very frustrating, any feedback
would
be helpful.

 

_
Robert Leland INTEGRITYOne (Formerly PRIZUM)
P: (703) 581-6522   1900 Campus Commons Drive
F: (703) 476-7405Reston, VA 20191
[EMAIL PROTECTED]


BUSINESS CONSULTING | TECHNOLOGY SOLUTIONS | INNOVATION RD

 

___
resin-interest mailing list
resin-interest@caucho.com
http://maillist.caucho.com/mailman/listinfo/resin-interest


Re: [Resin-interest] Isapi_dll 3.0.18 vs 3.0.22

2006-12-26 Thread Matt Pangaro
Robert,
Try out the latest snapshot, if you have an environment in which you can 
test this. It should turn into a 3.0.23 release very soon, and has a fix 
for chunked encoding with cached responses. (i.e. it shouldn't be 
setting the header for chunked encoding.) 3.0.22 also contained some 
plugin and chunked encoding fixes, but the static file behavior you're 
seeing is because of the header issue that's fixed in the snaphot.

Please report anything else you do see with the current snapshot so that 
any fix that might arise from it can be include in .23.

Hope that helps,

Matt Pangaro
Lokitech  software . strategy . design
http://www.lokitech.com
m. 1.301.728.6906
f. 1.815.364.0656
e. [EMAIL PROTECTED]


Leland, Robert wrote:
 On about 50% of our machines using IE 6.0 is not reloading
 JavaScript/Image files.
 We are running HTTPS/SSL over IIS 6.0 SP2.
 (IE loads the file the first time but when IE Checks to see if the files
 in its cache are up to date
 I believe the reload fails)
 
 When we switched to the 3.0.18 version of the ISAPI DLL,
   and used either 3.0.21 or 3.0.22 PRO core the application works like a
 champ !


___
resin-interest mailing list
resin-interest@caucho.com
http://maillist.caucho.com/mailman/listinfo/resin-interest