Hi,
We were using old post-review utility which was supporting following review
option.
parser.add_option(--file-list,
dest=file_list, default=None,
help=use file list instead of all files in
changelist)
parser.add_option(--ignore-diff-size,
But i can see this version available with post-review util, just to tell
you its 0.4 version of post-review.
Here are the lines of code written for file_list option
# process diff file list
if options.file_list:
dfl_array = {}
new_description = []
Sorry version 0.4 i am not sure but post-review util contain this lines :(
On Mon, May 14, 2012 at 1:06 PM, Nilesh Jaiswal nileshj...@gmail.comwrote:
But i can see this version available with post-review util, just to tell
you its 0.4 version of post-review.
Here are the lines of code
These exist in yours, but that must be some modified copy. We never had
those options in post-review, and we've never removed any options.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Mon, May 14, 2012
is this patch version mentioned in the email you are talking about.? Or
something else.
What do i need to do?
On Mon, May 14, 2012 at 10:48 AM, Nilesh Jaiswal nileshj...@gmail.comwrote:
If you are asking about the version path util then here it is.
patch -version
patch 2.5.4
Copyright
Hi Christian,
Many thanks for your answer. The diff file were generated by codereview, so
I expected it to be compatible with reviewboard. I will ask my colleagues
to check what end of line character they are using.
Best regards,
Jean-Noël
--
Want to help the Review Board project? Donate
When I say get latest I'm referring to the Get Latest Revision option
in P4V. I don't use p4 directly, so I'm not sure what command it maps to.
Right click in your workspace view on the folder you want to get latest
changes, and click Get Latest Revision. This will pull down the latest
changes in
Oh! The interdiff was the key thing.
So, yes, viewing a diff between uploaded diffs will give you that result.
There's really not anything we can do about this. What that is really doing
is taking the patched set of files in r1 and diffing them against the
patched set in r2. Since there are
Status: New
Owner:
Labels: Type-Enhancement Priority-Medium
New issue 2600 by anthon.d...@gmail.com: Add metrics on
review_request_box.html
http://code.google.com/p/reviewboard/issues/detail?id=2600
What version are you running?
RBTools 0.4.1
ReviewBoard 1.6.5
What's the URL of the
Status: New
Owner:
Labels: Type-Enhancement Priority-Medium
New issue 2601 by anthon.d...@gmail.com: Add Report modules on pdf file
http://code.google.com/p/reviewboard/issues/detail?id=2601
What version are you running?
RBTools 0.4.1
ReviewBoard 1.6.5
What's the URL of the page this
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 2602 by anthon.d...@gmail.com: Add ClearCase Versions/Labels on
source and destination Files
http://code.google.com/p/reviewboard/issues/detail?id=2602
What version are you running?
RBTools 0.4.1
ReviewBoard 1.6.5
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 2603 by anthon.d...@gmail.com: Add ClearCase Versions/Labels on
source and destination Files
http://code.google.com/p/reviewboard/issues/detail?id=2603
What version are you running?
RBTools 0.4.1
ReviewBoard 1.6.5
Comment #10 on issue 929 by sed...@gmail.com: reviewboard should not alter
the diff file
http://code.google.com/p/reviewboard/issues/detail?id=929
All git diff format support tickets were closed as duplicate of this
ticket. I don't know why but the need for git diff format support has more
Updates:
Status: Duplicate
Mergedinto: 2602
Comment #1 on issue 2603 by trowb...@gmail.com: Add ClearCase
Versions/Labels on source and destination Files
http://code.google.com/p/reviewboard/issues/detail?id=2603
(No comment was entered for this change.)
--
You received this
Comment #1 on issue 2602 by trowb...@gmail.com: Add ClearCase
Versions/Labels on source and destination Files
http://code.google.com/p/reviewboard/issues/detail?id=2602
Issue 2603 has been merged into this issue.
--
You received this message because you are subscribed to the Google Groups
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 2604 by eyuw...@gmail.com: Why do we find opened files ('Affected
files') by using pattern matching instead of 'p4 opened -c CHANGESET'?
http://code.google.com/p/reviewboard/issues/detail?id=2604
* NOTE: Do not post
Updates:
Status: Duplicate
Mergedinto: 1457
Comment #1 on issue 2601 by trowb...@gmail.com: Add Report modules on pdf
file
http://code.google.com/p/reviewboard/issues/detail?id=2601
(No comment was entered for this change.)
--
You received this message because you are
Comment #6 on issue 1457 by trowb...@gmail.com: Add ability to define
metrics and generate reports
http://code.google.com/p/reviewboard/issues/detail?id=1457
Issue 2600 has been merged into this issue.
--
You received this message because you are subscribed to the Google Groups
Status: New
Owner:
Labels: Type-Enhancement Priority-Medium
New issue 2605 by ctoo...@gmail.com: Add a Back to File List link under
each diff in Diff Viewer
http://code.google.com/p/reviewboard/issues/detail?id=2605
*NOTE: If you have a patch, please submit it to
Updates:
Status: NeedInfo
Comment #11 on issue 929 by chip...@gmail.com: reviewboard should not alter
the diff file
http://code.google.com/p/reviewboard/issues/detail?id=929
Hi sedatk,
The reason they were closed is that they're all symptoms of Review Board
inadvertently stripping
20 matches
Mail list logo
