Re: View Diff has issue in 1.7.2, and fine in 1.7.1

2013-01-27 Thread Christian Hammond
I haven't been able to reproduce this. Can you get me a stack trace from the JavaScript console, showing what's calling what? I also need to know which page you're hitting this on, and a repro case. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org

Re: emial setting problem

2013-01-27 Thread xf0407
Hi, Thanks for your answer. now I find a way to solve it. I modify this file./usr/local/lib/python2.6/dist-packages/ReviewBoard-1.7.2-py2.6.egg/reviewboard/notifications/email.py In function send_review_email, I modify from_email = a...@xxx.com. now RB will send email use

Re: how long does a rb-site upgrade take?

2013-01-27 Thread Mukund Rajamannar
I use Postgres. The upgrade progressed from this step and then I had the issue with assets (CSS/JS) not showing up. Googling around helped me add an entry in my Apache conf file to add an alias for 'static'. Review board works afterwards, but I frequently get errors like this. ---

Re: how long does a rb-site upgrade take?

2013-01-27 Thread Christian Hammond
We keep seeing this reported, but it never ends up making any sense. It's attempting to get the mercurial version from their module, which is just a string, but I gets None instead. We haven't figured out why or how that happens. However, we will be putting out a release tonight, and we'll

Re: View Diff has issue in 1.7.2, and fine in 1.7.1

2013-01-27 Thread Tao Zhou
New to reviewboard, I am not quite familiar with the system and bug fix process, I have submitted a codereview: http://reviews.reviewboard.org/r/3804/ Regards, Tao On Sunday, January 27, 2013 4:29:26 AM UTC+8, Christian Hammond wrote: Hi Tao, Can you post the fix up on

Re: Issue 2878 in reviewboard: SVN diff patch fails if file has diff around svn keyword

2013-01-27 Thread reviewboard
Updates: Status: NeedInfo Comment #1 on issue 2878 by chip...@gmail.com: SVN diff patch fails if file has diff around svn keyword http://code.google.com/p/reviewboard/issues/detail?id=2878 Hi Sudhir, We have unit tests that should cover this exact case, and I tried your example

Re: Issue 2878 in reviewboard: SVN diff patch fails if file has diff around svn keyword

2013-01-27 Thread reviewboard
Comment #2 on issue 2878 by sudhir.s...@gmail.com: SVN diff patch fails if file has diff around svn keyword http://code.google.com/p/reviewboard/issues/detail?id=2878 Hi Christian, I think below is what you are asking. Yes it is listed. $ svn propget svn:keywords hello_world.c id FYI, I

Re: Issue 2876 in reviewboard: Diff currently unavailable.

2013-01-27 Thread reviewboard
Updates: Status: Fixed Owner: chip...@gmail.com Labels: Milestone-Release1.7.x Component-DiffViewer Comment #3 on issue 2876 by chip...@gmail.com: Diff currently unavailable. http://code.google.com/p/reviewboard/issues/detail?id=2876 Fixed on release-1.7.x