Re: post-review only update testing-done field for existing request

2013-09-30 Thread Steve
I haven't tried this, but does it work if you include the --change-only option? --steve On Saturday, September 28, 2013 8:04:36 PM UTC-7, Lynn Lin wrote: Environment: Git source code repostior y Linux ubuntu RBTools:0.5.2 Reviewboard:1.6.1 I try to *ONLY* update testing-done

Re: post-review only update testing-done field for existing request

2013-09-30 Thread Christian Hammond
--change-only really is intended only for Perforce, and will not work for this case. Today, you cannot set only a field without uploading a diff using post-review or rbt post. That would need to be added. It would be pretty easy, though, to write a custom script using the RBTools Python API to

Web API: review-requests?changenum=NNNN stopped working in 1.7.14

2013-09-30 Thread Steve
I upgraded one of our servers to 1.7.14 and this url no longer works: ${rb_url}/api/review-requests?changenum= When I attempt to access that now I get fail Object does not exist 100 That url works on 1.7.12. Is this an intentional change in the web api, a bug, or am I doing something

Re: Web API: review-requests?changenum=NNNN stopped working in 1.7.14

2013-09-30 Thread David Trowbridge
The problem is with a trailing slash. Try this URL: /api/review-requests/?changenum=N -David On Mon, Sep 30, 2013 at 7:03 PM, Steve seide.al...@gmail.com wrote: I upgraded one of our servers to 1.7.14 and this url no longer works: ${rb_url}/api/review-requests?changenum= When I

Re: Web API: review-requests?changenum=NNNN stopped working in 1.7.14

2013-09-30 Thread Steve
That seems to work. Curious that it worked previously without the '/'. Thanks! --Steve On Monday, September 30, 2013 4:31:23 PM UTC-7, David Trowbridge wrote: The problem is with a trailing slash. Try this URL: /api/review-requests/?changenum=N -David On Mon, Sep 30, 2013 at 7:03 PM,

Re: Web API: review-requests?changenum=NNNN stopped working in 1.7.14

2013-09-30 Thread David Trowbridge
Steve, I think we used to redirect requests that didn't have the /, but that caused two requests to the web server for every API hit. The documentation has always said that trailing slashes were required, so we didn't consider it to be a breaking change, but I guess we ought to have made it more

Issue 3102 in reviewboard: Something broke! (Error 500) on adding review

2013-09-30 Thread reviewboard
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3102 by ralf.hab...@gmail.com: Something broke! (Error 500) on adding review http://code.google.com/p/reviewboard/issues/detail?id=3102 *** READ THIS BEFORE POSTING! *** *** You must complete this form in its entirety, or