Re: Integrating a custom SCM / non-numeric change IDs

2009-05-15 Thread Christian Hammond
First, I want to be 100% sure that we're having the same definition of this field. This field represents an upstream server-side ID that is tied to that specific set of changes, and will exist up to and possibly past the point where the change is committed, regardless of how many updates are made

Re: Integrating a custom SCM / non-numeric change IDs

2009-05-15 Thread Alexey Morozov
On Friday 15 May 2009 14:46:27 Christian Hammond wrote: First, I want to be 100% sure that we're having the same definition of this field. This field represents an upstream server-side ID that is tied to that specific set of changes, and will exist up to and possibly past the point where the

Re: Integrating a custom SCM / non-numeric change IDs

2009-05-14 Thread Alexey Morozov
Hi! On Tuesday 12 May 2009 04:41:06 Christian Hammond wrote: As for the DB change, we have a nice database migration system in place. You pretty much need to just make the change to the appropriate Model class(es) and then add an Evolution definition (see reviews/evolutions/*.py for

Integrating a custom SCM / non-numeric change IDs

2009-05-11 Thread Thilo-Alexander Ginkel
Hello everybody, while attempting to add some basic support for a proprietary SCM to Review Board / post-review I stumbled over one issue that I'm currently uncertain how to solve: The SCM I'm integrating uses change identifiers, which are not numeric. Instead arbitrary strings are used, which

Re: Integrating a custom SCM / non-numeric change IDs

2009-05-11 Thread Thilo-Alexander Ginkel
On May 11, 9:55 pm, Christian Hammond chip...@chipx86.com wrote: With this SCM, is the change identifier a server-stored ID that contains the description and other information for Review Board to parse? Or is it more like an atomic ID representing that change that gets pushed to the server

Re: Integrating a custom SCM / non-numeric change IDs

2009-05-11 Thread Christian Hammond
On Mon, May 11, 2009 at 2:32 PM, Thilo-Alexander Ginkel thilo.gin...@gmail.com wrote: On May 11, 9:55 pm, Christian Hammond chip...@chipx86.com wrote: With this SCM, is the change identifier a server-stored ID that contains the description and other information for Review Board to parse?