Re: Post review with combination of binary + txt file does not work

2010-02-02 Thread Kunjal
Any info. on this one? Thanks ! On Jan 26, 6:50 pm, Kunjal kunjal.par...@gmail.com wrote: Hello Chris, With RB 1.0.5.1, when someone post the review with 1 binary file + 1 txt file, RB should filter out the binary file but txt file should be able to get reviewed in RB. We are getting

Re: Post review with combination of binary + txt file does not work

2010-02-02 Thread Christian Hammond
Hi, Sorry, missed the previous e-mail. On Perforce, we actually use 'diff' itself to determine if it's a binary file. We do this by running diff on the old file and the new modified file. If it tells us that it's a binary file, then we mark it as such, but otherwise we treat it as a plain text

Post review with combination of binary + txt file does not work

2010-01-26 Thread Kunjal
Hello Chris, With RB 1.0.5.1, when someone post the review with 1 binary file + 1 txt file, RB should filter out the binary file but txt file should be able to get reviewed in RB. We are getting below message when the user look at the RB web after posting review. When I test RB, I could post