Considering all Visual Studio 2008 new source code files have initial
unicode BOM characters, any diff of source files from a default VS
install should do.
I am surprised *anyone* that uses VS can use post-review.
I set up a new user on the latest RBTools and had them modify a
checked in file and
The red rectangle doesn't come from us. This is a Pygments thing, so you'd
need to talk to them about changing that. We have no control over it.
It seems that change to post-review for encoding in UTF-8 breaks a lot of
things, so I'm going to remove it and look into an alternative fix.
Christian
FYI: I ran an older version of post-review on the same code and it
uploaded just fine.
I easy_install -U rbtools and ran post-review -r # and it failed
w/ the UnicodeDecodeError.
Again, the files post-review is having a hard time with use the
default encoding of Visual Studio 2008.
After running
On Thursday 25 February 2010 01:55:42 Pv wrote:
I am pretty sure this aborts in RBTools itself before it ever gets to
the server.
Again, a manual upload of the diff file to the server works fine.
Could http://reviews.reviewboard.org/r/1298/ have caused this?
Regards,
Thilo
--
Want to help
Yes, I just commented that out and the upload was successful.
Pv
On Feb 25, 12:25 pm, Thilo-Alexander Ginkel th...@ginkel.com
wrote:
On Thursday 25 February 2010 01:55:42 Pv wrote:
I am pretty sure this aborts in RBTools itself before it ever gets to
the server.
Again, a manual upload of
It should have been:
return content_type, content.encode('utf-8', 'ignore')
Pv
On Feb 25, 12:43 pm, Pv p...@swooby.com wrote:
Yes, I just commented that out and the upload was successful.
Pv
On Feb 25, 12:25 pm, Thilo-Alexander Ginkel th...@ginkel.com
wrote:
On Thursday 25
Actually, that doesn't work either.
This stuff has always blown my mind a bit:
s = 'La Pe\xf1a'
print s
La Pe±a
s.encode('utf8')
Traceback (most recent call last):
File stdin, line 1, in module
UnicodeDecodeError: 'ascii' codec can't decode byte 0xf1 in position
5: ordinal not
Sorry for the poor formatting (couldn't find how to edit the previous
post):
s = 'La Pe\xf1a'
print s
La Pe±a
s.encode('utf8')
Traceback (most recent call last):
File stdin, line 1, in module
UnicodeDecodeError: 'ascii' codec can't decode byte 0xf1 in position
5: ordinal not in
1.1 alpha 2 (dev)
I am pretty sure this aborts in RBTools itself before it ever gets to
the server.
Again, a manual upload of the diff file to the server works fine.
Pv
On Feb 23, 5:27 pm, Christian Hammond chip...@chipx86.com wrote:
Hi Pv,
Which version of Review Board is this?
Christian
NOTE: If I manually browse to my reviewboard server and upload the
diff it accepts it no problem.
I am not doing anything to intentionally encode these files beyond the
default VS2K8 encoding.
Pv
On Feb 23, 4:20 pm, Pv p...@swooby.com wrote:
I have installed a fresh copy of Win7 x64 and VS2K8.
10 matches
Mail list logo
