Re: Git style mercurial diffs with file renames don't work

2014-09-23 Thread Colin Caughie
I submitted the patch that enabled Mercurial rename support a few years ago. For the most part it works well but there are definitely cases where it doesn't and I haven't been able to pin them all down. I think it may be something to do with whether the original file was added or changed in

Re: Git style mercurial diffs with file renames don't work

2014-09-19 Thread Christian Hammond
Hi Sara, Definitely looks like a bug in how we're representing the revisions. Would you be able to file a bug and provide a full diff (of a trivial file or something) that we can use to reproduce the problem? Thanks, Christian -- Christian Hammond - christ...@beanbaginc.com Review Board -

Re: Git style mercurial diffs with file renames don't work

2014-09-19 Thread Sara Rayburn
Done. Note that I was unable to attach the diffs to the bug as Issue attachment quota exceeded but they are very short, and I included the contents. https://code.google.com/p/reviewboard/issues/detail?id=3573thanks=3573ts=1411132852 Thanks. Sara On Friday, September 19, 2014 1:10:12 AM

Re: Git style mercurial diffs with file renames don't work

2014-09-19 Thread Christian Hammond
Yeah... we're having a lot of trouble getting Google to bump up our very limited attachment quota. We might be switching bug trackers in the future. Thanks for the bug! Christian -- Christian Hammond - christ...@beanbaginc.com Review Board - https://www.reviewboard.org Beanbag, Inc. -