Re: This file contains only whitespace changes (CC pragmas ignored by diff viewer)

2020-05-23 Thread Christian Hammond
Yep, same issue then. It’s not about the content, but rather an issue at file boundaries and based on certain conditions in the diff file itself. The new algorithm addresses those cases. Christian On Sat, May 23, 2020 at 03:40 Vlad wrote: > This is an interdiff, "Changes between revision 1

Re: This file contains only whitespace changes (CC pragmas ignored by diff viewer)

2020-05-23 Thread Vlad
This is an interdiff, "Changes between revision 1 and 2". I have found your reply on a similar problem: "The new algorithm is being tested in the 4.0 work, and once we know it's stable, the plan is to backport to 3.0.x. It's a full rewrite designed to address these sorts of problems, but

Re: This file contains only whitespace changes (CC pragmas ignored by diff viewer)

2020-05-22 Thread Christian Hammond
Is this a standard diff, or an interdiff? We don’t do anything special with pragmas that should impact diff rendering. They could be getting caught up in the interdiff bug, but it’s just text like any other where diffs are concerned. Christian On Tue, May 19, 2020 at 09:01 Vlad S. wrote: >

This file contains only whitespace changes (CC pragmas ignored by diff viewer)

2020-05-19 Thread Vlad S.
Hi, RB diff ignores CPP pragmas treating them as whitespace. Please see the screenshot attached. The diff viewer says "This file contains only whitespace changes". RB version is 3.0.15, installed from sources using pip install and virtualenv. Diff viewer system settings: "*.c, *.cc, *.h,