Re: How to do not allow to close review if issue still open?

[MoonWalker]

Any ideas, recommendations, suggestions? 

On Tuesday, October 20, 2015 at 5:11:27 PM UTC+11, MoonWalker wrote:
>
> Is it possible to do not allow to close any review if 1+ issues still 
> open? BTW I am using RB 2.0.20
>
> Cheers
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: How to do not allow to close review if issue still open?

[David Trowbridge]

This is not directly possible without making some modifications.

However, a similar workflow may cover what you're looking for, and be even
more accurate (since just closing a review request doesn't mean much if
you've still pushed the code to source control).

https://github.com/reviewboard/rbtools/blob/master/contrib/tools/git-hook-check-approval
is a script that can be installed as a git pre-receive hook to check each
commit for a "Reviewed at http://...; and will check the "approval" state
of the review request. By default, "approval" means 2+ "ship it"s and no
open issues, but that can be tweaked with extensions. This will block any
commits that have not gone through code review.

You can then also use
https://github.com/reviewboard/rbtools/blob/master/contrib/tools/git-hook-set-submitted
as a post-receive hook, to automatically close review requests as
"submitted" once the code is successfully pushed.

-David

On Thu, Oct 22, 2015 at 8:17 PM, MoonWalker 
wrote:

> Any ideas, recommendations, suggestions?
>
> On Tuesday, October 20, 2015 at 5:11:27 PM UTC+11, MoonWalker wrote:
>
>> Is it possible to do not allow to close any review if 1+ issues still
>> open? BTW I am using RB 2.0.20
>>
>> Cheers
>>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.