Re: rbt post error message

2016-03-30 Thread David Trowbridge 
If you can run "p4 info" from the command-line, then I'm not sure what's
going on. Something is different from when you run it and when rbt is
trying to run it.

-David

On Tue, Mar 22, 2016 at 4:50 PM Caesar  wrote:

> I have p4 client installed. How is p4 command-line tool different from p4
> client?
>
> Anyway, I googled p4 command-line tool and found this
> https://www.perforce.com/downloads/helix#product-6 and installed it.
>
> I am still getting the same error.  I see the new installation directory
> in the path environment variable.
>
> But when I just run 'p4 info' in the command line, I see some output, such
> as client name, host, current directory and p4 server information and
> license.
>
> I am not sure what the issue is.
>
> Thanks.
>
>
>
>
>
>
> On Tuesday, March 22, 2016 at 7:30:14 PM UTC-4, David Trowbridge wrote:
>
>> I think what's happening is it's unable to run "p4 info". Do you have the
>> p4 command-line tool installed?
>>
>> -David
>>
>> On Tue, Mar 22, 2016 at 3:30 PM Caesar  wrote:
>>
> I ran it with rbt post --debug. Here is the output.
>>>
>>> >>> RBTools 0.7.1 alpha 0 (dev)
>>> >>> Python 2.7.6 (default, Nov 10 2013, 19:24:18) [MSC v.1500 32 bit
>>> (Intel)]
>>> >>> Running on Windows-7-6.1.7601-SP1
>>> >>> Home = C:\Users\\AppData\Roaming
>>> >>> Current directory = D:\code\branch123
>>> >>> Checking for a Subversion repository...
>>> >>> Unable to execute "svn help": skipping SVN
>>> >>> Checking for a Git repository...
>>> >>> Unable to execute "git --help" or "git.cmd --help": skipping Git
>>> >>> Checking for a Mercurial repository...
>>> >>> Unable to execute "hg --help": skipping Mercurial
>>> >>> Checking for a CVS repository...
>>> >>> Unable to execute "cvs": skipping CVS
>>> >>> Checking for a Perforce repository...
>>> >>> Running: p4 info
>>> >>> Checking for a Plastic repository...
>>> >>> Unable to execute "cm version": skipping Plastic
>>> >>> Checking for a ClearCase repository...
>>> >>> Unable to execute "cleartool help": skipping ClearCase
>>> >>> Checking for a Bazaar repository...
>>> >>> Unable to execute "bzr help": skipping Bazaar
>>> >>> Checking for a TFS repository...
>>> >>> Unable to execute "tf help": skipping TFS
>>> ERROR: The current directory does not contain a checkout from a
>>> supported source code repository.
>>>
>>>
>>>
>>> On Tuesday, March 22, 2016 at 5:57:27 PM UTC-4, Caesar wrote:

 Hi.

 I am trying to set up the reviewboard with Perforce. So I installed
 review board in the apache in Linux and configured it with mysql. Now I am
 trying to set up a client tool so that I can generate/upload a diff into
 the review board server.

 So I checked out one file for testing and created a change list in p4.
 When I run rbt post , I am getting the following error.
 I already created .reviewboardrc file (under
 D:\code\brand123) with a reviewboard url, repository and p4 information.

 D:\code\brand123>rbt post
 ERROR: The current directory does not contain a checkout from a
 supported source code repository.

 I am using 0.7.4 rbtool and windows.

 Is there any configuration that I need to check?

 Thanks.

>>> --
>>> Supercharge your Review Board with Power Pack:
>>> https://www.reviewboard.org/powerpack/
>>> Want us to host Review Board for you? Check out RBCommons:
>>> https://rbcommons.com/
>>> Happy user? Let us know! https://www.reviewboard.org/users/
>>> ---
>>> You received this message because you are subscribed to the Google
>>> Groups "reviewboard" group.
>>>
>> To unsubscribe from this group and stop receiving emails from it, send an
>>> email to reviewboard...@googlegroups.com.
>>
>>
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>> --
>> -David
>>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: SVN hook for Checking Reviews before commit

2016-03-30 Thread David Trowbridge 
John,

I'd recommend basing your script on the git pre-receive hook at
https://github.com/reviewboard/rbtools/blob/master/contrib/tools/git-hook-check-approval

Basically, in your pre-commit hook, parse the commit message to find a
review request link, and then use that to check the approval API to see if
that review request has been approved.

If you do implement this, we'd be happy to accept it and ship it in the
contrib/ directory of rbtools.

-David

On Mon, Mar 28, 2016 at 2:55 AM john levin  wrote:

> Hi,
>
> Could someone let me know how to integrate ReviewBoard with SVN using
> pre-commit. I googled and got some info that API's can be useful but i dont
> know how to use those API's.
>
> Any Documentations on this ?
>
> /BR
> John
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
-- 
-David

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.