Re: Index failure after upgrade to ReviewBoard 2.5.16

2017-10-09 Thread Christian Hammond 
Can you send me the fields.py file as you now have it? That output
contradicts the logic that should be in the code.

Christian


On Mon, Oct 9, 2017 at 03:29 'Rob Backhurst' via reviewboard <
reviewboard@googlegroups.com> wrote:

> Hi Christian,
>
> See the new output below...
>
> Removing all documents from your index because you said so.
> All documents removed.
> Indexing 558 users
> Indexing 27878 review requests
> ERROR:root:Error updating reviews using default
> Traceback (most recent call last):
>   File
> "/usr/lib/python2.7/site-packages/haystack/management/commands/update_index.py",
> line 189, in handle_label
> self.update_backend(label, using)
>   File
> "/usr/lib/python2.7/site-packages/haystack/management/commands/update_index.py",
> line 234, in update_backend
> do_update(backend, index, qs, start, end, total, self.verbosity)
>   File
> "/usr/lib/python2.7/site-packages/haystack/management/commands/update_index.py",
> line 89, in do_update
> backend.update(index, current_qs)
>   File
> "/usr/lib/python2.7/site-packages/haystack/backends/whoosh_backend.py",
> line 191, in update
> doc = index.full_prepare(obj)
>   File "/usr/lib/python2.7/site-packages/haystack/indexes.py", line 207,
> in full_prepare
> self.prepared_data = self.prepare(obj)
>   File "/usr/lib/python2.7/site-packages/haystack/indexes.py", line 198,
> in prepare
> self.prepared_data[field.index_fieldname] = field.prepare(obj)
>   File "/usr/lib/python2.7/site-packages/haystack/fields.py", line 160, in
> prepare
> return self.convert(super(CharField, self).prepare(obj))
>   File "/usr/lib/python2.7/site-packages/haystack/fields.py", line 88, in
> prepare
> raise SearchFieldError("The model '%s' ('%s' -- %s) does not have a
> model_attr '%s' (%s)." % (repr(obj), repr(current_object),
> current_object.__class__.__name__, attr, hasattr(current_object, attr)))
> SearchFieldError: The model ''
> ('' -- ReviewRequest) does not have a
> model_attr 'commit' (True).
> Traceback (most recent call last):
>   File "/usr/bin/rb-site", line 9, in 
> load_entry_point('ReviewBoard==2.5.16', 'console_scripts', 'rb-site')()
>   File "/usr/lib/python2.7/site-packages/reviewboard/cmdline/rbsite.py",
> line 1964, in main
> command.run()
>   File "/usr/lib/python2.7/site-packages/reviewboard/cmdline/rbsite.py",
> line 1884, in run
> site.run_manage_command(args[0], args[1:])
>   File "/usr/lib/python2.7/site-packages/reviewboard/cmdline/rbsite.py",
> line 712, in run_manage_command
> execute_from_command_line([__file__, cmd] + params)
>   File
> "/usr/lib/python2.7/site-packages/django/core/management/__init__.py", line
> 399, in execute_from_command_line
> utility.execute()
>   File
> "/usr/lib/python2.7/site-packages/django/core/management/__init__.py", line
> 392, in execute
> self.fetch_command(subcommand).run_from_argv(self.argv)
>   File "/usr/lib/python2.7/site-packages/django/core/management/base.py",
> line 242, in run_from_argv
> self.execute(*args, **options.__dict__)
>   File "/usr/lib/python2.7/site-packages/django/core/management/base.py",
> line 285, in execute
> output = self.handle(*args, **options)
>   File
> "/usr/lib/python2.7/site-packages/reviewboard/reviews/management/commands/index.py",
> line 19, in handle
> call_command('rebuild_index', interactive=False)
>   File
> "/usr/lib/python2.7/site-packages/django/core/management/__init__.py", line
> 159, in call_command
> return klass.execute(*args, **defaults)
>   File "/usr/lib/python2.7/site-packages/django/core/management/base.py",
> line 285, in execute
> output = self.handle(*args, **options)
>   File
> "/usr/lib/python2.7/site-packages/haystack/management/commands/rebuild_index.py",
> line 16, in handle
> call_command('update_index', **options)
>   File
> "/usr/lib/python2.7/site-packages/django/core/management/__init__.py", line
> 159, in call_command
> return klass.execute(*args, **defaults)
>   File "/usr/lib/python2.7/site-packages/django/core/management/base.py",
> line 285, in execute
> output = self.handle(*args, **options)
>   File
> "/usr/lib/python2.7/site-packages/haystack/management/commands/update_index.py",
> line 184, in handle
> return super(Command, self).handle(*items, **options)
>   File "/usr/lib/python2.7/site-packages/django/core/management/base.py",
> line 385, in handle
> label_output = self.handle_label(label, **options)
>   File
> "/usr/lib/python2.7/site-packages/haystack/management/commands/update_index.py",
> line 189, in handle_label
> self.update_backend(label, using)
>   File
> "/usr/lib/python2.7/site-packages/haystack/management/commands/update_index.py",
> line 234, in update_backend
> do_update(backend, index, qs, start, end, total, self.verbosity)
>   File
> "/usr/lib/python2.7/site-packages/haystack/management/commands/update_index.py",
> line 89, in do_update
> backend.update(index, current_qs)
>   File
>

Jenkins CI integration on RB 3 Plz

2017-10-09 Thread MoonWalker 
I read that RB 3 beta 2 added support for Travis CI and Circle CI. Could 
you please add support for Jenkins as well. Not sure if that can be done 
with Webhooks in the mean time

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board 3.0 beta 2 is out -- beta testers needed!

2017-10-09 Thread MoonWalker 

When do you guys think that RB 3 will be *ready* for production?
On Saturday, October 7, 2017 at 4:15:54 AM UTC+11, Christian Hammond wrote:
>
> Hi everyone,
>
> We just put out a release of Review Board 3.0 beta 2. There's a lot of new 
> features in this release, and at this point we're feature-complete, 
> focusing on bug fixing. Some of the highlights include:
>
> * Highlighting of new updates and discussions on review requests
> * Ability to revoke Ship Its
> * Ability to require the reviewer's verification on closed issues
> * OAuth2 Provider support
> * Emoji shortcodes
> * CircleCI and Travis CI integration
> * On-the-fly search indexing
> * Lots more
>
> We'd like to get the RC1 (Release Candidate 1) release out in two weeks. 
> In the meantime, we're focusing on bug fixing and documentation.
>
> We could really use your help on testing this release (on a test server, 
> not production!). Installing the beta on a test server, along with a copy 
> of your database, and ensuring everything works will help us to ship a 
> better final release of 3.0.
>
> If you use or develop in-house extensions, we'd like your feedback as 
> well. We've done a lot of work on our extension capabilities, adding 
> improved support for custom fields and review request actions, and we could 
> use feedback here.
>
> Our release announcement for beta 2 is here: 
> https://www.reviewboard.org/news/2017/10/05/review-board-3-0-beta-2-here/
>
> Christian
>
> -- 
> Christian Hammond
> President/CEO of Beanbag 
> Makers of Review Board 
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Jenkins CI integration on RB 3 Plz

2017-10-09 Thread Christian Hammond 
Hi,

I definitely want to do Jenkins support. It won't happen by 3.0 but it's on
my radar. Supporting another CI system requires a lot of work, so we still
have to see what's involved. There's also a question of what we'll be
shipping with Review Board and what we'll be shipping with Power Pack,
which we need to discuss internally.

Christian


On Mon, Oct 9, 2017 at 13:59 MoonWalker  wrote:

> I read that RB 3 beta 2 added support for Travis CI and Circle CI. Could
> you please add support for Jenkins as well. Not sure if that can be done
> with Webhooks in the mean time
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
-- 
-- 
Christian Hammond
President/CEO of Beanbag
Makers of Review Board

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board 3.0 beta 2 is out -- beta testers needed!

2017-10-09 Thread Christian Hammond 
The plan is to get RC1 out in 2-3 weeks, based on what bugs get reported to
us. This is basically what we'll end up shipping as 3.0 (minus some docs
and bug fixes/visual polish). So if you'd like, you can install RC1 when
it's out. Just test first on a non-production server.

Christian


On Mon, Oct 9, 2017 at 14:00 MoonWalker  wrote:

>
> When do you guys think that RB 3 will be *ready* for production?
>
> On Saturday, October 7, 2017 at 4:15:54 AM UTC+11, Christian Hammond wrote:
>>
>> Hi everyone,
>>
>> We just put out a release of Review Board 3.0 beta 2. There's a lot of
>> new features in this release, and at this point we're feature-complete,
>> focusing on bug fixing. Some of the highlights include:
>>
>> * Highlighting of new updates and discussions on review requests
>> * Ability to revoke Ship Its
>> * Ability to require the reviewer's verification on closed issues
>> * OAuth2 Provider support
>> * Emoji shortcodes
>> * CircleCI and Travis CI integration
>> * On-the-fly search indexing
>> * Lots more
>>
>> We'd like to get the RC1 (Release Candidate 1) release out in two weeks.
>> In the meantime, we're focusing on bug fixing and documentation.
>>
>> We could really use your help on testing this release (on a test server,
>> not production!). Installing the beta on a test server, along with a copy
>> of your database, and ensuring everything works will help us to ship a
>> better final release of 3.0.
>>
>> If you use or develop in-house extensions, we'd like your feedback as
>> well. We've done a lot of work on our extension capabilities, adding
>> improved support for custom fields and review request actions, and we could
>> use feedback here.
>>
>> Our release announcement for beta 2 is here:
>> https://www.reviewboard.org/news/2017/10/05/review-board-3-0-beta-2-here/
>>
>> Christian
>>
>> --
>> Christian Hammond
>> President/CEO of Beanbag 
>> Makers of Review Board 
>>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
-- 
-- 
Christian Hammond
President/CEO of Beanbag
Makers of Review Board

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board 3.0 beta 2 is out -- beta testers needed!

2017-10-09 Thread MoonWalker 
I  am guessing that base on the testers feedback we way see additional RCs 
before the final release

On Tuesday, October 10, 2017 at 8:12:20 AM UTC+11, Christian Hammond wrote:
>
> The plan is to get RC1 out in 2-3 weeks, based on what bugs get reported 
> to us. This is basically what we'll end up shipping as 3.0 (minus some docs 
> and bug fixes/visual polish). So if you'd like, you can install RC1 when 
> it's out. Just test first on a non-production server.
>
> Christian
>
>
> On Mon, Oct 9, 2017 at 14:00 MoonWalker  > wrote:
>
>>
>> When do you guys think that RB 3 will be *ready* for production?
>>
>> On Saturday, October 7, 2017 at 4:15:54 AM UTC+11, Christian Hammond 
>> wrote:
>>>
>>> Hi everyone,
>>>
>>> We just put out a release of Review Board 3.0 beta 2. There's a lot of 
>>> new features in this release, and at this point we're feature-complete, 
>>> focusing on bug fixing. Some of the highlights include:
>>>
>>> * Highlighting of new updates and discussions on review requests
>>> * Ability to revoke Ship Its
>>> * Ability to require the reviewer's verification on closed issues
>>> * OAuth2 Provider support
>>> * Emoji shortcodes
>>> * CircleCI and Travis CI integration
>>> * On-the-fly search indexing
>>> * Lots more
>>>
>>> We'd like to get the RC1 (Release Candidate 1) release out in two weeks. 
>>> In the meantime, we're focusing on bug fixing and documentation.
>>>
>>> We could really use your help on testing this release (on a test server, 
>>> not production!). Installing the beta on a test server, along with a copy 
>>> of your database, and ensuring everything works will help us to ship a 
>>> better final release of 3.0.
>>>
>>> If you use or develop in-house extensions, we'd like your feedback as 
>>> well. We've done a lot of work on our extension capabilities, adding 
>>> improved support for custom fields and review request actions, and we could 
>>> use feedback here.
>>>
>>> Our release announcement for beta 2 is here: 
>>> https://www.reviewboard.org/news/2017/10/05/review-board-3-0-beta-2-here/
>>>
>>> Christian
>>>
>>> -- 
>>> Christian Hammond
>>> President/CEO of Beanbag 
>>> Makers of Review Board 
>>>
>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/d/optout.
>>
> -- 
> -- 
> Christian Hammond
> President/CEO of Beanbag
> Makers of Review Board
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Jenkins CI integration on RB 3 Plz

2017-10-09 Thread MoonWalker 
IMO Jenkins is by far one of the most well Known and used CI and adding it 
will really help boost you guys

On Tuesday, October 10, 2017 at 8:10:24 AM UTC+11, Christian Hammond wrote:
>
> Hi,
>
> I definitely want to do Jenkins support. It won't happen by 3.0 but it's 
> on my radar. Supporting another CI system requires a lot of work, so we 
> still have to see what's involved. There's also a question of what we'll be 
> shipping with Review Board and what we'll be shipping with Power Pack, 
> which we need to discuss internally.
>
> Christian
>
>
> On Mon, Oct 9, 2017 at 13:59 MoonWalker  > wrote:
>
>> I read that RB 3 beta 2 added support for Travis CI and Circle CI. Could 
>> you please add support for Jenkins as well. Not sure if that can be done 
>> with Webhooks in the mean time
>>
>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/d/optout.
>>
> -- 
> -- 
> Christian Hammond
> President/CEO of Beanbag
> Makers of Review Board
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Jenkins CI integration on RB 3 Plz

2017-10-09 Thread MoonWalker 
BTW IMO plugins/extensions is the way to go, since it can extend RB 
functionality without messing around with RB core 

On Tuesday, October 10, 2017 at 8:10:24 AM UTC+11, Christian Hammond wrote:
>
> Hi,
>
> I definitely want to do Jenkins support. It won't happen by 3.0 but it's 
> on my radar. Supporting another CI system requires a lot of work, so we 
> still have to see what's involved. There's also a question of what we'll be 
> shipping with Review Board and what we'll be shipping with Power Pack, 
> which we need to discuss internally.
>
> Christian
>
>
> On Mon, Oct 9, 2017 at 13:59 MoonWalker  > wrote:
>
>> I read that RB 3 beta 2 added support for Travis CI and Circle CI. Could 
>> you please add support for Jenkins as well. Not sure if that can be done 
>> with Webhooks in the mean time
>>
>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/d/optout.
>>
> -- 
> -- 
> Christian Hammond
> President/CEO of Beanbag
> Makers of Review Board
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Jenkins CI integration on RB 3 Plz

2017-10-09 Thread Christian Hammond 
Yeah, our integrations are actually not part of the Review Board code base.
They live in a rbintegrations package, which we'll be maintaining and
releasing separately from Review Board, so that it's not dependent on the
Review Board release cycle as much.

Christian

On Mon, Oct 9, 2017 at 4:28 PM, MoonWalker 
wrote:

> BTW IMO plugins/extensions is the way to go, since it can extend RB
> functionality without messing around with RB core
>
> On Tuesday, October 10, 2017 at 8:10:24 AM UTC+11, Christian Hammond wrote:
>>
>> Hi,
>>
>> I definitely want to do Jenkins support. It won't happen by 3.0 but it's
>> on my radar. Supporting another CI system requires a lot of work, so we
>> still have to see what's involved. There's also a question of what we'll be
>> shipping with Review Board and what we'll be shipping with Power Pack,
>> which we need to discuss internally.
>>
>> Christian
>>
>>
>> On Mon, Oct 9, 2017 at 13:59 MoonWalker  wrote:
>>
>>> I read that RB 3 beta 2 added support for Travis CI and Circle CI. Could
>>> you please add support for Jenkins as well. Not sure if that can be done
>>> with Webhooks in the mean time
>>>
>>> --
>>> Supercharge your Review Board with Power Pack:
>>> https://www.reviewboard.org/powerpack/
>>> Want us to host Review Board for you? Check out RBCommons:
>>> https://rbcommons.com/
>>> Happy user? Let us know! https://www.reviewboard.org/users/
>>> ---
>>> You received this message because you are subscribed to the Google
>>> Groups "reviewboard" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to reviewboard...@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>> --
>> --
>> Christian Hammond
>> President/CEO of Beanbag
>> Makers of Review Board
>>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>



-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board 3.0 beta 2 is out -- beta testers needed!

2017-10-09 Thread Christian Hammond 
The expectation is that we'll have a single RC release, based on our usage
so far.

Christian

On Mon, Oct 9, 2017 at 4:07 PM, MoonWalker 
wrote:

> I  am guessing that base on the testers feedback we way see additional RCs
> before the final release
>
> On Tuesday, October 10, 2017 at 8:12:20 AM UTC+11, Christian Hammond wrote:
>>
>> The plan is to get RC1 out in 2-3 weeks, based on what bugs get reported
>> to us. This is basically what we'll end up shipping as 3.0 (minus some docs
>> and bug fixes/visual polish). So if you'd like, you can install RC1 when
>> it's out. Just test first on a non-production server.
>>
>> Christian
>>
>>
>> On Mon, Oct 9, 2017 at 14:00 MoonWalker  wrote:
>>
>>>
>>> When do you guys think that RB 3 will be *ready* for production?
>>>
>>> On Saturday, October 7, 2017 at 4:15:54 AM UTC+11, Christian Hammond
>>> wrote:

 Hi everyone,

 We just put out a release of Review Board 3.0 beta 2. There's a lot of
 new features in this release, and at this point we're feature-complete,
 focusing on bug fixing. Some of the highlights include:

 * Highlighting of new updates and discussions on review requests
 * Ability to revoke Ship Its
 * Ability to require the reviewer's verification on closed issues
 * OAuth2 Provider support
 * Emoji shortcodes
 * CircleCI and Travis CI integration
 * On-the-fly search indexing
 * Lots more

 We'd like to get the RC1 (Release Candidate 1) release out in two
 weeks. In the meantime, we're focusing on bug fixing and documentation.

 We could really use your help on testing this release (on a test
 server, not production!). Installing the beta on a test server, along with
 a copy of your database, and ensuring everything works will help us to ship
 a better final release of 3.0.

 If you use or develop in-house extensions, we'd like your feedback as
 well. We've done a lot of work on our extension capabilities, adding
 improved support for custom fields and review request actions, and we could
 use feedback here.

 Our release announcement for beta 2 is here: https://www.reviewboard.
 org/news/2017/10/05/review-board-3-0-beta-2-here/

 Christian

 --
 Christian Hammond
 President/CEO of Beanbag 
 Makers of Review Board 

>>> --
>>> Supercharge your Review Board with Power Pack:
>>> https://www.reviewboard.org/powerpack/
>>> Want us to host Review Board for you? Check out RBCommons:
>>> https://rbcommons.com/
>>> Happy user? Let us know! https://www.reviewboard.org/users/
>>> ---
>>> You received this message because you are subscribed to the Google
>>> Groups "reviewboard" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to reviewboard...@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>> --
>> --
>> Christian Hammond
>> President/CEO of Beanbag
>> Makers of Review Board
>>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>



-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: uglifyjs

2017-10-09 Thread Erik Johansson 
Hi,

I just noticed that when running ".../djblets % python setup.py develop"
you now get the warning:

npm WARN deprecated uglifyjs@2.4.10: uglifyjs is deprecated - use uglify-js
instead.

Perhaps this is something you would like to look into before 3.0?

There's also a warning about babel-preset-es2015 being deprecated.

// Erik

On 29 March 2017 at 21:45, Christian Hammond 
wrote:

> Yeah I don't know what's with the two package names. We've been using this
> one for a long time, which has worked without hiccups. We can try moving to
> uglify-js, but given the version bump, I want to do a lot of testing first.
> We're going to be shipping some new releases very soon, so I'd want to hold
> off until after those go out to try upgrading to uglify-js 2.8.
>
> Christian
>
> --
> Christian Hammond
> President/CEO of Beanbag 
> Makers of Review Board 
>
> On Wed, Mar 29, 2017 at 12:39 PM, Erik Johansson 
> wrote:
>
>> Isn't it telling that the instructions on https://www.npmjs.com/package/
>> uglifyjs for how to install the NPM is "npm install uglify-js" (note the
>> dash).
>>
>> Also, looking at the package.json file for version 2.4.10, the name is
>> actually uglify-js (https://github.com/mishoo/Ugl
>> ifyJS2/blob/v2.4.10/package.json).
>>
>> As for our local changes, I'm trying to push (at least some of) them
>> upstream... (https://reviews.reviewboard.org/r/8585/, hint hint :) )
>>
>> // Erik
>>
>>
>> On 29 March 2017 at 21:18, Christian Hammond 
>> wrote:
>>
>>> Okay. Well, this sounds like a packaging issue on the RPM side (we're
>>> using the dependencies we mean to use), but someone rope me in if this
>>> turns out to be something we have to address locally.
>>>
>>> As for making changes to JavaScript/CSS, it's best if you can make these
>>> changes using an extension so you don't add to your maintenance burden or
>>> when upgrading Review Board, as things will undoubtedly break you in 3.0.
>>>
>>> Christian
>>>
>>> --
>>> Christian Hammond
>>> President/CEO of Beanbag 
>>> Makers of Review Board 
>>>
>>> On Wed, Mar 29, 2017 at 11:38 AM, Erik Johansson 
>>> wrote:
>>>
 After making some local changes to javascript/css files (I think - I'm
 not actually the person doing this, I just wanted to report it upstream to
 hopefully have it fixed going forward).

 // Erik

 On 29 March 2017 at 20:30, Christian Hammond 
 wrote:

> Out of curiosity, why are you running collectstatic?
>
> Christian
>
>
> On Wed, Mar 29, 2017 at 11:25 Erik Johansson 
> wrote:
>
>> I'm not so sure that the problem is with the way Fedora packages
>> uglifyjs. I think the problem is that RB uses
>> https://www.npmjs.com/package/uglifyjs which seems to be version
>> 2.4.10 of https://github.com/mishoo/UglifyJS2 while Fedora packages
>> the latest version of https://github.com/mishoo/UglifyJS2 which is
>> available from https://www.npmjs.com/package/uglify-js.
>>
>> Something like the attached (untested) patches could perhaps be
>> applied?
>>
>> // Erik
>>
>> On 29 March 2017 at 16:02, Stephen Gallagher <
>> step...@gallagherhome.com> wrote:
>>
>> Would you please file a bug at https://bugzilla.redhat.com
>> /enter_bug.cgi?product=Fedora%20EPEL against the "python-djblets"
>> package with the exact commands you are running?
>>
>> I suspect it's a minor glitch with the way that Fedora packages
>> uglifyjs vs. the upstream NPM. I can probably have a patch fairly quickly
>> once you tell me how to reproduce it.
>>
>>
>> On Wed, Mar 29, 2017 at 9:34 AM Erik Johansson 
>> wrote:
>>
>> The EPEL package.
>>
>> // Erik
>>
>>
>> On Mar 29, 2017 15:10, "Stephen Gallagher" 
>> wrote:
>>
>> Did you install ReviewBoard using pip or did you use the EPEL package
>> for ReviewBoard and Djblets?
>>
>> On Wed, Mar 29, 2017 at 8:12 AM Erik Johansson 
>> wrote:
>>
>> Hi,
>>
>> We are having problems running the collectstatic manage command on
>> our CentOS installation (RB 2.5.9). The problem is that we have the
>> uglify-js RPM installed which installs to /usr/lib/node_modules/uglify-js
>> while reviewboard/settings.py configures the path to be os.path.join(
>> NODE_PATH, 'uglifyjs', 'bin', 'uglifyjs') (i.e. uglifyjs instead of
>> uglify-js).
>>
>> This seems to be caused by RB (actually djblets) having a dependency
>> on the uglifyjs NPM instead of uglify-js, even though both seems to use 
>> the
>> same source, but the latter seems to be more active. Any

Re: Index failure after upgrade to ReviewBoard 2.5.16

2017-10-09 Thread 'Rob Backhurst' via reviewboard 
Hi Christian,

See the new output below...

Removing all documents from your index because you said so.
All documents removed.
Indexing 558 users
Indexing 27878 review requests
ERROR:root:Error updating reviews using default
Traceback (most recent call last):
  File 
"/usr/lib/python2.7/site-packages/haystack/management/commands/update_index.py",
 
line 189, in handle_label
self.update_backend(label, using)
  File 
"/usr/lib/python2.7/site-packages/haystack/management/commands/update_index.py",
 
line 234, in update_backend
do_update(backend, index, qs, start, end, total, self.verbosity)
  File 
"/usr/lib/python2.7/site-packages/haystack/management/commands/update_index.py",
 
line 89, in do_update
backend.update(index, current_qs)
  File 
"/usr/lib/python2.7/site-packages/haystack/backends/whoosh_backend.py", 
line 191, in update
doc = index.full_prepare(obj)
  File "/usr/lib/python2.7/site-packages/haystack/indexes.py", line 207, in 
full_prepare
self.prepared_data = self.prepare(obj)
  File "/usr/lib/python2.7/site-packages/haystack/indexes.py", line 198, in 
prepare
self.prepared_data[field.index_fieldname] = field.prepare(obj)
  File "/usr/lib/python2.7/site-packages/haystack/fields.py", line 160, in 
prepare
return self.convert(super(CharField, self).prepare(obj))
  File "/usr/lib/python2.7/site-packages/haystack/fields.py", line 88, in 
prepare
raise SearchFieldError("The model '%s' ('%s' -- %s) does not have a 
model_attr '%s' (%s)." % (repr(obj), repr(current_object), 
current_object.__class__.__name__, attr, hasattr(current_object, attr)))
SearchFieldError: The model '' 
('' -- ReviewRequest) does not have a 
model_attr 'commit' (True).
Traceback (most recent call last):
  File "/usr/bin/rb-site", line 9, in 
load_entry_point('ReviewBoard==2.5.16', 'console_scripts', 'rb-site')()
  File "/usr/lib/python2.7/site-packages/reviewboard/cmdline/rbsite.py", 
line 1964, in main
command.run()
  File "/usr/lib/python2.7/site-packages/reviewboard/cmdline/rbsite.py", 
line 1884, in run
site.run_manage_command(args[0], args[1:])
  File "/usr/lib/python2.7/site-packages/reviewboard/cmdline/rbsite.py", 
line 712, in run_manage_command
execute_from_command_line([__file__, cmd] + params)
  File 
"/usr/lib/python2.7/site-packages/django/core/management/__init__.py", line 
399, in execute_from_command_line
utility.execute()
  File 
"/usr/lib/python2.7/site-packages/django/core/management/__init__.py", line 
392, in execute
self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/usr/lib/python2.7/site-packages/django/core/management/base.py", 
line 242, in run_from_argv
self.execute(*args, **options.__dict__)
  File "/usr/lib/python2.7/site-packages/django/core/management/base.py", 
line 285, in execute
output = self.handle(*args, **options)
  File 
"/usr/lib/python2.7/site-packages/reviewboard/reviews/management/commands/index.py",
 
line 19, in handle
call_command('rebuild_index', interactive=False)
  File 
"/usr/lib/python2.7/site-packages/django/core/management/__init__.py", line 
159, in call_command
return klass.execute(*args, **defaults)
  File "/usr/lib/python2.7/site-packages/django/core/management/base.py", 
line 285, in execute
output = self.handle(*args, **options)
  File 
"/usr/lib/python2.7/site-packages/haystack/management/commands/rebuild_index.py",
 
line 16, in handle
call_command('update_index', **options)
  File 
"/usr/lib/python2.7/site-packages/django/core/management/__init__.py", line 
159, in call_command
return klass.execute(*args, **defaults)
  File "/usr/lib/python2.7/site-packages/django/core/management/base.py", 
line 285, in execute
output = self.handle(*args, **options)
  File 
"/usr/lib/python2.7/site-packages/haystack/management/commands/update_index.py",
 
line 184, in handle
return super(Command, self).handle(*items, **options)
  File "/usr/lib/python2.7/site-packages/django/core/management/base.py", 
line 385, in handle
label_output = self.handle_label(label, **options)
  File 
"/usr/lib/python2.7/site-packages/haystack/management/commands/update_index.py",
 
line 189, in handle_label
self.update_backend(label, using)
  File 
"/usr/lib/python2.7/site-packages/haystack/management/commands/update_index.py",
 
line 234, in update_backend
do_update(backend, index, qs, start, end, total, self.verbosity)
  File 
"/usr/lib/python2.7/site-packages/haystack/management/commands/update_index.py",
 
line 89, in do_update
backend.update(index, current_qs)
  File 
"/usr/lib/python2.7/site-packages/haystack/backends/whoosh_backend.py", 
line 191, in update
doc = index.full_prepare(obj)
  File "/usr/lib/python2.7/site-packages/haystack/indexes.py", line 207, in 
full_prepare
self.prepared_data = self.prepare(obj)
  File "/usr/lib/python2.7/site-packages/haystack/indexes.py", line 198, in 
prepare
self.prepared_data[field.index_fieldname] = field.prepare(obj)
  File