Re: Site-root being applied twice to links sent in emails in upgraded 3.0.1 install

2017-12-13 Thread Christian Hammond 
Hi Peter,

That's definitely a regression in 3.0 with subdirectory installs. We have a
fix in progress already, and will be shipping that in 3.0.2. Sorry for the
trouble!

Christian

On Wed, Dec 13, 2017 at 4:11 PM, Peter Hodgson 
wrote:

> Hi,
>
> I am in the position of emails being generated with the site config
> applied twice eg. The below from a mail.
>
> “This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.redacted.com/ReviewBoard//ReviewBoard/r/237/“
>
> This is the same for the diff link in the email but I can’t find anywhere
> else it happens, ie. all links on the review page/info boxes work.
>
> One consideration that could be how I got here is that I did a fresh site
> install of v3 against the v2 DB, letting it perform the evolutions then.
> Could that be relevant?
>
> Thanks in advance,
> Peter
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>



-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Uploaded Avatar issues with http/https in RB 3.0.1

2017-12-13 Thread Peter Hodgson 
That makes perfect sense. The reason I'd wanted to set it at install time 
is I've been extending a dockerised version, but, as you point out the 
domain method is part of the site_config table so gets migrated with the 
rest of the data. This'll work perfectly.

I'm happy,

Thanks again,
Peter

On Wednesday, 13 December 2017 00:53:57 UTC, Christian Hammond wrote:
>
> Glad it worked!
>
> There's no way to set this during install today, but it's something we 
> should add. You can set it automatically using the set-siteconfig 
> management command:
>
> rb-site manage /path/to/sitedir set-siteconfig -- 
> --key=site_domain_method --value=https
>
> Hopefully you aren't needing to create site directories often. If you're 
> scaling out or moving servers, you want to copy the site directory and run 
> rb-site upgrade, instead of installing a new site directory, as some 
> important state will otherwise change.
>
> Christian
>
> On Tue, Dec 12, 2017 at 1:54 AM, Peter Hodgson  > wrote:
>
>> Hi Christian,
>>
>> Thanks very much, that was it exactly, the general settings page had the 
>> url as http. The avatars are now working great.
>>
>> Is that setting generated from the --domain-name parameter of rb-site 
>> install? I presume there's no way to set that on install?
>>
>> Thanks again,
>> Peter
>>
>> On Saturday, 9 December 2017 20:56:14 UTC, Christian Hammond wrote:
>>>
>>> Hi Peter,
>>>
>>> Thanks!
>>>
>>> This looks like it might be setting-related, so let's start there. Can 
>>> you tell me if the Admin UI -> General Settings page lists the URL of the 
>>> server as using http or https? And is Media URL using a relative path or a 
>>> URL (and if so, is that using http or https)?
>>>
>>> Any uploaded avatar should be referenced based on the Media URL path, so 
>>> I'd first suspect it to be that. If that's the case, this would also impact 
>>> file attachments and their thumbnails.
>>>
>>> Christian
>>>
>>> On Fri, Dec 8, 2017 at 8:23 AM, Peter Hodgson  
>>> wrote:
>>>
 Hi guys,

 Congrats on getting v3 out. I'm a big fan of ReviewBoard, it's 
 certainly made my life easier and v3 looks great. 

 An issue I've having is uploaded avatar images not being shown whilst 
 using ReviewBoard through https as they are linked as http.

 Chrome reports them as
 Mixed Content: The page at 'https://redacted.com/ReviewBoard/dashboard/' 
 was loaded over HTTPS, but requested an insecure image '
 http://redacted.com/ReviewBoard/media/uploaded/avatars/p/pe/peter.hodgson__xyz.jpg'.
  
 This request has been blocked; the content must be served over HTTPS.

 My position is possibly complicated by the RB server being behind a 
 reverse proxy but I've had no other similar issues.

 Thanks in advance,
 Peter

 -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google 
 Groups "reviewboard" group.
 To unsubscribe from this group and stop receiving emails from it, send 
 an email to reviewboard...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.

>>>
>>>
>>>
>>> -- 
>>> Christian Hammond
>>> President/CEO of Beanbag 
>>> Makers of Review Board 
>>>
>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>
>
> -- 
> Christian Hammond
> President/CEO of Beanbag 
> Makers of Review Board 
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4610: Issue Verification cannot drop or verify

2017-12-13 Thread Marcin Zawadzki 
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4610/
--

New update by Misery
For Beanbag, Inc. > Review Board > Ticket #4610


Reply:

@RB team, any possibility to fix it? This is major feature in this release 
and sadly is not working :/

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.