date:20171221

Re: Going to Reviewboard Repositories with error by admin user

2017-12-21 Thread Jianchun Lu

Hi Christian,
We're install reviewboard with 2.5.9 version, Apache2 and memcached.  there 
is no upgraded currently.  Reviewboad server Ubuntu 14.04.2 LTS with Linux 
3.16.0-30-generic

Only affect to repo add/view/modify. new review request is OK.


Error when I click any repo ( dashboard--admin --Repositories) with error 
below

Expected output : 


Environment:

Request Method: GET

Request URL: http://reviewboard.***.com/admin/db/scmtools/repository/3/ 


Django Version: 1.6.11

Python Version: 2.7.6

Installed Applications:

[u'django.contrib.admin',

 u'django.contrib.auth',

 u'django.contrib.contenttypes',

 u'django.contrib.sites',

 u'django.contrib.sessions',

 u'django.contrib.staticfiles',

 u'djblets',

 u'djblets.configforms',

 u'djblets.datagrid',

 u'djblets.extensions',

 u'djblets.feedview',

 u'djblets.gravatars',

 u'djblets.log',

 u'djblets.pipeline',

 u'djblets.siteconfig',

 u'djblets.util',

 u'haystack',

 u'pipeline',

 u'reviewboard',

 u'reviewboard.accounts',

 u'reviewboard.admin',

 u'reviewboard.attachments',

 u'reviewboard.changedescs',

 u'reviewboard.diffviewer',

 u'reviewboard.extensions',

 u'reviewboard.hostingsvcs',

 u'reviewboard.notifications',

 u'reviewboard.reviews',

 u'reviewboard.scmtools',

 u'reviewboard.site',

 u'reviewboard.webapi',

 u'django_evolution']

Installed Middleware:

[u'django.middleware.gzip.GZipMiddleware',

 u'reviewboard.admin.middleware.InitReviewBoardMiddleware',

 u'django.middleware.clickjacking.XFrameOptionsMiddleware',

 u'django.middleware.common.CommonMiddleware',

 u'django.middleware.doc.XViewMiddleware',

 u'django.middleware.http.ConditionalGetMiddleware',

 u'django.middleware.locale.LocaleMiddleware',

 u'django.contrib.sessions.middleware.SessionMiddleware',

 u'django.contrib.auth.middleware.AuthenticationMiddleware',

 u'django.contrib.messages.middleware.MessageMiddleware',

 u'djblets.siteconfig.middleware.SettingsMiddleware',

 u'reviewboard.admin.middleware.LoadSettingsMiddleware',

 u'djblets.extensions.middleware.ExtensionsMiddleware',

 u'djblets.log.middleware.LoggingMiddleware',

 u'reviewboard.accounts.middleware.TimezoneMiddleware',

 u'reviewboard.admin.middleware.CheckUpdatesRequiredMiddleware',

 u'reviewboard.admin.middleware.X509AuthMiddleware',

 u'reviewboard.site.middleware.LocalSiteMiddleware',

 u'djblets.extensions.middleware.ExtensionsMiddlewareRunner',

 u'reviewboard.admin.middleware.ExtraExceptionInfoMiddleware']

Traceback:

File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py" in 
get_response

  112. response = wrapped_callback(request, 



*callback_args, callback_kwargs)File 
"/usr/local/lib/python2.7/dist-packages/django/contrib/admin/options.py" in 
wrapper465. return self.admin_site.admin_view(view)(*args, kwargs)File 
"/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py" in 
_wrapped_view99. response = view_func(request, *args, 

*kwargs)File 
"/usr/local/lib/python2.7/dist-packages/django/views/decorators/cache.py" in 
_wrapped_view_func52. response = view_func(request, *args, *kwargs)

File "/usr/local/lib/python2.7/dist-packages/django/contrib/admin/sites.py" in 
inner

  198. return view(request, 



*args, kwargs)File 
"/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py" in 
_wrapper29. return bound_func(*args, kwargs)File 
"/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py" in 
_wrapped_view99. response = view_func(request, *args, 

*kwargs)File 
"/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py" in 
bound_func25. return func(self, *args2, *kwargs2)

File "/usr/local/lib/python2.7/dist-packages/django/db/transaction.py" in inner

  371. return func(*args, **kwargs)

File "/usr/local/lib/python2.7/dist-packages/django/contrib/admin/options.py" 
in change_view

  1270. form = ModelForm(instance=obj)

File "/usr/local/lib/python2.7/dist-packages/reviewboard/scmtools/forms.py" in 
*init*

  297.hosting_accounts)

File "/usr/local/lib/python2.7/dist-packages/reviewboard/scmtools/forms.py" in 
_get_hosting_service_info

  471. if account.service_name == hosting_service.id

File "/usr/local/lib/python2.7/dist-packages/reviewboard/hostingsvcs/models.py" 
in is_authorized

  54. return service.is_authorized()

File "/usr/local/lib/python2.7/dist-packages/reviewboard/hostingsvcs/gitlab.py" 
in is_authorized

  279. return 'private_token' in self.account.data

Exception Type: TypeError at /admin/db/scmtools/repository/3/

Exception Value: argument of type 'NoneType' is not iterable


thanks!


On Friday, December 22, 2017 at 4:02:13 AM UTC+8, Christian Hammond wrote:
>
> Hi,
>
> Can you provide more info about your install? What version of Review Board 
> are you using? Did you just recently upgrade?

Going to Reviewboard Repositories with error by admin user

2017-12-21 Thread Jianchun Lu

Hi Sir,


2017-12-21 09:39:58,086 - ERROR - None - admin - 
/admin/db/scmtools/repository/227/ - Exception thrown for user admin at 
http://reviewboard.***.com/admin/db/scmtools/repository/227/

argument of type 'NoneType' is not iterable
Traceback (most recent call last):
  File 
"/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py", line 
112, in get_response
response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File 
"/usr/local/lib/python2.7/dist-packages/django/contrib/admin/options.py", 
line 465, in wrapper
return self.admin_site.admin_view(view)(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py", 
line 99, in _wrapped_view
response = view_func(request, *args, **kwargs)
  File 
"/usr/local/lib/python2.7/dist-packages/django/views/decorators/cache.py", 
line 52, in _wrapped_view_func
response = view_func(request, *args, **kwargs)
  File 
"/usr/local/lib/python2.7/dist-packages/django/contrib/admin/sites.py", 
line 198, in inner
return view(request, *args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py", 
line 29, in _wrapper
return bound_func(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py", 
line 99, in _wrapped_view
response = view_func(request, *args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py", 
line 25, in bound_func
return func(self, *args2, **kwargs2)
  File "/usr/local/lib/python2.7/dist-packages/django/db/transaction.py", 
line 371, in inner
return func(*args, **kwargs)
  File 
"/usr/local/lib/python2.7/dist-packages/django/contrib/admin/options.py", 
line 1270, in change_view
form = ModelForm(instance=obj)
  File 
"/usr/local/lib/python2.7/dist-packages/reviewboard/scmtools/forms.py", 
line 297, in __init__
hosting_accounts)
  File 
"/usr/local/lib/python2.7/dist-packages/reviewboard/scmtools/forms.py", 
line 471, in _get_hosting_service_info
if account.service_name == hosting_service.id
  File 
"/usr/local/lib/python2.7/dist-packages/reviewboard/hostingsvcs/models.py", 
line 54, in is_authorized
return service.is_authorized()
  File 
"/usr/local/lib/python2.7/dist-packages/reviewboard/hostingsvcs/gitlab.py", 
line 279, in is_authorized
return 'private_token' in self.account.data
TypeError: argument of type 'NoneType' is not iterable



-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Review link in email notification is wrong on RB 3.0.1

2017-12-21 Thread Christian Hammond

Hi,

We have a fix for this coming in the next release, which will be after the
holidays.

Christian


On Thu, Dec 21, 2017 at 08:19  wrote:

> Hi,
>
> I've just finished upgrading reviewboard from v2.5.16 to v3.0.1.
> [installed via bitnami]
> After the upgrading, email notification has the wrong review link.
> Below quote is an example, application name reviewboard was added twice to
> the URL.
>
>> This is an automatically generated e-mail. To reply, visit:
>> http://192.168.0.250:8081/*reviewboard/*/reviewboard/r/107/
>
>
> I've checked that Server URL setting [http://192.168.0.250:8081] seems
> correct in Admin > General Settings.
> And it shouldn't be related to upgrading from the old one, because I
> installed fresh new reviewboard v3.0.1 [via bitnami as well], and it also
> has the same problem.
>
> If I want to fix this issue, what do I have to do? Might be
> bitnami package problem?
>
> Thank you in advance.
>
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
-- 
-- 
Christian Hammond
President/CEO of Beanbag
Makers of Review Board

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: How to set extra_data for review model in RVB3.0?

2017-12-21 Thread Christian Hammond

I haven’t been able to fix it yet. With the holidays coming up, things have
been busy, and we’ve had a couple higher-priority bugs taking our time.
I’ll make my way back to this soon though.

Christian


On Tue, Dec 19, 2017 at 18:27 Xy Sui  wrote:

> Hi Christian,
>
> Any progress on this topic?
>
> BR
> oswicer
>
>
> On Thursday, December 14, 2017 at 7:00:10 PM UTC+8, Xy Sui wrote:
>
>> Hi,
>>
>> I'm getting desperate after hours' searching/trying... One of our
>> extensions doesn't work now in RVB3.0 because previous setExtraData method
>> doesn't work anymore for review model.
>>
>> In my implementation, I wrote one RB.ReviewDialogHook javascript hook
>> with one customized view. And I would like to save some data in model
>> Review's extraData field. I noticed model Review does have "setExtraData"
>> method, but it's not working...
>>
>> And it looks like the extension rbstopwatch also saves data in
>> extra_data, while the extension is broken in RVB 3.0 as well. So I couldn't
>> find one working example either.
>>
>> Could anybody help? Or anybody has one working example for extra_data
>> setting in javascript?
>>
>> Thanks.
>>
>> BR
>> oswicer
>>
>>
>> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
-- 
-- 
Christian Hammond
President/CEO of Beanbag
Makers of Review Board

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Going to Reviewboard Repositories with error by admin user

2017-12-21 Thread Christian Hammond

Hi,

Can you provide more info about your install? What version of Review Board
are you using? Did you just recently upgrade? What’s the repro case?

Christian


On Thu, Dec 21, 2017 at 08:19 Jianchun Lu  wrote:

> Hi Sir,
>
>
> 2017-12-21 09:39:58,086 - ERROR - None - admin -
> /admin/db/scmtools/repository/227/ - Exception thrown for user admin at
> http://reviewboard.***.com/admin/db/scmtools/repository/227/
>
> argument of type 'NoneType' is not iterable
> Traceback (most recent call last):
>   File
> "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py", line
> 112, in get_response
> response = wrapped_callback(request, *callback_args, **callback_kwargs)
>   File
> "/usr/local/lib/python2.7/dist-packages/django/contrib/admin/options.py",
> line 465, in wrapper
> return self.admin_site.admin_view(view)(*args, **kwargs)
>   File
> "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py", line
> 99, in _wrapped_view
> response = view_func(request, *args, **kwargs)
>   File
> "/usr/local/lib/python2.7/dist-packages/django/views/decorators/cache.py",
> line 52, in _wrapped_view_func
> response = view_func(request, *args, **kwargs)
>   File
> "/usr/local/lib/python2.7/dist-packages/django/contrib/admin/sites.py",
> line 198, in inner
> return view(request, *args, **kwargs)
>   File
> "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py", line
> 29, in _wrapper
> return bound_func(*args, **kwargs)
>   File
> "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py", line
> 99, in _wrapped_view
> response = view_func(request, *args, **kwargs)
>   File
> "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py", line
> 25, in bound_func
> return func(self, *args2, **kwargs2)
>   File "/usr/local/lib/python2.7/dist-packages/django/db/transaction.py",
> line 371, in inner
> return func(*args, **kwargs)
>   File
> "/usr/local/lib/python2.7/dist-packages/django/contrib/admin/options.py",
> line 1270, in change_view
> form = ModelForm(instance=obj)
>   File
> "/usr/local/lib/python2.7/dist-packages/reviewboard/scmtools/forms.py",
> line 297, in __init__
> hosting_accounts)
>   File
> "/usr/local/lib/python2.7/dist-packages/reviewboard/scmtools/forms.py",
> line 471, in _get_hosting_service_info
> if account.service_name == hosting_service.id
>   File
> "/usr/local/lib/python2.7/dist-packages/reviewboard/hostingsvcs/models.py",
> line 54, in is_authorized
> return service.is_authorized()
>   File
> "/usr/local/lib/python2.7/dist-packages/reviewboard/hostingsvcs/gitlab.py",
> line 279, in is_authorized
> return 'private_token' in self.account.data
> TypeError: argument of type 'NoneType' is not iterable
>
>
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
-- 
-- 
Christian Hammond
President/CEO of Beanbag
Makers of Review Board

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Review Board Ticket #4622: Going to repository error with argument of type 'NoneType' is not iterable

2017-12-21 Thread Jianchun Lu

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4622/
--

New ticket #4622 by jianchun.lu
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect


--
Going to repository error with argument of type 'NoneType' is not iterable
==

# What version are you running?
2.5.9

# What's the URL of the page containing the problem?
http://reviewboard.abc.com/admin/db/scmtools/repository/3/

# What steps will reproduce the problem?
1. login dashboard
2. switch to admin console
3. click repository 
4. click any repo


# What is the expected output? What do you see instead?

Environment:


Request Method: GET
Request URL: http://reviewboard.56qq.com/admin/db/scmtools/repository/3/

Django Version: 1.6.11
Python Version: 2.7.6
Installed Applications:
[u'django.contrib.admin',
 u'django.contrib.auth',
 u'django.contrib.contenttypes',
 u'django.contrib.sites',
 u'django.contrib.sessions',
 u'django.contrib.staticfiles',
 u'djblets',
 u'djblets.configforms',
 u'djblets.datagrid',
 u'djblets.extensions',
 u'djblets.feedview',
 u'djblets.gravatars',
 u'djblets.log',
 u'djblets.pipeline',
 u'djblets.siteconfig',
 u'djblets.util',
 u'haystack',
 u'pipeline',
 u'reviewboard',
 u'reviewboard.accounts',
 u'reviewboard.admin',
 u'reviewboard.attachments',
 u'reviewboard.changedescs',
 u'reviewboard.diffviewer',
 u'reviewboard.extensions',
 u'reviewboard.hostingsvcs',
 u'reviewboard.notifications',
 u'reviewboard.reviews',
 u'reviewboard.scmtools',
 u'reviewboard.site',
 u'reviewboard.webapi',
 u'django_evolution']
Installed Middleware:
[u'django.middleware.gzip.GZipMiddleware',
 u'reviewboard.admin.middleware.InitReviewBoardMiddleware',
 u'django.middleware.clickjacking.XFrameOptionsMiddleware',
 u'django.middleware.common.CommonMiddleware',
 u'django.middleware.doc.XViewMiddleware',
 u'django.middleware.http.ConditionalGetMiddleware',
 u'django.middleware.locale.LocaleMiddleware',
 u'django.contrib.sessions.middleware.SessionMiddleware',
 u'django.contrib.auth.middleware.AuthenticationMiddleware',
 u'django.contrib.messages.middleware.MessageMiddleware',
 u'djblets.siteconfig.middleware.SettingsMiddleware',
 u'reviewboard.admin.middleware.LoadSettingsMiddleware',
 u'djblets.extensions.middleware.ExtensionsMiddleware',
 u'djblets.log.middleware.LoggingMiddleware',
 u'reviewboard.accounts.middleware.TimezoneMiddleware',
 u'reviewboard.admin.middleware.CheckUpdatesRequiredMiddleware',
 u'reviewboard.admin.middleware.X509AuthMiddleware',
 u'reviewboard.site.middleware.LocalSiteMiddleware',
 u'djblets.extensions.middleware.ExtensionsMiddlewareRunner',
 u'reviewboard.admin.middleware.ExtraExceptionInfoMiddleware']


Traceback:
File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py" in 
get_response
  112. response = wrapped_callback(request, *callback_args, 
**callback_kwargs)
File "/usr/local/lib/python2.7/dist-packages/django/contrib/admin/options.py" 
in wrapper
  465. return self.admin_site.admin_view(view)(*args, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py" in 
_wrapped_view
  99. response = view_func(request, *args, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/django/views/decorators/cache.py" 
in _wrapped_view_func
  52. response = view_func(request, *args, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/django/contrib/admin/sites.py" in 
inner
  198. return view(request, *args, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py" in 
_wrapper
  29. return bound_func(*args, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py" in 
_wrapped_view
  99. response = view_func(request, *args, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/django/utils/decorators.py" in 
bound_func
  25. return func(self, *args2, **kwargs2)
File "/usr/local/lib/python2.7/dist-packages/django/db/transaction.py" in inner
  371. return func(*args, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/django/contrib/admin/options.py" 
in change_view
  1270. form = ModelForm(instance=obj)
File "/usr/local/lib/python2.7/dist-packages/reviewboard/scmtools/forms.py" in 
__init__
  297.hosting_accounts)
File "/usr/local/lib/python2.7/dist-packages/reviewboard/scmtools/forms.py" in 
_get_hosting_service_info
  471. if account.service_name == hosting_service.id
File "/usr/local/lib/python2.7/dist-packages/reviewboard/hostingsvcs/models.py" 
in is_authorized
  54.

Re: Review Board Ticket #4622: Going to repository error with argument of type 'NoneType' is not iterable

2017-12-21 Thread Jianchun Lu

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4622/
--

New update by jianchun.lu
For Beanbag, Inc. > Review Board > Ticket #4622


Reply:

What operating system are you using? What browser?
Reviewboad server Ubuntu 14.04.2 LTS with Linux 3.16.0-30-generic
Client acceess by chrome

Please provide any additional information below.
Only affect repo , new request to old repo is OK

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Review Board Ticket #4624: Syntax highlight missing for CMakeLists.txt in diff viewer

2017-12-21 Thread Tushar Maheshwari

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4624/
--

New ticket #4624 by tusharpm
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect

File attachments:

 * cmake.diff
   

 * CMakeLists.txt
   



--
Syntax highlight missing for CMakeLists.txt in diff viewer
==

# What version are you running?
- 2.5.3 in production (private instance - access restricted).
- Issue also seen on [demo.reviewboard.org](demo.reviewboard.org) 3.0 RC2.

# What's the URL of the page containing the problem?
No public permalink available.
Can use attachment to see issue on 
[demo.reviewboard.org](http://demo.reviewboard.org/r/1021/diff/1#index_header) 
[Note: may get purged at midnight].

# What steps will reproduce the problem?
1. Create new review request with (attached) `cmake.diff`.
2. Go to Diff viewer.

# What is the expected output? What do you see instead?
The diff viewer does not highlight the added CMakeLists.txt.
The expected behavior is to see highlighted syntax.

# What operating system are you using? What browser?
The private instance is running on Ubuntu 14.04.5 LTS.
The issue is visible on all major browsers: Apple Safari, Google Chrome, 
Mozilla Firefox, Opera browser. [Haven't tried Microsoft Internet Explorer or 
Edge.]

# Please provide any additional information below.
- The file attachment view shows syntax highlighted properly.
- The code most relevant to the issue is in 
[f4a7da4ec0f854bf9ae618a3a28d922f704cc90c](https://github.com/reviewboard/reviewboard/commit/f4a7da4ec0f854bf9ae618a3a28d922f704cc90c).

--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Review Board Ticket #4623: Change in newline at end of file provokes patch rejection / error

2017-12-21 Thread Retink Bach

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4623/
--

New ticket #4623 by retinkab
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect

File attachments:

 * CMakeLists.txt.diff
   

 * CMakeLists.txt.rej
   



--
Change in newline at end of file provokes patch rejection / error
==

# What version are you running?
Reviewboard 3.0.1

# What steps will reproduce the problem?
1. Upload patch
2. Upload updated patch to same review


Consider a patch, generated on Linux. Someone adds a newline to the end of the 
file. You get in the patch file, (from the .diff file)
-)
\ No newline at end of file
+)

Reviewboard seems to be unaware of how to handle this, and tries to apply a 
patch that looks like: (from the .rej file)
-)+)

This results in a rejection being created, and a message allowing you to view 
or download the results of the rejected patch.

# What operating system are you using?
Linux.



--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4621: Enhancement on screenshot view

2017-12-21 Thread bear

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4621/
--

New update by bhsiung
For Beanbag, Inc. > Review Board > Ticket #4621


Reply:

awesome, thanks!

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Going to Reviewboard Repositories with error by admin user

Going to Reviewboard Repositories with error by admin user

Re: Review link in email notification is wrong on RB 3.0.1

Re: How to set extra_data for review model in RVB3.0?

Re: Going to Reviewboard Repositories with error by admin user

Review Board Ticket #4622: Going to repository error with argument of type 'NoneType' is not iterable

Re: Review Board Ticket #4622: Going to repository error with argument of type 'NoneType' is not iterable

Review Board Ticket #4624: Syntax highlight missing for CMakeLists.txt in diff viewer

Review Board Ticket #4623: Change in newline at end of file provokes patch rejection / error

Re: Review Board Ticket #4621: Enhancement on screenshot view

10 matches

Site Navigation

Mail list logo

Footer information