Re: unexpected return value (400 Bad Request) in response to OPTIONS request for

2018-01-27 Thread Christian Hammond 
You’ll probably need to upgrade PySVN/Subvertpy (whichever you’re using)
and libsvn on the Review Board server. Seems it’s not able to speak the
same protocol as your Subversion server. The RBTools clients don’t be
affected, so long as the command line svn tool works.

Christian


On Tue, Jan 23, 2018 at 01:48 Mai Waly  wrote:

> I enbaled httpd debug found the below error on svn server side and this is
> server logs
>
> current svn version on server is 1.9.7 shall we ask for upgrading svn on
> reviewboard client.
>
> [Tue Jan 23 00:54:07.649606 2018] [core:debug] [pid 5011]
> protocol.c(1151): [client xx:43416] AH02427: Request header value is
> malformed: SVN/1.6.11 (r934486)/\x10\xebM\xa8 + neon/0.25.5
> [Tue Jan 23 00:54:07.649653 2018] [core:debug] [pid 5011]
> protocol.c(1309): [client xx:43416] AH00567: request failed: error
> reading the headers
>
>
> On Sunday, January 21, 2018 at 10:20:08 PM UTC+2, Mai Waly wrote:
>>
>> SVN server is working and users can run their builds and do commits
>>
>> If mod_dav_svn is not there svn wont work at all.
>>
>> I can confirm  that we disbaled mod_status is it needed.
>>
>> Do you think user needs to reconfigure review board after we changed svn
>> server with a higher OS one.
>>
>> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
-- 
-- 
Christian Hammond
President/CEO of Beanbag
Makers of Review Board

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Extra whitespace in Review boxes

2018-01-27 Thread Christian Hammond 
The extra space above the Reply button isn’t intentional. We can surely
tidy that up.

The extra space around the diff is sort of almost an illusion, kinda. It’s
really space allocated for the diff header/footer/expansion controls, but
we use some CSS magic to squash those so that we can slide then back into
position when hovering over the diff, without impacting layout on the page.
In 2.5, hovering would expand and push page content down, which slowed down
the page briefly and made scrolling pretty rough whenever the page scroll
caused the cursor to land over the diff. The header needs to expand into
its allocated position on the page, which is why that gap is there.

The one at the top though is completely fixable, so we’ll poke at that.

Christian


On Fri, Jan 26, 2018 at 04:18 Peter Hodgson 
wrote:

> Hi,
>
> Is the extra whitespace in the review-comment box in v3 intentional? It
> seems like a lot of wasted space and extra scrolling on review pages with
> lots of small individual reviews. I've attached a picture of the difference
> I'm seeing between v2.5.17 and v3.0.2. It looks like there is extra spacing
> in general but I think it's most noticeable at the top of the review.
>
> Thanks as always for your excellent product,
> Peter
>
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
-- 
-- 
Christian Hammond
President/CEO of Beanbag
Makers of Review Board

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: trying to automate rbt post

2018-01-27 Thread benjamin . at . motive 


On Friday, January 26, 2018 at 5:10:42 PM UTC-8, David Trowbridge wrote:
>
> It is possible to run `rbt post` from outside of a source tree, but it 
> requires manually specifying the server and repository in your command 
> line. This is what it's trying to detect when it fails looking at the cwd.
>
>
I have a .reviewboardrc file in that directory. It contains server, 
username, and password declarations. With --debug rbt does not tell me it 
is reading the file, but I know it is because I get syntax errors if it has 
syntax problems.  If it is reading it, it is presumably using it.

There doesn't seem to be a command line option to just give a repository 
name. There are:

–repository-type
–repository-url

Should I use the URL one to specify type? I had been leaving both out 
since, like I said, I already had the diffs. The docs for post:

https://www.reviewboard.org/docs/rbtools/0.7/rbt/commands/post/
(My version, but the later one is the same on this point.)

Just say I need username and password with a "--diff-filename=-". If that's 
wrong, it would be good to have it corrected.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.