Re: Can anybody do review?
Thanks for quick response. But if user has not user level permissions to do review, which we set at the time of user creation, then also he can do review. Is this designed in that way too? If yes then whats significance of the user level permissions that we set up? I apologies if it has been already mentioned in some docs on the site. On Tue, Oct 7, 2008 at 10:42 AM, Christian Hammond [EMAIL PROTECTED]wrote: It's as designed. The reviewers list is the group of people you're requesting review requests from, but anyone can review. Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Mon, Oct 6, 2008 at 9:53 PM, Atul Phalke [EMAIL PROTECTED]wrote: Hi Team, I created a user John without any user permissions. Another user Mike created a review request and assigned Bill as reviewer. But still John can review the review request created by Mike, although he is neither a reviewer nor has any user permissions to do that. It seems to me a bug. Any thoughts? Thanks, Atul. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Can anybody do review?
Those permissions are provided automatically by Django. They're for the admin UI only, and do not govern the functionality of Review Board itself. Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Mon, Oct 6, 2008 at 11:41 PM, Atul Phalke [EMAIL PROTECTED]wrote: Thanks for quick response. But if user has not user level permissions to do review, which we set at the time of user creation, then also he can do review. Is this designed in that way too? If yes then whats significance of the user level permissions that we set up? I apologies if it has been already mentioned in some docs on the site. On Tue, Oct 7, 2008 at 10:42 AM, Christian Hammond [EMAIL PROTECTED]wrote: It's as designed. The reviewers list is the group of people you're requesting review requests from, but anyone can review. Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Mon, Oct 6, 2008 at 9:53 PM, Atul Phalke [EMAIL PROTECTED]wrote: Hi Team, I created a user John without any user permissions. Another user Mike created a review request and assigned Bill as reviewer. But still John can review the review request created by Mike, although he is neither a reviewer nor has any user permissions to do that. It seems to me a bug. Any thoughts? Thanks, Atul. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Cannot login after fresh install under apache http.
Can you try Django 1.0 instead of 1.1 alpha? I think we have some issues with 1.1 at the moment. Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Mon, Oct 6, 2008 at 11:39 PM, mascha [EMAIL PROTECTED] wrote: Hey, I tried the latest svn version and followed the wiki Getting Started steps to install all necessary stuff. I setuped reviewboard to work under apache httpd. But I cannot login. I get the message cookies must be enabled. My browser has cookies enabled and the following cookie is set rbsessionid. By following the installation guide I installed django version 1.1.0 alpha on my system. Any help would be appreciated. Bye, martin. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Using Perforce and Pre-Reviews
A better name for post-review is post-a-review. As long as you move the files you wish to review out of the default changelist you can use post-review. On Tue, Oct 7, 2008 at 5:41 AM, Marcos [EMAIL PROTECTED] wrote: Greetings. I installed reviewboard, and it seems to work ok using post-review, the only issue with is is that (as the name says) post-review is to make reviews already submitted, on what I want to do is use it on not committed changes. I use perforce, and that is why I am using post-review (as I heard p4 diff is broken, even I think that strange, specially using the -du flag). So does any one has a wrapper to p4 that allows the us of review-board with not submitted changes? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Cannot login after fresh install under apache http.
On 7 Okt., 08:58, Christian Hammond [EMAIL PROTECTED] wrote: Can you try Django 1.0 instead of 1.1 alpha? I think we have some issues with 1.1 at the moment. With version 1.0 I have the same problem. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Using Perforce and Pre-Reviews
Now I get this error: Unable to parse diff header: : Invalid argument This is the debug output J:\post-review.py -n --debug --diff-only 56843 Repository info 'Path: perforce.server.com:1666, Base path: None, Supports changesets: True' Generating diff for changenum 56843 p4 describe -s 56843 Processing edit of //project/branches/my_branch/client/GUI/StartWindow.cpp Writing //project/branches/my_branch/client/GUI/StartWindow.cpp#1 to c:\docume~1\marcosp\locals~1\temp\tmpvzainx p4 print -q //project/branches/my_branch/client/GUI/StartWindow.cpp#1 p4 where //project/branches/my_branch/client/GUI/StartWindow.cpp diff -urNp c:\docume~1\marcosp\locals~1\temp\tmpvzainx C:/CODE\branches\my_branch\client\GUI\StartWindow.cpp On Oct 7, 4:21 pm, Marcos [EMAIL PROTECTED] wrote: Cool, those are great news. Thanks for the reply. On Oct 7, 3:25 pm, Joshua Slominski [EMAIL PROTECTED] wrote: A better name for post-review is post-a-review. As long as you move the files you wish to review out of the default changelist you can use post-review. On Tue, Oct 7, 2008 at 5:41 AM, Marcos [EMAIL PROTECTED] wrote: Greetings. I installed reviewboard, and it seems to work ok using post-review, the only issue with is is that (as the name says) post-review is to make reviews already submitted, on what I want to do is use it on not committed changes. I use perforce, and that is why I am using post-review (as I heard p4 diff is broken, even I think that strange, specially using the -du flag). So does any one has a wrapper to p4 that allows the us of review-board with not submitted changes? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Using Perforce and Pre-Reviews
I think the issue might be on this line: diff -urNp c:\docume~1\marcosp\locals~1\temp\tmpvzainx C:/CODE\branches\my_branch\client\GUI\StartWindow.cpp Slash and backslash together, does not sound right. Any ideas? On Oct 7, 4:42 pm, Marcos [EMAIL PROTECTED] wrote: Now I get this error: Unable to parse diff header: : Invalid argument This is the debug output J:\post-review.py -n --debug --diff-only 56843 Repository info 'Path: perforce.server.com:1666, Base path: None, Supports changesets: True' Generating diff for changenum 56843 p4 describe -s 56843 Processing edit of //project/branches/my_branch/client/GUI/StartWindow.cpp Writing //project/branches/my_branch/client/GUI/StartWindow.cpp#1 to c:\docume~1\marcosp\locals~1\temp\tmpvzainx p4 print -q //project/branches/my_branch/client/GUI/StartWindow.cpp#1 p4 where //project/branches/my_branch/client/GUI/StartWindow.cpp diff -urNp c:\docume~1\marcosp\locals~1\temp\tmpvzainx C:/CODE\branches\my_branch\client\GUI\StartWindow.cpp On Oct 7, 4:21 pm, Marcos [EMAIL PROTECTED] wrote: Cool, those are great news. Thanks for the reply. On Oct 7, 3:25 pm, Joshua Slominski [EMAIL PROTECTED] wrote: A better name for post-review is post-a-review. As long as you move the files you wish to review out of the default changelist you can use post-review. On Tue, Oct 7, 2008 at 5:41 AM, Marcos [EMAIL PROTECTED] wrote: Greetings. I installed reviewboard, and it seems to work ok using post-review, the only issue with is is that (as the name says) post-review is to make reviews already submitted, on what I want to do is use it on not committed changes. I use perforce, and that is why I am using post-review (as I heard p4 diff is broken, even I think that strange, specially using the -du flag). So does any one has a wrapper to p4 that allows the us of review-board with not submitted changes? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Using Perforce and Pre-Reviews
Greetings. I installed reviewboard, and it seems to work ok using post-review, the only issue with is is that (as the name says) post-review is to make reviews already submitted, on what I want to do is use it on not committed changes. I use perforce, and that is why I am using post-review (as I heard p4 diff is broken, even I think that strange, specially using the -du flag). So does any one has a wrapper to p4 that allows the us of review-board with not submitted changes? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: How are comments associated with code?
They aren't brought along as people commit changes to code. ok, as far as I understand now the commits are stored with the diffs in reviewboard (or the database it uses). --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Help with Apache
On Oct 6, 5:12 am, demjanenko [EMAIL PROTECTED] wrote: On Oct 5, 11:14 pm, flyincognito [EMAIL PROTECTED] wrote: I managed to get this going - I played with it a bit, and my paths must have been set up wrong. Hi! I have similar problem. Can you post your corrected vhost config? No problem - I believe that the issue was in the dbjlets path. The working virtual host entry is below: VirtualHost *:80 ServerName {domain} DocumentRoot /var/www/rb/reviewboard/htdocs # Error handlers ErrorDocument 500 /errordocs/500.html # Serve django pages Location / PythonPath ['/usr/lib/python2.4/site-packages/ django','/var/www/rb/','/var/www/rb/reviewboard'] + sys.path SetEnv PYTHON_EGG_CACHE /var/cache/www/pythoneggs SetEnv DJANGO_SETTINGS_MODULE reviewboard.settings SetHandler mod_python PythonHandler django.core.handlers.modpython PythonAutoReload Off PythonDebug Off /Location # Serve static media without running it through mod_python # (overrides the above) Location /media SetHandler None /Location Location /errordocs SetHandler None /Location # Alias static media requests to filesystem Alias /media /var/www/rb/reviewboard/htdocs/media Alias /errordocs /var/www/rb/reviewboard/htdocs/errordocs /VirtualHost --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Issue 682 in reviewboard: Cannot login after fresh install under apache http.
Issue 682: Cannot login after fresh install under apache http. http://code.google.com/p/reviewboard/issues/detail?id=682 Comment #2 by [EMAIL PROTECTED]: I tried with version 1.0.0 final and have the same issue. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 401 in reviewboard: Comments should be inserted into diff below lines being discussed, instead of in dialog box
Issue 401: Comments should be inserted into diff below lines being discussed, instead of in dialog box http://code.google.com/p/reviewboard/issues/detail?id=401 Comment #5 by chipx86: The key difference with the popup window is that we get intelligently place it initially but give users the freedom to move it if they're reviewing a large block of code. I assumed in this design that all inline comments would just show up automatically, rather than having comment flags. That's been the design people have recommended to me in the past when talking about an inline comment field like this. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---