Re: Cleartool missing + Svn access issue ?

2009-03-20 Thread Bartlomiej Celary
Are you using a Clear Case SCM? Cleartool is the tool needed to manage this kind of repo. If not that means the post-review gives a false positive for a clearcase repo instead of detecting subversion (I presume this is what you actually need). Are you sure you are in a subversion repository?

Re: Small UI feature request: 2 new fields

2009-03-20 Thread Sebastien Douche
On Fri, Feb 20, 2009 at 16:57, Sebastien Douche sdou...@gmail.com wrote: 1. field dependency 2. field state No success for my proposal ;(. Now I need 4 new fields, how adding them? -- Sebastien Douche sdou...@gmail.com --~--~-~--~~~---~--~~ You received this

RE: Cleartool missing + Svn access issue ?

2009-03-20 Thread Laurent Dufréchou
Hum yeah... I've set up a svn repos in the web interface. But I access it usually via svn:// (I never heard of Clear Case SCM until now :) ) -Message d'origine- De : reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com] De la part de Bartlomiej Celary Envoyé : vendredi

Re: Cleartool missing + Svn access issue ?

2009-03-20 Thread Christian Hammond
I imagine we're trying to detect if it's a clearcase repository and something with the locale is causing us to fail incorrectly. Possibly a locale-related issue. What does Le fichier spÚcifiÚ est introuvable translate to in English? Christian -- Christian Hammond - chip...@chipx86.com Review

Re: Small UI feature request: 2 new fields

2009-03-20 Thread Christian Hammond
I missed this e-mail entirely. Sorry about that. We have no plans to add additional fields to Review Board. Custom fields are often very dependent on the company that wants them, and it's not easy to just add them directly in the codebase. However, after 1.0, we're putting in support for

Re: Cleartool missing + Svn access issue ?

2009-03-20 Thread Christian Hammond
The .reviewboardrc is needed for specifying which server to use, but really this should be done through a property on the SVN server. See the docs in the script for details on setting this up. However, .reviewboardrc isn't related to this. The problem is that we're attempting to execute the

Re: Cleartool missing + Svn access issue ?

2009-03-20 Thread Laurent Dufrechou
By the way .reviewboardrc for the filename of config name is not good for portability because under windows you can't '.reviewboardrc' It absolutely want somthin like .yy or :( perhaps alowing a second name for windows could be a good idea too. somethong like reviewboardrc.conf. If you

Re: Cleartool missing + Svn access issue ?

2009-03-20 Thread Laurent Dufrechou
Just tested under linux got this execption: Traceback (most recent call last): File ./post-review, line 2312, in module main(sys.argv[1:]) File ./post-review, line 2253, in main repository_info, tool = determine_client() File ./post-review, line 2205, in determine_client

Re: Cleartool missing + Svn access issue ?

2009-03-20 Thread Gary M. Josack
I'm going to guess you got that error because cleartool isn't installed. Laurent Dufrechou wrote: Just tested under linux got this execption: Traceback (most recent call last): File ./post-review, line 2312, in module main(sys.argv[1:]) File ./post-review, line 2253, in main

Re: Cleartool missing + Svn access issue ?

2009-03-20 Thread Laurent Dufrechou
Yeah yeah for sure 2009/3/20 Gary M. Josack g...@byoteki.com I'm going to guess you got that error because cleartool isn't installed. Laurent Dufrechou wrote: Just tested under linux got this execption: Traceback (most recent call last): File ./post-review, line 2312, in module

How post-review must be used?

2009-03-20 Thread laurent.dufrec...@gmail.com
Hello, Just another thread because this is not related to the exception handling. It seems that I misuse post-review. I was thinking that I had to launch it (wherever I was), and it would ask me what was my SVN repos, what was my diff file, ans it would send the update to the server. Seems it

Re: Cleartool missing + Svn access issue ?

2009-03-20 Thread Christian Hammond
We'll have to do the try/catch method I suppose. I don't know why you'd be getting the OSError below. There's something clearly different between the subprocess implementations we're using. We officially are supporting the version from python.org, so it's something in the one you're using. As for

Re: How post-review must be used?

2009-03-20 Thread Vinay Venkatesh
I apologize in advance for the stream of consciousness nature of this email. But hopefully, it helps. You can set the reviewboard:url property by doingsvn propedit reviewboard:url . inside the directory for the repository using cygwin. When you run post-review you'll want to be inside that

Re: How post-review must be used?

2009-03-20 Thread Laurent Dufrechou
Hi christian your mail helps me! svn info gave the URL. I didn't get for what it was used while reading the doc. The fact is there is a ' ' space in my repos URL, and it add to be translated to %20 ... teah I know (I didn't choose the path name ;) ) so I changed the name from

RE: Cleartool missing + Svn access issue ?

2009-03-20 Thread Laurent Dufréchou
Hum, I think this is official python. (python(x,y) is just packaging a lot of python install into a one .msi. And under linux I use the one given by apt-get install under ubuntu 8.10. That is a 2.5.2 Perhaps you still use older python than 2.5.0? From python doc: Exceptions

Re: How post-review must be used?

2009-03-20 Thread laurent.dufrec...@gmail.com
OK that's better. I decided to first give a try to linux, since it seems your base platfrom. I've managed to post my first review that support diff. Here are some point you could find interesting (as I think I've done all the basic stupid things a newbie user will do): First a little exaplantion:

Issue 973 in reviewboard: Allow code review without a patch

2009-03-20 Thread codesite-noreply
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 973 by jocelyn.fiat: Allow code review without a patch http://code.google.com/p/reviewboard/issues/detail?id=973 Currently code review seems to only work for actually reviewing a patch, not for reviewing existing code for

Issue 974 in reviewboard: Clicking anywhere now brings up the comment box, even expand code links

2009-03-20 Thread codesite-noreply
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 974 by clarkd4: Clicking anywhere now brings up the comment box, even expand code links http://code.google.com/p/reviewboard/issues/detail?id=974 Firefox 3.0.7 on Win2003 64-bit. In the latest version of Reviewboard,

Issue 975 in reviewboard: Launching and moving comment box, backspacing over text are very slow

2009-03-20 Thread codesite-noreply
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 975 by clarkd4: Launching and moving comment box, backspacing over text are very slow http://code.google.com/p/reviewboard/issues/detail?id=975 Firefox 3.0.7, Win2003 64-bit. In the latest version of Reviewboard at

Issue 975 in reviewboard: Launching and moving comment box, backspacing over text are very slow

2009-03-20 Thread codesite-noreply
Updates: Status: NeedInfo Comment #1 on issue 975 by chipx86: Launching and moving comment box, backspacing over text are very slow http://code.google.com/p/reviewboard/issues/detail?id=975 What extensions are you using in Firefox? The textarea is actually just a standard textarea,

Issue 974 in reviewboard: Clicking anywhere now brings up the comment box, even expand code links

2009-03-20 Thread codesite-noreply
Updates: Status: Duplicate Mergedinto: 933 Comment #1 on issue 974 by chipx86: Clicking anywhere now brings up the comment box, even expand code links http://code.google.com/p/reviewboard/issues/detail?id=974 (No comment was entered for this change.) -- You received this

Issue 933 in reviewboard: Clicking expand triggers review comment

2009-03-20 Thread codesite-noreply
Comment #6 on issue 933 by clarkd4: Clicking expand triggers review comment http://code.google.com/p/reviewboard/issues/detail?id=933 For the record, I liked the old behavior that only clicking or drag-selecting in the line number column triggers a comment box. -- You received this message

Issue 975 in reviewboard: Launching and moving comment box, backspacing over text are very slow

2009-03-20 Thread codesite-noreply
Comment #2 on issue 975 by clarkd4: Launching and moving comment box, backspacing over text are very slow http://code.google.com/p/reviewboard/issues/detail?id=975 Yes, both issues go away when I restart the browser. The comment box is still a little slow, but not horrible. It might be

Issue 966 in reviewboard: Under General Settings, updating Server field not saved despite successful message

2009-03-20 Thread codesite-noreply
Comment #1 on issue 966 by ciaomary: Under General Settings, updating Server field not saved despite successful message http://code.google.com/p/reviewboard/issues/detail?id=966 Turns out this is not limited to just server field in General Settings. On a new install of 3-13-09 nightly,

Issue 933 in reviewboard: Clicking expand triggers review comment

2009-03-20 Thread codesite-noreply
Comment #7 on issue 933 by jefflamb: Clicking expand triggers review comment http://code.google.com/p/reviewboard/issues/detail?id=933 I agree. I like highlighting blocks by click and dragging text when I'm showing something to people (or myself.) -- You received this message because you