Apache hangs when searching
Hi, My setup: ubuntu 8.10 Reviewboard 1.0 beta2 apache2 pylucene 2.4.1 (downloaded source from apache and built) python 2.5.2 Problem: When executing a search in the web interface of reviewboard, apache hangs/deadlocks, using 100% cpu. Issue 770 seems to be about the same problem (http://code.google.com/p/reviewboard/issues/detail?id=770), but is has been closed. Doing an strace on apache reveals a lot of lines ala the ones below here with viewing e.g. viewing a diff (which seems to work fine dispite all this): # strace output begin ## 15981 open(/usr/lib/python2.5/site-packages/django_evolution-0.0.0- py2.5.egg/array.py, O_RDONLY|O_LARGEFILE) = -1 ENOENT (No such file or directory) 15981 open(/usr/lib/python2.5/site-packages/django_evolution-0.0.0- py2.5.egg/array.pyc, O_RDONLY|O_LARGEFILE) = -1 ENOENT (No such file or directory) 15981 stat64(/usr/lib/python2.5/site-packages/Django-1.0.2_final- py2.5.egg/array, 0xb6201f34) = -1 ENOENT (No such file or directory) .. 15981 open(/usr/lib/python2.5/site-packages/ReviewBoard-1.0beta2- py2.5.egg/uu.so, O_RDONLY|O_LARGEFILE) = -1 ENOENT (No such file or directory) 15981 open(/usr/lib/python2.5/site-packages/ReviewBoard-1.0beta2- py2.5.egg/uumodule.so, O_RDONLY|O_LARGEFILE) = -1 ENOENT (No such file or directory) 15981 open(/usr/lib/python2.5/site-packages/ReviewBoard-1.0beta2- py2.5.egg/uu.py, O_RDONLY|O_LARGEFILE) = -1 ENOENT (No such file or directory) 15981 open(/usr/lib/python2.5/site-packages/ReviewBoard-1.0beta2- py2.5.egg/uu.pyc, O_RDONLY|O_LARGEFILE) = -1 ENOENT (No such file or directory) 15981 stat64(/usr/lib/python2.5/site-packages/Pygments-1.0-py2.5.egg/ uu, 0xb61fbd44) = -1 ENOENT (No such file or directory) 15981 open(/usr/lib/python2.5/site-packages/Pygments-1.0-py2.5.egg/ uu.so, O_RDONLY|O_LARGEFILE) = -1 ENOENT (No such file or directory) 15981 open(/usr/lib/python2.5/site-packages/Pygments-1.0-py2.5.egg/ uumodule.so, O_RDONLY|O_LARGEFILE) = -1 ENOENT (No such file or directory) 15981 open(/usr/lib/python2.5/site-packages/Pygments-1.0-py2.5.egg/ uu.py, O_RDONLY|O_LARGEFILE) = -1 ENOENT (No such file or directory) 15981 open(/usr/lib/python2.5/site-packages/Pygments-1.0-py2.5.egg/ uu.pyc, O_RDONLY|O_LARGEFILE) = -1 ENOENT (No such file or directory) 15981 stat64(/usr/lib/python2.5/site-packages/Djblets-0.5beta1- py2.5.egg/uu, 0xb61fbd44) = -1 ENOENT (No such file or directory) 15981 open(/usr/lib/python2.5/site-packages/Djblets-0.5beta1- py2.5.egg/uu.so, O_RDONLY|O_LARGEFILE) = -1 ENOENT (No such file or directory) 15981 open(/usr/lib/python2.5/site-packages/Djblets-0.5beta1- py2.5.egg/uumodule.so, O_RDONLY|O_LARGEFILE) = -1 ENOENT (No such file or directory) 15981 open(/usr/lib/python2.5/site-packages/Djblets-0.5beta1- py2.5.egg/uu.py, O_RDONLY|O_LARGEFILE) = -1 ENOENT (No such file or directory) 15981 open(/usr/lib/python2.5/site-packages/Djblets-0.5beta1- py2.5.egg/uu.pyc, O_RDONLY|O_LARGEFILE) = -1 ENOENT (No such file or directory) 15981 stat64(/usr/lib/python2.5/site-packages/django_evolution-0.0.0- py2.5.egg/uu, 0xb61fbd44) = -1 ENOENT (No such file or directory) 15981 open(/usr/lib/python2.5/site-packages/django_evolution-0.0.0- py2.5.egg/uu.so, O_RDONLY|O_LARGEFILE) = -1 ENOENT (No such file or directory) 15981 open(/usr/lib/python2.5/site-packages/django_evolution-0.0.0- py2.5.egg/uumodule.so, O_RDONLY|O_LARGEFILE) = -1 ENOENT (No such file or directory) # strace output end ## When execute a search, apache2 hangs/deadlocks. strace reveals: # strace output begin ## 15981 open(/proc/self/maps, O_RDONLY) = 11 15981 fstat64(11, {st_mode=S_IFREG|0444, st_size=0, ...}) = 0 15981 mmap2(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE| MAP_ANONYMOUS, -1, 0) = 0xa9762000 15981 read(11, 0xa9762000, 1024)= -1 EACCES (Permission denied) 15981 read(11, 0xa9762000, 1024)= -1 EACCES (Permission denied) 15981 read(11, 0xa9762000, 1024)= -1 EACCES (Permission denied) 15981 read(11, 0xa9762000, 1024)= -1 EACCES (Permission denied) 15981 read(11, 0xa9762000, 1024)= -1 EACCES (Permission denied) 15981 read(11, 0xa9762000, 1024)= -1 EACCES (Permission denied) 15981 read(11, 0xa9762000, 1024)= -1 EACCES (Permission denied) 15981 read(11, 0xa9762000, 1024)= -1 EACCES (Permission denied) 15981 read(11, 0xa9762000, 1024)= -1 EACCES (Permission denied) 15981 read(11, 0xa9762000, 1024)= -1 EACCES (Permission denied) 15981 read(11, 0xa9762000, 1024)= -1 EACCES (Permission denied) 15981 read(11, 0xa9762000, 1024)= -1 EACCES (Permission denied) 15981 read(11, 0xa9762000, 1024)= -1 EACCES (Permission denied) 15981 read(11, 0xa9762000, 1024)= -1 EACCES (Permission denied) 15981 read(11, 0xa9762000, 1024)= -1 EACCES (Permission denied) # strace output end ## The read - permission denied lines are repeated forever until apache is shut down. Any ideas to what my problem might be? Thanks -- Jeppe
Re: Unable to get any images and .css files are not loaded
On Apr 6, 5:25 pm, kmw kochhar...@gmail.com wrote: ... Figured it out: my url.rewrite rules were wrong, try this in the lighttpd.conf, it should work alias.url = ( /media = /opt/reviewboard/var/www/localhost/htdocs/media, /errordocs = /opt/reviewboard/var/www/localhost/htdocs/ errordocs, ) url.rewrite-once = ( ^/reviews(/media/.*)$ = $1, ^/reviews(/errordocs/.*)$ = $1, ^(/.*)$ = /reviewboard.fcgi$1, ) The above fixed things for me. Thanks, this made my day!! --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
django.core.exceptions.ImproperlyConfigured: MySQLdb-1.2.1p2 or newer is required; you have 1.2.1
Hello, I am getting errors while running the tool: rb-site install /var/www/reviews.example.com I have created the database, but have the following issues, any help is appreciated: * Installing the site... Building site directories ... OK Building site configuration files ... OK Creating database ... Traceback (most recent call last): File /usr/bin/rb-site, line 5, in ? pkg_resources.run_script('ReviewBoard==1.0beta2', 'rb-site') File /usr/lib/python2.4/site-packages/pkg_resources.py, line 448, in run_script self.require(requires)[0].run_script(script_name, ns) File /usr/lib/python2.4/site-packages/pkg_resources.py, line 1166, in run_script execfile(script_filename, namespace, namespace) File /usr/lib/python2.4/site-packages/ReviewBoard-1.0beta2- py2.4.egg/EGG-INFO/scripts/rb-site, line 1280, in ? main(sys.argv[1:]) File /usr/lib/python2.4/site-packages/ReviewBoard-1.0beta2- py2.4.egg/EGG-INFO/scripts/rb-site, line 1275, in main command.run() File /usr/lib/python2.4/site-packages/ReviewBoard-1.0beta2- py2.4.egg/EGG-INFO/scripts/rb-site, line 912, in run self.show_install_status() File /usr/lib/python2.4/site-packages/ReviewBoard-1.0beta2- py2.4.egg/EGG-INFO/scripts/rb-site, line 1134, in show_install_status site.sync_database) File /usr/lib/python2.4/site-packages/ReviewBoard-1.0beta2- py2.4.egg/EGG-INFO/scripts/rb-site, line 519, in step func() File /usr/lib/python2.4/site-packages/ReviewBoard-1.0beta2- py2.4.egg/EGG-INFO/scripts/rb-site, line 224, in sync_database self.run_manage_command(syncdb, [--noinput]) File /usr/lib/python2.4/site-packages/ReviewBoard-1.0beta2- py2.4.egg/EGG-INFO/scripts/rb-site, line 261, in run_manage_command fix_django_evolution_issues(reviewboard.settings) File /usr/lib/python2.4/site-packages/ReviewBoard-1.0beta2- py2.4.egg/reviewboard/admin/migration.py, line 13, in fix_django_evolution_issues import django.db.models.fields as model_fields File /usr/lib/python2.4/site-packages/Django-1.0.2_final-py2.4.egg/ django/db/__init__.py, line 16, in ? backend = __import__('%s%s.base' % (_import_path, settings.DATABASE_ENGINE), {}, {}, ['']) File /usr/lib/python2.4/site-packages/Django-1.0.2_final-py2.4.egg/ django/db/backends/mysql/base.py, line 22, in ? raise ImproperlyConfigured(MySQLdb-1.2.1p2 or newer is required; you have %s % Database.__version__) django.core.exceptions.ImproperlyConfigured: MySQLdb-1.2.1p2 or newer is required; you have 1.2.1 --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: django.core.exceptions.ImproperlyConfigured: MySQLdb-1.2.1p2 or newer is required; you have 1.2.1
Sorry, I forgot to say that I am using Red Hat Enterprise 5, on a new server. + On Apr 7, 1:35 pm, Mohamed Mansour m0.interact...@gmail.com wrote: Hello, I am getting errors while running the tool: rb-site install /var/www/reviews.example.com I have created the database, but have the following issues, any help is appreciated: * Installing the site... Building site directories ... OK Building site configuration files ... OK Creating database ... Traceback (most recent call last): File /usr/bin/rb-site, line 5, in ? pkg_resources.run_script('ReviewBoard==1.0beta2', 'rb-site') File /usr/lib/python2.4/site-packages/pkg_resources.py, line 448, in run_script self.require(requires)[0].run_script(script_name, ns) File /usr/lib/python2.4/site-packages/pkg_resources.py, line 1166, in run_script execfile(script_filename, namespace, namespace) File /usr/lib/python2.4/site-packages/ReviewBoard-1.0beta2- py2.4.egg/EGG-INFO/scripts/rb-site, line 1280, in ? main(sys.argv[1:]) File /usr/lib/python2.4/site-packages/ReviewBoard-1.0beta2- py2.4.egg/EGG-INFO/scripts/rb-site, line 1275, in main command.run() File /usr/lib/python2.4/site-packages/ReviewBoard-1.0beta2- py2.4.egg/EGG-INFO/scripts/rb-site, line 912, in run self.show_install_status() File /usr/lib/python2.4/site-packages/ReviewBoard-1.0beta2- py2.4.egg/EGG-INFO/scripts/rb-site, line 1134, in show_install_status site.sync_database) File /usr/lib/python2.4/site-packages/ReviewBoard-1.0beta2- py2.4.egg/EGG-INFO/scripts/rb-site, line 519, in step func() File /usr/lib/python2.4/site-packages/ReviewBoard-1.0beta2- py2.4.egg/EGG-INFO/scripts/rb-site, line 224, in sync_database self.run_manage_command(syncdb, [--noinput]) File /usr/lib/python2.4/site-packages/ReviewBoard-1.0beta2- py2.4.egg/EGG-INFO/scripts/rb-site, line 261, in run_manage_command fix_django_evolution_issues(reviewboard.settings) File /usr/lib/python2.4/site-packages/ReviewBoard-1.0beta2- py2.4.egg/reviewboard/admin/migration.py, line 13, in fix_django_evolution_issues import django.db.models.fields as model_fields File /usr/lib/python2.4/site-packages/Django-1.0.2_final-py2.4.egg/ django/db/__init__.py, line 16, in ? backend = __import__('%s%s.base' % (_import_path, settings.DATABASE_ENGINE), {}, {}, ['']) File /usr/lib/python2.4/site-packages/Django-1.0.2_final-py2.4.egg/ django/db/backends/mysql/base.py, line 22, in ? raise ImproperlyConfigured(MySQLdb-1.2.1p2 or newer is required; you have %s % Database.__version__) django.core.exceptions.ImproperlyConfigured: MySQLdb-1.2.1p2 or newer is required; you have 1.2.1 --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: post-review deployment
Go into rbtools and try running: python setup.py bdist_msi See if that works. It should generate a Windows installer for RBTools that you can hand out. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Tue, Apr 7, 2009 at 11:52 AM, Vesterbaek vesterb...@gmail.com wrote: Hi, I would like to package the post-review tool (+ whatever dependencies there may be) into a zip that I can easily distribute to other developers running either linux or windows. It should be possible to simply download and unzip the file and directly call the post-review script. All developers have python 2.5x installed. I would like to avoid them having to install setuptools, rbtools etc., i.e., have a simple download-and-unzip deployment of post-review. Has anyone done this? Thanks -- Jeppe --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Clearcase
To add support for diffing against any version, you need to implement the ClearCaseTool's get_file function to take into account the specified revision. If you can return the right revision from that, you should be good. That might have to do with why you're seeing the old version in both. You *should* have a patched version in the right-hand side, but there's certainly going to be issues with get_file() not supporting revisions. So I'd look into that first. Also, make sure the code is parsing useful revisions out of the diffs (and the diffs should contain useful revisions to parse). I don't know enough about the clearcase support to know whether this works today. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Tue, Apr 7, 2009 at 6:43 AM, Lars Olsson lars.olsso...@gmail.com wrote: hi, my current status: post-review: - some smaller patches to post-review tool regading filename handling so it finds the files. - configuration of view and server name - removed import cleartool from clearcase.py - In Reviewboard UI, added a new tool for ClearCase using classes in clearcase.py - Added a new repository with clearcase tool. Result: - A diff. is created and uploaded to the server by the post-review tool. - a new pending review request is created. Problems: - When selecting View Diffs, I see the old version of the file in both columns. Download Diffgives the correct diff (uploaded by the post-review tool). Any one knows why? Am I missing something? I have not installed the highlighting tool but that should not affect this, right? - If I would like to diff the current version against any given version ( not only the previous version ) how do I do that? best regards, Lars 2009/4/3 Dan Savilonis d...@n-cube.org I haven't tried the Clearcase support myself, but there is definitely a ClearCaseClient class in post-review. Are you sure you have an up-to- date copy of rbtools? You can see the latest post-review here: http://code.google.com/p/reviewboard/source/browse/trunk/rbtools/scripts/post-review Dan On Apr 2, 8:41 am, Bartlomiej Celary bartlomiej.cel...@gmail.com wrote: Hi, I am looking for that info as well. From what I can see (from today's svn checkout ofhttp:// reviewboard.googlecode.com/svn/trunk/reviewboard) there is a ClearCaseTool class for it. I tried adding a repo tool like so: Tool: Clearcase Class name: reviewboard.scmtools.clearcase.ClearCaseTool But I cannot see any changes in post-review tool. There is no mention about clearcase or cleartool. How do I post diffs for review with clearcase? Best regards, Bartek Celary 2009/3/26 lasseo lars.olsso...@gmail.com: Hi all, As from Review Board 1.0 alpha 2, there is an announced support for Clearcase. Yesterday, I downloaded the alpha 4 version with the hope of getting it up and running against our clearcase environment. Unfortunately, I can not find any documentation on how to configure it for Clearcase. Are there any examples present on the website/net? Can someone please provide hints on how to configure it? My issues so far: - At the moment I can not select Clearcase as tool when adding a new repository - What is the syntax when adding a clearcase repository - How and where do I specify my Clearcase view? All hints are appreciated. Best Regards, Lars --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
getting the max request id via the API
I've been using the API to generate statistics. What I want to do is traverse through all the reviews (no matter what state) and generate my statistics. I can pretty much do this with api/json/reviewrequests/id/ except for determining what the max id is. I wrote a function to do it using the following url: api/json/reviewrequests/all/maxid/ Is this a good url for this api function? Is it useful enough to commit to the codebase? Along the same lines what I really want is a query for all review requests created in a given date range. If I were to write such a function, what would be an appropriate url? Anything I should know before I try? Thanks, Kimon --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Fresh review board never lets me register or do anything...
Hi This is our first time using the product as we review it if suits our needs. We plan to use it with Bazaar. I got the reviewboard and all the dependencies installed. Copying the modpython conf file to apache sites-available directory and when I go to the browser it shows up too. It is always in the login page and when i click on Register it always reverts back to login page. Thus I am not able to setup the site as suggested at: http://www.mail-archive.com/reviewboard@googlegroups.com/msg01548.html During setup, I chose default authentication. Can somebody tell me what simple mistake I am doing? -- Ritesh --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Fresh review board never lets me register or do anything...
There's a bug that will be fixed in the next beta where registration is turned off by default yet appears on in the settings. You'll need to log in as the admin user you created during install, go into the admin UI - General Settings, make sure registration is enabled, and hit Save. It should then work. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Tue, Apr 7, 2009 at 6:55 PM, riteshn rite...@gmail.com wrote: Hi This is our first time using the product as we review it if suits our needs. We plan to use it with Bazaar. I got the reviewboard and all the dependencies installed. Copying the modpython conf file to apache sites-available directory and when I go to the browser it shows up too. It is always in the login page and when i click on Register it always reverts back to login page. Thus I am not able to setup the site as suggested at: http://www.mail-archive.com/reviewboard@googlegroups.com/msg01548.html During setup, I chose default authentication. Can somebody tell me what simple mistake I am doing? -- Ritesh --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: getting the max request id via the API
The date range handler would be good, but I'd rather not have the maxid. However, there's another way we can do that. Update the handler for api/json/reviewrequests/all/ and let it take optional start and end ranges that work like Python's lists. I'd have to think how I want this API to look, but maybe something like: api/json/reviewrequests/all/?start=start indexmax_results=number of resultsorder_by=comma-separated order criteria Then you could do: api/json/reviewrequests/all/?max_results=0order_by=-id And that would return the most recent public review request. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Tue, Apr 7, 2009 at 6:54 PM, Kimon kim...@gmail.com wrote: I've been using the API to generate statistics. What I want to do is traverse through all the reviews (no matter what state) and generate my statistics. I can pretty much do this with api/json/reviewrequests/id/ except for determining what the max id is. I wrote a function to do it using the following url: api/json/reviewrequests/all/maxid/ Is this a good url for this api function? Is it useful enough to commit to the codebase? Along the same lines what I really want is a query for all review requests created in a given date range. If I were to write such a function, what would be an appropriate url? Anything I should know before I try? Thanks, Kimon --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: getting the max request id via the API
Is there a similar call that's already in the codebase I can use as an example? On Apr 7, 7:38 pm, Christian Hammond chip...@chipx86.com wrote: The date range handler would be good, but I'd rather not have the maxid. However, there's another way we can do that. Update the handler for api/json/reviewrequests/all/ and let it take optional start and end ranges that work like Python's lists. I'd have to think how I want this API to look, but maybe something like: api/json/reviewrequests/all/?start=start indexmax_results=number of resultsorder_by=comma-separated order criteria Then you could do: api/json/reviewrequests/all/?max_results=0order_by=-id And that would return the most recent public review request. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Tue, Apr 7, 2009 at 6:54 PM, Kimon kim...@gmail.com wrote: I've been using the API to generate statistics. What I want to do is traverse through all the reviews (no matter what state) and generate my statistics. I can pretty much do this with api/json/reviewrequests/id/ except for determining what the max id is. I wrote a function to do it using the following url: api/json/reviewrequests/all/maxid/ Is this a good url for this api function? Is it useful enough to commit to the codebase? Along the same lines what I really want is a query for all review requests created in a given date range. If I were to write such a function, what would be an appropriate url? Anything I should know before I try? Thanks, Kimon --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Issue 770 in reviewboard: Apache hangs when search enabled
Comment #4 on issue 770 by vesterbaek: Apache hangs when search enabled http://code.google.com/p/reviewboard/issues/detail?id=770 I've installed latest beta of reviewboard + pylucene 2.4.1. My apache2 server does also hang/100%cpu when searching. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1028 in reviewboard: diffviewer does not show all comments
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1028 by ksuszka: diffviewer does not show all comments http://code.google.com/p/reviewboard/issues/detail?id=1028 There is a serious bug in findLineNumRow/addCommentFlags java script functions in ReviewBoard Beta 2 which causes some comments not to appear on diff viewer page. (Almost 30% of all comments is not visible on my reviewboard web site) addCommentFlags calls findLineNumRow function and passes LINE numbers as second and third argument, but findLineNumRow treats second and thirds argument as ROW numbers. As the result, findLineNumRow function narrows the area of search to much. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1028 in reviewboard: diffviewer does not show all comments
Comment #1 on issue 1028 by ksuszka: diffviewer does not show all comments http://code.google.com/p/reviewboard/issues/detail?id=1028 I've just recreated the issue on review board demo page. You can see it: http://demo.review-board.org/r/1621/ There are two comments, click the second comment. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 74 in reviewboard: Need a way to update diff without clobbering other fields
Comment #5 on issue 74 by john.firebaugh: Need a way to update diff without clobbering other fields http://code.google.com/p/reviewboard/issues/detail?id=74 I too got bitten by post-review clobbering the Testing Done field. It seems to me that --diff-only should be the default behavior. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---