Re: Binary Files handling in RB 1.0.5
Chris, I think we have not updated post-review for a while. Where to find it in RB website? Can you point me location? Kunjal On Dec 1, 5:22 pm, Christian Hammond chip...@chipx86.com wrote: Tom is right, they should be filtered so long as Perforce has them listed as binary files. How recent is your post-review? I'd recommend trying a nightly and seeing if the problem goes away. I seem to recall a corrupt patch issue that was fixed when using binary files, which may trigger this. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Tue, Dec 1, 2009 at 5:16 PM, Kunjal kunjal.par...@gmail.com wrote: The perforce has marked them as binary file. Why I get error message instead of some standard message saying this is binary file or similar? Do I need to install some patch ? On Dec 1, 5:04 pm, Tom Sakkos nasis...@gmail.com wrote: Assuming that the files are marked as Binary files in Perforce, Review-Board should ignore them and properly say something along the lines of Binary files differ. -Tom On Tue, Dec 1, 2009 at 6:51 PM, Kunjal kunjal.par...@gmail.com wrote: Hello, In our development environment, we have lot of reviews only with Binary files. For example, If I post the review with 4 binary files, what should happen when I click on View Diff? For now, I just try with one binary file, and I get below message when I click on View Diff. Is there any work-around for binary files? The patch to 'c:/Perforce/Sources/Common/stack/hedge/sdt/usim.sbk' didn't apply cleanly. The temporary files have been left in '/tmp/ reviewboard.6SzZlW' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.6SzZlW/tmpSst3n_ patch: malformed patch at line 21: Traceback (most recent call last): File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ views.py, line 153, in view_diff interdiffset, highlighting, True) File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py, line 623, in get_diff_files large_data=True) File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/Djblets-0.5.5-py2.5.egg/djblets/util/misc.py, line 162, in cache_memoize data = lookup_callable() File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py, line 622, in lambda enable_syntax_highlighting), File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py, line 345, in get_chunks new = get_patched_file(old, filediff) File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py, line 261, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py, line 129, in patch (filename, tempdir, patch_output)) Exception: The patch to 'c:/Perforce/Sources/Common/stack/hedge/sdt/ usim.sbk' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.6SzZlW' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.6SzZlW/tmpSst3n_ patch: malformed patch at line 21: -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com reviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en-Hide quoted text - - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en- Hide quoted text - - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from
Re: ValueError: No JSON object could be decoded
Hi, Is it really reviewboard.com that you're trying to access? Because we don't own that domain :) What's specifying that domain? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Dec 2, 2009 at 4:10 AM, Mahesh vsmait...@gmail.com wrote: Hello brothers, I have installed reviewboard 1.0.1 on a linux(fedora 8) m/c. Everything is working fine in the GUI. But when I try to use the post-review he's giving me some strange error or rather strange to me!! [r...@testvm cli]# /home/mahesh/lib/post-review == Review Board Login Required Enter username and password for Review Board at http://reviewboard.com/ Username: mahesh Password: Traceback (most recent call last): File /home/mahesh/lib/post-review, line 8, in module load_entry_point('RBTools==0.2beta2', 'console_scripts', 'post- review')() File /home/mahesh/lib/RBTools-0.2beta2-py2.6.egg/rbtools/ postreview.py, line 2518, in main File /home/mahesh/lib/RBTools-0.2beta2-py2.6.egg/rbtools/ postreview.py, line 314, in login File /home/mahesh/lib/RBTools-0.2beta2-py2.6.egg/rbtools/ postreview.py, line 575, in api_post File /home/mahesh/lib/RBTools-0.2beta2-py2.6.egg/rbtools/ postreview.py, line 486, in process_json File /usr/lib/python2.6/json/__init__.py, line 307, in loads return _default_decoder.decode(s) File /usr/lib/python2.6/json/decoder.py, line 319, in decode obj, end = self.raw_decode(s, idx=_w(s, 0).end()) File /usr/lib/python2.6/json/decoder.py, line 338, in raw_decode raise ValueError(No JSON object could be decoded) ValueError: No JSON object could be decoded Can anyone pls help me to get out of this?? Don feel bad if it is a very basic one!! Thanks, Mahesh -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: post-review with bypass proxy settings in Internet Explorer
Yeah, modifying postreview.py isn't ideal. It was just one suggestion. What I'd like to see, I think, is an optional configuration variable in the user's .reviewboardrc that allows users to control post-review's proxy settings manually. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Dec 2, 2009 at 11:42 AM, Akhilesh akhileshjo...@gmail.com wrote: thanks Christian for suggestion. I thought if I modify postreview.py then it will be difficult for me to roll out official updates to individual users. I did a workaround. Wrote following wrapper script to disable/enable proxy. It's dirty but serves my purpose: import _winreg, os, sys if len(sys.argv) != 2: print Usage: rr ChangeListId sys.exit(0) root = _winreg.HKEY_CURRENT_USER keypath = Software\Microsoft\Windows\CurrentVersion\Internet Settings value_name = ProxyEnable hKey = _winreg.OpenKey (root, keypath, 0, _winreg.KEY_READ | _winreg.KEY_SET_VALUE) existingValue, type = _winreg.QueryValueEx (hKey, value_name) #Disable Proxy setting if ON. if existingValue == 1: _winreg.SetValueEx (hKey, value_name, 0, _winreg.REG_DWORD, 0) # Call post-review.exe command = post-review + sys.argv[1] os.system(command) # If original setting was PROXY ON then turn it ON. if existingValue == 1: _winreg.SetValueEx (hKey, value_name, 0, _winreg.REG_DWORD, 1) _winreg.CloseKey(hKey) On Nov 24, 4:45 pm, Christian Hammond chip...@chipx86.com wrote: Is the Review Board server on HTTP or HTTPS? It sounds like custom code would need to be added to specifically disable the proxy server. It's also possible that a 2.6 release would fix this issue, but I don't know. If you were to modify postreview.py , you could try adding some code like: proxy_support = urllib2.ProxyHandler({}) opener = urllib2.build_opener(proxy_support) urllib2.install_opener(opener) in ReviewBoardServer.__init__ probably at the end. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Tue, Nov 24, 2009 at 4:30 PM, Akhilesh akhileshjo...@gmail.com wrote: Thanks Christian. I tried setting http_proxy environment variable to empty string but Windows wouldn't allow me. I set it to (with space) - but as expected it didn't work. Is there any work-around? The problem is that one of the sites in our organization uses proxy and all developers from that site have to toggle Proxy settings to access Reviewboard/Internet as by-pass proxy option is not working for them. I appreciate any help. I'm ready to test private code for post-review as well if needed. Regards, Akhilesh On Nov 24, 1:57 pm, Christian Hammond chip...@chipx86.com wrote: Sadly, this is due to Python's usage of the system proxy settings. I'd have to see if there's anything we can do for this. On Linux, I know you can set the HTTP_PROXY variable to an empty string to work around it, but I doubt that works on Windows... Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Tue, Nov 24, 2009 at 8:16 AM, Akhilesh akhileshjo...@gmail.com wrote: We are facing a problem where if proxy settings are enabled in Internet Explorer, post-review doesn't work (Proxy Error 502) but I we disabled proxy settings, it works perfectly. so we added reviewboard site under 'bypass proxy' settings (Exceptions) but still same problem. It appears that post-review doesn't honor the bypass proxy settings. We have Python 2.5 installed. Further, reviewboard site is accessible using Internet Explorer whether proxy settings are on/off. Here is trace of the error that we get from post-review - I see the error returned by Proxy. Point is that we want to bypass the proxy but that setting in IE is not honored. any ideas? UL class=adminList LI id=L_10060_11Error Code 10060: Connection timeout LI id=L_10060_12Background: The gateway could not receive a timely response fr om the website you are trying to access. This might indicate that the network is congested, or that the website is experiencing technical difficulties. LI id=L_10060_13Date: 11/16/2009 9:44:32 PM LI id=L_10060_14Server: Server.Company.Com ==Replaced LI id=L_10060_15Source: Firewall /UL /TD /TR /TBODY /TABLE /BODY /HTML Unable to accesshttp://10.0.3.83/api/json/accounts/login/. The host path may be invalid HTTP Error 504: Proxy Timeout ( The connection timed out. For more information a bout this event, see ISA Server Help. ) -- Want to help the Review Board
Re: Binary Files handling in RB 1.0.5
Hi Kunjal, See: http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/ And the section on nightlies at: http://www.reviewboard.org/docs/manual/dev/admin/installation/development-releases/ Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Dec 2, 2009 at 10:42 AM, Kunjal kunjal.par...@gmail.com wrote: Chris, I think we have not updated post-review for a while. Where to find it in RB website? Can you point me location? Kunjal On Dec 1, 5:22 pm, Christian Hammond chip...@chipx86.com wrote: Tom is right, they should be filtered so long as Perforce has them listed as binary files. How recent is your post-review? I'd recommend trying a nightly and seeing if the problem goes away. I seem to recall a corrupt patch issue that was fixed when using binary files, which may trigger this. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Tue, Dec 1, 2009 at 5:16 PM, Kunjal kunjal.par...@gmail.com wrote: The perforce has marked them as binary file. Why I get error message instead of some standard message saying this is binary file or similar? Do I need to install some patch ? On Dec 1, 5:04 pm, Tom Sakkos nasis...@gmail.com wrote: Assuming that the files are marked as Binary files in Perforce, Review-Board should ignore them and properly say something along the lines of Binary files differ. -Tom On Tue, Dec 1, 2009 at 6:51 PM, Kunjal kunjal.par...@gmail.com wrote: Hello, In our development environment, we have lot of reviews only with Binary files. For example, If I post the review with 4 binary files, what should happen when I click on View Diff? For now, I just try with one binary file, and I get below message when I click on View Diff. Is there any work-around for binary files? The patch to 'c:/Perforce/Sources/Common/stack/hedge/sdt/usim.sbk' didn't apply cleanly. The temporary files have been left in '/tmp/ reviewboard.6SzZlW' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.6SzZlW/tmpSst3n_ patch: malformed patch at line 21: Traceback (most recent call last): File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ views.py, line 153, in view_diff interdiffset, highlighting, True) File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py, line 623, in get_diff_files large_data=True) File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/Djblets-0.5.5-py2.5.egg/djblets/util/misc.py, line 162, in cache_memoize data = lookup_callable() File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py, line 622, in lambda enable_syntax_highlighting), File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py, line 345, in get_chunks new = get_patched_file(old, filediff) File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py, line 261, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) File /projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site- packages/ReviewBoard-1.0.5.1-py2.5.egg/reviewboard/diffviewer/ diffutils.py, line 129, in patch (filename, tempdir, patch_output)) Exception: The patch to 'c:/Perforce/Sources/Common/stack/hedge/sdt/ usim.sbk' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.6SzZlW' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.6SzZlW/tmpSst3n_ patch: malformed patch at line 21: -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com reviewboard%2bunsubscr...@googlegroups.com reviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en-Hide quoted text - - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know
Re: post-review with bypass proxy settings in Internet Explorer
My 2 cents. Modifying the registry and then restoring is not a great idea. I can see why you are doing it but I'd encourage you to NOT do this. There is a potential here for a background web app to fail (e.g. web browser based IM tool). I'd be tempted to monkey patch urllib(2), presumably that is the beast causing the issue here if you want a quick solution. Either monkey patch urllib OR monkey patch _winreg lookup that urllib relies on. As the real Chris said, improving postreview and getting the code into the main git repo is the ideal solution here. You may be the first to hit this but you are not going to be the last :-) so it it would be good to get a more robust solution. Chris Christian Hammond wrote: Yeah, modifying postreview.py isn't ideal. It was just one suggestion. What I'd like to see, I think, is an optional configuration variable in the user's .reviewboardrc that allows users to control post-review's proxy settings manually. Christian -- Christian Hammond - chip...@chipx86.com mailto:chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Dec 2, 2009 at 11:42 AM, Akhilesh akhileshjo...@gmail.com mailto:akhileshjo...@gmail.com wrote: thanks Christian for suggestion. I thought if I modify postreview.py then it will be difficult for me to roll out official updates to individual users. I did a workaround. Wrote following wrapper script to disable/enable proxy. It's dirty but serves my purpose: import _winreg, os, sys if len(sys.argv) != 2: print Usage: rr ChangeListId sys.exit(0) root = _winreg.HKEY_CURRENT_USER keypath = Software\Microsoft\Windows\CurrentVersion\Internet Settings value_name = ProxyEnable hKey = _winreg.OpenKey (root, keypath, 0, _winreg.KEY_READ | _winreg.KEY_SET_VALUE) existingValue, type = _winreg.QueryValueEx (hKey, value_name) #Disable Proxy setting if ON. if existingValue == 1: _winreg.SetValueEx (hKey, value_name, 0, _winreg.REG_DWORD, 0) # Call post-review.exe command = post-review + sys.argv[1] os.system(command) # If original setting was PROXY ON then turn it ON. if existingValue == 1: _winreg.SetValueEx (hKey, value_name, 0, _winreg.REG_DWORD, 1) _winreg.CloseKey(hKey) On Nov 24, 4:45 pm, Christian Hammond chip...@chipx86.com mailto:chip...@chipx86.com wrote: Is the Review Board server on HTTP or HTTPS? It sounds like custom code would need to be added to specifically disable the proxy server. It's also possible that a 2.6 release would fix this issue, but I don't know. If you were to modify postreview.py , you could try adding some code like: proxy_support = urllib2.ProxyHandler({}) opener = urllib2.build_opener(proxy_support) urllib2.install_opener(opener) in ReviewBoardServer.__init__ probably at the end. Christian -- Christian Hammond - chip...@chipx86.com mailto:chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Tue, Nov 24, 2009 at 4:30 PM, Akhilesh akhileshjo...@gmail.com mailto:akhileshjo...@gmail.com wrote: Thanks Christian. I tried setting http_proxy environment variable to empty string but Windows wouldn't allow me. I set it to (with space) - but as expected it didn't work. Is there any work-around? The problem is that one of the sites in our organization uses proxy and all developers from that site have to toggle Proxy settings to access Reviewboard/Internet as by-pass proxy option is not working for them. I appreciate any help. I'm ready to test private code for post-review as well if needed. Regards, Akhilesh On Nov 24, 1:57 pm, Christian Hammond chip...@chipx86.com mailto:chip...@chipx86.com wrote: Sadly, this is due to Python's usage of the system proxy settings. I'd have to see if there's anything we can do for this. On Linux, I know you can set the HTTP_PROXY variable to an empty string to work around it, but I doubt that works on Windows... Christian -- Christian Hammond - chip...@chipx86.com mailto:chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Tue, Nov 24, 2009 at 8:16 AM, Akhilesh akhileshjo...@gmail.com mailto:akhileshjo...@gmail.com wrote: We are facing a problem where if proxy settings are enabled in Internet Explorer, post-review doesn't work (Proxy Error 502) but I we disabled proxy settings, it works perfectly. so we added
Re: ValueError: No JSON object could be decoded
Have you tried using the: --server= flag? RE the version of reviewboard, if this is a new install I would go ahead and use 1.0.5.1 this shouldn't impact the error you are seeing but why use an old version when you can use the new stable one ;-) Chris Christian Hammond wrote: Hi, Is it really reviewboard.com http://reviewboard.com that you're trying to access? Because we don't own that domain :) What's specifying that domain? Christian -- Christian Hammond - chip...@chipx86.com mailto:chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Dec 2, 2009 at 4:10 AM, Mahesh vsmait...@gmail.com mailto:vsmait...@gmail.com wrote: Hello brothers, I have installed reviewboard 1.0.1 on a linux(fedora 8) m/c. Everything is working fine in the GUI. But when I try to use the post-review he's giving me some strange error or rather strange to me!! [r...@testvm cli]# /home/mahesh/lib/post-review == Review Board Login Required Enter username and password for Review Board at http://reviewboard.com/ Username: mahesh Password: Traceback (most recent call last): File /home/mahesh/lib/post-review, line 8, in module load_entry_point('RBTools==0.2beta2', 'console_scripts', 'post- review')() File /home/mahesh/lib/RBTools-0.2beta2-py2.6.egg/rbtools/ postreview.py, line 2518, in main File /home/mahesh/lib/RBTools-0.2beta2-py2.6.egg/rbtools/ postreview.py, line 314, in login File /home/mahesh/lib/RBTools-0.2beta2-py2.6.egg/rbtools/ postreview.py, line 575, in api_post File /home/mahesh/lib/RBTools-0.2beta2-py2.6.egg/rbtools/ postreview.py, line 486, in process_json File /usr/lib/python2.6/json/__init__.py, line 307, in loads return _default_decoder.decode(s) File /usr/lib/python2.6/json/decoder.py, line 319, in decode obj, end = self.raw_decode(s, idx=_w(s, 0).end()) File /usr/lib/python2.6/json/decoder.py, line 338, in raw_decode raise ValueError(No JSON object could be decoded) ValueError: No JSON object could be decoded Can anyone pls help me to get out of this?? Don feel bad if it is a very basic one!! Thanks, Mahesh -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com mailto:reviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Submitting patches, subversion post-review support for already committed revisions
Hi Jason, A standard diff -u doesn't contain the revision information needed, and a git diff by default uses short SHA1s, which we can't use to fetch the files. You will need to use either post-review (recommended) or git diff --full-index. post-review with Subversion should support renames and posting diffs of existing commits. What versions of Review Board and of post-review are you using? Can you show me exactly what happens with post-review in the two cases (renames and existing commits)? You can run post-review with --debug for more information, which would help to diagnose an issue. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Dec 2, 2009 at 7:04 PM, Jason Felice jason.m.fel...@gmail.comwrote: First, I tried to submit a patch to reviewboard's reviewboard, but it is behaving strangely. It won't accept a standard diff -u or a git diff --cached. Second, there is conflicting info on whether subversion post-commit reviews are supported with post-review. I'm having problems submitting subversion diffs with file renames in them and using post-review for committed revisions with files in them. What's going on? Thanks... -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en