Re: SHIP IT countre is zero even if reviewer clicks ship it.

2010-02-01 Thread Kunjal
Ok. It looks like I found the issue. I am doing query on incorrect table.. Let me try this out. On Jan 29, 2:22 pm, Christian Hammond chip...@chipx86.com wrote: Hi, I'd love to provide a patch, except I don't think Review Board is broken. This works fine from what I can tell, and the code

Re: SHIP IT countre is zero even if reviewer clicks ship it.

2010-02-01 Thread Kunjal
so, what is the diff between ship_it and shipit_count? If there is at-least one ship it marked, the value of ship_it should not be one? I understand that ship_it is providing 0 or 1 only. It is not the actual count. Just want to understand why if the review is approved, ship_it is still zero?

Re: SHIP IT countre is zero even if reviewer clicks ship it.

2010-02-01 Thread Christian Hammond
ship_it is a flag on a review indicating whether or not that particular review says that the review request is, in the reviewer's opinion, ready to be shipped. shipit_count on the Review Request is a counter of the total number of reviews made on that review request where ship_it=1. If the

About Installation of RBTools (post-review)

2010-02-01 Thread qhlonline
Hi, everybody. I would like to install post-review customly but not through Python easy_install. Easy_install will install post-view in the path PYTHONHOME/lib/site-packages/. And after easy_install, We can execute post-review command any where (If not in CVS directory, it will report

Fields error on windows with svn

2010-02-01 Thread Jan Koprowski
I made experiment. I create very simple svn repository on linux and try use post-review for it on Windows and on Linux. What I get: On Linux: HTTP POSTing to http://192.168.56.2/api/json/reviewrequests/11/diff/new/: {'basedir': '/'} --127.0.1.1.1000.2795.1265030375.375.2 Content-Disposition:

Email notifications to review Groups not working when there is an entry for People

2010-02-01 Thread Nizar
Hi, I see that the the review request notifications to the reviewers specified in the Groups field are not sent out if there is an entry in the People field. It works fine if there are only Groups or People. Also, any option to specify if a reviewer should be notified as To or Cc? Thanks,

Re: Fields error on windows with svn

2010-02-01 Thread Christian Hammond
Hmm.. Very hard to say. They certainly look identical. What version of Review Board is this? I believe the 1.1 nightlies have some additional server-side logging for these errors, but either way, it might be worth instrumenting the server to find out where exactly it's failing. Take a look at the

Re: About Installation of RBTools (post-review)

2010-02-01 Thread Christian Hammond
Hi, You should be able to control where easy_install is installing things by using the -d (--install-dir) and -s (--script-dir) options. I *think* the -s option will control where that script is installed, but I'm not 100% sure off-hand. By default, the scripts are installed in a system

Re: Email notifications to review Groups not working when there is an entry for People

2010-02-01 Thread Christian Hammond
Are the groups set up to use a mailing list, or do they e-mail out to the individual users on the group? What version of Review Board is this? There aren't any options to specify To vs CC. The way the logic works is that if there are people set under the People list, then the To field will have

What is best approach for setup with multiport, multiproject perforce repository

2010-02-01 Thread Onkar
We are evaluating the use of reviewboard for reviews on a multiport, multiproject perforce repository. For example consider following scenario. 1. There are two perforce servers running on different host:port combinations. 2. Each of these servers host codelines for 3 different projects. These

Re: Fields error on windows with svn

2010-02-01 Thread Jan Koprowski
Hi Christian! I use Reviewboard 1.0.5.1. I can check it on ReviewBoard 1.1. I looked to both this files when I get this error with ClearCase (I don't check clearcase on linux yet but on windows they generate identical error). So the problem was in diffviewer/forms.py in class