Re: Error when upgrading to 1.5.1

2010-11-22 Thread Christian Hammond
Looks like a regression in Djblets due to some fixes for Django
1.2/1.3. I'll try to get this fixed and updated ASAP.

Christian

--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com



On Mon, Nov 22, 2010 at 3:14 AM, Mikko Matilainen mik...@iki.fi wrote:
 Hi,
 After successfully executing easy_install -U ReviewBoard I ran into
 problems when performing the site upgrade:
 C:\rb-site upgrade C:\Program Files\Apache Software
 Foundation\Apache2.2\htdocs\reviewboard.example.com
 Rebuilding directory structure
 Updating database. This may take a while.
 Upgrading Review Board from 1.5 to 1.5.1
 Traceback (most recent call last):
   File C:\Python25\Scripts\rb-site-script.py, line 8, in module
     load_entry_point('ReviewBoard==1.5.1', 'console_scripts', 'rb-site')()
   File
 c:\python25\lib\site-packages\ReviewBoard-1.5.1-py2.5.egg\reviewboard\cmdline\rbsite.py,
 line 1611, in main
     command.run()
   File
 c:\python25\lib\site-packages\ReviewBoard-1.5.1-py2.5.egg\reviewboard\cmdline\rbsite.py,
 line 1511, in run
     site.sync_database()
   File
 c:\python25\lib\site-packages\ReviewBoard-1.5.1-py2.5.egg\reviewboard\cmdline\rbsite.py,
 line 339, in sync_database
     self.run_manage_command(syncdb, params)
   File
 c:\python25\lib\site-packages\ReviewBoard-1.5.1-py2.5.egg\reviewboard\cmdline\rbsite.py,
 line 397, in run_manage_command
     execute_manager(reviewboard.settings, [__file__, cmd] + params)
   File
 C:\Python25\lib\site-packages\django-1.1.1-py2.5.egg\django\core\management\__init__.py,
 line 362, in execute_manager
     utility.execute()
   File
 C:\Python25\lib\site-packages\django-1.1.1-py2.5.egg\django\core\management\__init__.py,
 line 303, in execute
     self.fetch_command(subcommand).run_from_argv(self.argv)
   File
 C:\Python25\lib\site-packages\django-1.1.1-py2.5.egg\django\core\management\base.py,
 line 195, in run_from_argv
     self.execute(*args, **options.__dict__)
   File
 C:\Python25\lib\site-packages\django-1.1.1-py2.5.egg\django\core\management\base.py,
 line 222, in execute
     output = self.handle(*args, **options)
   File
 C:\Python25\lib\site-packages\django-1.1.1-py2.5.egg\django\core\management\base.py,
 line 351, in handle
     return self.handle_noargs(**options)
   File
 C:\Python25\lib\site-packages\django-1.1.1-py2.5.egg\django\core\management\commands\syncdb.py,
 line 99, in handle_noargs
     emit_post_sync_signal(created_models, verbosity, interactive)
   File
 C:\Python25\lib\site-packages\django-1.1.1-py2.5.egg\django\core\management\sql.py,
 line 205, in emit_post_sync_signal
     interactive=interactive)
   File
 C:\Python25\lib\site-packages\django-1.1.1-py2.5.egg\django\dispatch\dispatcher.py,
 line 166, in send
     response = receiver(signal=self, sender=sender, **named)
   File
 c:\python25\lib\site-packages\ReviewBoard-1.5.1-py2.5.egg\reviewboard\admin\management\sites.py,
 line 54, in init_siteconfig
     siteconfig.save()
   File
 c:\python25\lib\site-packages\Djblets-0.6.5-py2.5.egg\djblets\siteconfig\models.py,
 line 129, in save
     super(SiteConfiguration, self).save(**kwargs)
   File
 C:\Python25\lib\site-packages\django-1.1.1-py2.5.egg\django\db\models\base.py,
 line 410, in save
     self.save_base(force_insert=force_insert, force_update=force_update)
   File
 C:\Python25\lib\site-packages\django-1.1.1-py2.5.egg\django\db\models\base.py,
 line 474, in save_base
     rows = manager.filter(pk=pk_val)._update(values)
   File
 C:\Python25\lib\site-packages\django-1.1.1-py2.5.egg\django\db\models\query.py,
 line 442, in _update
     query.add_update_fields(values)
   File
 C:\Python25\lib\site-packages\django-1.1.1-py2.5.egg\django\db\models\sql\subqueries.py,
 line 245, in add_update_fields
     val = field.get_db_prep_save(val)
   File
 c:\python25\lib\site-packages\Djblets-0.6.5-py2.5.egg\djblets\util\fields.py,
 line 185, in get_db_prep_save
     return super(JSONField, self).get_db_prep_save(value, connection=None)
 TypeError: get_db_prep_save() got an unexpected keyword argument
 'connection'

 Blindly changing line 185 in fields.py from
         return super(JSONField, self).get_db_prep_save(value,
 connection=None)
 to
         return super(JSONField, self).get_db_prep_save(value)
 got rid of the error. Probably there was no need to even run the upgrade
 command in this case, but I just wanted to be sure.
 --
 Mikko

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/

Re: Error when upgrading to 1.5.1

2010-11-22 Thread Christian Hammond
I just put out a quick 0.6.6 release that fixes this regression. You
can install it with:

easy_install -U Djblets

Christian

--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com



On Mon, Nov 22, 2010 at 3:36 AM, Christian Hammond chip...@chipx86.com wrote:
 Looks like a regression in Djblets due to some fixes for Django
 1.2/1.3. I'll try to get this fixed and updated ASAP.

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.reviewboard.org
 VMware, Inc. - http://www.vmware.com



 On Mon, Nov 22, 2010 at 3:14 AM, Mikko Matilainen mik...@iki.fi wrote:
 Hi,
 After successfully executing easy_install -U ReviewBoard I ran into
 problems when performing the site upgrade:
 C:\rb-site upgrade C:\Program Files\Apache Software
 Foundation\Apache2.2\htdocs\reviewboard.example.com
 Rebuilding directory structure
 Updating database. This may take a while.
 Upgrading Review Board from 1.5 to 1.5.1
 Traceback (most recent call last):
   File C:\Python25\Scripts\rb-site-script.py, line 8, in module
     load_entry_point('ReviewBoard==1.5.1', 'console_scripts', 'rb-site')()
   File
 c:\python25\lib\site-packages\ReviewBoard-1.5.1-py2.5.egg\reviewboard\cmdline\rbsite.py,
 line 1611, in main
     command.run()
   File
 c:\python25\lib\site-packages\ReviewBoard-1.5.1-py2.5.egg\reviewboard\cmdline\rbsite.py,
 line 1511, in run
     site.sync_database()
   File
 c:\python25\lib\site-packages\ReviewBoard-1.5.1-py2.5.egg\reviewboard\cmdline\rbsite.py,
 line 339, in sync_database
     self.run_manage_command(syncdb, params)
   File
 c:\python25\lib\site-packages\ReviewBoard-1.5.1-py2.5.egg\reviewboard\cmdline\rbsite.py,
 line 397, in run_manage_command
     execute_manager(reviewboard.settings, [__file__, cmd] + params)
   File
 C:\Python25\lib\site-packages\django-1.1.1-py2.5.egg\django\core\management\__init__.py,
 line 362, in execute_manager
     utility.execute()
   File
 C:\Python25\lib\site-packages\django-1.1.1-py2.5.egg\django\core\management\__init__.py,
 line 303, in execute
     self.fetch_command(subcommand).run_from_argv(self.argv)
   File
 C:\Python25\lib\site-packages\django-1.1.1-py2.5.egg\django\core\management\base.py,
 line 195, in run_from_argv
     self.execute(*args, **options.__dict__)
   File
 C:\Python25\lib\site-packages\django-1.1.1-py2.5.egg\django\core\management\base.py,
 line 222, in execute
     output = self.handle(*args, **options)
   File
 C:\Python25\lib\site-packages\django-1.1.1-py2.5.egg\django\core\management\base.py,
 line 351, in handle
     return self.handle_noargs(**options)
   File
 C:\Python25\lib\site-packages\django-1.1.1-py2.5.egg\django\core\management\commands\syncdb.py,
 line 99, in handle_noargs
     emit_post_sync_signal(created_models, verbosity, interactive)
   File
 C:\Python25\lib\site-packages\django-1.1.1-py2.5.egg\django\core\management\sql.py,
 line 205, in emit_post_sync_signal
     interactive=interactive)
   File
 C:\Python25\lib\site-packages\django-1.1.1-py2.5.egg\django\dispatch\dispatcher.py,
 line 166, in send
     response = receiver(signal=self, sender=sender, **named)
   File
 c:\python25\lib\site-packages\ReviewBoard-1.5.1-py2.5.egg\reviewboard\admin\management\sites.py,
 line 54, in init_siteconfig
     siteconfig.save()
   File
 c:\python25\lib\site-packages\Djblets-0.6.5-py2.5.egg\djblets\siteconfig\models.py,
 line 129, in save
     super(SiteConfiguration, self).save(**kwargs)
   File
 C:\Python25\lib\site-packages\django-1.1.1-py2.5.egg\django\db\models\base.py,
 line 410, in save
     self.save_base(force_insert=force_insert, force_update=force_update)
   File
 C:\Python25\lib\site-packages\django-1.1.1-py2.5.egg\django\db\models\base.py,
 line 474, in save_base
     rows = manager.filter(pk=pk_val)._update(values)
   File
 C:\Python25\lib\site-packages\django-1.1.1-py2.5.egg\django\db\models\query.py,
 line 442, in _update
     query.add_update_fields(values)
   File
 C:\Python25\lib\site-packages\django-1.1.1-py2.5.egg\django\db\models\sql\subqueries.py,
 line 245, in add_update_fields
     val = field.get_db_prep_save(val)
   File
 c:\python25\lib\site-packages\Djblets-0.6.5-py2.5.egg\djblets\util\fields.py,
 line 185, in get_db_prep_save
     return super(JSONField, self).get_db_prep_save(value, connection=None)
 TypeError: get_db_prep_save() got an unexpected keyword argument
 'connection'

 Blindly changing line 185 in fields.py from
         return super(JSONField, self).get_db_prep_save(value,
 connection=None)
 to
         return super(JSONField, self).get_db_prep_save(value)
 got rid of the error. Probably there was no need to even run the upgrade
 command in this case, but I just wanted to be sure.
 --
 Mikko

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To