Re: Enable a use to mark other users' requests as submitted

2011-02-11 Thread Clemens Ballarin
I double checked this and Can change status does in fact enable to  
mark other users' requests as submitted.


Clemens


On 8 Feb 2011, at 00:23, Christian Hammond wrote:


Hi,

The Can change status should definitely be it. I didn't see  
anything requiring staff access, but maybe. Can you file a bug?


Christian

--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Thu, Feb 3, 2011 at 8:16 AM, Clemens Ballarin  
balla...@aicas.com wrote:

Hi all,

I would like to give a user the ability to mark other users'  
requests as submitted without giving staff or superuser status.


I tried these permissions

 reviews | review request | Can change status
 reviews | review request | Can submit as another user

but that wasn't sufficient.

Clemens

--
Dr. Clemens Ballarin -- Senior Software Engineer

aicas GmbH  *  Haid-und-Neu-Straße 18  *  D-76131 Karlsruhe  *   
Germany

http://www.aicas.com  *  phone +49 721 663 968-35  *  fax -99

USt-Id: DE216375633, Handelsregister HRB 109481, AG Mannheim
Geschäftsführer: Dr. James J. Hunt

--
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


--
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


--
Dr. Clemens Ballarin -- Senior Software Engineer

aicas GmbH  *  Haid-und-Neu-Straße 18  *  D-76131 Karlsruhe  *  Germany
http://www.aicas.com  *  phone +49 721 663 968-35  *  fax -99

USt-Id: DE216375633, Handelsregister HRB 109481, AG Mannheim
Geschäftsführer: Dr. James J. Hunt

--
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Problem posting diff

2011-02-11 Thread Jerry
I recently set up ReviewBoard connecting to a mercurial repository.
When trying to post a diff through the web UI, I get an error:

The file build.xml (revision ef6b39fd44d9) was not found in the
repository

I have verified that this file with this revision number is in the
repo.  The mercurial repository path is set to http://ServerName/RepoName
(this lists files at the root of the repo, like .hg).  That's where
build.xml is located, and I can see it in a web browser.

Am I setting up the mercurial path incorrectly?

Thanks,

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Problem posting diff

2011-02-11 Thread Christian Hammond
Hi Jerry,

Have you tried post-review or hg post-review? Can you try these (with debug
mode on, which is --debug on post-review at least, dunno about hg
post-review) and see if you still hit this problem? If so, the debug log
would be helpful in identifying the problem.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Fri, Feb 11, 2011 at 11:51 AM, Jerry gpjerrymalo...@gmail.com wrote:

 I recently set up ReviewBoard connecting to a mercurial repository.
 When trying to post a diff through the web UI, I get an error:

 The file build.xml (revision ef6b39fd44d9) was not found in the
 repository

 I have verified that this file with this revision number is in the
 repo.  The mercurial repository path is set to http://ServerName/RepoName
 (this lists files at the root of the repo, like .hg).  That's where
 build.xml is located, and I can see it in a web browser.

 Am I setting up the mercurial path incorrectly?

 Thanks,

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Problem posting diff

2011-02-11 Thread Jerry
Thanks, Christian.  I had tried hg postreview from mdelagra's fork
(https://bitbucket.org/mdelagra/mercurial-reviewboard) first, and was
unsuccessful, so I went to the GUI to try to eliminate that as a
culprit.  Is this the tool you are referring to?

Here is the --debug result from that (I added some output to explain
the HTTP 400 error):

-

$ hg postreview tip -g -o --debug
postreview plugin, version 3.5.0
running C:\cygwin\bin\ssh scm hg -R /opt/hg/main/core/
AnyModalConsole serve --stdio
sending hello command
sending between command
remote: 79
remote: capabilities: unbundle lookup changegroupsubset branchmap
pushkey stream=65537
remote: 1
sending heads command
searching for changes
common changesets up to 8611b86cc9dc ef6b39fd44d9

=== Diff from parent to rev ===
diff -r ef6b39fd44d9fcacc3e3b9d825c49b07acf17e2c -r
ebefc4bde45bce94672ee937cac8df0eb5f48135 build.xml
--- a/build.xml Wed Feb 02 16:05:49 2011 -0500
+++ b/build.xml Fri Feb 11 14:41:58 2011 -0500
@@ -4,6 +4,7 @@
  basedir=.
  xmlns:ivy=antlib:org.apache.ivy.ant
  !--xmlns:ac=net.sf.antcontrib--
+  !-- some stupid comment --
   property environment=env/
   property name=devTools.dir value=${env.DEVTOOLS} /
   import file=${devTools.dir}/default-build.xml/

changesets:
259:ebefc4bde45b asfd

reviewboard:http://of1dvweb-lnx001/

username: jerry.maloney
password: **
abort: HTTP 400 Error: Bad Request POST 
http://of1dvweb-lnx001/api/review-requests/63/diffs/
(None)

-

I'll try post-review (not hg post-review) now to see if I get
different results.

Thanks,



On Feb 11, 3:16 pm, Christian Hammond chip...@chipx86.com wrote:
 Hi Jerry,

 Have you tried post-review or hg post-review? Can you try these (with debug
 mode on, which is --debug on post-review at least, dunno about hg
 post-review) and see if you still hit this problem? If so, the debug log
 would be helpful in identifying the problem.

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board -http://www.reviewboard.org
 VMware, Inc. -http://www.vmware.com

 On Fri, Feb 11, 2011 at 11:51 AM, Jerry gpjerrymalo...@gmail.com wrote:
  I recently set up ReviewBoard connecting to a mercurial repository.
  When trying to post a diff through the web UI, I get an error:

  The file build.xml (revision ef6b39fd44d9) was not found in the
  repository

  I have verified that this file with this revision number is in the
  repo.  The mercurial repository path is set tohttp://ServerName/RepoName
  (this lists files at the root of the repo, like .hg).  That's where
  build.xml is located, and I can see it in a web browser.

  Am I setting up the mercurial path incorrectly?

  Thanks,

  --
  Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
  Happy user? Let us know athttp://www.reviewboard.org/users/
  -~--~~~~--~~--~--~---
  To unsubscribe from this group, send email to
  reviewboard+unsubscr...@googlegroups.com
  For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en



-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


post-review with git-svn parent throwing error

2011-02-11 Thread Martin
Hi everyone,

I'm working with git-svn and the post-review command is failing when
working on branches. I'm using the --parent and there are differences
between the branches and the master.

My repo is like this:

* master - The one that fetches from svn trunk
  mockito_refactor - Branched from master
  mockito_refactor_models - Branched from mockito-refactor

I did a review between mockito-refactor and master as usual, but
between mockito-refactor-models and mockito-refactor fails.

This is what I'm running
laptop15:~/dev/models/quijote.git:mockito_refactor_models$ post-review
--parent=mockito_refactor --guess_summary --guess-description

And this is the error:
Traceback (most recent call last):
  File /usr/local/bin/post-review, line 9, in module
load_entry_point('RBTools==0.2', 'console_scripts', 'post-review')
()
  File /usr/local/lib/python2.6/dist-packages/RBTools-0.2-py2.6.egg/
rbtools/postreview.py, line 2861, in main
submit_as=options.submit_as)
  File /usr/local/lib/python2.6/dist-packages/RBTools-0.2-py2.6.egg/
rbtools/postreview.py, line 2554, in tempt_fate
parent_diff_content)
  File /usr/local/lib/python2.6/dist-packages/RBTools-0.2-py2.6.egg/
rbtools/postreview.py, line 503, in upload_diff
debug(Uploading diff, size: %d % len(diff_content))
TypeError: object of type 'NoneType' has no len()

If I run git diff between the branches I see all the differences.

Does anyone knows why this is failing?

The server runs 1.5.1 version.

Thanks,
Martin

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Issue Upgrading.

2011-02-11 Thread Sapna Vempati
Hi Christian,

Using the below command for upgrade, upgrades to the latest version (1.5.3)
by default. Is there a way we can upgrade to an older version we prefer ?
Like for example, we want to do install to RB1.5.1. Is it possible ?

  easy_install -U ReviewBoard

Also, from the release notes, looks like this version has a newer RBTools.
Is this compatible with older RB versions ?

When we try to upgrade using the above command, we got the below error, so
that's the reason we want to go back to older version to see if that works.

  #[root@mob-rb-test /]# rb-site --debug upgrade
  /opt/lampp/htdocs/reviewboard
  Rebuilding directory structure
  Updating database. This may take a while.
  [NOTICE@1297389237.811425] mcm_storage_cmd():3334:
unable to store value: add
  [NOTICE@1297389237.845006] mcm_storage_cmd():3334:
unable to store value: add
  [NOTICE@1297389237.866137] mcm_storage_cmd():3334:
unable to store value: add
  [NOTICE@1297389237.900860] mcm_storage_cmd():3334:
unable to store value: add
  [NOTICE@1297389237.934480] mcm_storage_cmd():3334:
unable to store value: add
  [NOTICE@1297389237.967112] mcm_storage_cmd():3334:
unable to store value: add
  [NOTICE@1297389238.012221] mcm_storage_cmd():3334:
unable to store value: add
  [NOTICE@1297389238.048986] mcm_storage_cmd():3334:
unable to store value: add
  [NOTICE@1297389238.104145] mcm_storage_cmd():3334:
unable to store value: add
  [NOTICE@1297389238.224780] mcm_storage_cmd():3334:
unable to store value: add
  [NOTICE@1297389238.273282] mcm_storage_cmd():3334:
unable to store value: add
  [NOTICE@1297389238.320729] mcm_storage_cmd():3334:
unable to store value: add

   No fixtures found.
  /opt/lampp/lib/python2.5/site-packages/pycrypto-2.3-py2.5-
linux-i686.egg/Crypto/Util/randpool.py:40: RandomPool_DeprecationWarning:
This application uses RandomPool, which is BROKEN in older releases.  See
http://www.pycrypto.org/randpool-broken

  RandomPool_DeprecationWarning)

   No evolution required.
   Upgrade complete.
Thanks,
Sapna

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Issue Upgrading.

2011-02-11 Thread Christian Hammond
Hi Sapna,

Going back to 1.5.1 from 1.5.3 unfortunately means removing the old version
from the filesystem manually. At that point you can do:

easy_install -U ReviewBoard==1.5.1

However, this won't fix the errors below. Those appear to me to be harmless.
Are you hitting any real problems with the site?

The mcm_storage_add errors appear to be from the old cmemcache libraries. If
you can locate these on the filesystem and remove them, they should go away,
as Django will fall back on the new libraries we now install along with
Review Board.

The current release of RBTools should be compatible with everything from
1.0.x to 1.5.3.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Fri, Feb 11, 2011 at 11:21 AM, Sapna Vempati sapnavemp...@gmail.comwrote:

 Hi Christian,

 Using the below command for upgrade, upgrades to the latest version (1.5.3)
 by default. Is there a way we can upgrade to an older version we prefer ?
 Like for example, we want to do install to RB1.5.1. Is it possible ?

   easy_install -U ReviewBoard

 Also, from the release notes, looks like this version has a newer RBTools.
 Is this compatible with older RB versions ?

 When we try to upgrade using the above command, we got the below error, so
 that's the reason we want to go back to older version to see if that works.

   #[root@mob-rb-test /]# rb-site --debug upgrade

   /opt/lampp/htdocs/reviewboard
   Rebuilding directory structure

   Updating database. This may take a while.
   [NOTICE@1297389237.811425] mcm_storage_cmd():3334: unable to 
 store value: add

   [NOTICE@1297389237.845006] mcm_storage_cmd():3334: unable to 
 store value: add


   [NOTICE@1297389237.866137] mcm_storage_cmd():3334: unable to 
 store value: add
   [NOTICE@1297389237.900860] mcm_storage_cmd():3334: unable to 
 store value: add

   [NOTICE@1297389237.934480] mcm_storage_cmd():3334: unable to 
 store value: add
   [NOTICE@1297389237.967112] mcm_storage_cmd():3334: unable to 
 store value: add


   [NOTICE@1297389238.012221] mcm_storage_cmd():3334: unable to 
 store value: add
   [NOTICE@1297389238.048986] mcm_storage_cmd():3334: unable to 
 store value: add


   [NOTICE@1297389238.104145] mcm_storage_cmd():3334: unable to 
 store value: add

   [NOTICE@1297389238.224780] mcm_storage_cmd():3334: unable to 
 store value: add

   [NOTICE@1297389238.273282] mcm_storage_cmd():3334: unable to 
 store value: add

   [NOTICE@1297389238.320729] mcm_storage_cmd():3334: unable to 
 store value: add

No fixtures found.
   /opt/lampp/lib/python2.5/site-packages/pycrypto-2.3-py2.5-
 linux-i686.egg/Crypto/Util/randpool.py:40: RandomPool_DeprecationWarning:
 This application uses RandomPool, which is BROKEN in older releases.  See
 http://www.pycrypto.org/randpool-broken

   RandomPool_DeprecationWarning)

No evolution required.
Upgrade complete.
 Thanks,
 Sapna

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: unable to save seach index path

2011-02-11 Thread Christian Hammond
My apologies, this wasn't sufficient due to another bug where it doesn't
even save the entry. I've put out a hot-fix release (1.5.3.1) which you
should be able to upgrade to in the normal manner. It will fix this.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Fri, Feb 11, 2011 at 12:36 PM, Christian Hammond chip...@chipx86.comwrote:

 Hi Jerry,

 I've fixed this in our repository and will be doing a release this weekend.
 There is a workaround, though.

 Create an empty file somewhere in a writable directory (your site's data/
 directory is good or this) and then set the Search Index field to be an
 absolute path to that file. The validation should then work.

 Christian

 --
 Christian Hammond - chip...@chipx86.com

 Review Board - http://www.reviewboard.org
 VMware, Inc. - http://www.vmware.com


 On Thu, Feb 10, 2011 at 10:41 AM, Jerry gpjerrymalo...@gmail.com wrote:

 I'm prevented from saving settings unrelated to this, but on the same
 page.  I tried to change my time zone and, despite having the Enable
 Search option unchecked, I still got the error message Search index
 path should be absolute after clicking Save.  My time zone setting
 is unchanged after this.

 -- Jerry


 On Feb 9, 9:04 pm, Christian Hammond chip...@chipx86.com wrote:
  Hi Henry,
 
  I doubt you screwed anything up by not doing rb-site upgrade. It's
 likely a
  flaw in the new validation logic. I'll see if I can work around this and
 get
  you a patch tonight.
 
  Christian
 
  --
  Christian Hammond - chip...@chipx86.com
  Review Board -http://www.reviewboard.org
  VMware, Inc. -http://www.vmware.com
 
  On Wed, Feb 9, 2011 at 5:46 PM, Henry Yei henry@gmail.com wrote:
   After upgrading from 1.5.2 to 1.5.3, I am unable to save the path of
   the search index file. Has anyone else hit this problem, or is
   specific to my configuration?
 
   The path validation seems to work, but after the path is saved, the
   path  does not appear in the Admin UI under the Settings-General
   section and that field is blank.
 
   The command rb-site manage /var/www/reviewboard index -- --full throws
   an exception which seems to show that there is no value saved in the
   variable store_dir which is initialized by that search_index_file
   variable:
 
   sh-4.1$ rb-site manage /var/www/reviewboard/ index -- --full
   Traceback (most recent call last):
File /usr/local/bin/rb-site, line 9, in module
  load_entry_point('ReviewBoard==1.5.3', 'console_scripts', 'rb-
   site')()
File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5.3-
   py2.6.egg/reviewboard/cmdline/rbsite.py, line 1611, in main
 
   command.run()
File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5.3-
   py2.6.egg/reviewboard/cmdline/rbsite.py, line 1545, in run
  site.run_manage_command(args[0],
   args[1:])
File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5.3-
   py2.6.egg/reviewboard/cmdline/rbsite.py, line 397, in
   run_manage_command
  execute_manager(reviewboard.settings, [__file__, cmd] +
   params)
File /usr/local/lib/python2.6/dist-packages/Django-1.2.4-py2.6.egg/
   django/core/management/__init__.py, line 438, in execute_manager
 
   utility.execute()
File /usr/local/lib/python2.6/dist-packages/Django-1.2.4-py2.6.egg/
   django/core/management/__init__.py, line 379, in execute
 
   self.fetch_command(subcommand).run_from_argv(self.argv)
File /usr/local/lib/python2.6/dist-packages/Django-1.2.4-py2.6.egg/
   django/core/management/base.py, line 191, in run_from_argv
  self.execute(*args,
   **options.__dict__)
File /usr/local/lib/python2.6/dist-packages/Django-1.2.4-py2.6.egg/
   django/core/management/base.py, line 220, in execute
  output = self.handle(*args,
   **options)
File /usr/local/lib/python2.6/dist-packages/Django-1.2.4-py2.6.egg/
   django/core/management/base.py, line 351, in handle
  return
   self.handle_noargs(**options)
File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5.3-
   py2.6.egg/reviewboard/reviews/management/commands/index.py, line 55,
   in
   handle_noargs
  if not
   os.path.exists(store_dir):
File /usr/lib/python2.6/genericpath.py, line 18, in
   exists
  st =
   os.stat(path)
   TypeError: coercing to Unicode: need string or buffer, NoneType
   found
 
   I may have screwed something up when I forgot to do an rb-site
   upgrade  until after a full day of use when I updated the ReviewBoard
   installation via easy_install.
 
   --
   Want to help the Review Board project? Donate today at
  http://www.reviewboard.org/donate/
   Happy user? Let us know athttp://www.reviewboard.org/users/
   -~--~~~~--~~--~--~---
   To unsubscribe from this group, send email to
   reviewboard+unsubscr...@googlegroups.com
   For more options, visit this group at
  http://groups.google.com/group/reviewboard?hl=en
 
 

 --
 Want 

Re: post-review with git-svn parent throwing error

2011-02-11 Thread Christian Hammond
Can you run with --output-diff and see if it gives you anything useful? Also
with --debug to see which commands it executes.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Fri, Feb 11, 2011 at 9:55 AM, Martin marr...@gmail.com wrote:

 Hi everyone,

 I'm working with git-svn and the post-review command is failing when
 working on branches. I'm using the --parent and there are differences
 between the branches and the master.

 My repo is like this:

 * master - The one that fetches from svn trunk
  mockito_refactor - Branched from master
  mockito_refactor_models - Branched from mockito-refactor

 I did a review between mockito-refactor and master as usual, but
 between mockito-refactor-models and mockito-refactor fails.

 This is what I'm running
 laptop15:~/dev/models/quijote.git:mockito_refactor_models$ post-review
 --parent=mockito_refactor --guess_summary --guess-description

 And this is the error:
 Traceback (most recent call last):
  File /usr/local/bin/post-review, line 9, in module
load_entry_point('RBTools==0.2', 'console_scripts', 'post-review')
 ()
  File /usr/local/lib/python2.6/dist-packages/RBTools-0.2-py2.6.egg/
 rbtools/postreview.py, line 2861, in main
submit_as=options.submit_as)
  File /usr/local/lib/python2.6/dist-packages/RBTools-0.2-py2.6.egg/
 rbtools/postreview.py, line 2554, in tempt_fate
parent_diff_content)
  File /usr/local/lib/python2.6/dist-packages/RBTools-0.2-py2.6.egg/
 rbtools/postreview.py, line 503, in upload_diff
debug(Uploading diff, size: %d % len(diff_content))
 TypeError: object of type 'NoneType' has no len()

 If I run git diff between the branches I see all the differences.

 Does anyone knows why this is failing?

 The server runs 1.5.1 version.

 Thanks,
 Martin

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: post-review with git-svn parent throwing error

2011-02-11 Thread marr...@gmail.com
Well, I started with two new branches, topic_a and topic_b, to avoid
any commit interference

The work was:

$ git checkout -b topic_a
$ vim doc/AUTHORS.rst
$ commit
$ git checkout -b topic_b
$ vim doc/INSTALL.rst
$ commit
$ git checkout topic_a
$ post-review --guess-summary --guess-description
Review request #2188 posted.

http://review-board/r/2188

$ git checkout topic_b
$ post-review --guess-summary --guess-description --parent=topic_a
Traceback (most recent call last):
  File /usr/local/bin/post-review, line 9, in module
load_entry_point('RBTools==0.2', 'console_scripts', 'post-review')()
  File 
/usr/local/lib/python2.6/dist-packages/RBTools-0.2-py2.6.egg/rbtools/postreview.py,
line 2861, in main
submit_as=options.submit_as)
  File 
/usr/local/lib/python2.6/dist-packages/RBTools-0.2-py2.6.egg/rbtools/postreview.py,
line 2554, in tempt_fate
parent_diff_content)
  File 
/usr/local/lib/python2.6/dist-packages/RBTools-0.2-py2.6.egg/rbtools/postreview.py,
line 503, in upload_diff
debug(Uploading diff, size: %d % len(diff_content))
TypeError: object of type 'NoneType' has no len()

So now I run what you asked me, --debug and --output-diff

$ post-review --guess-summary --guess-description --parent=topic_a
--debug --output-diff
 svn info
 git rev-parse --git-dir
 git symbolic-ref -q HEAD
 git svn info
 repository info: Path: http://svn_server/repos/backend, Base path: /trunk, 
 Supports changesets: False
 git merge-base topic_a refs/heads/topic_b
 git diff --no-color --no-prefix -r -u topic_a..
 git svn find-rev topic_a
 git diff --no-color --no-prefix -r -u 
 c253759707fc49d670409e15b0e5a9f92804cebf..topic_a
 git svn find-rev c253759707fc49d670409e15b0e5a9f92804cebf
 git log --pretty=format:%s HEAD^..
 git log --pretty=format:%s%n%n%b topic_a..
None

But git diff shows me the difference between topic_b and topic_a

$ git diff topic_a
diff --git a/doc/INSTALL.rst b/doc/INSTALL.rst
index 05236e4..3553220 100644
--- a/doc/INSTALL.rst
+++ b/doc/INSTALL.rst
@@ -1,3 +1,5 @@
+TEST TEST TEST
+
 ==
 Installing
 ==



Don't really know why the changes between the branches are not seen by
the post-review. This weekend I will test it with a pure git
repository just to be sure that is only that happening with git-svn
(at least to me)

Thanks,

On Fri, Feb 11, 2011 at 17:46, Christian Hammond chip...@chipx86.com wrote:
 Can you run with --output-diff and see if it gives you anything useful? Also
 with --debug to see which commands it executes.

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.reviewboard.org
 VMware, Inc. - http://www.vmware.com


 On Fri, Feb 11, 2011 at 9:55 AM, Martin marr...@gmail.com wrote:

 Hi everyone,

 I'm working with git-svn and the post-review command is failing when
 working on branches. I'm using the --parent and there are differences
 between the branches and the master.

 My repo is like this:

 * master - The one that fetches from svn trunk
  mockito_refactor - Branched from master
  mockito_refactor_models - Branched from mockito-refactor

 I did a review between mockito-refactor and master as usual, but
 between mockito-refactor-models and mockito-refactor fails.

 This is what I'm running
 laptop15:~/dev/models/quijote.git:mockito_refactor_models$ post-review
 --parent=mockito_refactor --guess_summary --guess-description

 And this is the error:
 Traceback (most recent call last):
  File /usr/local/bin/post-review, line 9, in module
    load_entry_point('RBTools==0.2', 'console_scripts', 'post-review')
 ()
  File /usr/local/lib/python2.6/dist-packages/RBTools-0.2-py2.6.egg/
 rbtools/postreview.py, line 2861, in main
    submit_as=options.submit_as)
  File /usr/local/lib/python2.6/dist-packages/RBTools-0.2-py2.6.egg/
 rbtools/postreview.py, line 2554, in tempt_fate
    parent_diff_content)
  File /usr/local/lib/python2.6/dist-packages/RBTools-0.2-py2.6.egg/
 rbtools/postreview.py, line 503, in upload_diff
    debug(Uploading diff, size: %d % len(diff_content))
 TypeError: object of type 'NoneType' has no len()

 If I run git diff between the branches I see all the differences.

 Does anyone knows why this is failing?

 The server runs 1.5.1 version.

 Thanks,
 Martin

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 

Re: Problem posting diff

2011-02-11 Thread Christian Hammond
A 500. Interesting... So it's more than just a matter of not finding the
right path in the repository.

What version of Review Board is this?

Can you enable logging on the Review Board end, repeat the process, and then
find the accompanying error for this in the reviewboard.log file?

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Fri, Feb 11, 2011 at 1:07 PM, Jerry gpjerrymalo...@gmail.com wrote:

 And, the dbug log from RBTools' post-review:

 -
 $ post-review --debug
  RBTools 0.3.2
  Home = C:\Documents and Settings\jm\Application Data
  hg showconfig
  hg root
  hg svn info
  Using candidate path 'default':
 'ssh://scm//opt/hg/main/core/AnyModalConsole'
  repository info: Path: ssh://scm//opt/hg/main/core/AnyModalConsole,
 Base path: , Supports changesets: False
  HTTP GETting api/
  HTTP GETting http://of1dvweb-lnx001/api/info/
  Using the new web API
  hg branch
  hg -q outgoing --template b:{branches}
 r:{rev}

  default
  Found outgoing changeset 259 for branch 'default'
  hg diff -r 258 -r 259
  Attempting to create review request on
 ssh://scm//opt/hg/main/core/AnyModalConsole for None
  HTTP POSTing to http://of1dvweb-lnx001/api/review-requests/:
 {'repository': 'ssh://scm//opt/hg/main/core/AnyModalConsole'}
  Review request created
  Uploading diff, size: 454
  HTTP POSTing to http://of1dvweb-lnx001/api/review-requests/67/diffs/:
 {}
  Got HTTP error: 500: !DOCTYPE html PUBLIC -//W3C//DTD XHTML 1.0
 Transitional//EN
  http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd;

 html xmlns=http://www.w3.org/1999/xhtml; xml:lang=en lang=en
  head
  title500 - Internal Server Error | Review Board/title
  /head
  body
  h1Something broke! (Error 500)/h1
  p
   It appears something broke when you tried to go to here. This is
 either
   a bug in Review Board or a server configuration error. Please
 report
   this to your administrator.
  /p
  /body
 /title


 Error uploading diff

 Your review request still exists, but the diff is not attached.
 -

 On Feb 11, 3:16 pm, Christian Hammond chip...@chipx86.com wrote:
  Hi Jerry,
 
  Have you tried post-review or hg post-review? Can you try these (with
 debug
  mode on, which is --debug on post-review at least, dunno about hg
  post-review) and see if you still hit this problem? If so, the debug log
  would be helpful in identifying the problem.
 
  Christian
 
  --
  Christian Hammond - chip...@chipx86.com
  Review Board -http://www.reviewboard.org
  VMware, Inc. -http://www.vmware.com
 
  On Fri, Feb 11, 2011 at 11:51 AM, Jerry gpjerrymalo...@gmail.com
 wrote:
   I recently set up ReviewBoard connecting to a mercurial repository.
   When trying to post a diff through the web UI, I get an error:
 
   The file build.xml (revision ef6b39fd44d9) was not found in the
   repository
 
   I have verified that this file with this revision number is in the
   repo.  The mercurial repository path is set
 tohttp://ServerName/RepoName
   (this lists files at the root of the repo, like .hg).  That's where
   build.xml is located, and I can see it in a web browser.
 
   Am I setting up the mercurial path incorrectly?
 
   Thanks,
 
   --
   Want to help the Review Board project? Donate today at
  http://www.reviewboard.org/donate/
   Happy user? Let us know athttp://www.reviewboard.org/users/
   -~--~~~~--~~--~--~---
   To unsubscribe from this group, send email to
   reviewboard+unsubscr...@googlegroups.com
   For more options, visit this group at
  http://groups.google.com/group/reviewboard?hl=en
 
 

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en


-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Problem posting diff

2011-02-11 Thread Jerry
ReviewBoard version 1.5.3.

I notice that for the review requests created by RBTools post-review,
if I go to the web UI and try to select the review request, I also get
a 500 error in my browser.

OK, so here is the full output in reviewboard.log for a post-review
command:
-
2011-02-11 13:38:38,934 - INFO - Logging to /var/www/reviewboard/logs/
reviewboard.log with a minimum level of DEBUG
2011-02-11 13:38:38,934 - INFO - Log file for Review Board v1.5.3 (PID
10530)
2011-02-11 13:38:39,743 - INFO - Logging to /var/www/reviewboard/logs/
reviewboard.log with a minimum level of DEBUG
2011-02-11 13:38:39,743 - INFO - Log file for Review Board v1.5.3 (PID
10529)
2011-02-11 13:38:41,452 - INFO - Logging to /var/www/reviewboard/logs/
reviewboard.log with a minimum level of DEBUG
2011-02-11 13:38:41,453 - INFO - Log file for Review Board v1.5.3 (PID
10531)
2011-02-11 13:38:42,330 - INFO - Logging to /var/www/reviewboard/logs/
reviewboard.log with a minimum level of DEBUG
2011-02-11 13:38:42,331 - INFO - Log file for Review Board v1.5.3 (PID
10532)
2011-02-11 13:38:42,824 - ERROR - Exception thrown for user
jerry.maloney at http://of1dvweb-lnx001/api/review-requests/72/diffs/

no suitable response from remote hg
Traceback (most recent call last):
  File /usr/local/lib/python2.6/dist-packages/Django-1.2.4-py2.6.egg/
django/core/handlers/base.py, line 100, in get_response
response = callback(request, *callback_args, **callback_kwargs)
  File /usr/local/lib/python2.6/dist-packages/Django-1.2.4-py2.6.egg/
django/views/decorators/cache.py, line 78, in _wrapped_view_func
response = view_func(request, *args, **kwargs)
  File /usr/local/lib/python2.6/dist-packages/Django-1.2.4-py2.6.egg/
django/views/decorators/vary.py, line 22, in inner_func
response = func(*args, **kwargs)
  File /usr/local/lib/python2.6/dist-packages/Djblets-0.6.7-py2.6.egg/
djblets/webapi/resources.py, line 289, in __call__
result = view(request, api_format=api_format, *args, **kwargs)
  File /usr/local/lib/python2.6/dist-packages/Djblets-0.6.7-py2.6.egg/
djblets/webapi/resources.py, line 415, in post
return self.create(*args, **kwargs)
  File /usr/local/lib/python2.6/dist-packages/Djblets-0.6.7-py2.6.egg/
djblets/webapi/decorators.py, line 88, in _checklogin
return view_func(*args, **kwargs)
  File /usr/local/lib/python2.6/dist-packages/Djblets-0.6.7-py2.6.egg/
djblets/webapi/decorators.py, line 62, in _call
return view_func(*args, **kwargs)
  File /usr/local/lib/python2.6/dist-packages/Djblets-0.6.7-py2.6.egg/
djblets/webapi/decorators.py, line 224, in _validate
return view_func(*args, **new_kwargs)
  File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5.3-
py2.6.egg/reviewboard/webapi/resources.py, line , in create
form = UploadDiffForm(review_request, form_data, request.FILES)
  File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5.3-
py2.6.egg/reviewboard/reviews/forms.py, line 229, in __init__
data, *args, **kwargs)
  File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5.3-
py2.6.egg/reviewboard/diffviewer/forms.py, line 44, in __init__
if self.repository.get_scmtool().get_diffs_use_absolute_paths():
  File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5.3-
py2.6.egg/reviewboard/scmtools/models.py, line 52, in get_scmtool
return cls(self)
  File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5.3-
py2.6.egg/reviewboard/scmtools/hg.py, line 29, in __init__
self.client = HgClient(repository.path)
  File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5.3-
py2.6.egg/reviewboard/scmtools/hg.py, line 179, in __init__
self.repo = hg.repository(hg_ui, path=repoPath)
  File /usr/local/lib/python2.6/dist-packages/mercurial-1.7.5-py2.6-
linux-i686.egg/mercurial/hg.py, line 96, in repository
repo = _lookup(path).instance(ui, path, create)
  File /usr/local/lib/python2.6/dist-packages/mercurial-1.7.5-py2.6-
linux-i686.egg/mercurial/sshrepo.py, line 50, in __init__
self.validate_repo(ui, sshcmd, args, remotecmd)
  File /usr/local/lib/python2.6/dist-packages/mercurial-1.7.5-py2.6-
linux-i686.egg/mercurial/sshrepo.py, line 81, in validate_repo
self._abort(error.RepoError(_(no suitable response from remote
hg)))
  File /usr/local/lib/python2.6/dist-packages/mercurial-1.7.5-py2.6-
linux-i686.egg/mercurial/sshrepo.py, line 101, in _abort
raise exception
RepoError: no suitable response from remote hg
-


no suitable response from remote hg makes me suspect I have the
wrong path for the Repository Path setting, but this path works fine
in other settings.  I set it up with ssh credentials that I know to be
valid.  For what it's worth, I have different problems if I use http
instead of ssh in the path.

Thanks,



On Feb 11, 4:18 pm, Christian Hammond chip...@chipx86.com wrote:
 A 500. Interesting... So it's more than just a matter of not finding the
 right path in the repository.

 What version of Review Board is this?

 Can you enable logging on 

Re: Problem posting diff

2011-02-11 Thread Christian Hammond
Are you using a fully-qualified domain for the path, or just scm or
something? It may matter.

Also, try cloning the repository using that path on your server, just to see
what happens.

I assume you have an SSH key uploaded. Can you verify it's the right one in
the Admin UI?

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Fri, Feb 11, 2011 at 1:46 PM, Jerry gpjerrymalo...@gmail.com wrote:

 ReviewBoard version 1.5.3.

 I notice that for the review requests created by RBTools post-review,
 if I go to the web UI and try to select the review request, I also get
 a 500 error in my browser.

 OK, so here is the full output in reviewboard.log for a post-review
 command:
 -
 2011-02-11 13:38:38,934 - INFO - Logging to /var/www/reviewboard/logs/
 reviewboard.log with a minimum level of DEBUG
 2011-02-11 13:38:38,934 - INFO - Log file for Review Board v1.5.3 (PID
 10530)
 2011-02-11 13:38:39,743 - INFO - Logging to /var/www/reviewboard/logs/
 reviewboard.log with a minimum level of DEBUG
 2011-02-11 13:38:39,743 - INFO - Log file for Review Board v1.5.3 (PID
 10529)
 2011-02-11 13:38:41,452 - INFO - Logging to /var/www/reviewboard/logs/
 reviewboard.log with a minimum level of DEBUG
 2011-02-11 13:38:41,453 - INFO - Log file for Review Board v1.5.3 (PID
 10531)
 2011-02-11 13:38:42,330 - INFO - Logging to /var/www/reviewboard/logs/
 reviewboard.log with a minimum level of DEBUG
 2011-02-11 13:38:42,331 - INFO - Log file for Review Board v1.5.3 (PID
 10532)
 2011-02-11 13:38:42,824 - ERROR - Exception thrown for user
 jerry.maloney at http://of1dvweb-lnx001/api/review-requests/72/diffs/

 no suitable response from remote hg
 Traceback (most recent call last):
  File /usr/local/lib/python2.6/dist-packages/Django-1.2.4-py2.6.egg/
 django/core/handlers/base.py, line 100, in get_response
response = callback(request, *callback_args, **callback_kwargs)
  File /usr/local/lib/python2.6/dist-packages/Django-1.2.4-py2.6.egg/
 django/views/decorators/cache.py, line 78, in _wrapped_view_func
response = view_func(request, *args, **kwargs)
  File /usr/local/lib/python2.6/dist-packages/Django-1.2.4-py2.6.egg/
 django/views/decorators/vary.py, line 22, in inner_func
response = func(*args, **kwargs)
  File /usr/local/lib/python2.6/dist-packages/Djblets-0.6.7-py2.6.egg/
 djblets/webapi/resources.py, line 289, in __call__
result = view(request, api_format=api_format, *args, **kwargs)
  File /usr/local/lib/python2.6/dist-packages/Djblets-0.6.7-py2.6.egg/
 djblets/webapi/resources.py, line 415, in post
return self.create(*args, **kwargs)
  File /usr/local/lib/python2.6/dist-packages/Djblets-0.6.7-py2.6.egg/
 djblets/webapi/decorators.py, line 88, in _checklogin
return view_func(*args, **kwargs)
  File /usr/local/lib/python2.6/dist-packages/Djblets-0.6.7-py2.6.egg/
 djblets/webapi/decorators.py, line 62, in _call
return view_func(*args, **kwargs)
  File /usr/local/lib/python2.6/dist-packages/Djblets-0.6.7-py2.6.egg/
 djblets/webapi/decorators.py, line 224, in _validate
return view_func(*args, **new_kwargs)
  File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5.3-
 py2.6.egg/reviewboard/webapi/resources.py, line , in create
form = UploadDiffForm(review_request, form_data, request.FILES)
  File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5.3-
 py2.6.egg/reviewboard/reviews/forms.py, line 229, in __init__
data, *args, **kwargs)
  File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5.3-
 py2.6.egg/reviewboard/diffviewer/forms.py, line 44, in __init__
if self.repository.get_scmtool().get_diffs_use_absolute_paths():
  File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5.3-
 py2.6.egg/reviewboard/scmtools/models.py, line 52, in get_scmtool
return cls(self)
  File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5.3-
 py2.6.egg/reviewboard/scmtools/hg.py, line 29, in __init__
self.client = HgClient(repository.path)
  File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5.3-
 py2.6.egg/reviewboard/scmtools/hg.py, line 179, in __init__
self.repo = hg.repository(hg_ui, path=repoPath)
  File /usr/local/lib/python2.6/dist-packages/mercurial-1.7.5-py2.6-
 linux-i686.egg/mercurial/hg.py, line 96, in repository
repo = _lookup(path).instance(ui, path, create)
  File /usr/local/lib/python2.6/dist-packages/mercurial-1.7.5-py2.6-
 linux-i686.egg/mercurial/sshrepo.py, line 50, in __init__
self.validate_repo(ui, sshcmd, args, remotecmd)
  File /usr/local/lib/python2.6/dist-packages/mercurial-1.7.5-py2.6-
 linux-i686.egg/mercurial/sshrepo.py, line 81, in validate_repo
self._abort(error.RepoError(_(no suitable response from remote
 hg)))
  File /usr/local/lib/python2.6/dist-packages/mercurial-1.7.5-py2.6-
 linux-i686.egg/mercurial/sshrepo.py, line 101, in _abort
raise exception
 RepoError: no suitable response from remote hg
 -


 no suitable 

Re: Problem posting diff

2011-02-11 Thread Jerry
 Are you using a fully-qualified domain for the path, or just scm or
something? It may matter.
I was just using scm.  I just put in the fully-qualified path and will
try again (see below.).


 Also, try cloning the repository using that path on your server, just to see
what happens.
I am able to clone the repo on the Apache server using the path
ssh://scm//opt/hg/main/core/AnyModalConsole.


 I assume you have an SSH key uploaded. Can you verify it's the right one in
the Admin UI?
I had not uploaded an SSH key, but I just did this and tried again.
(How do I check if it is the right key in the Admin UI?)  After adding
the fully-qualified domain and uploading an ssh key, I tried again,
and this is what I got on the client:

-
$ post-review --debug
 RBTools 0.3.2
 Home = C:\Documents and Settings\jerry.maloney\Application Data
 hg showconfig
 hg root
 hg svn info
 Using candidate path 'default': 
 'ssh://scm.interactivesys.com//opt/hg/main/core/AnyModalConsole'
 repository info: Path: 
 ssh://scm.interactivesys.com//opt/hg/main/core/AnyModalConsole, Base path: 
 , Supports changesets: False
 HTTP GETting api/
 HTTP GETting http://of1dvweb-lnx001/api/info/
 Using the new web API
 hg branch
 hg -q outgoing --template b:{branches}
r:{rev}

 default
-
When it gets to the last line, default, it stays there for 5 minutes
or more.

The relevant lines from reviewboard.log on the server:
-
2011-02-11 14:09:25,121 - DEBUG - Trying discovered key
287637e1d8a393fefcc82e2c35f4f567 in /var/www/reviewboard/data/.ssh/
id_dsa
2011-02-11 14:09:25,156 - DEBUG - userauth is OK
2011-02-11 14:09:25,192 - INFO - Authentication (publickey)
successful!
2011-02-11 14:09:25,297 - DEBUG - EOF in transport thread
2011-02-11 14:09:25,317 - DEBUG - EOF in transport thread
-
This log also hasn't changed over the course of 5 minutes.  So it
looks like adding the ssh key helped (though only in conjunction with
the fully-qualified path, so that did matter as you suspected it
might).


I just killed the process on the client because I have to leave the
computer now, but I'm gonna try to come back later tonight and see if
I can debug it.  Any ideas you have in the meantime will be
appreciated.  Thanks so much for all your help so far!





On Feb 11, 4:53 pm, Christian Hammond chip...@chipx86.com wrote:
 Are you using a fully-qualified domain for the path, or just scm or
 something? It may matter.

 Also, try cloning the repository using that path on your server, just to see
 what happens.

 I assume you have an SSH key uploaded. Can you verify it's the right one in
 the Admin UI?

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board -http://www.reviewboard.org
 VMware, Inc. -http://www.vmware.com

 On Fri, Feb 11, 2011 at 1:46 PM, Jerry gpjerrymalo...@gmail.com wrote:
  ReviewBoard version 1.5.3.

  I notice that for the review requests created by RBTools post-review,
  if I go to the web UI and try to select the review request, I also get
  a 500 error in my browser.

  OK, so here is the full output in reviewboard.log for a post-review
  command:
  -
  2011-02-11 13:38:38,934 - INFO - Logging to /var/www/reviewboard/logs/
  reviewboard.log with a minimum level of DEBUG
  2011-02-11 13:38:38,934 - INFO - Log file for Review Board v1.5.3 (PID
  10530)
  2011-02-11 13:38:39,743 - INFO - Logging to /var/www/reviewboard/logs/
  reviewboard.log with a minimum level of DEBUG
  2011-02-11 13:38:39,743 - INFO - Log file for Review Board v1.5.3 (PID
  10529)
  2011-02-11 13:38:41,452 - INFO - Logging to /var/www/reviewboard/logs/
  reviewboard.log with a minimum level of DEBUG
  2011-02-11 13:38:41,453 - INFO - Log file for Review Board v1.5.3 (PID
  10531)
  2011-02-11 13:38:42,330 - INFO - Logging to /var/www/reviewboard/logs/
  reviewboard.log with a minimum level of DEBUG
  2011-02-11 13:38:42,331 - INFO - Log file for Review Board v1.5.3 (PID
  10532)
  2011-02-11 13:38:42,824 - ERROR - Exception thrown for user
  jerry.maloney athttp://of1dvweb-lnx001/api/review-requests/72/diffs/

  no suitable response from remote hg
  Traceback (most recent call last):
   File /usr/local/lib/python2.6/dist-packages/Django-1.2.4-py2.6.egg/
  django/core/handlers/base.py, line 100, in get_response
     response = callback(request, *callback_args, **callback_kwargs)
   File /usr/local/lib/python2.6/dist-packages/Django-1.2.4-py2.6.egg/
  django/views/decorators/cache.py, line 78, in _wrapped_view_func
     response = view_func(request, *args, **kwargs)
   File /usr/local/lib/python2.6/dist-packages/Django-1.2.4-py2.6.egg/
  django/views/decorators/vary.py, line 22, in inner_func
     response = func(*args, **kwargs)
   File /usr/local/lib/python2.6/dist-packages/Djblets-0.6.7-py2.6.egg/
  djblets/webapi/resources.py, line 289, in __call__
     result = view(request, api_format=api_format, *args, **kwargs)
   File /usr/local/lib/python2.6/dist-packages/Djblets-0.6.7-py2.6.egg/
  djblets/webapi/resources.py, line 415, in post
 

Re: Issue Upgrading.

2011-02-11 Thread Sapna Vempati
Thanks Christian.

If the errors are just warnings, the issue is that we don't see a complete
installation and upgrade.  The RB servers still shows as 1.0.X. and not
1.5.3.

Do you know how I could locate: cmemcache on the file system ?

Thanks,
Sapna


On Fri, Feb 11, 2011 at 12:39 PM, Christian Hammond chip...@chipx86.comwrote:

 Hi Sapna,

 Going back to 1.5.1 from 1.5.3 unfortunately means removing the old version
 from the filesystem manually. At that point you can do:

 easy_install -U ReviewBoard==1.5.1

 However, this won't fix the errors below. Those appear to me to be
 harmless. Are you hitting any real problems with the site?

 The mcm_storage_add errors appear to be from the old cmemcache libraries.
 If you can locate these on the filesystem and remove them, they should go
 away, as Django will fall back on the new libraries we now install along
 with Review Board.

 The current release of RBTools should be compatible with everything from
 1.0.x to 1.5.3.

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.reviewboard.org
 VMware, Inc. - http://www.vmware.com


 On Fri, Feb 11, 2011 at 11:21 AM, Sapna Vempati sapnavemp...@gmail.comwrote:

 Hi Christian,

 Using the below command for upgrade, upgrades to the latest version
 (1.5.3) by default. Is there a way we can upgrade to an older version we
 prefer ? Like for example, we want to do install to RB1.5.1. Is it possible
 ?

   easy_install -U ReviewBoard

 Also, from the release notes, looks like this version has a newer RBTools.
 Is this compatible with older RB versions ?

 When we try to upgrade using the above command, we got the below error, so
 that's the reason we want to go back to older version to see if that works.

   #[root@mob-rb-test /]# rb-site --debug upgrade


   /opt/lampp/htdocs/reviewboard
   Rebuilding directory structure


   Updating database. This may take a while.
   [NOTICE@1297389237.811425] mcm_storage_cmd():3334: unable to 
 store value: add


   [NOTICE@1297389237.845006] mcm_storage_cmd():3334: unable to 
 store value: add



   [NOTICE@1297389237.866137] mcm_storage_cmd():3334: unable to 
 store value: add
   [NOTICE@1297389237.900860] mcm_storage_cmd():3334: unable to 
 store value: add


   [NOTICE@1297389237.934480] mcm_storage_cmd():3334: unable to 
 store value: add
   [NOTICE@1297389237.967112] mcm_storage_cmd():3334: unable to 
 store value: add



   [NOTICE@1297389238.012221] mcm_storage_cmd():3334: unable to 
 store value: add
   [NOTICE@1297389238.048986] mcm_storage_cmd():3334: unable to 
 store value: add



   [NOTICE@1297389238.104145] mcm_storage_cmd():3334: unable to 
 store value: add


   [NOTICE@1297389238.224780] mcm_storage_cmd():3334: unable to 
 store value: add


   [NOTICE@1297389238.273282] mcm_storage_cmd():3334: unable to 
 store value: add


   [NOTICE@1297389238.320729] mcm_storage_cmd():3334: unable to 
 store value: add

No fixtures found.
   /opt/lampp/lib/python2.5/site-packages/pycrypto-2.3-py2.5-
 linux-i686.egg/Crypto/Util/randpool.py:40: RandomPool_DeprecationWarning:
 This application uses RandomPool, which is BROKEN in older releases.  See
 http://www.pycrypto.org/randpool-broken

   RandomPool_DeprecationWarning)

No evolution required.
Upgrade complete.
 Thanks,
 Sapna

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en


  --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Issue 1981 in reviewboard: Can't save General Settings after upgrade from 1.5.2

2011-02-11 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 1981 by bra...@gmail.com: Can't save General Settings after  
upgrade from 1.5.2

http://code.google.com/p/reviewboard/issues/detail?id=1981

What version are you running?
1.5.3, upgraded from 1.5.2

What's the URL of the page containing the problem?
https://localhost/reviews/admin/settings/general/

What steps will reproduce the problem?
1. Login as admin
2. Go to Settings - General Settings
3. Save (with or without changing anything)

What is the expected output? What do you see instead?
Expect it to say The settings have been saved.

Instead it puts an error message above the Search index file: field that  
says

Search index path should be absolute. and it won't let me save.

The Search index file field is currently empty and has always been  
empty.  But I can't change it now to satisfy the error checker since search  
is disabled.  I can't enable search because PyLucene isn't installed.  So I  
can't save General Settings.


What operating system are you using? What browser?
OS: SLES-11 is where ReviewBoard is installed
Browser: Firefox 3.5.9 on SLES-11  Google Chrome 8.0.552.237 on Windows  
Vista


Please provide any additional information below.

I used to be able to change these settings.  At that time, I was using  
version 1.5.2 and the Apache configuration was not setup to use https.  I  
have modified the configuration to use https and also upgraded to 1.5.3  
since then.



--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 1982 in reviewboard: HTTP 500 viewing graphics review with bug number (RB 1.5)

2011-02-11 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 1982 by enqueu...@gmail.com: HTTP 500 viewing graphics review  
with bug number (RB 1.5)

http://code.google.com/p/reviewboard/issues/detail?id=1982

* NOTE: Do not post confidential information in this bug report. *
*   If you need immediate support, please contact*
*   reviewbo...@googlegroups.com *

What version are you running?
1.5.0

What's the URL of the page containing the problem?
http://rbsite/rb/r/req#

What steps will reproduce the problem?
1. Click 'New Review Request'
2. Select '(None - Graphics Only)' in Repository drop down.
3. Specify a bug # in the request.

What is the expected output? What do you see instead?

Expected - bug # displayed as plaintext when the review request is viewed.

Actual - HTTP 500 raised.

What operating system are you using? What browser?

Linux 2.6.18-194.26.1.el5 #1 SMP Tue Nov 9 12:54:40 EST 2010 i686 i686 i386  
GNU/Linux


All browsers affected. Last browser to receive error:

Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 6.1; WOW64; Trident/4.0;  
SLCC2; .NET CLR 2.0.50727; Media Center PC 6.0; MDDR; InfoPath.2; .NET CLR  
3.5.30729; .NET CLR 3.0.30729; .NET4.0C; MS-RTC LM 8)


Please provide any additional information below.

Traceback (most recent call last):

   
File /usr/lib/python2.4/site-packages/Django-1.2.3-py2.4.egg/django/core/handlers/base.py,  
line 100, in get_response

response = callback(request, *callback_args, **callback_kwargs)

   
File /usr/lib/python2.4/site-packages/ReviewBoard-1.5-py2.4.egg/reviewboard/accounts/decorators.py,  
line 25, in _check

return login_required(view_func)(*args, **kwargs)

   
File /usr/lib/python2.4/site-packages/Djblets-0.6.4-py2.4.egg/djblets/auth/util.py,  
line 46, in _checklogin

return view_func(request, *args, **kwargs)

   
File /usr/lib/python2.4/site-packages/ReviewBoard-1.5-py2.4.egg/reviewboard/accounts/decorators.py,  
line 46, in _check_valid_prefs

return view_func(request, *args, **kwargs)

   
File /usr/lib/python2.4/site-packages/ReviewBoard-1.5-py2.4.egg/reviewboard/reviews/views.py,  
line 244, in review_detail

RequestContext(request, make_review_request_context(review_request, {

   
File /usr/lib/python2.4/site-packages/Django-1.2.3-py2.4.egg/django/shortcuts/__init__.py,  
line 20, in render_to_response
return HttpResponse(loader.render_to_string(*args, **kwargs),  
**httpresponse_kwargs)


   
File /usr/lib/python2.4/site-packages/Django-1.2.3-py2.4.egg/django/template/loader.py,  
line 186, in render_to_string

return t.render(context_instance)

   
File /usr/lib/python2.4/site-packages/Django-1.2.3-py2.4.egg/django/template/__init__.py,  
line 173, in render

return self._render(context)

   
File /usr/lib/python2.4/site-packages/Django-1.2.3-py2.4.egg/django/template/__init__.py,  
line 167, in _render

return self.nodelist.render(context)

   
File /usr/lib/python2.4/site-packages/Django-1.2.3-py2.4.egg/django/template/__init__.py,  
line 796, in render

bits.append(self.render_node(node, context))

   
File /usr/lib/python2.4/site-packages/Django-1.2.3-py2.4.egg/django/template/__init__.py,  
line 809, in render_node

return node.render(context)

   
File /usr/lib/python2.4/site-packages/Django-1.2.3-py2.4.egg/django/template/loader_tags.py,  
line 125, in render

return compiled_parent._render(context)

   
File /usr/lib/python2.4/site-packages/Django-1.2.3-py2.4.egg/django/template/__init__.py,  
line 167, in _render

return self.nodelist.render(context)

   
File /usr/lib/python2.4/site-packages/Django-1.2.3-py2.4.egg/django/template/__init__.py,  
line 796, in render

bits.append(self.render_node(node, context))

   
File /usr/lib/python2.4/site-packages/Django-1.2.3-py2.4.egg/django/template/__init__.py,  
line 809, in render_node

return node.render(context)

   
File /usr/lib/python2.4/site-packages/Django-1.2.3-py2.4.egg/django/template/loader_tags.py,  
line 125, in render

return compiled_parent._render(context)

   
File /usr/lib/python2.4/site-packages/Django-1.2.3-py2.4.egg/django/template/__init__.py,  
line 167, in _render

return self.nodelist.render(context)

   
File /usr/lib/python2.4/site-packages/Django-1.2.3-py2.4.egg/django/template/__init__.py,  
line 796, in render

bits.append(self.render_node(node, context))

   
File /usr/lib/python2.4/site-packages/Django-1.2.3-py2.4.egg/django/template/__init__.py,  
line 809, in render_node

return node.render(context)

   
File /usr/lib/python2.4/site-packages/Django-1.2.3-py2.4.egg/django/template/loader_tags.py,  
line 62, in render

result = block.nodelist.render(context)

   
File /usr/lib/python2.4/site-packages/Django-1.2.3-py2.4.egg/django/template/__init__.py,  
line 796, in render

bits.append(self.render_node(node, context))

   
File 

Re: Issue 1982 in reviewboard: HTTP 500 viewing graphics review with bug number (RB 1.5)

2011-02-11 Thread reviewboard

Updates:
Status: Confirmed
Labels: -Priority-Medium Priority-Critical Milestone-Release1.5.x

Comment #1 on issue 1982 by chip...@gmail.com: HTTP 500 viewing graphics  
review with bug number (RB 1.5)

http://code.google.com/p/reviewboard/issues/detail?id=1982

We'll fix for 1.5.4.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1980 in reviewboard: User names with ' in the name don't display correctly when adding comment

2011-02-11 Thread reviewboard

Updates:
Status: Confirmed
Labels: Milestone-Release1.5.x Component-Reviews

Comment #1 on issue 1980 by chip...@gmail.com: User names with ' in the  
name don't display correctly when adding comment

http://code.google.com/p/reviewboard/issues/detail?id=1980

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.