LDAP failure
I am cloning a ReviewBoard machine (ReviewBoard 1.5.5 on RHEL5) and
copied all settings, in particular LDAP settings. LDAP works on the
original machine, but not on the second one.
This is what I see in the logfile:
2011-05-10 23:09:53,683 - WARNING - LDAP error: {'info': ':
LdapErr: DSID-0C090627, comment: In order to perform this operation a
successful bind must be completed on the connection., data 0, vece',
'desc': 'Operations error'}
2011-05-10 23:10:01,804 - WARNING - LDAP error: {'info': '', 'desc':
'Bad search filter'}
Does anyone know what is wrong/missing?
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: LDAP failure
More info: Apache + mod_python User Mask is copy + paste form working machine -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: LDAP failure
Update: After making sure the User Mask was identical, I do not get the Bad search filter error. I still get the bind failure. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: LDAP failure
What LDAP are you authenticating to? On Wed, May 11, 2011 at 4:54 PM, minkzanity min...@gmail.com wrote: Update: After making sure the User Mask was identical, I do not get the Bad search filter error. I still get the bind failure. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Realized web-based post-commit reviews
Rob,
The fix is committed. Could you please test with the latest version of
reviewboard/scmtools/svn_post_tracker.py?
- Philipp
On May 10, 8:58 pm, Philipp Henkel weltraumpi...@googlemail.com
wrote:
Hi Rob,
Thanks, I'm glad you like it.
Currently I rely on svn:log property in order to extract the commit
description. This property might not exist because you don't enforce
commit messages (like we do). I have already a better solution in mind
and it should be easy to fix.
Best regards,
Philipp
On May 10, 12:35 am, Rob Coward r...@jive-videos.net wrote:
Hi Philipp,
I am very interested in your Subversion Post-commit
enhancement, and quite possibly might be the killer feature that
persuades us to start using it at work too.
I have downloaded your
code and dropped it on top of 1.5.5 for now (if I get time, I'll be
trying to port your patches up to the latest 1.6 beta2) and it is mostly
working in that I can manually specify a list of revisions and it will
generate the diffs and create the review etc, however when clicking on
the 'Get Revisions' button I get an Error500 back from the server with
the following in apache's error_log:
ERROR:root:Exception thrown for
user admin athttp://192.168.1.68/r/newpost/
'revprops'
Traceback (most
recent call last):
File
/usr/lib/python2.4/site-packages/django/core/handlers/base.py, line
99, in get_response
response = callback(request, *callback_args,
**callback_kwargs)
File
/usr/lib/python2.4/site-packages/djblets/auth/util.py, line 46, in
_checklogin
return view_func(request, *args, **kwargs)
File
/usr/lib/python2.4/site-packages/reviewboard/reviews/views.py, line
98, in new_post_review_request
diff_file=request.FILES.get('diff_path'))
File
/usr/lib/python2.4/site-packages/reviewboard/reviews/forms.py, line
411, in create
raise e
KeyError: 'revprops'
The subversion repo is a
brand new repo I created for the task of reviewing your code, populated
initially with cvs2svn to import an existing cvs repository.
Any
thoughts ?
Thanks for your hard work.
Rob Coward
On Fri, 6 May
2011 02:43:05 -0700 (PDT), Philipp Henkel wrote:
Hi,
Did anyone
had a chance to have look at my post-commit implementation?
http://philipphenkel.github.com/post-reviewboard[1]
The subversion
implementation is complete and for Perforce I realized the basic
feature set. It is already possible to create requests by typing in
change numbers in the Post-commit web form.
Best regards,
Philipp
--
Philipp Henkel
Citrix Online -www.citrixonline.com
[2]
The views expressed here are mine alone and have not been
authorized
by, and do not necessarily reflect the views of, Citrix.
Links:
--
[1]http://philipphenkel.github.com/post-reviewboard
[2]http://www.citrixonline.com
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Want to add href in line comments
Hi, I want to add href in line comments. Following tag is not working: a href=http://test; testComments/a Is there any way to add href to comment? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Want to add href in line comments
There's no way to add a link with inline text, like that. However, if you just include the link itself in the comment, it should be turned into a hyperlink. Most people do it like this: blah blah comment, see http://test for info. -David On Wed, May 11, 2011 at 6:02 AM, shilpageo shilpa.anan...@gmail.com wrote: Hi, I want to add href in line comments. Following tag is not working: a href=http://test; testComments/a Is there any way to add href to comment? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Review Submitter Field Out of Whack
I don't know how hg postreview works, but at some point it calls post-review, correct? I think it would need to be modified to use --submit-as to suit your case. - David On May 10, 2011, at 4:40 PM, Jeffrey Reynolds jeffrey.james.reyno...@gmail.com wrote: Howdy all, I'm posting here because we are starting to use Review Board and find it a very useful tool. However we are having some issues with implementation. We have several Mecurial repos setup right now, all of which are set up with an out of process (terminology?) incoming hook. It's a script to validate the user who made the push, and if the users isn't one of the core developers, a review notification is posted to our ReviewBoard instance. The validation thing works fine, and only users who aren't amoung the core devs have review submissions at review board. However, ReviewBoard lists all of the submitters as one particular user, never the user who actually made the push. The hook calls hg postreview -i # -r # (which syntactically may be incorrect, not 100%). Apparently the postreview hg command doesn't have a --submit-as option, but we have the username as a BASH variable in the script. Is there some special means that the submitting user has to be specified when using hg postreview in an out of process hook? Please let me know if I shold specify anyhitng further, I'm far from a Mercurial pro so I might need to refine my question. Thanks in advance, Ho-Hum -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Error uploading diff
Hi,
Thanks for getting back to me Christian. I tried svn diff and svn diff works
fine. . The diff was also able to be generated locally. Any other ideas?
On Tue, May 10, 2011 at 6:22 PM, Christian Hammond chip...@chipx86.comwrote:
What type of repository are you using? I assume Subversion?
It looks like there are two things going wrong. The first is that Review
Board's having some sort of trouble fetching server information from your
repository. The second is that locally, it's been unable to generate a diff.
So assuming Subversion, what happens if you run svn diff on your
checkout?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Tue, May 10, 2011 at 5:49 PM, Thomas Vincent tvinc...@astreya.comwrote:
Hi,
I am getting the following errors when I try to upload a file using
post-review.
Got API Error 210 (HTTP code 200): There was an error fetching
extended information for this repository.
Error data: {'deprecated': {'in_version': '1.5'}, 'stat': 'fail',
'err': {'msg': 'There was an error fetching extended information for this
repository.', 'code': 210}}
HTTP GETting api/json/repositories/3/info/
Got API Error 210 (HTTP code 200): There was an error fetching
extended information for this repository.
Error data: {'deprecated': {'in_version': '1.5'}, 'stat': 'fail',
'err': {'msg': 'There was an error fetching extended information for this
repository.', 'code': 210}}
HTTP GETting api/json/repositories/4/info/
Attempting to create review request on https://repository/option for
None
HTTP POSTing to http://truncated/option/api/json/reviewrequests/new/:
{'repository_path': 'https://truncated.com/option'}
Review request created
Attempting to set field 'summary' to 'review board test' for review
request '408'
HTTP POSTing to
http://truncated/api/json/reviewrequests/408/draft/set/: {'summary':
'review board test'}
Attempting to set field 'description' to 'REVIEW BOARD TEST' for
review request '408'
HTTP POSTing to
http://truncated/api/json/reviewrequests/408/draft/set/: {'description':
'REVIEW BOARD TEST'}
Uploading diff, size: 421
HTTP POSTing to
http://truncating/api/json/reviewrequests/408/diff/new/: {'basedir':
'/operations/puppet'}
Got API Error 105 (HTTP code 200): One or more fields had errors
Error data: {'fields': {'path': [Server sent unexpected return value
(500 Internal Server Error) in response to OPTIONS request for '
https://truncated/opt/operations/puppet/USE_SVN_README']}, 'stat':
'fail', 'err': {'msg': 'One or more fields had errors', 'code': 105},
'deprecated': {'in_version': '1.5'}}
Error uploading diff
The generated diff file was empty. This usually means no files were
modified in this change.
Try running with --output-diff and --debug for more information.
Your review request still exists, but the diff is not attached.
RB is 1.5, and rbtools are 0.3.2 .
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: Review Board 1.6 beta 2 - For real this time!
Upgrade to 1.6 beta 2 went fine for me. However, I noticed there are a couple lines in the release note indicating some fixes for incoming review and starred review request counts. This doesn't seem to have fixed the counts for me. I currently have -15 incoming reviews and -1 outgoing reviews. I've noticed it slowly decrementing since we installed 1.6 beta 1 :) Dan On May 10, 3:03 am, Ashithraj Shetty asithraj.she...@gmail.com wrote: Upgraded to the latest release. Big bad box is not seen anymore J -Ashith From: reviewboard@googlegroups.com [mailto:reviewboard@googlegroups.com] On Behalf Of Christian Hammond Sent: Tuesday, May 10, 2011 11:37 AM To: reviewboard@googlegroups.com Subject: Review Board 1.6 beta 2 - For real this time! Let's try this again. 1.6 beta 2 is out! It should work with PostgreSQL and shouldn't have a giant box at the bottom of every page. Give it a try! Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com -- Want to help the Review Board project? Donate today athttp://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group athttp://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Error uploading diff
I changed the site setting from http to https. Now I get:
[13:07:36 tvincent@SERVER02:~/puppet]$ post-review -pd --
summary=review board test --description=REVIEW BOARD TEST
USE_SVN_README --username=tvincent
RBTools 0.3.2
Home = /home/tvincent
svn info
diff --version
repository info: Path: https://SERVER01.truncated.com/opt, Base path:
/operations/puppet, Supports changesets: False
HTTP GETting api/
== HTTP Authentication Required
Enter authorization information for Web API at
reviewboard.truncated.com
Password:
HTTP GETting http://reviewboard.truncated.com/api/info/
Using the deprecated Review Board 1.0 web API
svn diff --diff-cmd=diff USE_SVN_README
svn info USE_SVN_README
svn info USE_SVN_README
svn info USE_SVN_README
svn info USE_SVN_README
== Review Board Login Required
Enter username and password for Review Board at
http://reviewboard.truncated.com/
Password:
Logging in with username tvincent
HTTP POSTing to http://reviewboard.truncated.com/api/json/accounts/login/:
{'username': 'tvincent', 'password': '**'}
Traceback (most recent call last):
File /usr/bin/post-review, line 7, in ?
sys.exit(
File /usr/lib/python2.4/site-packages/RBTools-0.3.2-py2.4.egg/
rbtools/postreview.py, line 3790, in main
File /usr/lib/python2.4/site-packages/RBTools-0.3.2-py2.4.egg/
rbtools/postreview.py, line 488, in login
File /usr/lib/python2.4/site-packages/RBTools-0.3.2-py2.4.egg/
rbtools/postreview.py, line 982, in api_post
File /usr/lib/python2.4/site-packages/RBTools-0.3.2-py2.4.egg/
rbtools/postreview.py, line 903, in http_post
File /usr/lib64/python2.4/urllib2.py, line 130, in urlopen
return _opener.open(url, data)
File /usr/lib64/python2.4/urllib2.py, line 364, in open
response = meth(req, response)
File /usr/lib/python2.4/site-packages/RBTools-0.3.2-py2.4.egg/
rbtools/postreview.py, line 317, in http_response
File /usr/lib64/python2.4/urllib2.py, line 396, in error
result = self._call_chain(*args)
File /usr/lib64/python2.4/urllib2.py, line 337, in _call_chain
result = func(*args)
File /usr/lib64/python2.4/urllib2.py, line 741, in http_error_401
host, req, headers)
File /usr/lib64/python2.4/urllib2.py, line 720, in
http_error_auth_reqed
return self.retry_http_basic_auth(host, req, realm)
File /usr/lib/python2.4/site-packages/RBTools-0.3.2-py2.4.egg/
rbtools/postreview.py, line 339, in retry_http_basic_auth
File /usr/lib64/python2.4/urllib2.py, line 730, in
retry_http_basic_auth
return self.parent.open(req)
File /usr/lib64/python2.4/urllib2.py, line 364, in open
response = meth(req, response)
File /usr/lib/python2.4/site-packages/RBTools-0.3.2-py2.4.egg/
rbtools/postreview.py, line 317, in http_response
File /usr/lib64/python2.4/urllib2.py, line 396, in error
result = self._call_chain(*args)
File /usr/lib64/python2.4/urllib2.py, line 337, in _call_chain
result = func(*args)
File /usr/lib64/python2.4/urllib2.py, line 916, in http_error_401
host, req, headers)
File /usr/lib64/python2.4/urllib2.py, line 807, in
http_error_auth_reqed
raise ValueError(AbstractDigestAuthHandler doesn't know
ValueError: AbstractDigestAuthHandler doesn't know about Basic
On May 10, 6:22 pm, Christian Hammond chip...@chipx86.com wrote:
What type of repository are you using? I assume Subversion?
It looks like there are two things going wrong. The first is that Review
Board's having some sort of trouble fetching server information from your
repository. The second is that locally, it's been unable to generate a diff.
So assuming Subversion, what happens if you run svn diff on your checkout?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Tue, May 10, 2011 at 5:49 PM, Thomas Vincent tvinc...@astreya.comwrote:
Hi,
I am getting the following errors when I try to upload a file using
post-review.
Got API Error 210 (HTTP code 200): There was an error fetching extended
information for this repository.
Error data: {'deprecated': {'in_version': '1.5'}, 'stat': 'fail',
'err': {'msg': 'There was an error fetching extended information for this
repository.', 'code': 210}}
HTTP GETting api/json/repositories/3/info/
Got API Error 210 (HTTP code 200): There was an error fetching extended
information for this repository.
Error data: {'deprecated': {'in_version': '1.5'}, 'stat': 'fail',
'err': {'msg': 'There was an error fetching extended information for this
repository.', 'code': 210}}
HTTP GETting api/json/repositories/4/info/
Attempting to create review request onhttps://repository/optionfor
None
HTTP POSTing tohttp://truncated/option/api/json/reviewrequests/new/:
{'repository_path': 'https://truncated.com/option'}
Review request created
Attempting to set field 'summary' to 'review board test' for review
request '408'
HTTP POSTing to
Re: LDAP failure
Corporate LDAP server On May 11, 3:26 am, Paul Schulz p...@mawsonlakes.org wrote: What LDAP are you authenticating to? On Wed, May 11, 2011 at 4:54 PM, minkzanity min...@gmail.com wrote: Update: After making sure the User Mask was identical, I do not get the Bad search filter error. I still get the bind failure. -- Want to help the Review Board project? Donate today athttp://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group athttp://groups.google.com/group/reviewboard?hl=en- Hide quoted text - - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Error uploading diff
You're running exactly 1.5? Try upgrading. There are a lot of API issues in
1.5, which I want to rule out first.
Also, are you using mod_python, or something else?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, May 11, 2011 at 11:10 AM, Thomas Vincent tvinc...@astreya.comwrote:
I changed the site setting from http to https. Now I get:
[13:07:36 tvincent@SERVER02:~/puppet]$ post-review -pd --
summary=review board test --description=REVIEW BOARD TEST
USE_SVN_README --username=tvincent
RBTools 0.3.2
Home = /home/tvincent
svn info
diff --version
repository info: Path: https://SERVER01.truncated.com/opt, Base path:
/operations/puppet, Supports changesets: False
HTTP GETting api/
== HTTP Authentication Required
Enter authorization information for Web API at
reviewboard.truncated.com
Password:
HTTP GETting http://reviewboard.truncated.com/api/info/
Using the deprecated Review Board 1.0 web API
svn diff --diff-cmd=diff USE_SVN_README
svn info USE_SVN_README
svn info USE_SVN_README
svn info USE_SVN_README
svn info USE_SVN_README
== Review Board Login Required
Enter username and password for Review Board at
http://reviewboard.truncated.com/
Password:
Logging in with username tvincent
HTTP POSTing to
http://reviewboard.truncated.com/api/json/accounts/login/: {'username':
'tvincent', 'password': '**'}
Traceback (most recent call last):
File /usr/bin/post-review, line 7, in ?
sys.exit(
File /usr/lib/python2.4/site-packages/RBTools-0.3.2-py2.4.egg/
rbtools/postreview.py, line 3790, in main
File /usr/lib/python2.4/site-packages/RBTools-0.3.2-py2.4.egg/
rbtools/postreview.py, line 488, in login
File /usr/lib/python2.4/site-packages/RBTools-0.3.2-py2.4.egg/
rbtools/postreview.py, line 982, in api_post
File /usr/lib/python2.4/site-packages/RBTools-0.3.2-py2.4.egg/
rbtools/postreview.py, line 903, in http_post
File /usr/lib64/python2.4/urllib2.py, line 130, in urlopen
return _opener.open(url, data)
File /usr/lib64/python2.4/urllib2.py, line 364, in open
response = meth(req, response)
File /usr/lib/python2.4/site-packages/RBTools-0.3.2-py2.4.egg/
rbtools/postreview.py, line 317, in http_response
File /usr/lib64/python2.4/urllib2.py, line 396, in error
result = self._call_chain(*args)
File /usr/lib64/python2.4/urllib2.py, line 337, in _call_chain
result = func(*args)
File /usr/lib64/python2.4/urllib2.py, line 741, in http_error_401
host, req, headers)
File /usr/lib64/python2.4/urllib2.py, line 720, in
http_error_auth_reqed
return self.retry_http_basic_auth(host, req, realm)
File /usr/lib/python2.4/site-packages/RBTools-0.3.2-py2.4.egg/
rbtools/postreview.py, line 339, in retry_http_basic_auth
File /usr/lib64/python2.4/urllib2.py, line 730, in
retry_http_basic_auth
return self.parent.open(req)
File /usr/lib64/python2.4/urllib2.py, line 364, in open
response = meth(req, response)
File /usr/lib/python2.4/site-packages/RBTools-0.3.2-py2.4.egg/
rbtools/postreview.py, line 317, in http_response
File /usr/lib64/python2.4/urllib2.py, line 396, in error
result = self._call_chain(*args)
File /usr/lib64/python2.4/urllib2.py, line 337, in _call_chain
result = func(*args)
File /usr/lib64/python2.4/urllib2.py, line 916, in http_error_401
host, req, headers)
File /usr/lib64/python2.4/urllib2.py, line 807, in
http_error_auth_reqed
raise ValueError(AbstractDigestAuthHandler doesn't know
ValueError: AbstractDigestAuthHandler doesn't know about Basic
On May 10, 6:22 pm, Christian Hammond chip...@chipx86.com wrote:
What type of repository are you using? I assume Subversion?
It looks like there are two things going wrong. The first is that Review
Board's having some sort of trouble fetching server information from your
repository. The second is that locally, it's been unable to generate a
diff.
So assuming Subversion, what happens if you run svn diff on your
checkout?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Tue, May 10, 2011 at 5:49 PM, Thomas Vincent tvinc...@astreya.com
wrote:
Hi,
I am getting the following errors when I try to upload a file using
post-review.
Got API Error 210 (HTTP code 200): There was an error fetching
extended
information for this repository.
Error data: {'deprecated': {'in_version': '1.5'}, 'stat': 'fail',
'err': {'msg': 'There was an error fetching extended information for
this
repository.', 'code': 210}}
HTTP GETting api/json/repositories/3/info/
Got API Error 210 (HTTP code 200): There was an error fetching
extended
information for this repository.
Error data: {'deprecated': {'in_version': '1.5'}, 'stat': 'fail',
'err': {'msg': 'There was an error fetching extended
Re: Review Board 1.6 beta 2 - For real this time!
Ah, I suspected that it might be in the database. Thanks, Dan On May 11, 2:54 pm, Christian Hammond chip...@chipx86.com wrote: It fixes all future ones going forward. We need to reset the broken 1.6 beta 1 counts, which I'm still trying to figure out the best way to do. It'll happen by the next beta, unless there's some emergency that forces us to put the beta out sooner than planned. We have a Review Board instance with negative counts too. I'm keeping it that way as a reminder :) Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Wed, May 11, 2011 at 10:59 AM, Dan Savilonis d...@n-cube.org wrote: Upgrade to 1.6 beta 2 went fine for me. However, I noticed there are a couple lines in the release note indicating some fixes for incoming review and starred review request counts. This doesn't seem to have fixed the counts for me. I currently have -15 incoming reviews and -1 outgoing reviews. I've noticed it slowly decrementing since we installed 1.6 beta 1 :) Dan On May 10, 3:03 am, Ashithraj Shetty asithraj.she...@gmail.com wrote: Upgraded to the latest release. Big bad box is not seen anymore J -Ashith From: reviewboard@googlegroups.com [mailto:reviewboard@googlegroups.com] On Behalf Of Christian Hammond Sent: Tuesday, May 10, 2011 11:37 AM To: reviewboard@googlegroups.com Subject: Review Board 1.6 beta 2 - For real this time! Let's try this again. 1.6 beta 2 is out! It should work with PostgreSQL and shouldn't have a giant box at the bottom of every page. Give it a try! Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com -- Want to help the Review Board project? Donate today athttp:// www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group athttp:// groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Error uploading diff
Hi,
I upgraded to version 1.5.5 and I am running mod_python with Python 2.6.
Only asks me for my password once now.
Less errors, but still a error:
post-review -pd --summary=review board test --description=REVIEW BOARD
TEST USE_SVN_README --username=tvincent
RBTools 0.3.2
Home = /home/tvincent
svn info
diff --version
repository info: Path: https://SERVER01.truncated.com/opt, Base path:
/operations/puppet, Supports changesets: False
HTTP GETting api/
== HTTP Authentication Required
Enter authorization information for Web API at SERVER02.truncated.com
Password:
HTTP GETting http://SERVER02.truncated.com/api/info/
Using the new web API
svn diff --diff-cmd=diff USE_SVN_README
svn info USE_SVN_README
svn info USE_SVN_README
svn info USE_SVN_README
svn info USE_SVN_README
HTTP GETting http://SERVER02.truncated.com/api/repositories/
HTTP GETting http://SERVER02.truncated.com/api/repositories/2/
HTTP GETting http://SERVER02.truncated.com/api/repositories/2/info/
Got API Error 210 (HTTP code 500): There was an error fetching extended
information for this repository
Error data: {'stat': 'fail', 'err': {'msg': 'There was an error fetching
extended information for this repository', 'code': 210}}
HTTP GETting http://SERVER02.truncated.com/api/repositories/3/
HTTP GETting http://SERVER02.truncated.com/api/repositories/3/info/
Got API Error 210 (HTTP code 500): There was an error fetching extended
information for this repository
Error data: {'stat': 'fail', 'err': {'msg': 'There was an error fetching
extended information for this repository', 'code': 210}}
HTTP GETting http://SERVER02.truncated.com/api/repositories/4/
HTTP GETting http://SERVER02.truncated.com/api/repositories/4/info/
Attempting to create review request on
https://SERVER01.truncated.com/opt for None
HTTP POSTing to http://SERVER02.truncated.com/api/review-requests/:
{'repository': 'https://SERVER01.truncated.com/opt'}
Review request created
Attempting to set field 'summary' to 'review board test' for review
request '414'
HTTP PUTting to
http://SERVER02.truncated.com/api/review-requests/414/draft/: {'summary':
'review board test'}
Attempting to set field 'description' to 'REVIEW BOARD TEST' for review
request '414'
HTTP PUTting to
http://SERVER02.truncated.com/api/review-requests/414/draft/:
{'description': 'REVIEW BOARD TEST'}
Uploading diff, size: 421
HTTP POSTing to
http://SERVER02.truncated.com/api/review-requests/414/diffs/: {'basedir':
'/operations/puppet'}
Got API Error 105 (HTTP code 400): One or more fields had errors
Error data: {'fields': {'path': [Server sent unexpected return value
(500 Internal Server Error) in response to OPTIONS request for '
https://SERVER01.truncated.com/opt/operations/puppet/USE_SVN_README']},
'stat': 'fail', 'err': {'msg': 'One or more fields had errors', 'code':
105}}
Error uploading diff
The generated diff file was empty. This usually means no files were
modified in this change.
Try running with --output-diff and --debug for more information.
Your review request still exists, but the diff is not attached.
On Wed, May 11, 2011 at 12:28 PM, Christian Hammond chip...@chipx86.comwrote:
You're running exactly 1.5? Try upgrading. There are a lot of API issues in
1.5, which I want to rule out first.
Also, are you using mod_python, or something else?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, May 11, 2011 at 11:10 AM, Thomas Vincent tvinc...@astreya.comwrote:
I changed the site setting from http to https. Now I get:
[13:07:36 tvincent@SERVER02:~/puppet]$ post-review -pd --
summary=review board test --description=REVIEW BOARD TEST
USE_SVN_README --username=tvincent
RBTools 0.3.2
Home = /home/tvincent
svn info
diff --version
repository info: Path: https://SERVER01.truncated.com/opt, Base path:
/operations/puppet, Supports changesets: False
HTTP GETting api/
== HTTP Authentication Required
Enter authorization information for Web API at
reviewboard.truncated.com
Password:
HTTP GETting http://reviewboard.truncated.com/api/info/
Using the deprecated Review Board 1.0 web API
svn diff --diff-cmd=diff USE_SVN_README
svn info USE_SVN_README
svn info USE_SVN_README
svn info USE_SVN_README
svn info USE_SVN_README
== Review Board Login Required
Enter username and password for Review Board at
http://reviewboard.truncated.com/
Password:
Logging in with username tvincent
HTTP POSTing to
http://reviewboard.truncated.com/api/json/accounts/login/: {'username':
'tvincent', 'password': '**'}
Traceback (most recent call last):
File /usr/bin/post-review, line 7, in ?
sys.exit(
File /usr/lib/python2.4/site-packages/RBTools-0.3.2-py2.4.egg/
rbtools/postreview.py, line 3790, in main
File /usr/lib/python2.4/site-packages/RBTools-0.3.2-py2.4.egg/
rbtools/postreview.py, line 488, in login
File
Re: Error uploading diff
It still looks like Review Board is having a problem accessing your
Subversion repository. It's failing in some way. Might want to check the
Review Board log file to see if anything is coming up, and attempt a 'svn
info' on the repository path from the Review Board server.
It could be some issue with your PySVN install, too.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, May 11, 2011 at 3:23 PM, Thomas Vincent tvinc...@astreya.comwrote:
Hi,
I upgraded to version 1.5.5 and I am running mod_python with Python 2.6.
Only asks me for my password once now.
Less errors, but still a error:
post-review -pd --summary=review board test --description=REVIEW BOARD
TEST USE_SVN_README --username=tvincent
RBTools 0.3.2
Home = /home/tvincent
svn info
diff --version
repository info: Path: https://SERVER01.truncated.com/opt, Base path:
/operations/puppet, Supports changesets: False
HTTP GETting api/
== HTTP Authentication Required
Enter authorization information for Web API at SERVER02.truncated.com
Password:
HTTP GETting http://SERVER02.truncated.com/api/info/
Using the new web API
svn diff --diff-cmd=diff USE_SVN_README
svn info USE_SVN_README
svn info USE_SVN_README
svn info USE_SVN_README
svn info USE_SVN_README
HTTP GETting http://SERVER02.truncated.com/api/repositories/
HTTP GETting http://SERVER02.truncated.com/api/repositories/2/
HTTP GETting http://SERVER02.truncated.com/api/repositories/2/info/
Got API Error 210 (HTTP code 500): There was an error fetching extended
information for this repository
Error data: {'stat': 'fail', 'err': {'msg': 'There was an error
fetching extended information for this repository', 'code': 210}}
HTTP GETting http://SERVER02.truncated.com/api/repositories/3/
HTTP GETting http://SERVER02.truncated.com/api/repositories/3/info/
Got API Error 210 (HTTP code 500): There was an error fetching extended
information for this repository
Error data: {'stat': 'fail', 'err': {'msg': 'There was an error
fetching extended information for this repository', 'code': 210}}
HTTP GETting http://SERVER02.truncated.com/api/repositories/4/
HTTP GETting http://SERVER02.truncated.com/api/repositories/4/info/
Attempting to create review request on
https://SERVER01.truncated.com/opt for None
HTTP POSTing to http://SERVER02.truncated.com/api/review-requests/:
{'repository': 'https://SERVER01.truncated.com/opt'}
Review request created
Attempting to set field 'summary' to 'review board test' for review
request '414'
HTTP PUTting to
http://SERVER02.truncated.com/api/review-requests/414/draft/: {'summary':
'review board test'}
Attempting to set field 'description' to 'REVIEW BOARD TEST' for review
request '414'
HTTP PUTting to
http://SERVER02.truncated.com/api/review-requests/414/draft/:
{'description': 'REVIEW BOARD TEST'}
Uploading diff, size: 421
HTTP POSTing to
http://SERVER02.truncated.com/api/review-requests/414/diffs/: {'basedir':
'/operations/puppet'}
Got API Error 105 (HTTP code 400): One or more fields had errors
Error data: {'fields': {'path': [Server sent unexpected return value
(500 Internal Server Error) in response to OPTIONS request for '
https://SERVER01.truncated.com/opt/operations/puppet/USE_SVN_README']},
'stat': 'fail', 'err': {'msg': 'One or more fields had errors', 'code':
105}}
Error uploading diff
The generated diff file was empty. This usually means no files were
modified in this change.
Try running with --output-diff and --debug for more information.
Your review request still exists, but the diff is not attached.
On Wed, May 11, 2011 at 12:28 PM, Christian Hammond
chip...@chipx86.comwrote:
You're running exactly 1.5? Try upgrading. There are a lot of API issues
in 1.5, which I want to rule out first.
Also, are you using mod_python, or something else?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, May 11, 2011 at 11:10 AM, Thomas Vincent tvinc...@astreya.comwrote:
I changed the site setting from http to https. Now I get:
[13:07:36 tvincent@SERVER02:~/puppet]$ post-review -pd --
summary=review board test --description=REVIEW BOARD TEST
USE_SVN_README --username=tvincent
RBTools 0.3.2
Home = /home/tvincent
svn info
diff --version
repository info: Path: https://SERVER01.truncated.com/opt, Base
path: /operations/puppet, Supports changesets: False
HTTP GETting api/
== HTTP Authentication Required
Enter authorization information for Web API at
reviewboard.truncated.com
Password:
HTTP GETting http://reviewboard.truncated.com/api/info/
Using the deprecated Review Board 1.0 web API
svn diff --diff-cmd=diff USE_SVN_README
svn info USE_SVN_README
svn info USE_SVN_README
svn info USE_SVN_README
svn info USE_SVN_README
== Review Board Login
Re: Realized web-based post-commit reviews
Hi Philipp,
I've pulled your latest code from git and updated my
install. It no longer errors, but just displays No pending revisions
found. on clicking on the 'Get Revisions' button.
I've checked in a
handful of new revisions too in case it remembered the revisions I had
previously listed manually in my previous tests, but its not returning
anything on screen.
Python isnt my language (I usually code in
perl/php/C) but taking a brief look at your code, I tried increasing the
freshness_delta variable as well, but it made no difference.
Let me
know if you would like me to try anything else.
Regards,
Rob
On
Wed, 11 May 2011 03:47:39 -0700 (PDT), Philipp Henkel wrote:
Rob,
The fix is committed. Could you please test with the latest version
of
reviewboard/scmtools/svn_post_tracker.py?
- Philipp
On
May 10, 8:58 pm, Philipp Henkel
wrote:
Hi Rob, Thanks, I'm glad
you like it. Currently I rely on svn:log property in order to extract
the commit description. This property might not exist because you don't
enforce commit messages (like we do). I have already a better solution
in mind and it should be easy to fix. Best regards, Philipp On May 10,
12:35 am, Rob Coward wrote:
Hi Philipp,
I am very
interested in your Subversion Post-commit enhancement, and quite
possibly might be the killer feature that persuades us to start using it
at work too.
your patches up to the latest 1.6 beta2) and it is
mostly working in that I can manually specify a list of revisions and it
will generate the diffs and create the review etc, however when clicking
on the 'Get Revisions' button I get an Error500 back from the server
with the following in apache's error_log:
%ERROR:root:Exception
thrown for user admin athttp://192.168.1.68/r/newpost/ eback (most
recent call last): File /usr/lib/python2.4/site-packages
handlers/base.py, line 99, in get_response response = callback(request,
*callback_args, **callback_kwargs) File
/usr/lib/python2.4/site-packages/djblets/auth/util.py, line 46, in
_checklogin ret
ews.py, line 98, in new_post_review_request
diff_file=request.FILES.get('diff_path')) File
/usr/lib/python2.4/site-packages/reviewboard/reviews/forms.py, line
411, in create raise e KeyError: 'revprops'
The subvers
brand new
repo I created for the task of reviewing your code, populated initially
with cvs2svn to import an e
2px solid; margin-left:5px;
width:100%Any thoughts ?
your hard work. Rob Coward On Fri, 6 May
2011 02:43:05 -0700 (PDT), Philipp Henkel wro
ft:5px;
width:100%
Hi,
type=cite style=padding-left:5px;
border-left:#1010ff 2px solid; margin-left:5px; width:100%Did anyone
eft:5px; width:10
nce to have look at my post-commit implementation?
implementation is complete and
r-left:#1010ff 2px solid;
margin-left:5px; width:100%feature se
ady possible to create
requests by typing in #1010ff 2px solid; margin-left:5px;
width:100%Philipp
lid; margin-left:5px; width:100%-- Philipp
Henkel Citrix Online -www.citrix
:#1010ff 2px solid;
margin-left:5px; width:100%
tyle=padding-left:5px;
border-left:#1010ff 2px solid; margin-left:5px; width:100%The views
expressed here are mine alone and have not been authorized not
necessarily reflect the views of, Citrix.
eft:#1010ff 2px solid;
margin-left:5px; width:100%Links: --
[1]http://www.citrixonline.com
-- Want to help the Review Board
project? Donate today at http://www.reviewboard.org/donate/ [1] Happy
user? Let us know at http://www.reviewboard.org/users/ [2]
-~--~~~~--~~--~--~--- To unsubscribe
from this group, send email to reviewboard+unsubscr...@googlegroups.com
[3] For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en [4]
Links:
--
[1] http://www.reviewboard.org/donate/
[2]
http://www.reviewboard.org/users/
[3]
mailto:reviewboard+unsubscr...@googlegroups.com
[4]
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: Error uploading diff
Hi Chris,
I posted the logs at http://pastebin.com/aB4a8iMr . I see the errors that
indicate something wrong. But I can't reproduce the problem at the command
line. Thanks in advance.
On Wed, May 11, 2011 at 3:25 PM, Christian Hammond chip...@chipx86.comwrote:
It still looks like Review Board is having a problem accessing your
Subversion repository. It's failing in some way. Might want to check the
Review Board log file to see if anything is coming up, and attempt a 'svn
info' on the repository path from the Review Board server.
It could be some issue with your PySVN install, too.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, May 11, 2011 at 3:23 PM, Thomas Vincent tvinc...@astreya.comwrote:
Hi,
I upgraded to version 1.5.5 and I am running mod_python with Python 2.6.
Only asks me for my password once now.
Less errors, but still a error:
post-review -pd --summary=review board test --description=REVIEW BOARD
TEST USE_SVN_README --username=tvincent
RBTools 0.3.2
Home = /home/tvincent
svn info
diff --version
repository info: Path: https://SERVER01.truncated.com/opt, Base path:
/operations/puppet, Supports changesets: False
HTTP GETting api/
== HTTP Authentication Required
Enter authorization information for Web API at SERVER02.truncated.com
Password:
HTTP GETting http://SERVER02.truncated.com/api/info/
Using the new web API
svn diff --diff-cmd=diff USE_SVN_README
svn info USE_SVN_README
svn info USE_SVN_README
svn info USE_SVN_README
svn info USE_SVN_README
HTTP GETting http://SERVER02.truncated.com/api/repositories/
HTTP GETting http://SERVER02.truncated.com/api/repositories/2/
HTTP GETting http://SERVER02.truncated.com/api/repositories/2/info/
Got API Error 210 (HTTP code 500): There was an error fetching
extended information for this repository
Error data: {'stat': 'fail', 'err': {'msg': 'There was an error
fetching extended information for this repository', 'code': 210}}
HTTP GETting http://SERVER02.truncated.com/api/repositories/3/
HTTP GETting http://SERVER02.truncated.com/api/repositories/3/info/
Got API Error 210 (HTTP code 500): There was an error fetching
extended information for this repository
Error data: {'stat': 'fail', 'err': {'msg': 'There was an error
fetching extended information for this repository', 'code': 210}}
HTTP GETting http://SERVER02.truncated.com/api/repositories/4/
HTTP GETting http://SERVER02.truncated.com/api/repositories/4/info/
Attempting to create review request on
https://SERVER01.truncated.com/opt for None
HTTP POSTing to http://SERVER02.truncated.com/api/review-requests/:
{'repository': 'https://SERVER01.truncated.com/opt'}
Review request created
Attempting to set field 'summary' to 'review board test' for review
request '414'
HTTP PUTting to
http://SERVER02.truncated.com/api/review-requests/414/draft/: {'summary':
'review board test'}
Attempting to set field 'description' to 'REVIEW BOARD TEST' for
review request '414'
HTTP PUTting to
http://SERVER02.truncated.com/api/review-requests/414/draft/:
{'description': 'REVIEW BOARD TEST'}
Uploading diff, size: 421
HTTP POSTing to
http://SERVER02.truncated.com/api/review-requests/414/diffs/: {'basedir':
'/operations/puppet'}
Got API Error 105 (HTTP code 400): One or more fields had errors
Error data: {'fields': {'path': [Server sent unexpected return value
(500 Internal Server Error) in response to OPTIONS request for '
https://SERVER01.truncated.com/opt/operations/puppet/USE_SVN_README']},
'stat': 'fail', 'err': {'msg': 'One or more fields had errors', 'code':
105}}
Error uploading diff
The generated diff file was empty. This usually means no files were
modified in this change.
Try running with --output-diff and --debug for more information.
Your review request still exists, but the diff is not attached.
On Wed, May 11, 2011 at 12:28 PM, Christian Hammond
chip...@chipx86.comwrote:
You're running exactly 1.5? Try upgrading. There are a lot of API issues
in 1.5, which I want to rule out first.
Also, are you using mod_python, or something else?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, May 11, 2011 at 11:10 AM, Thomas Vincent
tvinc...@astreya.comwrote:
I changed the site setting from http to https. Now I get:
[13:07:36 tvincent@SERVER02:~/puppet]$ post-review -pd --
summary=review board test --description=REVIEW BOARD TEST
USE_SVN_README --username=tvincent
RBTools 0.3.2
Home = /home/tvincent
svn info
diff --version
repository info: Path: https://SERVER01.truncated.com/opt, Base
path: /operations/puppet, Supports changesets: False
HTTP GETting api/
== HTTP Authentication Required
Enter authorization information for Web API at
reviewboard.truncated.com
Password:
Re: Realized web-based post-commit reviews
Ignore me - further code inspection led me to realise that my
reviewboard userid wasnt the same user that had done the subversion
checkin. On changing my reviewboard userid to match, the button now
populates a nice list of revisions.
Great job.:-)
Now to convince
the team at work that this is a worth while package to start using. Lets
hope this functionality makes it into the main code soon.
Rob
On
Wed, 11 May 2011 23:38:03 +0100, Rob Coward wrote:
Hi Philipp,
I've pulled your latest code from git and updated my install. It no
longer errors, but just displays No pending revisions found. on
clicking on the 'Get Revisions' button.
I've checked in a handful
of new revisions too in case it remembered the revisions I had
previously listed manually in my previous tests, but its not returning
anything on screen.
Python isnt my language (I usually code in
perl/php/C) but taking a brief look at your code, I tried increasing the
freshness_delta variable as well, but it made no difference.
Let
me know if you would like me to try anything else.
Regards,
Rob
On Wed, 11 May 2011 03:47:39 -0700 (PDT), Philipp Henkel
wrote:
Rob,
The fix is committed. Could you please test
with the latest version of
reviewboard/scmtools/svn_post_tracker.py?
- Philipp
On May
10, 8:58 pm, Philipp Henkel
wrote:
Hi Rob, Thanks, I'm glad you
like it. Currently I rely on svn:log property in order to extract the
commit description. This property might not exist because you don't
enforce commit messages (like we do). I have already a better solution
in mind and it should be easy to fix. Best regards, Philipp On May 10,
12:35 am, Rob Coward wrote:
Hi Philipp,
I am very
interested in your Subversion Post-commit enhancement, and quite
possibly might be the killer feature that persuades us to start using it
at work too.
port your patches up to the latest 1.6 beta2) and it is
mostly working in that I can manually specify a list of revisions and it
will generate the diffs and create the review etc, however when clicking
on the 'Get Revisions' button I get an Error500 back from the server
with the following in apache's error_log:
;ERROR:root:Exception
thrown for user admin athttp://192.168.1.68/r/newpost/ Traceback (most
recent call last): File /usr/lib/python2.4/site-pac
core/handlers/base.py, line 99, in get_response response =
callback(request, *callback_args, **callback_kwargs) File
/usr/lib/python2.4/site-packages/djblets/auth/util.py, line 46, in
_checkl
viewboard/reviews/views.py, line 98, in
new_post_review_request
diff_file=request.FILES.get('diff_path')) File
/usr/lib/python2.4/site-packages/reviewboard/reviews/forms.py, line
411, in create raise e KeyError: 'revprops'
T
repo is a brand
new repo I created for the task of reviewing your code, populated
initially with cvs2svn
#1010ff 2px solid; margin-left: 5px;
width: 100%;Any thoughts ?
anks for your hard work. Rob Coward On
Fri, 6 May 2011 02:43:05 -0700 (PDT), Phil
; margin-left: 5px;
width: 100%;
Hi,
ockquote style=padding-left: 5px;
border-left: #1010ff 2px solid; margin-left: 5px; width: 100%;Did
id; margin-left:
00%;had a chance to have look at my
post-commit implementation?
It is already possible to create
requests by typing in Philipp
rgin-left: 5px; width: 100%;--
Philipp Henkel Citrix Online -www.citrix
0ff 2px solid;
margin-left: 5px; width: 100%;
g-left: 5px; border-left: #1010ff
2px solid; margin-left: 5px; width: 100%;The views expressed here are
mine alone and have not been authorized not necessarily reflect the
views of, Citrix.
f 2px solid; margin-left: 5px; width:
100%;Links: -- [1]http://www.citrixonline.com
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/ [1] Happy user? Let us know at
http://www.reviewboard.org/users/ [2]
-~--~~~~--~~--~--~--- To unsubscribe
from this group, send email to reviewboard+unsubscr...@googlegroups.com
[3] For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en [4]
--
Want to
help the Review Board project? Donate today at
http://www.reviewboard.org/donate/ [5]
Happy user? Let us know at
http://www.reviewboard.org/users/ [6]
-~--~~~~--~~--~--~---
To unsubscribe
from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this
group at http://groups.google.com/group/reviewboard?hl=en [7]
Links:
--
[1] http://www.reviewboard.org/donate/
[2]
http://www.reviewboard.org/users/
[3]
mailto:reviewboard+unsubscr...@googlegroups.com
[4]
http://groups.google.com/group/reviewboard?hl=en
[5]
http://www.reviewboard.org/donate/
[6]
http://www.reviewboard.org/users/
[7]
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at
Re: Realized web-based post-commit reviews
It's a bit too late in the game for 1.6, but it's something I'd love to see
us get in after that. We've wanted this functionality before and had a
couple attempts for doing it as part of student projects.
At some point if we get a patch up on reviews.reviewboard.org, we'll see
what it'd take to get it all pushed upstream.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, May 11, 2011 at 3:45 PM, Rob Coward r...@jive-videos.net wrote:
Ignore me - further code inspection led me to realise that my reviewboard
userid wasnt the same user that had done the subversion checkin. On changing
my reviewboard userid to match, the button now populates a nice list of
revisions.
Great job.[image: Smile]
Now to convince the team at work that this is a worth while package to
start using. Lets hope this functionality makes it into the main code soon.
Rob
On Wed, 11 May 2011 23:38:03 +0100, Rob Coward wrote:
Hi Philipp,
I've pulled your latest code from git and updated my install. It no longer
errors, but just displays No pending revisions found. on clicking on the
'Get Revisions' button.
I've checked in a handful of new revisions too in case it remembered the
revisions I had previously listed manually in my previous tests, but its not
returning anything on screen.
Python isnt my language (I usually code in perl/php/C) but taking a brief
look at your code, I tried increasing the freshness_delta variable as well,
but it made no difference.
Let me know if you would like me to try anything else.
Regards,
Rob
On Wed, 11 May 2011 03:47:39 -0700 (PDT), Philipp Henkel wrote:
Rob,
The fix is committed. Could you please test with the latest version of
reviewboard/scmtools/svn_post_tracker.py?
- Philipp
On May 10, 8:58 pm, Philipp Henkel
wrote:
Hi Rob,
Thanks, I'm glad you like it.
Currently I rely on svn:log property in order to extract the commit
description. This property might not exist because you don't enforce
commit messages (like we do). I have already a better solution in mind
and it should be easy to fix.
Best regards,
Philipp
On May 10, 12:35 am, Rob Coward wrote:
Hi Philipp,
I am very interested in your Subversion Post-commit
enhancement, and quite possibly might be the killer feature that
persuades us to start using it at work too.
I have downloaded your
code and dropped it on top of 1.5.5 for now (if I get time, I'll be
trying to port your patches up to the latest 1.6 beta2) and it is mostly
working in that I can manually specify a list of revisions and it will
generate the diffs and create the review etc, however when clicking on
the 'Get Revisions' button I get an Error500 back from the server with
the following in apache's error_log:
ERROR:root:Exception thrown for
user admin athttp://192.168.1.68/r/newpost/
'revprops'
Traceback (most
recent call last):
File
/usr/lib/python2.4/site-packages/django/core/handlers/base.py, line
99, in get_response
response = callback(request, *callback_args,
**callback_kwargs)
File
/usr/lib/python2.4/site-packages/djblets/auth/util.py, line 46, in
_checklogin
return view_func(request, *args, **kwargs)
File
/usr/lib/python2.4/site-packages/reviewboard/reviews/views.py, line
98, in new_post_review_request
diff_file=request.FILES.get('diff_path'))
File
/usr/lib/python2.4/site-packages/reviewboard/reviews/forms.py, line
411, in create
raise e
KeyError: 'revprops'
The subversion repo is a
brand new repo I created for the task of reviewing your code, populated
initially with cvs2svn to import an existing cvs repository.
Any
thoughts ?
Thanks for your hard work.
Rob Coward
On Fri, 6 May
2011 02:43:05 -0700 (PDT), Philipp Henkel wrote:
Hi,
Did anyone
had a chance to have look at my post-commit implementation?
http://philipphenkel.github.com/post-reviewboard[1]
The subversion
implementation is complete and for Perforce I realized the basic
feature set. It is already possible to create requests by typing in
change numbers in the Post-commit web form.
Best regards,
Philipp
--
Philipp Henkel
Citrix Online -www.citrixonline.com
[2]
The views expressed here are mine alone and have not been
authorized
by, and do not necessarily reflect the views of, Citrix.
Links:
--
[1]http://philipphenkel.github.com/post-reviewboard
[2]http://www.citrixonline.com
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Re: Error uploading diff
So it does look as if the Subversion server or perhaps some proxy that's
inbetween Review Board and the SVN server is actually breaking when doing an
HTTP OPTIONS call. I can't guess at this point what the cause would be, but
it seems that Review Board isn't the problem. You'd need to track down why
the SVN server is breaking during an HTTP OPTIONS query.
You can probably simulate that query using either telnet or curl.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, May 11, 2011 at 3:39 PM, Thomas Vincent tvinc...@astreya.comwrote:
Hi Chris,
I posted the logs at http://pastebin.com/aB4a8iMr . I see the errors that
indicate something wrong. But I can't reproduce the problem at the command
line. Thanks in advance.
On Wed, May 11, 2011 at 3:25 PM, Christian Hammond chip...@chipx86.comwrote:
It still looks like Review Board is having a problem accessing your
Subversion repository. It's failing in some way. Might want to check the
Review Board log file to see if anything is coming up, and attempt a 'svn
info' on the repository path from the Review Board server.
It could be some issue with your PySVN install, too.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, May 11, 2011 at 3:23 PM, Thomas Vincent tvinc...@astreya.comwrote:
Hi,
I upgraded to version 1.5.5 and I am running mod_python with Python 2.6.
Only asks me for my password once now.
Less errors, but still a error:
post-review -pd --summary=review board test --description=REVIEW
BOARD TEST USE_SVN_README --username=tvincent
RBTools 0.3.2
Home = /home/tvincent
svn info
diff --version
repository info: Path: https://SERVER01.truncated.com/opt, Base
path: /operations/puppet, Supports changesets: False
HTTP GETting api/
== HTTP Authentication Required
Enter authorization information for Web API at SERVER02.truncated.com
Password:
HTTP GETting http://SERVER02.truncated.com/api/info/
Using the new web API
svn diff --diff-cmd=diff USE_SVN_README
svn info USE_SVN_README
svn info USE_SVN_README
svn info USE_SVN_README
svn info USE_SVN_README
HTTP GETting http://SERVER02.truncated.com/api/repositories/
HTTP GETting http://SERVER02.truncated.com/api/repositories/2/
HTTP GETting http://SERVER02.truncated.com/api/repositories/2/info/
Got API Error 210 (HTTP code 500): There was an error fetching
extended information for this repository
Error data: {'stat': 'fail', 'err': {'msg': 'There was an error
fetching extended information for this repository', 'code': 210}}
HTTP GETting http://SERVER02.truncated.com/api/repositories/3/
HTTP GETting http://SERVER02.truncated.com/api/repositories/3/info/
Got API Error 210 (HTTP code 500): There was an error fetching
extended information for this repository
Error data: {'stat': 'fail', 'err': {'msg': 'There was an error
fetching extended information for this repository', 'code': 210}}
HTTP GETting http://SERVER02.truncated.com/api/repositories/4/
HTTP GETting http://SERVER02.truncated.com/api/repositories/4/info/
Attempting to create review request on
https://SERVER01.truncated.com/opt for None
HTTP POSTing to http://SERVER02.truncated.com/api/review-requests/:
{'repository': 'https://SERVER01.truncated.com/opt'}
Review request created
Attempting to set field 'summary' to 'review board test' for review
request '414'
HTTP PUTting to
http://SERVER02.truncated.com/api/review-requests/414/draft/:
{'summary': 'review board test'}
Attempting to set field 'description' to 'REVIEW BOARD TEST' for
review request '414'
HTTP PUTting to
http://SERVER02.truncated.com/api/review-requests/414/draft/:
{'description': 'REVIEW BOARD TEST'}
Uploading diff, size: 421
HTTP POSTing to
http://SERVER02.truncated.com/api/review-requests/414/diffs/:
{'basedir': '/operations/puppet'}
Got API Error 105 (HTTP code 400): One or more fields had errors
Error data: {'fields': {'path': [Server sent unexpected return value
(500 Internal Server Error) in response to OPTIONS request for '
https://SERVER01.truncated.com/opt/operations/puppet/USE_SVN_README']},
'stat': 'fail', 'err': {'msg': 'One or more fields had errors', 'code':
105}}
Error uploading diff
The generated diff file was empty. This usually means no files were
modified in this change.
Try running with --output-diff and --debug for more information.
Your review request still exists, but the diff is not attached.
On Wed, May 11, 2011 at 12:28 PM, Christian Hammond chip...@chipx86.com
wrote:
You're running exactly 1.5? Try upgrading. There are a lot of API issues
in 1.5, which I want to rule out first.
Also, are you using mod_python, or something else?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. -
Re: Happy User
Hey Andy, Thanks! Sorry for the late response. I kept meaning to add this but have been distracted all week. The Looxcie looks pretty cool. Must be fun to play with :) Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, May 2, 2011 at 11:16 AM, Andy Peterson apsoftw...@gmail.com wrote: Hi guys, I set up ReviewBoard while at Good Technology (became Motorola, became Visto, Became Good Technology again). I no longer work there, but from what I understand they are still using it and are happy. I now work for Looxcie, a Santa Clara based company, and set up Reviewboard here as well. I would like to add this company to your list of happy users. Looxcie -- The first wearable social video cam that records everything you see. Thanks! -Andy Peterson -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: LDAP failure
things work now.. On May 11, 10:34 am, minkzanity min...@gmail.com wrote: Corporate LDAP server On May 11, 3:26 am, Paul Schulz p...@mawsonlakes.org wrote: What LDAP are you authenticating to? On Wed, May 11, 2011 at 4:54 PM, minkzanity min...@gmail.com wrote: Update: After making sure the User Mask was identical, I do not get the Bad search filter error. I still get the bind failure. -- Want to help the Review Board project? Donate today athttp://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group athttp://groups.google.com/group/reviewboard?hl=en-Hide quoted text - - Show quoted text -- Hide quoted text - - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Issue 1398 in reviewboard: API to search reviews by bug ID and query review status
Comment #3 on issue 1398 by prasanna...@gmail.com: API to search reviews by bug ID and query review status http://code.google.com/p/reviewboard/issues/detail?id=1398 Can some one help on this ? Even I have something based on this -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 239 in reviewboard: Attach files other than screenshots
Comment #13 on issue 239 by da.s...@gmail.com: Attach files other than screenshots http://code.google.com/p/reviewboard/issues/detail?id=239 It'd be great for Reviewboard to be able to take a good guess at what type of file is being uploaded. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2098 in reviewboard: Add image to comments
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 2098 by da.s...@gmail.com: Add image to comments http://code.google.com/p/reviewboard/issues/detail?id=2098 *NOTE: If you have a patch, please submit it to http://reviews.reviewboard.org/ What version are you running? 1.5.5 What's the URL of the page this enhancement relates to, if any? Describe the enhancement and the motivation for it. I work with a lot of front end developers and often there is a link to some running environment together with the code they want to check in. I love being able to add screenshots when I start a review, but I can't add screenshots when I'm reviewing to point out problems with the running example. What operating system are you using? What browser? Please provide any additional information below. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1398 in reviewboard: API to search reviews by bug ID and query review status
Comment #4 on issue 1398 by chip...@gmail.com: API to search reviews by bug ID and query review status http://code.google.com/p/reviewboard/issues/detail?id=1398 We don't index bug IDs, and a query to get all review requests by bug ID doesn't scale. You can definitely get a review request with the API and get the submitted status. You can also look at all the reviews contained within and see the total and the number who marked it Ship It. So that's there today (assuming you're using 1.5.x and the new REST API). -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2095 in reviewboard: Cannot submit a bug using post-review
Comment #6 on issue 2095 by apsoftw...@gmail.com: Cannot submit a bug using post-review http://code.google.com/p/reviewboard/issues/detail?id=2095 It is working again. The only thing I did was take a system update from the Update Manager. I still don't know what was wrong, but you can close this item. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2095 in reviewboard: Cannot submit a bug using post-review
Updates: Status: SetupIssue Comment #7 on issue 2095 by trowb...@gmail.com: Cannot submit a bug using post-review http://code.google.com/p/reviewboard/issues/detail?id=2095 Thanks. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2099 in reviewboard: User admin page contains bad link
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2099 by ben.al...@gmail.com: User admin page contains bad link http://code.google.com/p/reviewboard/issues/detail?id=2099 * NOTE: Do not post confidential information in this bug report. * * If you need immediate support, please contact* * reviewbo...@googlegroups.com * What version are you running? 1.6 beta 2 What's the URL of the page containing the problem? http://localhost/reviews/admin/db/auth/user/1/ What steps will reproduce the problem? 1. Install ReviewBoard 1.6 beta 2 with sqlite and apache+mod_python 2. When asked for a directory to install RB into, enter /reviews/ 3. Create a default administrator account named 'admin' 4. Log into the site and click 'admin' - 'database' - 'users' - 'admin' 5. At the top-right-hand corner of the page, click on the button reading View on site What is the expected output? What do you see instead? When clicking on the button, I am taken to the URL http://localhost/users/admin and getting a 404 error. The URL I *should* be going to is http://localhost/reviews/users/admin. Manually inserting /reviews into the URL takes me to the correct page. In case it is helpful, I get the URL when hovering over the View on site button: http://localhost/reviews/admin/db/r/4/1/ Clicking on my username elsewhere in the site (e.g.: on a review page) takes me to the correct page. What operating system are you using? What browser? Linux (Ubuntu Maverick) Firefox 3.6.13 Please provide any additional information below. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
