Re: View Diff has issue in 1.7.2, and fine in 1.7.1
I haven't been able to reproduce this. Can you get me a stack trace from
the JavaScript console, showing what's calling what?
I also need to know which page you're hitting this on, and a repro case.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Fri, Jan 25, 2013 at 12:33 AM, Tao Zhou moon...@gmail.com wrote:
Hi,
I am using Review Board 1.7.2 on Windows 7 with repository on Clearcase,
and found the view diff page doesn't render correctly.
if I upload several changed files in one diff by post-review, say more
than 2 files, only 2 files' diff could display, and only can add comment
for the first one diff.
after some diagnose, I found the cause is in Line 15 of reviews.js, 'new
RB.CommentIssueManager({' will cause Uncaught TypeError
var gCommentIssueManager = new RB.CommentIssueManager({
Seems like the refactor of reviews.js in 1.7.2 by moving related code to
commentIssueManagerModel.js caused this problem, while 1.7.1 works just
fine.
As not so familiar with javascript, I can only find out the cause, don't
know how to fix.
Hope this also could be fixed in next Review Board release.
Thanks!
Tao Zhou
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: emial setting problem
Hi, Thanks for your answer. now I find a way to solve it. I modify this file./usr/local/lib/python2.6/dist-packages/ReviewBoard-1.7.2-py2.6.egg/reviewboard/notifications/email.py In function send_review_email, I modify from_email = a...@xxx.com. now RB will send email use a...@xxx.com.not use the submitter's email address. On Friday, January 25, 2013 3:28:23 PM UTC+8, Michael Zhilin wrote: Hi, RB uses the only email address and on behalf of mechanism. It's normal practice to suit email server policies. Could you explain your problem in details? Thank you, Michael Zhilin On Jan 25, 2013, at 10:31, xf0...@gmail.com javascript: wrote: Hi, Because of the limit of our company email server, I can not get a administrator email account to send an email by changing the sender to another email user. But when user A publish review, RB will use user A 's email address send email. When user B publish review.RB will use user B's email address to send email. Is there some method can let RB use one email address to send email. like modify email.py file. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard...@googlegroups.com javascript: For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: how long does a rb-site upgrade take?
I use Postgres. The upgrade progressed from this step and then I had the issue with assets (CSS/JS) not showing up. Googling around helped me add an entry in my Apache conf file to add an alias for 'static'. Review board works afterwards, but I frequently get errors like this. --- 2013-01-28 00:10:34,709 - ERROR - Internal Server Error: /r/1215/ Traceback (most recent call last): File /usr/local/lib/python2.7/dist-packages/Django-1.4.3-py2.7.egg/django/core/handlers/base.py, line 111, in get_response response = callback(request, *callback_args, **callback_kwargs) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.2-py2.7.egg/reviewboard/accounts/decorators.py, line 20, in _check return login_required(view_func)(*args, **kwargs) File /usr/local/lib/python2.7/dist-packages/Djblets-0.7.8-py2.7.egg/djblets/auth/util.py, line 47, in _checklogin return view_func(request, *args, **kwargs) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.2-py2.7.egg/reviewboard/reviews/views.py, line 728, in review_detail 'screenshots': screenshots, File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.2-py2.7.egg/reviewboard/reviews/views.py, line 124, in _make_review_request_context upload_diff_form = UploadDiffForm(review_request) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.2-py2.7.egg/reviewboard/reviews/forms.py, line 276, in __init__ data, *args, **kwargs) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.2-py2.7.egg/reviewboard/diffviewer/forms.py, line 51, in __init__ if self.repository.get_scmtool().get_diffs_use_absolute_paths(): File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.2-py2.7.egg/reviewboard/scmtools/models.py, line 134, in get_scmtool return cls(self) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.2-py2.7.egg/reviewboard/scmtools/hg.py, line 31, in __init__ self.client = HgClient(repository.path, repository.local_site) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.2-py2.7.egg/reviewboard/scmtools/hg.py, line 215, in __init__ if parse_version(version) = parse_version(1.2): File /usr/lib/python2.7/dist-packages/pkg_resources.py, line 1920, in parse_version for part in _parse_version_parts(s.lower()): TypeError: 'NoneType' object is not callable - rb-site doesn't show any problems / running the upgrade again doesn't do anything. Restarting the apache instance seems to help, but how do I fix this? Thanks, Mukund On Friday, January 25, 2013 1:33:59 AM UTC+5:30, Christian Hammond wrote: It looks like it's at the database migration stage. I've never seen this take a long time before. What type of database are you using, and how big is it? Christian -- Christian Hammond - chi...@chipx86.com javascript: Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Jan 24, 2013 at 11:39 AM, Christian Hammond chi...@gmail.comjavascript: wrote: It shouldn't take more than a few seconds. I'm not sure what it'd be blocking on... I'll check the list of steps when I'm back at the computer in 20 mins or so. Christian On Jan 24, 2013, at 0:58, Mukund Rajamannar muk...@synerzip.comjavascript: wrote: Hi, I have an extensively used reviewboard site with a lot of reviews. Doing a rb-site upgrade from 1.6.11 to 1.7.2 seems to be stuck at Rebuilding directory structure Updating database. This may take a while. The log output below, including warnings and errors, can be ignored unless upgrade fails. -- begin log output -- Creating tables ... There are unapplied evolutions for auth. There are unapplied evolutions for accounts. There are unapplied evolutions for diffviewer. There are unapplied evolutions for reviews. Project signature has changed - an evolution is required Installing custom SQL ... Installing indexes ... Installed 0 object(s) from 0 fixture(s) --- for more than 10 minutes. How long is this supposed to take? Thanks, Mukund This e-mail, including any attached files, may contain confidential and privileged information for the sole use of the intended recipient. Any review, use, distribution, or disclosure by others is strictly prohibited. If you are not the intended recipient (or authorized to receive information for the intended recipient), please contact the sender by reply e-mail and delete all copies of this message. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard...@googlegroups.com javascript: For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- This e-mail, including any
Re: how long does a rb-site upgrade take?
We keep seeing this reported, but it never ends up making any sense. It's attempting to get the mercurial version from their module, which is just a string, but I gets None instead. We haven't figured out why or how that happens. However, we will be putting out a release tonight, and we'll change that to log the error and have a fallback. Christian On Jan 27, 2013, at 22:21, Mukund Rajamannar muk...@synerzip.com wrote: I use Postgres. The upgrade progressed from this step and then I had the issue with assets (CSS/JS) not showing up. Googling around helped me add an entry in my Apache conf file to add an alias for 'static'. Review board works afterwards, but I frequently get errors like this. --- 2013-01-28 00:10:34,709 - ERROR - Internal Server Error: /r/1215/ Traceback (most recent call last): File /usr/local/lib/python2.7/dist-packages/Django-1.4.3-py2.7.egg/django/core/handlers/base.py, line 111, in get_response response = callback(request, *callback_args, **callback_kwargs) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.2-py2.7.egg/reviewboard/accounts/decorators.py, line 20, in _check return login_required(view_func)(*args, **kwargs) File /usr/local/lib/python2.7/dist-packages/Djblets-0.7.8-py2.7.egg/djblets/auth/util.py, line 47, in _checklogin return view_func(request, *args, **kwargs) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.2-py2.7.egg/reviewboard/reviews/views.py, line 728, in review_detail 'screenshots': screenshots, File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.2-py2.7.egg/reviewboard/reviews/views.py, line 124, in _make_review_request_context upload_diff_form = UploadDiffForm(review_request) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.2-py2.7.egg/reviewboard/reviews/forms.py, line 276, in __init__ data, *args, **kwargs) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.2-py2.7.egg/reviewboard/diffviewer/forms.py, line 51, in __init__ if self.repository.get_scmtool().get_diffs_use_absolute_paths(): File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.2-py2.7.egg/reviewboard/scmtools/models.py, line 134, in get_scmtool return cls(self) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.2-py2.7.egg/reviewboard/scmtools/hg.py, line 31, in __init__ self.client = HgClient(repository.path, repository.local_site) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.2-py2.7.egg/reviewboard/scmtools/hg.py, line 215, in __init__ if parse_version(version) = parse_version(1.2): File /usr/lib/python2.7/dist-packages/pkg_resources.py, line 1920, in parse_version for part in _parse_version_parts(s.lower()): TypeError: 'NoneType' object is not callable - rb-site doesn't show any problems / running the upgrade again doesn't do anything. Restarting the apache instance seems to help, but how do I fix this? Thanks, Mukund On Friday, January 25, 2013 1:33:59 AM UTC+5:30, Christian Hammond wrote: It looks like it's at the database migration stage. I've never seen this take a long time before. What type of database are you using, and how big is it? Christian -- Christian Hammond - chi...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Jan 24, 2013 at 11:39 AM, Christian Hammond chi...@gmail.com wrote: It shouldn't take more than a few seconds. I'm not sure what it'd be blocking on... I'll check the list of steps when I'm back at the computer in 20 mins or so. Christian On Jan 24, 2013, at 0:58, Mukund Rajamannar muk...@synerzip.com wrote: Hi, I have an extensively used reviewboard site with a lot of reviews. Doing a rb-site upgrade from 1.6.11 to 1.7.2 seems to be stuck at Rebuilding directory structure Updating database. This may take a while. The log output below, including warnings and errors, can be ignored unless upgrade fails. -- begin log output -- Creating tables ... There are unapplied evolutions for auth. There are unapplied evolutions for accounts. There are unapplied evolutions for diffviewer. There are unapplied evolutions for reviews. Project signature has changed - an evolution is required Installing custom SQL ... Installing indexes ... Installed 0 object(s) from 0 fixture(s) --- for more than 10 minutes. How long is this supposed to take? Thanks, Mukund This e-mail, including any attached files, may contain confidential and privileged information for the sole use of the intended recipient. Any review, use, distribution, or disclosure by others is strictly prohibited. If you are not the intended recipient (or authorized to receive information for the intended recipient), please contact the sender by reply e-mail and delete all
Re: View Diff has issue in 1.7.2, and fine in 1.7.1
New to reviewboard, I am not quite familiar with the system and bug fix
process,
I have submitted a codereview: http://reviews.reviewboard.org/r/3804/
Regards,
Tao
On Sunday, January 27, 2013 4:29:26 AM UTC+8, Christian Hammond wrote:
Hi Tao,
Can you post the fix up on http://reviews.reviewboard.org? All patches
must go through a review process there.
Thanks!
Christian
--
Christian Hammond - chi...@chipx86.com javascript:
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Sat, Jan 26, 2013 at 5:41 AM, Tao Zhou moo...@gmail.com
javascript:wrote:
Hi, Christian:
Thanks for your update, I will have a test after the new release, and see
if the issue being resolved.
And if possible, could you plz also add the fix to avoid prompting many
cleartool console window when doing post-review and viewing diff?
(see
https://groups.google.com/forum/?fromgroups=#!topic/reviewboard/R1kiku5tIqQ
)
Thanks,
Tao
On Saturday, January 26, 2013 5:05:07 PM UTC+8, Christian Hammond wrote:
Hi Tao,
I'll look into this and see what I can do. We'll be putting out a new
release this week.
Christian
--
Christian Hammond - chi...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Fri, Jan 25, 2013 at 12:33 AM, Tao Zhou moo...@gmail.com wrote:
Hi,
I am using Review Board 1.7.2 on Windows 7 with repository on
Clearcase, and found the view diff page doesn't render correctly.
if I upload several changed files in one diff by post-review, say more
than 2 files, only 2 files' diff could display, and only can add comment
for the first one diff.
after some diagnose, I found the cause is in Line 15 of reviews.js,
'new RB.CommentIssueManager({' will cause Uncaught TypeError
var gCommentIssueManager = new RB.CommentIssueManager({
Seems like the refactor of reviews.js in 1.7.2 by moving related code
to commentIssueManagerModel.js caused this problem, while 1.7.1 works just
fine.
As not so familiar with javascript, I can only find out the cause,
don't know how to fix.
Hope this also could be fixed in next Review Board release.
Thanks!
Tao Zhou
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/**donate/http://www.reviewboard.org/donate/
Happy user? Let us know at
http://www.reviewboard.org/**users/http://www.reviewboard.org/users/
-~--~~~~--**~~--~--~---
To unsubscribe from this group, send email to reviewboard...@**
googlegroups.com
For more options, visit this group at http://groups.google.com/**
group/reviewboard?hl=enhttp://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard...@googlegroups.com javascript:
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
---
You received this message because you are subscribed to the Google Groups
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2878 in reviewboard: SVN diff patch fails if file has diff around svn keyword
Updates: Status: NeedInfo Comment #1 on issue 2878 by chip...@gmail.com: SVN diff patch fails if file has diff around svn keyword http://code.google.com/p/reviewboard/issues/detail?id=2878 Hi Sudhir, We have unit tests that should cover this exact case, and I tried your example and it works. We can only expand keywords if you have those keywords set to expand by listing them in svn:keywords. In your case, is that actually listed? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2878 in reviewboard: SVN diff patch fails if file has diff around svn keyword
Comment #2 on issue 2878 by sudhir.s...@gmail.com: SVN diff patch fails if file has diff around svn keyword http://code.google.com/p/reviewboard/issues/detail?id=2878 Hi Christian, I think below is what you are asking. Yes it is listed. $ svn propget svn:keywords hello_world.c id FYI, I don't see below code change in RB 1.7.1/1.7.2 . I think this change was in RB Beta release. http://reviews.reviewboard.org/r/2441/ Regards Sudhir -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2876 in reviewboard: Diff currently unavailable.
Updates: Status: Fixed Owner: chip...@gmail.com Labels: Milestone-Release1.7.x Component-DiffViewer Comment #3 on issue 2876 by chip...@gmail.com: Diff currently unavailable. http://code.google.com/p/reviewboard/issues/detail?id=2876 Fixed on release-1.7.x (d78e5ca348290bea50c318ce042af9d869a228d3) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
