Re: Issue 3890 in reviewboard: Didn't apply patch cleanly when using rbt post --parent in mercurial

2015-06-19 Thread reviewboard


Comment #1 on issue 3890 by ronald.c...@visiercorp.com: Didn't apply patch  
cleanly when using rbt post --parent in mercurial

https://code.google.com/p/reviewboard/issues/detail?id=3890

A one-liner to replace rbi post --parent A is:
rbt diff --parent A | perl -pe 's/^(diff -r \w+) -r \w+/\1/g' | rbt  
post --diff-filename=-


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3886 in reviewboard: Username bigger than 40 characters

2015-06-19 Thread reviewboard

Updates:
Status: New

Comment #3 on issue 3886 by trowb...@gmail.com: Username bigger than 40  
characters

https://code.google.com/p/reviewboard/issues/detail?id=3886

(No comment was entered for this change.)

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: MemoryError: Problem installing fixture

2015-06-19 Thread Christian Hammond
Hi John,

Django's dumpdata/loaddata cannot scale. Do you still have a copy of the
old database? We have replacements for loaddata/dumpdata that do scale.

Are you trying to convert from one database type to another?

Christian


On Friday, June 19, 2015, John Schmitt marmalo...@gmail.com wrote:

 How do I work around this?

 # rb-site manage /var/www/reviews.tintri.com loaddata
  /tmp/reviews-charles2_rb20_data.json

 Traceback (most recent call last):
   File /usr/bin/rb-site, line 9, in module
 load_entry_point('ReviewBoard==2.0.15', 'console_scripts', 'rb-site'
 )()
   File /usr/lib/python2.7/site-packages/reviewboard/cmdline/rbsite.py,
 line 1885, in main
 command.run()
   File /usr/lib/python2.7/site-packages/reviewboard/cmdline/rbsite.py,
 line 1814, in run
 site.run_manage_command(args[0], args[1:])
   File /usr/lib/python2.7/site-packages/reviewboard/cmdline/rbsite.py,
 line 662, in run_manage_command
 execute_from_command_line([__file__, cmd] + params)
   File
 /usr/lib/python2.7/site-packages/django/core/management/__init__.py,
 line 399, in execute_from_command_line
 utility.execute()
   File
 /usr/lib/python2.7/site-packages/django/core/management/__init__.py,
 line 392, in execute
 self.fetch_command(subcommand).run_from_argv(self.argv)
   File /usr/lib/python2.7/site-packages/django/core/management/base.py,
 line 242, in run_from_argv
 self.execute(*args, **options.__dict__)
   File /usr/lib/python2.7/site-packages/django/core/management/base.py,
 line 285, in execute
 output = self.handle(*args, **options)
   File
 /usr/lib/python2.7/site-packages/django/core/management/commands/loaddata.py
 , line 55, in handle
 self.loaddata(fixture_labels)
   File
 /usr/lib/python2.7/site-packages/django/core/management/commands/loaddata.py
 , line 84, in loaddata
 self.load_label(fixture_label)
   File
 /usr/lib/python2.7/site-packages/django/core/management/commands/loaddata.py
 , line 134, in load_label
 for obj in objects:
   File /usr/lib/python2.7/site-packages/django/core/serializers/json.py,
 line 65, in Deserializer
 stream_or_string = stream_or_string.read()
 MemoryError: Problem installing fixture
 '/tmp/reviews-charles2_rb20_data.json':





  --
 Supercharge your Review Board with Power Pack:
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons:
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com
 javascript:_e(%7B%7D,'cvml','reviewboard%2bunsubscr...@googlegroups.com');
 .
 For more options, visit https://groups.google.com/d/optout.



-- 
-- 
Christian Hammond - christ...@beanbaginc.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Issue 3893 in reviewboard: Name, Username, and Password fields for repositories need new form field names

2015-06-19 Thread reviewboard

Status: Confirmed
Owner: 
Labels: Type-Defect Priority-Medium Milestone-Release2.0.x Component-Admin

New issue 3893 by chip...@gmail.com: Name, Username, and Password fields  
for repositories need new form field names

https://code.google.com/p/reviewboard/issues/detail?id=3893

What version are you running?
2.0.x

What's the URL of the page containing the problem?
http://localhost:8080/admin/db/scmtools/repository/add/

What steps will reproduce the problem?
1. In Safari 7.x (or probably other browsers), fill out some form somewhere  
else that saves a name. Also, fill out the login form on Review Board,  
saving the username and password.

2. Go to add or edit a repository.

What is the expected output? What do you see instead?
On some browsers (older versions of Safari, certainly), the Name, Username,  
and Password fields are filled in by the browser, which is not desired.


We have flags set to prevent this, but they can be ignored. We should  
rename the form field names (name=...) to prevent these from being filled  
in.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: email issue on RB group vs people

2015-06-19 Thread David Trowbridge
a) you're sure it's empty? no whitespace in there?
b) you're sure everyone is a member of that group?

-David

On Thu, Jun 18, 2015 at 7:18 PM, MoonWalker daniel.cabrera...@gmail.com
wrote:

 it is empty

 On Friday, June 19, 2015 at 12:12:44 PM UTC+10, David Trowbridge wrote:

 Please check the group configuration and check that the mailing list
 field is empty.

 -David
 On Thu, Jun 18, 2015 at 6:02 PM MoonWalker daniel.c...@gmail.com wrote:

 David,

 I setup the mail server (Settings - Email - EMail Server - Mail
 Server). I was under the impression that once that I establish the members
 of a group, RB will send an email to all the group members, but that is not
 the case. I have to add them to the People to have the expected result.

 Do I need to configure anything else on RB ?

 On Friday, June 19, 2015 at 10:14:18 AM UTC+10, David Trowbridge wrote:

 Does the group have a mailing list configured? If so, e-mail to that
 group will be sent only to the list and not to the group members.

 -David

 On Thu, Jun 18, 2015 at 5:11 PM, MoonWalker daniel.c...@gmail.com
 wrote:

 I have noticed this issue since several versions, not sure if this is a
 know issue or something else in my configuration, but basically in
 Reviewers  I need to add each team member to People, because if I add 
 the
 group they wont receive any email. not sure why.

 All these people are part of the same group, but still not email.

 BTW I am using the latest RB version

  --
 Supercharge your Review Board with Power Pack:
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons:
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google
 Groups reviewboard group.

 To unsubscribe from this group and stop receiving emails from it, send
 an email to reviewboard...@googlegroups.com.


 For more options, visit https://groups.google.com/d/optout.

  --
 Supercharge your Review Board with Power Pack:
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons:
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google
 Groups reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send
 an email to reviewboard...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.

  --
 Supercharge your Review Board with Power Pack:
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons:
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.


-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: MemoryError: Problem installing fixture

2015-06-19 Thread Christian Hammond
If you're just moving between databases, you'll want to use mysqldump, and then 
use the mysql command line to import it. This is the safest, fastest, most 
straight-forward way to migrate between MySQL servers.

Christian 

--  
Christian Hammond - christ...@beanbaginc.com  
Review Board - https://www.reviewboard.org  
Beanbag, Inc. - https://www.beanbaginc.com

-Original Message-
From: John Schmitt marmalo...@gmail.com
Reply: reviewboard@googlegroups.com reviewboard@googlegroups.com
Date: June 19, 2015 at 3:08:25 PM
To: reviewboard@googlegroups.com reviewboard@googlegroups.com
Cc: christ...@beanbaginc.com christ...@beanbaginc.com
Subject:  Re: MemoryError: Problem installing fixture

 On Friday, June 19, 2015 at 2:56:15 PM UTC-7, Christian Hammond wrote:

 Hi John,

 Django's dumpdata/loaddata cannot scale. Do you still have a copy of the
 old database? We have replacements for loaddata/dumpdata that do scale.

 Are you trying to convert from one database type to another?

 Christian


 On Friday, June 19, 2015, John Schmitt marma...@gmail.com javascript:
 wrote:

 How do I work around this?

 # rb-site manage /var/www/reviews.tintri.com loaddata
 /tmp/reviews-charles2_rb20_data.json

 Traceback (most recent call last):
 File /usr/bin/rb-site, line 9, in module
 load_entry_point('ReviewBoard==2.0.15', 'console_scripts', 'rb-site'
 )()
 File /usr/lib/python2.7/site-packages/reviewboard/cmdline/rbsite.py,
 line 1885, in main
 command.run()
 File /usr/lib/python2.7/site-packages/reviewboard/cmdline/rbsite.py,
 line 1814, in run
 site.run_manage_command(args[0], args[1:])
 File /usr/lib/python2.7/site-packages/reviewboard/cmdline/rbsite.py,
 line 662, in run_manage_command
 execute_from_command_line([__file__, cmd] + params)
 File
 /usr/lib/python2.7/site-packages/django/core/management/__init__.py,
 line 399, in execute_from_command_line
 utility.execute()
 File
 /usr/lib/python2.7/site-packages/django/core/management/__init__.py,
 line 392, in execute
 self.fetch_command(subcommand).run_from_argv(self.argv)
 File /usr/lib/python2.7/site-packages/django/core/management/base.py,
 line 242, in run_from_argv
 self.execute(*args, **options.__dict__)
 File /usr/lib/python2.7/site-packages/django/core/management/base.py,
 line 285, in execute
 output = self.handle(*args, **options)
 File
 /usr/lib/python2.7/site-packages/django/core/management/commands/loaddata.py
 , line 55, in handle
 self.loaddata(fixture_labels)
 File
 /usr/lib/python2.7/site-packages/django/core/management/commands/loaddata.py
 , line 84, in loaddata
 self.load_label(fixture_label)
 File
 /usr/lib/python2.7/site-packages/django/core/management/commands/loaddata.py
 , line 134, in load_label
 for obj in objects:
 File /usr/lib/python2.7/site-packages/django/core/serializers/json.py
 , line 65, in Deserializer
 stream_or_string = stream_or_string.read()
 MemoryError: Problem installing fixture
 '/tmp/reviews-charles2_rb20_data.json':


 I'm not converting databases. I do have a copy of the old database on the
 old installation.
  
 What are the replacements? I'm moving from an old mysql-based installation
 to a new one.
  
  
  
  
 --
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups 
 reviewboard
 group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.
  

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Review Board 2.0.16 is released, with security fixes and more

2015-06-19 Thread Christian Hammond
Hi Paul,

Thanks for reporting this. I went through our caching code, and I'm not really 
sure why this is happening off-hand. Were you able to fix this by clearing your 
browser cache, or did you have to restart memcached?

Christian

--  
Christian Hammond - christ...@beanbaginc.com  
Review Board - https://www.reviewboard.org  
Beanbag, Inc. - https://www.beanbaginc.com

-Original Message-
From: Paul Fee paul.f@gmail.com
Reply: reviewboard@googlegroups.com reviewboard@googlegroups.com
Date: June 18, 2015 at 9:45:59 AM
To: reviewboard@googlegroups.com reviewboard@googlegroups.com
Subject:  Re: Review Board 2.0.16 is released, with security fixes and more

 Hi Christian,
  
 I'm seeing some buggy behaviour around the caching of diffs. It looks like
 a server side problem as the buggy diff content persists even if I reload
 with CTRL-F5 or switch browsers (e.g. firefox to chromium).
  
 Steps to reproduce:
  
 1. Change some code, I happen to be using SVN.
 2. Upload diff to existing review.
 $ rbt post -r XXX svn_changelist
 3. View the draft interdiff, all it ok at this point.
 4. Change the code some more without publishing draft changes.
 5. Upload diff again, should change content of draft diff.
 $ rbt post -r XXX svn_changelist
 6. View the draft interdiff - BUG - diff content on web page is from first
 upload, changes from second rbt post are not displayed.
  
 From the 2.0.16 release notes, If a diff has already been viewed once, by
 anyone, it will be quicker to retrieve and display.. I suspect the draft
 is being cached. A blunt fix could be to avoid caching diffs for drafts.
 A better fix would be to invalidate caches for draft diffs when a new
 diffset is uploaded.
  
 Hopefully those steps are clear enough for you to reproduce the issue. Let
 me know if you need more information.
  
 Thanks,
 Paul
  
 --
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups 
 reviewboard
 group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.
  

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: rb-site upgrade help needed

2015-06-19 Thread Christian Hammond
Hi John,

Try upgrading to Django Evolution 0.7.5, restore the backup, and try the 
migration again. I believe you hit a bug we had already fixed.

Christian

--  
Christian Hammond - christ...@beanbaginc.com  
Review Board - https://www.reviewboard.org  
Beanbag, Inc. - https://www.beanbaginc.com

-Original Message-
From: John Schmitt marmalo...@gmail.com
Reply: reviewboard@googlegroups.com reviewboard@googlegroups.com
Date: June 17, 2015 at 10:10:46 PM
To: Christian Hammond christ...@beanbaginc.com
Cc: reviewboard@googlegroups.com reviewboard@googlegroups.com
Subject:  Re: rb-site upgrade help needed

 I do have a backup.
  
 python-django-evolution-0.7.4-1.el7.noarch
 evolution-data-server-3.8.5-34.el7.x86_64
  
  
 On Wed, Jun 17, 2015 at 8:10 PM, Christian Hammond christ...@beanbaginc.com
 wrote:
  
 What version of django_evolution do you have?

 Do you have a database backup?

 Christian

 --
 Christian Hammond - christ...@beanbaginc.com
 Review Board - https://www.reviewboard.org
 Beanbag, Inc. - https://www.beanbaginc.com

 -Original Message-
 From: John Schmitt marmalo...@gmail.com
 Reply: reviewboard@googlegroups.com reviewboard@googlegroups.com
 Date: June 17, 2015 at 6:35:54 PM
 To: reviewboard@googlegroups.com reviewboard@googlegroups.com
 Subject: rb-site upgrade help needed

  I need help getting my data from ReviewBoard 1.5 to 2.0 to migrate. Can
  anyone tell me what to do to make this work?
 
  Thank you.
 
  [root@dyn40-25-217 ~]# mysql -p  reviewboard.dump
  Enter password:
  [root@dyn40-25-217 ~]# rb-site upgrade /var/www/reviews.tintri.com
  Rebuilding directory structure
  Updating database. This may take a while.
 
 
  The log output below, including warnings and errors,
  can be ignored unless upgrade fails.
 
 
  -- begin log output --
  Creating tables ...
  Upgrading Review Board from 1.5.5 to 2.0.15
  There are unapplied evolutions for auth.
  There are unapplied evolutions for contenttypes.
  There are unapplied evolutions for accounts.
  There are unapplied evolutions for attachments.
  There are unapplied evolutions for changedescs.
  There are unapplied evolutions for diffviewer.
  There are unapplied evolutions for hostingsvcs.
  There are unapplied evolutions for reviews.
  There are unapplied evolutions for scmtools.
  There are unapplied evolutions for site.
  Adding baseline version for new models
  Evolutions in attachments baseline: file_attachment_orig_filename,
  file_attachment_file_max_length_512, file_attachment_repo_info,
  file_attachment_repo_path_no_index,
  file_attachment_repo_revision_max_length_64
  Evolutions in site baseline: localsite_public
  Evolutions in hostingsvcs baseline: account_hosting_url,
  account_hosting_url_max_length_255, account_unique_together_baseline
  Project signature has changed - an evolution is required
  Installing custom SQL ...
  Installing indexes ...
  Installed 0 object(s) from 0 fixture(s)
  Registering new SCM Tool Plastic SCM (reviewboard.scmtools.plastic.
  PlasticTool) in database
  CommandError: Error applying evolution: (1050, Table
  'reviews_review_file_attachment_comments' already exists)
 
 
  If I restart httpd at this point, I'll see this in /var/log/messages:
 
  Jun 17 18:26:49 localhost rb-site: -- begin log output
  --
  Jun 17 18:26:49 localhost rb-site: Creating tables ...
  Jun 17 18:26:50 localhost rb-site: There are unapplied evolutions for
 auth.
  Jun 17 18:26:50 localhost rb-site: There are unapplied evolutions for
  contenttypes.
  Jun 17 18:26:50 localhost rb-site: There are unapplied evolutions for
  accounts.
  Jun 17 18:26:50 localhost rb-site: There are unapplied evolutions for
  changedescs.
  Jun 17 18:26:50 localhost rb-site: There are unapplied evolutions for
  diffviewer.
  Jun 17 18:26:50 localhost rb-site: There are unapplied evolutions for
  reviews.
  Jun 17 18:26:50 localhost rb-site: There are unapplied evolutions for
  scmtools.
  Jun 17 18:26:50 localhost rb-site: Project signature has changed - an
  evolution is required
  Jun 17 18:26:50 localhost rb-site: Installing custom SQL ...
  Jun 17 18:26:50 localhost rb-site: Installing indexes ...
  Jun 17 18:26:50 localhost rb-site: Installed 0 object(s) from 0
 fixture(s)
  Jun 17 18:26:50 localhost rb-site: Traceback (most recent call last):
  Jun 17 18:26:50 localhost rb-site: File /usr/bin/rb-site, line 9, in
  module
  Jun 17 18:26:50 localhost rb-site:
 load_entry_point('ReviewBoard==2.0.15',
  'console_scripts', 'rb-site')()
  Jun 17 18:26:50 localhost rb-site: File
  /usr/lib/python2.7/site-packages/reviewboard/cmdline/rbsite.py, line
 1885,
  in main
  Jun 17 18:26:50 localhost rb-site: command.run()
  Jun 17 18:26:50 localhost rb-site: File
  /usr/lib/python2.7/site-packages/reviewboard/cmdline/rbsite.py, line
 1694,
  in run
  Jun 17 18:26:50 localhost rb-site: site.migrate_database()
  Jun 17 18:26:50 localhost rb-site: File
  

Re: Issue 3887 in reviewboard: Perforce diff submission is broken in 2.0.17

2015-06-19 Thread reviewboard

Updates:
Status: Fixed

Comment #6 on issue 3887 by bar...@beanbaginc.com: Perforce diff submission  
is broken in 2.0.17

https://code.google.com/p/reviewboard/issues/detail?id=3887

A fix for this has landed on release-2.0.x as  
6cc72eb8c3ee7a219b5d7656aa791b2feb976223. This will ship in Review Board  
2.0.18.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: ImportError: No module named urllib.parse

2015-06-19 Thread Christian Hammond
Hey Stephen,

I haven't been able to look into this yet (and will be out for a few days), but 
is this something that we can patch in our tree? Or is it a bug in six?

If it's something we can fix in RBTools, then we can just fix it and get a new 
release out.

Christian 

--  
Christian Hammond - christ...@beanbaginc.com  
Review Board - https://www.reviewboard.org  
Beanbag, Inc. - https://www.beanbaginc.com

-Original Message-
From: Stephen Gallagher step...@gallagherhome.com
Reply: reviewboard@googlegroups.com reviewboard@googlegroups.com
Date: June 19, 2015 at 7:21:19 AM
To: reviewboard@googlegroups.com reviewboard@googlegroups.com
Subject:  Re: ImportError: No module named urllib.parse

 On Thu, Jun 18, 2015 at 5:04 PM John Schmitt marmalo...@gmail.com wrote:
  


 On Thursday, June 18, 2015 at 1:33:55 PM UTC-7, Barret Rennie wrote:

 Hi John,

 Yes thats what I mean. I’ll take a look at it.

 Can you tell me what version of six is installed?

 python-six-1.3.0-4.el7.noarch



  
 OK, so we have a problem here (and one I'm really embarassed not to have
 noticed; I usually just bump and rebuild RBTools on EPEL 7 assuming it will
 continue to work there the same way that it does on EPEL 6.
  
 Well, it turns out that EPEL 6 has a newer version of python-six than RHEL
 7 does, and RBTools is completely broken on the latter platform because of
 it. (RHEL/CentOS 7.1 only ships with python-six 1.3.0 and the
 six.move.urllib.parse support was added in python-six 1.4.0)
  
 The good news is that RHEL/CentOS 7.2 should include python-six 1.9.0[1].
 The bad news is that's a ways out, so this will be broken in the meantime.
  
 I have two choices:
 1) Revert RBTools back to a version prior to this requirement. That looks
 like 0.6.3, which is almost certainly not a good idea.
 2) Ship RBTools broken in the standard repository and direct people to pull
 an unofficial python-six package from a COPR repository.
  
 I'm going to go with 2) for now, updating the version of RBTools in EPEL to
 have an explicit requirement on python-six = 1.4 so that it won't be
 installable without using my COPR repository until RHEL 7.2 is released.
  
 Given that RBTools has been broken like this for months, I suspect this
 won't actually affect a great many people, but I'd still like to ask that
 the Review Board devs add a note in the online documentation pointing
 people to drop
 https://copr.fedoraproject.org/coprs/sgallagh/EPEL7-rbtools/repo/epel-7/sgallagh-EPEL7-rbtools-epel-7.repo
 into /etc/yum.repos.d until RHEL 7.2 is released. This repository will
 contain only a rebased python-six package.
  
 It'll be available in a couple hours (right now, there's an unplanned
 outage going on causing COPR builds to fail).
  
  
 [1] https://bugzilla.redhat.com/show_bug.cgi?id=1185409
  
 --
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups 
 reviewboard
 group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.
  

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Disable the ship it button?

2015-06-19 Thread Christian Hammond
Hi Terrence,

There's no support for this yet. Short-term, one option would be to add a tiny 
extension that injects some CSS to hide that element. Longer-term, I want to 
make that list of actions something that are formally registered and tracked, 
so that an extension can simply say Remove Ship It and be done. Probably a 
post-2.5.0 thing at this point.

Christian

--  
Christian Hammond - christ...@beanbaginc.com  
Review Board - https://www.reviewboard.org  
Beanbag, Inc. - https://www.beanbaginc.com

-Original Message-
From: Dunnigan, Terrence J terrence.j.dunni...@boeing.com
Reply: reviewboard@googlegroups.com reviewboard@googlegroups.com
Date: June 19, 2015 at 7:52:28 AM
To: reviewboard@googlegroups.com reviewboard@googlegroups.com
Subject:  Disable the ship it button?

 Hi all,
  
 Is there a way in any current or future Review Board release to disable the 
 Ship it menu
 item? By disable I mean hide it, don't display it, or keep it in the menu bar 
 and just grey
 it out.
  
 Terry
  
  
 --
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups 
 reviewboard
 group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.
  

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3887 in reviewboard: Perforce diff submission is broken in 2.0.17

2015-06-19 Thread reviewboard


Comment #7 on issue 3887 by bar...@beanbaginc.com: Perforce diff submission  
is broken in 2.0.17

https://code.google.com/p/reviewboard/issues/detail?id=3887

It is actually fixed in cb9a791e722c161d7e06f1add407e180aa025586. I copied  
the wrong revision.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: ImportError: No module named urllib.parse

2015-06-19 Thread David Trowbridge
This isn't something we can work around in RBTools (at least not without
regressing in our python 3.x compatibility). The problem is that older
versions of six didn't ship moves for all of the urllib/urllib2 changes.

-David

On Fri, Jun 19, 2015 at 6:31 PM, Christian Hammond christ...@beanbaginc.com
 wrote:

 Hey Stephen,

 I haven't been able to look into this yet (and will be out for a few
 days), but is this something that we can patch in our tree? Or is it a bug
 in six?

 If it's something we can fix in RBTools, then we can just fix it and get a
 new release out.

 Christian

 --
 Christian Hammond - christ...@beanbaginc.com
 Review Board - https://www.reviewboard.org
 Beanbag, Inc. - https://www.beanbaginc.com

 -Original Message-
 From: Stephen Gallagher step...@gallagherhome.com
 Reply: reviewboard@googlegroups.com reviewboard@googlegroups.com
 Date: June 19, 2015 at 7:21:19 AM
 To: reviewboard@googlegroups.com reviewboard@googlegroups.com
 Subject:  Re: ImportError: No module named urllib.parse

  On Thu, Jun 18, 2015 at 5:04 PM John Schmitt marmalo...@gmail.com
 wrote:
 
 
 
  On Thursday, June 18, 2015 at 1:33:55 PM UTC-7, Barret Rennie wrote:
 
  Hi John,
 
  Yes thats what I mean. I’ll take a look at it.
 
  Can you tell me what version of six is installed?
 
  python-six-1.3.0-4.el7.noarch
 
 
 
 
  OK, so we have a problem here (and one I'm really embarassed not to have
  noticed; I usually just bump and rebuild RBTools on EPEL 7 assuming it
 will
  continue to work there the same way that it does on EPEL 6.
 
  Well, it turns out that EPEL 6 has a newer version of python-six than
 RHEL
  7 does, and RBTools is completely broken on the latter platform because
 of
  it. (RHEL/CentOS 7.1 only ships with python-six 1.3.0 and the
  six.move.urllib.parse support was added in python-six 1.4.0)
 
  The good news is that RHEL/CentOS 7.2 should include python-six 1.9.0[1].
  The bad news is that's a ways out, so this will be broken in the
 meantime.
 
  I have two choices:
  1) Revert RBTools back to a version prior to this requirement. That looks
  like 0.6.3, which is almost certainly not a good idea.
  2) Ship RBTools broken in the standard repository and direct people to
 pull
  an unofficial python-six package from a COPR repository.
 
  I'm going to go with 2) for now, updating the version of RBTools in EPEL
 to
  have an explicit requirement on python-six = 1.4 so that it won't be
  installable without using my COPR repository until RHEL 7.2 is released.
 
  Given that RBTools has been broken like this for months, I suspect this
  won't actually affect a great many people, but I'd still like to ask that
  the Review Board devs add a note in the online documentation pointing
  people to drop
 
 https://copr.fedoraproject.org/coprs/sgallagh/EPEL7-rbtools/repo/epel-7/sgallagh-EPEL7-rbtools-epel-7.repo
  into /etc/yum.repos.d until RHEL 7.2 is released. This repository will
  contain only a rebased python-six package.
 
  It'll be available in a couple hours (right now, there's an unplanned
  outage going on causing COPR builds to fail).
 
 
  [1] https://bugzilla.redhat.com/show_bug.cgi?id=1185409
 
  --
  Supercharge your Review Board with Power Pack:
 https://www.reviewboard.org/powerpack/
  Want us to host Review Board for you? Check out RBCommons:
 https://rbcommons.com/
  Happy user? Let us know! https://www.reviewboard.org/users/
  ---
  You received this message because you are subscribed to the Google
 Groups reviewboard
  group.
  To unsubscribe from this group and stop receiving emails from it, send
 an email to reviewboard+unsubscr...@googlegroups.com.
  For more options, visit https://groups.google.com/d/optout.
 

 --
 Supercharge your Review Board with Power Pack:
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons:
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.


-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Issue 3892 in reviewboard: Documentation for setting up Trac is wrong

2015-06-19 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Component-Docs

New issue 3892 by gzau...@gmail.com: Documentation for setting up Trac is  
wrong

https://code.google.com/p/reviewboard/issues/detail?id=3892

What's the URL of the page containing the problem?
https://www.reviewboard.org/docs/manual/2.0/admin/configuration/repositories/

Describe the problem and any recommendations below.
Given example for setting up Trac is wrong.
It should say:
 - Trac: http://trac.example.com/

Please provide any additional information below.
I had issue with setting up Trac in ReviewBoard. When I googled I found  
this link that helped me;

https://code.google.com/p/reviewboard/issues/detail?id=3033#c13

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: ImportError: No module named settings_local

2015-06-19 Thread Stephen Gallagher
On Thu, Jun 18, 2015 at 2:53 PM John Schmitt marmalo...@gmail.com wrote:

 I can run

 # rb-site manage --help

 just fine.  But, taking the help literally, I get this when I try:

 # rb-site manage -- --help



 ...
   'manage' command:
 Runs a Django management command on the site. Usage: `rb-site manage
 path command -- arguments.` Run `manage -- --help` for the list
 of commands.




This help dialog is incorrect. It needs to read:
Run `rb-site manage  path -- --help` for the list

I just verified (with the exact same version on RHEL 7 installed via EPEL
7) that this works correctly. Please file a bug on the incorrect help text
there.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: ImportError: No module named urllib.parse

2015-06-19 Thread Stephen Gallagher
On Thu, Jun 18, 2015 at 5:04 PM John Schmitt marmalo...@gmail.com wrote:



 On Thursday, June 18, 2015 at 1:33:55 PM UTC-7, Barret Rennie wrote:

 Hi John,

 Yes thats what I mean. I’ll take a look at it.

 Can you tell me what version of six is installed?

 python-six-1.3.0-4.el7.noarch




OK, so we have a problem here (and one I'm really embarassed not to have
noticed; I usually just bump and rebuild RBTools on EPEL 7 assuming it will
continue to work there the same way that it does on EPEL 6.

Well, it turns out that EPEL 6 has a newer version of python-six than RHEL
7 does, and RBTools is completely broken on the latter platform because of
it. (RHEL/CentOS 7.1 only ships with python-six 1.3.0 and the
six.move.urllib.parse support was added in python-six 1.4.0)

The good news is that RHEL/CentOS 7.2 should include python-six 1.9.0[1].
The bad news is that's a ways out, so this will be broken in the meantime.

I have two choices:
1) Revert RBTools back to a version prior to this requirement. That looks
like 0.6.3, which is almost certainly not a good idea.
2) Ship RBTools broken in the standard repository and direct people to pull
an unofficial python-six package from a COPR repository.

I'm going to go with 2) for now, updating the version of RBTools in EPEL to
have an explicit requirement on python-six = 1.4 so that it won't be
installable without using my COPR repository until RHEL 7.2 is released.

Given that RBTools has been broken like this for months, I suspect this
won't actually affect a great many people, but I'd still like to ask that
the Review Board devs add a note in the online documentation pointing
people to drop
https://copr.fedoraproject.org/coprs/sgallagh/EPEL7-rbtools/repo/epel-7/sgallagh-EPEL7-rbtools-epel-7.repo
into /etc/yum.repos.d until RHEL 7.2 is released. This repository will
contain only a rebased python-six package.

It'll be available in a couple hours (right now, there's an unplanned
outage going on causing COPR builds to fail).


[1] https://bugzilla.redhat.com/show_bug.cgi?id=1185409

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Reviewing without a Source control Repo: Uploading changes?

2015-06-19 Thread Luciano Moretti
Thank you Christian: 
That matches what we seemed to have figured, but is disappointing.

We're using Clearcase (moving to Perforce soon... hopefully), but are 
unable to install the Clearcase client on the Reviewboard evaluation 
machine as our IT does not support Clearcase under Linux.

Luciano

On Thursday, June 18, 2015 at 2:03:25 PM UTC-5, Christian Hammond wrote:

 Hi Luciano,

 Review Board requires a connected, supported repository in order to view 
 diffs. If you don't have a supported repository, a pre-generated diff won't 
 help.

 What are you currently using for source control?

 Christian


 On Thursday, June 18, 2015, Luciano Moretti luciano...@gmail.com 
 javascript: wrote:

 We're trying to evaluate Reviewboard but cannot integrate it with our 
 current Source Control system. We are switching source control soon to one 
 that can be integrated.

 Currently, we've got a review started and the initiator has made changes 
 to the files, but we can't figure out how to upload a pre-generated diff to 
 the review (or the new version of the file for Reviewboard itself to do the 
 diff).

 -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.



 -- 
 -- 
 Christian Hammond - chri...@beanbaginc.com javascript:
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com



-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Disable the ship it button?

2015-06-19 Thread Dunnigan, Terrence J
Hi all,

Is there a way in any current or future Review Board release to disable the 
Ship it menu item? By disable I mean hide it, don't display it, or keep it in 
the menu bar and just grey it out.

Terry


-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3886 in reviewboard: Username bigger than 40 characters

2015-06-19 Thread reviewboard


Comment #2 on issue 3886 by di...@microdice.net: Username bigger than 40  
characters

https://code.google.com/p/reviewboard/issues/detail?id=3886

The LDAP module uses this as the login, I guess the LDAP module is the one  
that needs to be modified then. How do I open against this ?


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


MemoryError: Problem installing fixture

2015-06-19 Thread John Schmitt
How do I work around this?

# rb-site manage /var/www/reviews.tintri.com loaddata 
 /tmp/reviews-charles2_rb20_data.json   
   
Traceback (most recent call last):
  File /usr/bin/rb-site, line 9, in module
load_entry_point('ReviewBoard==2.0.15', 'console_scripts', 'rb-site')()
  File /usr/lib/python2.7/site-packages/reviewboard/cmdline/rbsite.py, 
line 1885, in main
command.run()
  File /usr/lib/python2.7/site-packages/reviewboard/cmdline/rbsite.py, 
line 1814, in run
site.run_manage_command(args[0], args[1:])
  File /usr/lib/python2.7/site-packages/reviewboard/cmdline/rbsite.py, 
line 662, in run_manage_command
execute_from_command_line([__file__, cmd] + params)
  File /usr/lib/python2.7/site-packages/django/core/management/__init__.py
, line 399, in execute_from_command_line
utility.execute()
  File /usr/lib/python2.7/site-packages/django/core/management/__init__.py
, line 392, in execute
self.fetch_command(subcommand).run_from_argv(self.argv)
  File /usr/lib/python2.7/site-packages/django/core/management/base.py, 
line 242, in run_from_argv
self.execute(*args, **options.__dict__)
  File /usr/lib/python2.7/site-packages/django/core/management/base.py, 
line 285, in execute
output = self.handle(*args, **options)
  File 
/usr/lib/python2.7/site-packages/django/core/management/commands/loaddata.py
, line 55, in handle
self.loaddata(fixture_labels)
  File 
/usr/lib/python2.7/site-packages/django/core/management/commands/loaddata.py
, line 84, in loaddata
self.load_label(fixture_label)
  File 
/usr/lib/python2.7/site-packages/django/core/management/commands/loaddata.py
, line 134, in load_label
for obj in objects:
  File /usr/lib/python2.7/site-packages/django/core/serializers/json.py, 
line 65, in Deserializer
stream_or_string = stream_or_string.read()
MemoryError: Problem installing fixture 
'/tmp/reviews-charles2_rb20_data.json': 





-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.