Re: Posting a review against multiple repositories.

[David Trowbridge]

Joseph,

There's no way for a single review request to span repositories. What you
can do (and what we recommend) is to use the "depends on" field to indicate
the interdependencies between the changes in each repository.

Making custom rbt commands is pretty easy. You can either do it in Python,
or you could write a script named "rbt-X" that invokes "rbt post" in each
repository, which can then be accessed through the top-level as "rbt X"
(replace X with your own name).

-David

On Mon, Apr 4, 2016 at 9:37 AM Joseph Henry  wrote:

> Hello,
>
> Me and my team have been successfully using ReviewBoard for about half a
> year now, and I am looking at rolling it out to the whole of R
>
> The only problem that we have so far, is that many times, our code changes
> are across multiple repos. I have been able to work around this with CVS by
> creating a dummy CVS directory in the root, and adding all the repos to the
> ENTRIES, but now we are migrating to GIT and this will no longer work.
>
> Basically my question is: Is there any way to post a review that uses More
> than 1 repository?  Example would be 1 GIT repo and 1 CVS repo, or 2 GIT
> repos, ...
>
> If this is not currently possible, how difficult do you think it would be
> to make a custom RBT command to be able to do this?
>
> Thanks,
> Joseph.
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: diff viewer does not work after GitLab update, reviewboard version 1.7.27

[Christian Hammond]

Also, what version of Review Board are you using?

Christian

-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

On Wed, Apr 6, 2016 at 11:52 AM, Christian Hammond  wrote:

> Hi Ralf,
>
> Sounds like they made a backwards-incompatible change to their API. We'll
> need to investigate and likely work on a patch for the next release.
>
> Would you be able to file a bug on
> https://hellosplat.com/s/beanbag/tickets/new/?project=reviewboard and,
> after filing, privately attach the contents of the temp directory? You can
> do so by uploading each file and clicking the lock icon on the update box
> on Splat.
>
> Christian
>
> --
> Christian Hammond
> President/CEO of Beanbag 
> Makers of Review Board 
>
> On Tue, Apr 5, 2016 at 5:13 AM, Ralf Mueller 
> wrote:
>
>> Hi,
>>
>> we recently update our GitLab to 8.6.1 and now the 'View Diff' does not
>> work anymore. It produces an error message like:
>> Error: The patch to 'README' didn't apply cleanly. The temporary files
>> have been left in '/tmp/reviewboard.2YSn1I' for debugging purposes. `patch`
>> returned: patching file /tmp/reviewboard.2YSn1I/tmp2kVGGw-new (read from
>> /tmp/reviewboard.2YSn1I/tmp2kVGGw) Hunk #1 FAILED at 3. 1 out of 1 hunk
>> FAILED -- saving rejects to file /tmp/reviewboard.2YSn1I/tmp2kVGGw-new.rej
>>
>>
>> The result is similar to all review request in the system, which have
>> worked before the update.
>>
>> There are no visible error on the ReviewBoard log neither on GitLab. I
>> have check the content of the temporary files from the RB error message and
>> it look that the 'old' and the 'new' file contain the same blob. It's also
>> visible from the GitLab side that there are to requests and the answer is
>> the same.
>>
>> Any idea what happened here? Is it correct that the blob are identical?
>>
>> If you need any further information, please let me know.
>>
>> BR
>> Ralf
>>
>> --
>> Supercharge your Review Board with Power Pack:
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons:
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to reviewboard+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: diff viewer does not work after GitLab update, reviewboard version 1.7.27

[Christian Hammond]

Hi Ralf,

Sounds like they made a backwards-incompatible change to their API. We'll
need to investigate and likely work on a patch for the next release.

Would you be able to file a bug on
https://hellosplat.com/s/beanbag/tickets/new/?project=reviewboard and,
after filing, privately attach the contents of the temp directory? You can
do so by uploading each file and clicking the lock icon on the update box
on Splat.

Christian

-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

On Tue, Apr 5, 2016 at 5:13 AM, Ralf Mueller  wrote:

> Hi,
>
> we recently update our GitLab to 8.6.1 and now the 'View Diff' does not
> work anymore. It produces an error message like:
> Error: The patch to 'README' didn't apply cleanly. The temporary files
> have been left in '/tmp/reviewboard.2YSn1I' for debugging purposes. `patch`
> returned: patching file /tmp/reviewboard.2YSn1I/tmp2kVGGw-new (read from
> /tmp/reviewboard.2YSn1I/tmp2kVGGw) Hunk #1 FAILED at 3. 1 out of 1 hunk
> FAILED -- saving rejects to file /tmp/reviewboard.2YSn1I/tmp2kVGGw-new.rej
>
>
> The result is similar to all review request in the system, which have
> worked before the update.
>
> There are no visible error on the ReviewBoard log neither on GitLab. I
> have check the content of the temporary files from the RB error message and
> it look that the 'old' and the 'new' file contain the same blob. It's also
> visible from the GitLab side that there are to requests and the answer is
> the same.
>
> Any idea what happened here? Is it correct that the blob are identical?
>
> If you need any further information, please let me know.
>
> BR
> Ralf
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reviewboard upgrade failure

[Christian Hammond]

Hey Dan,

That looks like it's due to a half-updated database, where some changes
were applied and then there was a failure. Or, due to a forced hinted
evolution that took place at some point.

To fix it, you'd have to figure out exactly what SQL statements had applied
from which evolutions, how far all that got, and what entries in the schema
storage may be incorrect, and manually alter portions of the database to
get it back into the state it should be in to undo that upgrade. It's a lot
of work.

It's also the kind of thing we're good at. You've likely seen our other
threads about database repair. We can get you a working database within
hours for an hourly fee, if you wanted to go that route. We charge
$200/hour for the repair, and it usually takes only a few hours. We also
include this service as part of our Premium Support contracts, which I can
talk about more if you're interested.

Christian


On Tuesday, April 5, 2016, 'Daniel Laird' via reviewboard <
reviewboard@googlegroups.com
> wrote:

> All,
>
> I am trying to upgrade from 2.0.20 -> 2.5.3.
> I do this by taking a backup of the 2.0.20 database then importing into
> MySQL and then running the rb-site upgrade.
>
> However I get the following output:
> 
> Updating database. This may take a while.
>
> The log output below, including warnings and errors,
> can be ignored unless upgrade fails.
>
> --  --
> Creating tables ...
> There are unapplied evolutions for accounts.
> There are unapplied evolutions for attachments.
> There are unapplied evolutions for diffviewer.
> There are unapplied evolutions for reviews.
> There are unapplied evolutions for webapi.
> Project signature has changed - an evolution is required
> Installing custom SQL ...
> Installing indexes ...
> Installed 0 object(s) from 0 fixture(s)
> /usr/local/lib/python2.7/dist-packages/ReviewBoardPowerPack-1.4-py2.7.egg/rbpowerpack/scmtools/tfs.py:9:
> DeprecationWarning: django.utils.simplejson is deprecated; use json instead.
>
> CommandError: Error applying evolution: (1060, "Duplicate column name
> 'visibility'")
> ...
>
> Any ideas on why I am getting this error or how I can get more debug to
> help?
> Much appreciated
> Dan
>
> On Friday, 15 January 2016 19:44:43 UTC, Ben Cooksley wrote:
>>
>> On Sat, Jan 16, 2016 at 6:09 AM, Christian Hammond 
>> wrote:
>> > Hi Ben,
>> >
>> > You'll have a much easier time restoring from a backup. It's hard to
>> say how
>> > far it went through the evolution process, and unfortunately today it
>> > doesn't keep track of how far it got and what it'd have to do to
>> recover.
>> > You'd have a lot of trial and error to fix it manually. You can try it,
>> > though.
>> >
>> > Basically, you'll need to dump the SQL that the evolutions want to
>> apply,
>> > and go through and hand-undo each thing it did until you get back to
>> the
>> > point of where it was. You'd definitely want to do a backup first,
>> though.
>>
>> Unfortunately people had started using it already so this was the
>> easiest approach :(
>>
>> Would it be possible to get a copy of a normally, safely upgraded
>> schema so I can double check I haven't clobbered anything?
>>
>> The queries I ended up having to run to revert things to a state where
>> the upgrade process would work was:
>>
>> 160115 19:34:12 2197763 Query   ALTER TABLE
>> accounts_reviewrequestvisit DROP COLUMN visibility
>> 160115 19:34:24 2197763 Query   DROP INDEX
>> `accounts_reviewrequestvisit_05ee5d21` ON
>> `accounts_reviewrequestvisit`
>> 160115 19:34:45 2197763 Query   ALTER TABLE attachments_fileattachment
>> DROP COLUMN attachment_revision, DROP COLUMN attachment_history_id
>> 160115 19:34:58 2197763 Query   ALTER TABLE diffviewer_filediff DROP
>> COLUMN raw_diff_hash_id, DROP COLUMN raw_parent_diff_hash_id
>> 160115 19:36:18 2197763 Query   ALTER TABLE `reviews_group` DROP
>> COLUMN `email_list_only`, DROP COLUMN is_default_group
>> 160115 19:36:25 2197763 Query   DROP TABLE
>> reviews_reviewrequest_file_attachment_histories
>>
>> Note that I observed that the Reviewboard process tries to reverse
>> it's failed upgrade by doing a rollback. It is noted in the case of
>> InnoDB that schema changes cannot be rolled back (see
>> http://www.sitepoint.com/mysql-transaction-gotchas-good-parts/)
>>
>> >
>> > Christian
>>
>> Cheers,
>> Ben
>>
>> >
>> > --
>> > Christian Hammond - chi...@chipx86.com
>> > Review Board - https://www.reviewboard.org
>> > Beanbag, Inc. - https://www.beanbaginc.com
>> >
>> > On Fri, Jan 15, 2016 at 2:26 AM, Ben Cooksley  wrote:
>> >>
>> >> On Fri, Jan 15, 2016 at 11:09 PM, Ben Cooksley 
>> wrote:
>> >> > On Fri, Jan 15, 2016 at 11:04 PM, Christian Hammond
>> >> >  wrote:
>> >> >> Hi Ben,
>> >> >>
>> >> >> This is due to a mismatch between MySQL table types. The existing
>> >> >> tables are
>> >> >> likely MyISAM, 

Re: Integrated ReviewBoard in TortoiseSVN 1.8.X

[john levin]

Hi,

Wow. Infact i was trying the same (integrating with Tortoise-svn to create 
reviews automatically). I would like to see ur code. Could you please share 
it in public?

Thanks !
John

On Friday, May 9, 2014 at 3:32:39 AM UTC+5:30, Tamer Afify wrote:
>
> Hi All,
>
> I have made few changes in TortoiseSVN 1.8.X release to allow for;
> 1. Send a pre-commit review request from File Explorer menu
> 2. Send a post-commit review request from Tortoise Show Logs dialog
> 3. Review & Commit source in one step, that would add the review URL in 
> the commit log message
> 4. Setup a user local .reviewboardrc configuration file from TortoiseSVN 
> settings dialog
>
> I'm new to the open source world. Is that change of any value to the 
> ReviewBoard community? If so how can I share source and binaries?
> and maybe hopefully get a code review for my changes :)
>
>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Integrated ReviewBoard in TortoiseSVN 1.8.X

['Wolfgang Hottgenroth' via reviewboard]

Hi Tamer,

are the sources or a binary with this additional functionality anywhere 
available in public or can you share it with me?
Or is it already integrated into the official TortoiseSVN sources?

Cheers,
Wolfgang


Am Freitag, 9. Mai 2014 00:02:39 UTC+2 schrieb Tamer Afify:

> Hi All,
>
> I have made few changes in TortoiseSVN 1.8.X release to allow for;
> 1. Send a pre-commit review request from File Explorer menu
> 2. Send a post-commit review request from Tortoise Show Logs dialog
> 3. Review & Commit source in one step, that would add the review URL in 
> the commit log message
> 4. Setup a user local .reviewboardrc configuration file from TortoiseSVN 
> settings dialog
>
> I'm new to the open source world. Is that change of any value to the 
> ReviewBoard community? If so how can I share source and binaries?
> and maybe hopefully get a code review for my changes :)
>
>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.