Re: Can't commit reviews to ReviewBoard with rbt command on Windows

2016-11-10 Thread chaoqun . fang
Same problems:

> rbt post --diff-filename diff.txt
ERROR: Error validating diff

Unexpected error when validating the diff: 'utf8' codec can't decode byte 
0xb0 in position 1: invalid start byte (HTTP 400, API Error 224)



On Friday, November 11, 2016 at 1:43:39 PM UTC+8, 
chaoqu...@fengxingsoftware.com wrote:
>
> Hi, all
>
> I can't post a review to server with rbt command on Windows.
>
> My comnad and errors like below:
>
> D:\glsearch\platform-system\wemeta>rbt post --diff-filename out.diff
> CRITICAL: 'ascii' codec can't decode byte 0xb0 in position 1: ordinal not 
> in range(128)
>
>
> My system is win10, and my python version is Python 2.7.9.
>
> What's the problem and what can i do?
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Can't commit reviews to ReviewBoard with rbt command on Windows

2016-11-10 Thread chaoqun . fang
Hi, all

I can't post a review to server with rbt command on Windows.

My comnad and errors like below:

D:\glsearch\platform-system\wemeta>rbt post --diff-filename out.diff
CRITICAL: 'ascii' codec can't decode byte 0xb0 in position 1: ordinal not 
in range(128)


My system is win10, and my python version is Python 2.7.9.

What's the problem and what can i do?

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Index: pom.xml
===
--- pom.xml	(revision 383655)
+++ pom.xml	(working copy)
@@ -17,7 +17,7 @@
 biz
 web
 services
-common
+
 
 
 


Re: reviewboard 2.5.7 default reviewer do'nt work

2016-11-10 Thread LeeJunlong
*user:* lijl, zengzq
*review group:* appas, member: lijl, zengzq
*Repositories: *appas

default reviewer:
   * name:* appas
File regular expression: .*
Default groups: appas
*Repositories: *appas


在 2016年11月10日星期四 UTC+8上午2:24:29,David Trowbridge写道:
>
> Could you share the entire default reviewer configuration?
>
> -David
>
> On Tue, Nov 8, 2016 at 9:18 PM LeeJunlong  > wrote:
>
>> my svn url like this: svn://10.8.199.63:10223/appas
>>
>> when i add a new request with file regular express ".*", , the default 
>> reviewer dont work
>>
>>
>> 
>>
>>
>>
>> 
>>
>>
>>
>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/d/optout.
>>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: RB 2.5.2: modifying repository results with "Please correct the error below."

2016-11-10 Thread David Trowbridge
Yes, that's correct.

-David
On Thu, Nov 10, 2016 at 12:06 AM Yarden Bar  wrote:

> By 'remote path' you mean a git clone URL?
>
> And the gitweb url is for downloading the raw file?
>
>
> On November 10, 2016 9:25:44 AM GMT+02:00, David Trowbridge <
> trowb...@gmail.com> wrote:
>
> Hi,
>
> It's possible to use a remote path, but in that case, you also have to set
> the "raw file URL" to be a template of a URL to access raw file contents
> via GitWeb or cgit.
>
> -David
>
> On Wed, Nov 9, 2016 at 10:40 PM Yarden Bar  wrote:
>
> Hi David,
> Thank you for the quick reply.
>
> If I understand correctly, the Path setting can only be a local directory
> on ReviewBoard host?
>
> On November 9, 2016 8:23:48 PM GMT+02:00, David Trowbridge <
> trowb...@gmail.com> wrote:
>
> Review Board cannot talk to a remote git repository directly due to
> deficiencies in the git protocol. If you want to communicate with a remote
> repository, you'll have to have a frontend such as GitWeb or cgit. See
> https://www.reviewboard.org/docs/manual/2.5/admin/configuration/repositories/#git
>  for
> more details.
>
> -David
>
> On Wed, Nov 9, 2016 at 5:54 AM Yarden Bar  wrote:
>
> Hi all,
> I've searched for the string in the subject in the group also in google
> but didn't came up with anything useful.
> Also search in the release notes but nothing.
>
> I was trying to replace the repository Path variable from local path to
> git clone URL.
> Hitting save resulted with "Please correct the error below."
>
> Any Idea?
>
> Thank you,
> Yarden
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
>
> --
> Sent from my Android device with K-9 Mail. Please excuse my brevity.
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: RB 2.5.2: modifying repository results with "Please correct the error below."

2016-11-10 Thread Yarden Bar
By 'remote path' you mean a git clone URL?

And the gitweb url is for downloading the raw file?

On November 10, 2016 9:25:44 AM GMT+02:00, David Trowbridge 
 wrote:
>Hi,
>
>It's possible to use a remote path, but in that case, you also have to
>set
>the "raw file URL" to be a template of a URL to access raw file
>contents
>via GitWeb or cgit.
>
>-David
>
>On Wed, Nov 9, 2016 at 10:40 PM Yarden Bar 
>wrote:
>
>> Hi David,
>> Thank you for the quick reply.
>>
>> If I understand correctly, the Path setting can only be a local
>directory
>> on ReviewBoard host?
>>
>> On November 9, 2016 8:23:48 PM GMT+02:00, David Trowbridge <
>> trowb...@gmail.com> wrote:
>>
>> Review Board cannot talk to a remote git repository directly due to
>> deficiencies in the git protocol. If you want to communicate with a
>remote
>> repository, you'll have to have a frontend such as GitWeb or cgit.
>See
>>
>https://www.reviewboard.org/docs/manual/2.5/admin/configuration/repositories/#git
>for
>> more details.
>>
>> -David
>>
>> On Wed, Nov 9, 2016 at 5:54 AM Yarden Bar 
>wrote:
>>
>> Hi all,
>> I've searched for the string in the subject in the group also in
>google
>> but didn't came up with anything useful.
>> Also search in the release notes but nothing.
>>
>> I was trying to replace the repository Path variable from local path
>to
>> git clone URL.
>> Hitting save resulted with "Please correct the error below."
>>
>> Any Idea?
>>
>> Thank you,
>> Yarden
>>
>> --
>> Supercharge your Review Board with Power Pack:
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons:
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> ---
>> You received this message because you are subscribed to the Google
>Groups
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it,
>send an
>> email to reviewboard+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>>

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Review Board Ticket #4484: Commit_id no more shows if it is pending (perforce repository)

2016-11-10 Thread Subodh Konhor
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4484/
--

New ticket #4484 by subodhk
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect


--
Commit_id no more shows if it is pending (perforce repository)
==

# What version are you running?
2.5.7

# What's the URL of the page containing the problem?
review/r//

# What steps will reproduce the problem?
1. install reviewboard 2.5.7
2. rbt post 


# What is the expected output? What do you see instead?
Review request when opened should show "Change: 549348 (pending)" as it is a 
pending CL
Review request when opened displays as "Change: 549348" which is not expected.

# What operating system are you using? What browser?
CentOS 6

# Please provide any additional information below.
Tested the scenario in 2.5.6.1 and the change is shown properly

Below is the culprit sql

2.5.3/2.5.6.1
INSERT INTO `reviews_reviewrequest` (`description`, `description_rich_text`, 
`testing_done`, `testing_done_rich_text`, `bugs_closed`, `branch`, `commit_id`, 
`extra_data`, `rich_text`, `summary`, `submitter_id`, `time_added`, 
`last_updated`, `status`, `public`, `changenum`, `repository_id`, 
`email_message_id`, `time_emailed`, `diffset_history_id`, 
`last_review_timestamp`, `shipit_count`, `issue_open_count`, 
`issue_resolved_count`, `issue_dropped_count`, `local_site_id`, `local_id`) 
VALUES ('RBT Test 3\n=bug9690333 fix-partial  ', 0, '', 0, '9690333', 'tools', 
'549348', '{}', 0, 'RBT Test 3 =bug9690333 fix-partial  ', 1244, '2016-11-10 
07:29:06', '2016-11-10 07:29:06', 'P', 0, 549348, 1, NULL, NULL, 63093, NULL, 
0, 0, 0, 0, NULL, NULL)

2.5.7
INSERT INTO `reviews_reviewrequest` (`description`, `description_rich_text`, 
`testing_done`, `testing_done_rich_text`, `bugs_closed`, `branch`, `commit_id`, 
`extra_data`, `rich_text`, `summary`, `submitter_id`, `time_added`, 
`last_updated`, `status`, `public`, `changenum`, `repository_id`, 
`email_message_id`, `time_emailed`, `diffset_history_id`, 
`last_review_timestamp`, `shipit_count`, `issue_open_count`, 
`issue_resolved_count`, `issue_dropped_count`, `local_site_id`, `local_id`) 
VALUES ('', 0, '', 0, '', '', NULL, '{}', 0, '', 1244, '2016-11-10 07:23:15', 
'2016-11-10 07:23:15', 'P', 0, NULL, 1, NULL, NULL, 69438, NULL, 0, 0, 0, 0, 
NULL, NULL)

--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.