Re: Review Board Ticket #4545: User name is not shown with certain actions (update and publish diff, closing review request as submitted)

2017-04-24 Thread Christian Hammond 
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4545/
--

New update by samsun387
For Beanbag, Inc. > Review Board > Ticket #4545


Reply:

Review Board 3.0 (in beta) tracks the actual user who makes the changes. In 
prior versions, all actions on a review request are assumed to be from the 
owner of the review request (as it requires a special permission or an 
administrator to otherwise make changes to a review request). 3.0 allows for 
review request re-assignment and user tracking for all actions.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Review Board Ticket #4545: User name is not shown with certain actions (update and publish diff, closing review request as submitted)

2017-04-24 Thread Kevin Yu 
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4545/
--

New ticket #4545 by samsun387
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect

File attachments:

 * Selection_004.bmp
   



--
User name is not shown with certain actions (update and publish diff, closing 
review request as submitted)
==

# What version are you running?
2.5.6.1

# What's the URL of the page containing the problem?
/r/

# What steps will reproduce the problem?
1. Create review request
2. Close review request as submitted or discarded
3. Check the review events at the bottom of the page


# What is the expected output? What do you see instead?
The name of the user who performed these action should be shown. It should be 
the same as any other events. Please refer to the events that were not 
highlighted in the screenshot

--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Is there a way to update the notification subject before sending out email?

2017-04-24 Thread Christian Hammond 
Hi Kevin,

There's no support for this today, but it's something that could be added.
We have a series of EmailHook classes that we could use to modify more data
for e-mails. Right now it only supports augmenting the To/CC fields.

There's a couple of options I can recommend right now:

1) If you feel comfortable with Python and want to work on a patch for
Review Board, we can discuss the best options for adding subject
modification, and get that into a 2.5.x release.

2) Otherwise, you'd need to disable e-mail and write an extension that
re-adds all the signal connectivity needed to send out e-mails, and all the
e-mail sending code. More work than option #1, certainly.

Christian

-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

On Mon, Apr 24, 2017 at 5:45 PM, Kevin Yu  wrote:

> Hi,
>
> I'm wondering there is any way to update the notification subject before
> sending out email. We would like add some information to the notification
> email subject, which is currently using the review request's summary.
>
> I've created https://hellosplat.com/s/beanbag/tickets/4544/ as feature
> request but so far no news.
>
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Is there a way to update the notification subject before sending out email?

2017-04-24 Thread Kevin Yu 
Hi,

I'm wondering there is any way to update the notification subject before 
sending out email. We would like add some information to the notification 
email subject, which is currently using the review request's summary.

I've created https://hellosplat.com/s/beanbag/tickets/4544/ as feature 
request but so far no news.


-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: reviewboard - review is being posted with a different user!

2017-04-24 Thread Kevin Yu 
Just looked at your question again. If you are posting review request 
through GUI, I assume our issue is different.


On Monday, April 24, 2017 at 4:30:12 PM UTC-7, Kevin Yu wrote:
>
> We had run into the same issue a few times. What happened is that I use 
> user A for Reviewboard Server A and B user for reviewboard Server B. Even 
> after rbt logout, when i run rbt post to reviewboard B, it's posted as User 
> A.
>
> rm -Rf ~/.rbtools-cookies fixed the issue for me.
>
> On Monday, March 27, 2017 at 4:51:53 AM UTC-7, Narayanarao Yenduri wrote:
>>
>> thanks Christian for quick reply.
>> unfortunately re-login did not help.
>>
>> i also suspect some cookie might causing this., any other options to 
>> narrow it down?
>>
>> On Monday, 27 March 2017 14:44:55 UTC+5:30, Christian Hammond wrote:
>>>
>>> Sounds like the local user account on Windows is being reused by user2, 
>>> which would mean there's a stale session cookie file for the user.
>>>
>>> Try forcing a re-login using `rbt login`, and provide the 
>>> username/password of the user you want to use.
>>>
>>> Christian
>>>
>>> -- 
>>> Christian Hammond
>>> President/CEO of Beanbag 
>>> Makers of Review Board 
>>>
>>> On Mon, Mar 27, 2017 at 1:54 AM, Narayanarao Yenduri <
>>> ynaray...@gmail.com> wrote:
>>>
 hi 

 we have an windows machine with perforce as version control being used 
 by user1.
 uesr1 able to raise reviews properly (rbt post  )
 now user1 left, so allotted the same machine to user2.
 when user2 tries to post review, it seems taking id of user1.
 so user2 not able to submit the diff for reviews.

 did any one face similar issue.

 appreciate any quick response.

 thanks.

 -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google 
 Groups "reviewboard" group.
 To unsubscribe from this group and stop receiving emails from it, send 
 an email to reviewboard...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.

>>>
>>>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: reviewboard - review is being posted with a different user!

2017-04-24 Thread Kevin Yu 
We had run into the same issue a few times. What happened is that I use 
user A for Reviewboard Server A and B user for reviewboard Server B. Even 
after rbt logout, when i run rbt post to reviewboard B, it's posted as User 
A.

rm -Rf ~/.rbtools-cookies fixed the issue for me.

On Monday, March 27, 2017 at 4:51:53 AM UTC-7, Narayanarao Yenduri wrote:
>
> thanks Christian for quick reply.
> unfortunately re-login did not help.
>
> i also suspect some cookie might causing this., any other options to 
> narrow it down?
>
> On Monday, 27 March 2017 14:44:55 UTC+5:30, Christian Hammond wrote:
>>
>> Sounds like the local user account on Windows is being reused by user2, 
>> which would mean there's a stale session cookie file for the user.
>>
>> Try forcing a re-login using `rbt login`, and provide the 
>> username/password of the user you want to use.
>>
>> Christian
>>
>> -- 
>> Christian Hammond
>> President/CEO of Beanbag 
>> Makers of Review Board 
>>
>> On Mon, Mar 27, 2017 at 1:54 AM, Narayanarao Yenduri > > wrote:
>>
>>> hi 
>>>
>>> we have an windows machine with perforce as version control being used 
>>> by user1.
>>> uesr1 able to raise reviews properly (rbt post  )
>>> now user1 left, so allotted the same machine to user2.
>>> when user2 tries to post review, it seems taking id of user1.
>>> so user2 not able to submit the diff for reviews.
>>>
>>> did any one face similar issue.
>>>
>>> appreciate any quick response.
>>>
>>> thanks.
>>>
>>> -- 
>>> Supercharge your Review Board with Power Pack: 
>>> https://www.reviewboard.org/powerpack/
>>> Want us to host Review Board for you? Check out RBCommons: 
>>> https://rbcommons.com/
>>> Happy user? Let us know! https://www.reviewboard.org/users/
>>> --- 
>>> You received this message because you are subscribed to the Google 
>>> Groups "reviewboard" group.
>>> To unsubscribe from this group and stop receiving emails from it, send 
>>> an email to reviewboard...@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>
>>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.