Re: Review Board Ticket #4760: Update > Add File on a review request does not create a draft review request

[Sarah Hoven]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4760/
--

New update by shoven
For Beanbag, Inc. > Review Board > Ticket #4760


Reply:

I will work on this.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Review Board Ticket #4760: Update > Add File on a review request does not create a draft review request

[Sarah Hoven]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4760/
--

New ticket #4760 by shoven
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect

File attachments:

 * expected output.png
   

 * observed output.png
   



--
Update > Add File on a review request does not create a draft review request
==

# What version are you running?

4.0.x

# What's the URL of the page containing the problem?

/r/

# What steps will reproduce the problem?
1. Open an already published review request.
2. In the console, run the following commands:
- RB.PageManager.getPage().reviewRequest.draft.id (expected output: undefined)
- RB.PageManager.getPage().model.reviewRequestEditor.get('hasDraft') (expected 
output: false)
3. Select Update > Add File
4. Choose a file and upload
5. Once the page refreshes, run the commands again:
- RB.PageManager.getPage().reviewRequest.draft.id (expected output: defined 
(some id), observed output: undefined)
- RB.PageManager.getPage().model.reviewRequestEditor.get('hasDraft') (expected 
output: true)

In contrast, try uploading a file with the drag-and-drop method and notice that 
all commands will return the expected output.


# What is the expected output? What do you see instead?
See steps above for expected output at each step. The main change is that after 
uploading a file, we expect RB.PageManager.getPage().reviewRequest.draft.id to 
be defined, but currently it is undefined (see attached files for expected and 
observed output).

# What operating system are you using? What browser?
macOS 10.13.6, Chrome Version 69

# Please provide any additional information below.
Suggested fix: 
- Remove the reload in `views/uploadAttachmentView.js`.
- `_onUploadFileClicked` in `reviewRequestEditorView` would need to pass the 
`this.model` in as something like `reviewRequestEditor` when constructing the 
`RB.UploadAttachmentView`. That view would then need to store that and, in 
`send()`, call `this.reviewRequestEditor.createFileAttachment` instead of 
`this.options.reviewRequest.createFileAttachment`.
- Close the 'Add file' dialog.


--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Using Hashlibs.sha instead of hashlib.md5 on FIPS-enabled CentOS7. Am I totally off base? Is this possible?

[David Trowbridge]

Hi,

The only place that Review Board uses md5 is if you're using the HTTP
Digest authentication backend (in which case it's specified by the HTTP
Digest Auth spec). There are also a couple call sites in unit tests, but
those are only used in development and not on production servers.

-David

On Mon, Oct 22, 2018 at 9:09 AM Zachary Gallagher <
zachary.gallag...@remcom.com> wrote:

> Ideally we'd like to use the security profile for the NIST 800-171. Yes,
> this is for a security *need *and not some whimsical desire for security.
> For all new installs, that's what we're going with. That includes a certain
> required level of encryption. Reviewboard as is uses hashlibs.md5, and FIPS
> mode for CentOS7 rejects this.
>
> I'm unsure, but is there a simple pre-conf switch I can add to change the
> setting? I'm looking for it at the moment, but haven't found anything yet.
> Is this a Python/CentOS thing? I honestly don't know exactly where to look
> for support at the moment.
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Using Hashlibs.sha instead of hashlib.md5 on FIPS-enabled CentOS7. Am I totally off base? Is this possible?

[Zachary Gallagher]

Ideally we'd like to use the security profile for the NIST 800-171. Yes, 
this is for a security *need *and not some whimsical desire for security. 
For all new installs, that's what we're going with. That includes a certain 
required level of encryption. Reviewboard as is uses hashlibs.md5, and FIPS 
mode for CentOS7 rejects this.

I'm unsure, but is there a simple pre-conf switch I can add to change the 
setting? I'm looking for it at the moment, but haven't found anything yet. 
Is this a Python/CentOS thing? I honestly don't know exactly where to look 
for support at the moment.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

ReviewBoard - Elasticsearch setup

[Hema]

Hi,

I had setup single node Elasticsearch cluster and I'm trying to establish 
the connection between ReviewBoard and the cluster by providing the url and 
index in "Search Settings" page. It throws the keyerror 
'search_backend_id'. 

Can you please let me know what am I missing here?

Thanks,
Hemapriya.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.