Re: Bitbucket webhook integration fail with Review Board 3.0.10, payload empty

2018-11-26 Thread grant . zukel
Awesome, thank you. Is there documentation on upgrading to the new version 
? 

On Monday, November 26, 2018 at 12:16:41 PM UTC-8, Christian Hammond wrote:
>
> We're aiming for next week (Tuesday, December 4th).
>
> Christian
>
> On Mon, Nov 26, 2018 at 12:15 PM > wrote:
>
>> Do you have a targeted release date for 3.0.11? We would really like to 
>> have it integrated but I don't want to do a bunch of scripting work for 
>> Jenkins if it's going to be in the next couple of months.
>>
>> On Tuesday, November 20, 2018 at 4:44:48 PM UTC-8, Christian Hammond 
>> wrote:
>>>
>>> Hi,
>>>
>>> My understanding was that they'd be keeping the old service around 
>>> longer.. Well, we've been planning to move over to the new format, and 
>>> we'll just have to expedite it.
>>>
>>> Unfortunately, for now, there's no workaround. We'll need to address 
>>> this in 3.0.11.
>>>
>>> Christian
>>>
>>> On Thu, Nov 15, 2018 at 4:12 PM  wrote:
>>>
 Hello, I'm using bitbucket cloud, and I clicked setup webhook from my 
 review board installation on the repository I want to set the hook up for.
 When I clicked the link it took me to bitbucket services which is a 
 deprecated feature of bitbucket and the link isn't even present anymore. I 
 set that up, but bitbucket gives you a message about the functionality 
 being deprecated and no longer working and to utilize the new webhook 
 setup.
 I set the webhook up in the new method of bitbucket webhooks by using the 
 URL and the request gets a 400 response saying the payload is empty. 
 However, when I view the body payload in bitbucket it is not empty.


 ype: repo:push
 Event time: a few seconds ago (Thursday, November 15th 2018, 3:54:31 pm)
 Response from 
 http://mydomain.com/repos/3/bitbucket/hooks/{{uuid}}/close-submitted/
 HTTP status: 400
 Elapsed time: 38ms
 Request time: a few seconds ago (Thursday, November 15th 2018, 3:54:31 pm)
 Headers
 Content-Length 15
 Content-Language   en
 Vary   Cookie,Accept-Language
 Server Apache/2.4.29 (Ubuntu)
 Connection close
 Date   Thu, 15 Nov 2018 23:54:31 GMT
 X-Frame-OptionsSAMEORIGIN
 Content-Type   text/html; charset=utf-8
 Body
 Missing payload

 Here is the actual payload sent to review board by bitbucket with new 
 webhooks method obfuscated for security

 {
   "push": {
 "changes": [
   {
 "forced": false,
 "old": {
   "target": {
 "hash": "{{uuid}}",
 "links": {
   "self": {
 "href": 
 "https://api.bitbucket.org/2.0/repositories/DevTeam/ProjectCode-scratch/commit/{{uuid}};
   },
   "html": {
 "href": 
 "https://bitbucket.org/DevTeam/ProjectCode-scratch/commits/{{uuid}};
   }
 },
 "author": {
   "raw": "MyName ",
   "type": "author"
 },
 "summary": {
   "raw": "new file\n",
   "markup": "markdown",
   "html": "new file",
   "type": "rendered"
 },
 "parents": [
   {
 "type": "commit",
 "hash": "{{uuid}}",
 "links": {
   "self": {
 "href": 
 "https://api.bitbucket.org/2.0/repositories/DevTeam/ProjectCode-scratch/commit/{{uuid}};
   },
   "html": {
 "href": 
 "https://bitbucket.org/DevTeam/ProjectCode-scratch/commits/{{uuid}};
   }
 }
   }
 ],
 "date": "2018-11-15T23:53:41+00:00",
 "message": "new file\n",
 "type": "commit"
   },
   "links": {
 "commits": {
   "href": 
 "https://api.bitbucket.org/2.0/repositories/DevTeam/ProjectCode-scratch/commits/test_branch_1;
 },
 "self": {
   "href": 
 "https://api.bitbucket.org/2.0/repositories/DevTeam/ProjectCode-scratch/refs/branches/test_branch_1;
 },
 "html": {
   "href": 
 "https://bitbucket.org/DevTeam/ProjectCode-scratch/branch/test_branch_1;
 }
   },
   "default_merge_strategy": "merge_commit",
   "merge_strategies": [
 "merge_commit",
 "squash",
 "fast_forward"
   ],
   "type": "branch",
   "name": "test_branch_1"
 },
 "links": {
   "commits": {
 "href": 
 

Re: Bitbucket webhook integration fail with Review Board 3.0.10, payload empty

2018-11-26 Thread Christian Hammond
We're aiming for next week (Tuesday, December 4th).

Christian

On Mon, Nov 26, 2018 at 12:15 PM  wrote:

> Do you have a targeted release date for 3.0.11? We would really like to
> have it integrated but I don't want to do a bunch of scripting work for
> Jenkins if it's going to be in the next couple of months.
>
> On Tuesday, November 20, 2018 at 4:44:48 PM UTC-8, Christian Hammond wrote:
>>
>> Hi,
>>
>> My understanding was that they'd be keeping the old service around
>> longer.. Well, we've been planning to move over to the new format, and
>> we'll just have to expedite it.
>>
>> Unfortunately, for now, there's no workaround. We'll need to address this
>> in 3.0.11.
>>
>> Christian
>>
>> On Thu, Nov 15, 2018 at 4:12 PM  wrote:
>>
>>> Hello, I'm using bitbucket cloud, and I clicked setup webhook from my 
>>> review board installation on the repository I want to set the hook up for.
>>> When I clicked the link it took me to bitbucket services which is a 
>>> deprecated feature of bitbucket and the link isn't even present anymore. I 
>>> set that up, but bitbucket gives you a message about the functionality 
>>> being deprecated and no longer working and to utilize the new webhook setup.
>>> I set the webhook up in the new method of bitbucket webhooks by using the 
>>> URL and the request gets a 400 response saying the payload is empty. 
>>> However, when I view the body payload in bitbucket it is not empty.
>>>
>>>
>>> ype: repo:push
>>> Event time: a few seconds ago (Thursday, November 15th 2018, 3:54:31 pm)
>>> Response from 
>>> http://mydomain.com/repos/3/bitbucket/hooks/{{uuid}}/close-submitted/
>>> HTTP status: 400
>>> Elapsed time: 38ms
>>> Request time: a few seconds ago (Thursday, November 15th 2018, 3:54:31 pm)
>>> Headers
>>> Content-Length 15
>>> Content-Language   en
>>> Vary   Cookie,Accept-Language
>>> Server Apache/2.4.29 (Ubuntu)
>>> Connection close
>>> Date   Thu, 15 Nov 2018 23:54:31 GMT
>>> X-Frame-OptionsSAMEORIGIN
>>> Content-Type   text/html; charset=utf-8
>>> Body
>>> Missing payload
>>>
>>> Here is the actual payload sent to review board by bitbucket with new 
>>> webhooks method obfuscated for security
>>>
>>> {
>>>   "push": {
>>> "changes": [
>>>   {
>>> "forced": false,
>>> "old": {
>>>   "target": {
>>> "hash": "{{uuid}}",
>>> "links": {
>>>   "self": {
>>> "href": 
>>> "https://api.bitbucket.org/2.0/repositories/DevTeam/ProjectCode-scratch/commit/{{uuid}};
>>>   },
>>>   "html": {
>>> "href": 
>>> "https://bitbucket.org/DevTeam/ProjectCode-scratch/commits/{{uuid}};
>>>   }
>>> },
>>> "author": {
>>>   "raw": "MyName ",
>>>   "type": "author"
>>> },
>>> "summary": {
>>>   "raw": "new file\n",
>>>   "markup": "markdown",
>>>   "html": "new file",
>>>   "type": "rendered"
>>> },
>>> "parents": [
>>>   {
>>> "type": "commit",
>>> "hash": "{{uuid}}",
>>> "links": {
>>>   "self": {
>>> "href": 
>>> "https://api.bitbucket.org/2.0/repositories/DevTeam/ProjectCode-scratch/commit/{{uuid}};
>>>   },
>>>   "html": {
>>> "href": 
>>> "https://bitbucket.org/DevTeam/ProjectCode-scratch/commits/{{uuid}};
>>>   }
>>> }
>>>   }
>>> ],
>>> "date": "2018-11-15T23:53:41+00:00",
>>> "message": "new file\n",
>>> "type": "commit"
>>>   },
>>>   "links": {
>>> "commits": {
>>>   "href": 
>>> "https://api.bitbucket.org/2.0/repositories/DevTeam/ProjectCode-scratch/commits/test_branch_1;
>>> },
>>> "self": {
>>>   "href": 
>>> "https://api.bitbucket.org/2.0/repositories/DevTeam/ProjectCode-scratch/refs/branches/test_branch_1;
>>> },
>>> "html": {
>>>   "href": 
>>> "https://bitbucket.org/DevTeam/ProjectCode-scratch/branch/test_branch_1;
>>> }
>>>   },
>>>   "default_merge_strategy": "merge_commit",
>>>   "merge_strategies": [
>>> "merge_commit",
>>> "squash",
>>> "fast_forward"
>>>   ],
>>>   "type": "branch",
>>>   "name": "test_branch_1"
>>> },
>>> "links": {
>>>   "commits": {
>>> "href": 
>>> "https://api.bitbucket.org/2.0/repositories/DevTeam/ProjectCode-scratch/commits?include={{uuid}}={{uuid}};
>>>   },
>>>   "html": {
>>> "href": 
>>> "https://bitbucket.org/DevTeam/ProjectCode-scratch/branches/compare/{{uuid}}..{{uuid}};
>>>   },
>>>   "diff": {
>>> "href": 
>>> 

Re: Bitbucket webhook integration fail with Review Board 3.0.10, payload empty

2018-11-26 Thread grant . zukel
Do you have a targeted release date for 3.0.11? We would really like to 
have it integrated but I don't want to do a bunch of scripting work for 
Jenkins if it's going to be in the next couple of months.

On Tuesday, November 20, 2018 at 4:44:48 PM UTC-8, Christian Hammond wrote:
>
> Hi,
>
> My understanding was that they'd be keeping the old service around 
> longer.. Well, we've been planning to move over to the new format, and 
> we'll just have to expedite it.
>
> Unfortunately, for now, there's no workaround. We'll need to address this 
> in 3.0.11.
>
> Christian
>
> On Thu, Nov 15, 2018 at 4:12 PM > wrote:
>
>> Hello, I'm using bitbucket cloud, and I clicked setup webhook from my review 
>> board installation on the repository I want to set the hook up for.
>> When I clicked the link it took me to bitbucket services which is a 
>> deprecated feature of bitbucket and the link isn't even present anymore. I 
>> set that up, but bitbucket gives you a message about the functionality being 
>> deprecated and no longer working and to utilize the new webhook setup.
>> I set the webhook up in the new method of bitbucket webhooks by using the 
>> URL and the request gets a 400 response saying the payload is empty. 
>> However, when I view the body payload in bitbucket it is not empty.
>>
>>
>> ype: repo:push
>> Event time: a few seconds ago (Thursday, November 15th 2018, 3:54:31 pm)
>> Response from 
>> http://mydomain.com/repos/3/bitbucket/hooks/{{uuid}}/close-submitted/
>> HTTP status: 400
>> Elapsed time: 38ms
>> Request time: a few seconds ago (Thursday, November 15th 2018, 3:54:31 pm)
>> Headers
>> Content-Length 15
>> Content-Language   en
>> Vary   Cookie,Accept-Language
>> Server Apache/2.4.29 (Ubuntu)
>> Connection close
>> Date   Thu, 15 Nov 2018 23:54:31 GMT
>> X-Frame-OptionsSAMEORIGIN
>> Content-Type   text/html; charset=utf-8
>> Body
>> Missing payload
>>
>> Here is the actual payload sent to review board by bitbucket with new 
>> webhooks method obfuscated for security
>>
>> {
>>   "push": {
>> "changes": [
>>   {
>> "forced": false,
>> "old": {
>>   "target": {
>> "hash": "{{uuid}}",
>> "links": {
>>   "self": {
>> "href": 
>> "https://api.bitbucket.org/2.0/repositories/DevTeam/ProjectCode-scratch/commit/{{uuid}};
>>   },
>>   "html": {
>> "href": 
>> "https://bitbucket.org/DevTeam/ProjectCode-scratch/commits/{{uuid}};
>>   }
>> },
>> "author": {
>>   "raw": "MyName ",
>>   "type": "author"
>> },
>> "summary": {
>>   "raw": "new file\n",
>>   "markup": "markdown",
>>   "html": "new file",
>>   "type": "rendered"
>> },
>> "parents": [
>>   {
>> "type": "commit",
>> "hash": "{{uuid}}",
>> "links": {
>>   "self": {
>> "href": 
>> "https://api.bitbucket.org/2.0/repositories/DevTeam/ProjectCode-scratch/commit/{{uuid}};
>>   },
>>   "html": {
>> "href": 
>> "https://bitbucket.org/DevTeam/ProjectCode-scratch/commits/{{uuid}};
>>   }
>> }
>>   }
>> ],
>> "date": "2018-11-15T23:53:41+00:00",
>> "message": "new file\n",
>> "type": "commit"
>>   },
>>   "links": {
>> "commits": {
>>   "href": 
>> "https://api.bitbucket.org/2.0/repositories/DevTeam/ProjectCode-scratch/commits/test_branch_1;
>> },
>> "self": {
>>   "href": 
>> "https://api.bitbucket.org/2.0/repositories/DevTeam/ProjectCode-scratch/refs/branches/test_branch_1;
>> },
>> "html": {
>>   "href": 
>> "https://bitbucket.org/DevTeam/ProjectCode-scratch/branch/test_branch_1;
>> }
>>   },
>>   "default_merge_strategy": "merge_commit",
>>   "merge_strategies": [
>> "merge_commit",
>> "squash",
>> "fast_forward"
>>   ],
>>   "type": "branch",
>>   "name": "test_branch_1"
>> },
>> "links": {
>>   "commits": {
>> "href": 
>> "https://api.bitbucket.org/2.0/repositories/DevTeam/ProjectCode-scratch/commits?include={{uuid}}={{uuid}};
>>   },
>>   "html": {
>> "href": 
>> "https://bitbucket.org/DevTeam/ProjectCode-scratch/branches/compare/{{uuid}}..{{uuid}};
>>   },
>>   "diff": {
>> "href": 
>> "https://api.bitbucket.org/2.0/repositories/DevTeam/ProjectCode-scratch/diff/{{uuid}}..{{uuid}};
>>   }
>> },
>> "truncated": false,
>> "commits": [
>>   {
>> "hash": "{{uuid}}",
>> "links": {
>> 

Re: RBTools Ticket #3659: RBTools 0.6.2 not able to differentiate the binary content

2018-11-26 Thread David Trowbridge
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/3659/
--

New update by shahgu**@gmai* (Google Code)
For Beanbag, Inc. > RBTools > Ticket #3659


Reply:

Fixed in RBTools release-1.0.x (c09cb82). This will ship in RBTools 1.0.2. 
Thanks!


Status:
- PendingReview
+ Fixed

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.