date:20231102

Re: Unable to add Trello integration

2023-11-02 Thread Christian Hammond

Hi Fernando,

We have this fixed internally and will be getting a release out once we
address a couple of additional issues.

Christian

On Thu, Oct 26, 2023 at 10:25 PM 'ferna...@yahoo.es' via Review Board
Community  wrote:

> Hello Christian,
>
> Thanks for your prompt reply. That's what I was afraid of...
> Take a look at this:
>
> https://community.developer.atlassian.com/t/trello-tokens-are-getting-longer/62964
>
> Ok, looking forward to the fix.
> Regards,
> Fernando
>
> On Friday, October 27, 2023 at 4:21:13 AM UTC+2 Christian Hammond wrote:
>
>> Hi Fernando,
>>
>> It does sound like a field length issue. We might need to make some
>> changes to the Trello integration. Let us look into this and see if we can
>> get a fix out for the next release.
>>
>> Christian
>>
>> On Thu, Oct 26, 2023 at 9:07 AM 'ferna...@yahoo.es' via Review Board
>> Community  wrote:
>>
>>> Hello,
>>>
>>> We are starting to use Review Board within my organization... We are
>>> trying to integrate Trello within Review Board but it looks that it does
>>> not work... According to the documentation, I should get a "Trello Cards"
>>> field below the "Testing Done" field but no new field appears on a new
>>> review request...
>>>
>>> I realize that when creating the Trello API Key, the token generated is
>>> much longer (12 chars longer to be precise) than what I can paste on the
>>> field "Trello API Token".
>>>
>>> Is there a problem with the length of the API tokens? Why the "Trello
>>> Cards" field does not appear on a new review request?
>>>
>>> Thanks a lot!
>>> Fernando
>>>
>>> --
>>> Supercharge your Review Board with Power Pack:
>>> https://www.reviewboard.org/powerpack/
>>> Want us to host Review Board for you? Check out RBCommons:
>>> https://rbcommons.com/
>>> Happy user? Let us know! https://www.reviewboard.org/users/
>>> ---
>>> You received this message because you are subscribed to the Google
>>> Groups "Review Board Community" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to reviewboard...@googlegroups.com.
>>> To view this discussion on the web visit
>>> https://groups.google.com/d/msgid/reviewboard/7857acb7-a7e7-48cb-b5d0-da9bf4aa0cd6n%40googlegroups.com
>>> 
>>> .
>>>
>>
>>
>> --
>> Christian Hammond
>> President/CEO of Beanbag 
>> Makers of Review Board 
>>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/reviewboard/1b151601-a576-46fc-ba38-9378dc2cc25cn%40googlegroups.com
> 
> .
>


-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/CAE7Vnd%3D2FB8k2%2BFsxtLmAO02vThpd9MO1rggUYPqJOMFYK%2BnjQ%40mail.gmail.com.

Re: RB v6 "The following reviews are not valid []" when clicking "Publish"

2023-11-02 Thread Christian Hammond

Hi Changxing,

Can you give us a step-by-step process to reproduce this bug on your end?
It'll be helpful to get some more information from you for a
reproducible case.

First, some preparation:

1) Open the Network tab in the browser's developer tools
2) On Firefox, click the gear on the right of the networking pane and
enable Persist Logs. On Chrome, click the "Preserve log" checkbox instead
below the Network tab.
3) Reload the page, so it will begin gathering network logs.

Then if you can get me the following:

1) Are you creating just a single review?
2) Are you also replying to any reviews when you publish?
3) Can we get a screenshot of the review banner right before you publish?
4) After it fails, can you find the POST /r/_batch/ entry in Network, click
Request, and copy the information there? Send that to me privately.
5) Also click on Response, copy the information there, and send that as
well.

We have a possible theory on what's going wrong, but haven't found a repro
case. We hope this will help us confirm and resolve this.

Thanks,

Christian

On Mon, Oct 30, 2023 at 2:18 PM changxi...@taitcommunications.com <
changxing.g...@taitcommunications.com> wrote:

> Hi David,
>
> Thanks for your reply.
> I am using Google Chrome. Firefox has the same issue too.
>
> Yes, we are getting this every time.
> Please see attachment.
>
>
> Thanks,
> Changxing
>
> On Saturday, October 28, 2023 at 10:09:36 AM UTC+13 David Trowbridge wrote:
>
>> Changxing,
>>
>> A couple questions about this:
>> - What browser(s) are you using?
>> - Are you getting this every time, or is this an intermittent failure?
>> - Can you open your browser's developer tools and see if there are any
>> errors on the JavaScript console?
>>
>> Thanks,
>> David
>>
>> On Thu, Oct 26, 2023 at 10:07 AM Changxing Gong <
>> changxi...@taitcommunications.com> wrote:
>>
>>> Hello,
>>>
>>> We recently upgraded RB from v5 to v6.
>>>
>>> The owner or reviewers can still publish a general comment. However, if
>>> they want to reply to a comment, there will be "The following reviews are
>>> not valid []" prompt preventing them from publishing the reply. So neither
>>> the reviewers nor owner can reply to each other. Please see the attachment.
>>>
>>>
>>> Thanks,
>>> Changxing
>>>
>>>
>>>
>>>
>>> --
>>> This communication is confidential. We only send and receive email on the
>>> basis of the terms set out at
>>> www.taitcommunications.com/email_disclaimer
>>> --
>>>
>>> --
>>> Supercharge your Review Board with Power Pack:
>>> https://www.reviewboard.org/powerpack/
>>> Want us to host Review Board for you? Check out RBCommons:
>>> https://rbcommons.com/
>>> Happy user? Let us know! https://www.reviewboard.org/users/
>>> ---
>>> You received this message because you are subscribed to the Google
>>> Groups "Review Board Community" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to reviewboard...@googlegroups.com.
>>> To view this discussion on the web visit
>>> https://groups.google.com/d/msgid/reviewboard/003c49d0-3f44-471d-9ec4-cf889d566f59n%40googlegroups.com
>>> 
>>> .
>>>
>>
>
> --
> This communication is confidential. We only send and receive email on the
> basis of the terms set out at www.taitcommunications.com/email_disclaimer
> --
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/reviewboard/bfb11cdc-7e4c-432f-ade7-671ea7228f31n%40googlegroups.com
> 
> .
>


-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit

Re: Issues configuring ReviewBoard with local git repos

2023-11-02 Thread Christian Hammond

Hi,

There might be a bug in RBTools. We had a similar report recently and plan
to look into it for the next patch release.

What happens if you don't pass --username and --password? It should
prompt you for login at that point, and properly store the session
information.

Christian

On Thu, Nov 2, 2023 at 7:38 PM geof...@gmail.com 
wrote:

> We are trying to do an evaluation of ReviewBoard.
> I have setup ReviewBoard via the Docker container, wih SSL termination
> through a reverse proxy.  the website seems to work fine, and direct
> queries to the API via curl work fine.  I am able to use 'rbt setup-repo'
> to configure a repo.
>
> However, when I run 'rbt post --username myuser --password mypassword', I
> get:
>
> Validating commits... █
>  [1/4]
> ERROR: Error validating diff
>
> You are not logged in (API Error 103: Not Logged In)
>
> The logs show:
>
> reviewboard-reviewboard-1 | 2023-11-03 01:34:02,149 - ERROR - None -
> AnonymousUser - /review/api/repositories/1/info/ - django.request - Not
> Implemented: /review/api/repositories/1/info/
> reviewboard-nginx-1 | 172.28.0.1 - - [03/Nov/2023:01:34:02 +] "GET
> /review/api/repositories/1/info/ HTTP/1.1" 501 153 "-" "RBTools/4.1"
> "10.73.8.104"
> reviewboard-reviewboard-1 | [2023-11-03 01:34:02 +] [16] [DEBUG]
> Closing connection.
> reviewboard-reviewboard-1 | [2023-11-03 01:34:02 +] [16] [DEBUG] GET
> /review/api/validation/commits/
> reviewboard-nginx-1 | 172.28.0.1 - - [03/Nov/2023:01:34:02 +] "GET
> /review/api/validation/commits/ HTTP/1.1" 304 0 "-" "RBTools/4.1"
> "10.73.8.104"
> reviewboard-reviewboard-1 | [2023-11-03 01:34:02 +] [16] [DEBUG]
> Closing connection.
> reviewboard-reviewboard-1 | [2023-11-03 01:34:02 +] [16] [DEBUG] POST
> /review/api/validation/commits/
> reviewboard-reviewboard-1 | Unauthorized: /review/api/validation/commits/
> reviewboard-reviewboard-1 | 2023-11-03 01:34:02,407 - WARNING - None -
> AnonymousUser - /review/api/validation/commits/ - django.request -
> Unauthorized: /review/api/validation/commits/
> reviewboard-reviewboard-1 | [2023-11-03 01:34:02 +] [16] [DEBUG]
> Closing connection.
> reviewboard-nginx-1 | 172.28.0.1 - - [03/Nov/2023:01:34:02 +] "POST
> /review/api/validation/commits/ HTTP/1.1" 401 100 "-" "RBTools/4.1"
> "10.73.8.104"
> reviewboard-reviewboard-1 | [2023-11-03 01:34:02 +] [16] [DEBUG] POST
> /review/api/validation/commits/
> reviewboard-reviewboard-1 | 2023-11-03 01:34:02,431 - DEBUG - None -
> AnonymousUser - /review/api/validation/commits/ -
> djblets.webapi.auth.backends.base - Attempting authentication on API:
> username=myuser, password=
> reviewboard-reviewboard-1 | 2023-11-03 01:34:02,538 - DEBUG - -
> reviewboard.diffviewer.parser - GitDiffParser.parse_diff: Beginning parse
> of diff, size = 3311
> reviewboard-reviewboard-1 | 2023-11-03 01:34:02,539 - DEBUG - -
> reviewboard.diffviewer.parser - GitDiffParser.parse_diff: Finished parsing
> diff.
> reviewboard-reviewboard-1 | [2023-11-03 01:34:02 +] [16] [DEBUG]
> Closing connection.
> reviewboard-nginx-1 | 172.28.0.1 - myuser[03/Nov/2023:01:34:02 +]
> "POST /review/api/validation/commits/ HTTP/1.1" 200 564 "-" "RBTools/4.1"
> "10.73.8.104"
> reviewboard-reviewboard-1 | [2023-11-03 01:34:02 +] [15] [DEBUG] POST
> /review/api/validation/commits/
> reviewboard-reviewboard-1 | Unauthorized: /review/api/validation/commits/
> reviewboard-reviewboard-1 | 2023-11-03 01:34:02,581 - WARNING - None -
> AnonymousUser - /review/api/validation/commits/ - django.request -
> Unauthorized: /review/api/validation/commits/
> reviewboard-reviewboard-1 | [2023-11-03 01:34:02 +] [15] [DEBUG]
> Closing connection.
> reviewboard-nginx-1 | 172.28.0.1 - - [03/Nov/2023:01:34:02 +] "POST
> /review/api/validation/commits/ HTTP/1.1" 401 100 "-" "RBTools/4.1"
> "10.73.8.104"
>
> If I parse this properly, it accepts my credentials, uploads the diff to
> he validation endpoint, but then fails the authentication on the following
> request?  I am not sure how to proceed from here.
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/reviewboard/c48cff66-3203-4494-9407-a8a41368387an%40googlegroups.com
> 
> .
>


-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

--

Issues configuring ReviewBoard with local git repos

2023-11-02 Thread geof...@gmail.com

We are trying to do an evaluation of ReviewBoard.
I have setup ReviewBoard via the Docker container, wih SSL termination 
through a reverse proxy.  the website seems to work fine, and direct 
queries to the API via curl work fine.  I am able to use 'rbt setup-repo' 
to configure a repo.

However, when I run 'rbt post --username myuser --password mypassword', I 
get:

Validating commits... █   
 [1/4]
ERROR: Error validating diff

You are not logged in (API Error 103: Not Logged In)

The logs show:

reviewboard-reviewboard-1 | 2023-11-03 01:34:02,149 - ERROR - None - 
AnonymousUser - /review/api/repositories/1/info/ - django.request - Not 
Implemented: /review/api/repositories/1/info/
reviewboard-nginx-1 | 172.28.0.1 - - [03/Nov/2023:01:34:02 +] "GET 
/review/api/repositories/1/info/ HTTP/1.1" 501 153 "-" "RBTools/4.1" 
"10.73.8.104"
reviewboard-reviewboard-1 | [2023-11-03 01:34:02 +] [16] [DEBUG] 
Closing connection.
reviewboard-reviewboard-1 | [2023-11-03 01:34:02 +] [16] [DEBUG] GET 
/review/api/validation/commits/
reviewboard-nginx-1 | 172.28.0.1 - - [03/Nov/2023:01:34:02 +] "GET 
/review/api/validation/commits/ HTTP/1.1" 304 0 "-" "RBTools/4.1" 
"10.73.8.104"
reviewboard-reviewboard-1 | [2023-11-03 01:34:02 +] [16] [DEBUG] 
Closing connection.
reviewboard-reviewboard-1 | [2023-11-03 01:34:02 +] [16] [DEBUG] POST 
/review/api/validation/commits/
reviewboard-reviewboard-1 | Unauthorized: /review/api/validation/commits/
reviewboard-reviewboard-1 | 2023-11-03 01:34:02,407 - WARNING - None - 
AnonymousUser - /review/api/validation/commits/ - django.request - 
Unauthorized: /review/api/validation/commits/
reviewboard-reviewboard-1 | [2023-11-03 01:34:02 +] [16] [DEBUG] 
Closing connection.
reviewboard-nginx-1 | 172.28.0.1 - - [03/Nov/2023:01:34:02 +] "POST 
/review/api/validation/commits/ HTTP/1.1" 401 100 "-" "RBTools/4.1" 
"10.73.8.104"
reviewboard-reviewboard-1 | [2023-11-03 01:34:02 +] [16] [DEBUG] POST 
/review/api/validation/commits/
reviewboard-reviewboard-1 | 2023-11-03 01:34:02,431 - DEBUG - None - 
AnonymousUser - /review/api/validation/commits/ - 
djblets.webapi.auth.backends.base - Attempting authentication on API: 
username=myuser, password=
reviewboard-reviewboard-1 | 2023-11-03 01:34:02,538 - DEBUG - - 
reviewboard.diffviewer.parser - GitDiffParser.parse_diff: Beginning parse 
of diff, size = 3311
reviewboard-reviewboard-1 | 2023-11-03 01:34:02,539 - DEBUG - - 
reviewboard.diffviewer.parser - GitDiffParser.parse_diff: Finished parsing 
diff.
reviewboard-reviewboard-1 | [2023-11-03 01:34:02 +] [16] [DEBUG] 
Closing connection.
reviewboard-nginx-1 | 172.28.0.1 - myuser[03/Nov/2023:01:34:02 +] "POST 
/review/api/validation/commits/ HTTP/1.1" 200 564 "-" "RBTools/4.1" 
"10.73.8.104"
reviewboard-reviewboard-1 | [2023-11-03 01:34:02 +] [15] [DEBUG] POST 
/review/api/validation/commits/
reviewboard-reviewboard-1 | Unauthorized: /review/api/validation/commits/
reviewboard-reviewboard-1 | 2023-11-03 01:34:02,581 - WARNING - None - 
AnonymousUser - /review/api/validation/commits/ - django.request - 
Unauthorized: /review/api/validation/commits/
reviewboard-reviewboard-1 | [2023-11-03 01:34:02 +] [15] [DEBUG] 
Closing connection.
reviewboard-nginx-1 | 172.28.0.1 - - [03/Nov/2023:01:34:02 +] "POST 
/review/api/validation/commits/ HTTP/1.1" 401 100 "-" "RBTools/4.1" 
"10.73.8.104"

If I parse this properly, it accepts my credentials, uploads the diff to he 
validation endpoint, but then fails the authentication on the following 
request?  I am not sure how to proceed from here.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/c48cff66-3203-4494-9407-a8a41368387an%40googlegroups.com.

Re: ReviewBoard upgrade database migration issue

2023-11-02 Thread Christian Hammond

Hi,

You'll need to make sure that you have completely wiped the new database
before importing the old database in. If there's any Review Board 5 schema
still sitting around when importing Review Board 3, it will fail. You'll
want to fully re-create the database prior to import.

The error message unfortunately isn't very helpful, and I'm not sure what's
going on there, but there should be errors following that.

Worth noting, we never put out a 3.0.19.2 release, so there may be some
in-house customizations involved here that could have affected the upgrade
process. It'd help to know what modifications may have been made internally.

If the above guidance doesn't help you get through the upgrade, we do offer
database repair services as part of a Premium Support contract, where we'll
work with you to resolve any database issues (patching schema or upgrade
state as necessary, or providing custom builds) to get you through the
upgrade and to help address any other issues that come up. Outside of that,
we can't fix any database schema issues, but hopefully the failure is just
due to not re-creating the database prior to import.

Christian

On Thu, Nov 2, 2023 at 2:30 PM From Boston  wrote:

> Hello,
>
> We are currently at Review Board 3.0.19.2. We are trying to update to the
> 5.0.6 version.
>
> We were able to install 5.0.6 and make it work following the instructions.
> Then we dumped MySQL data from 3 to 5.
>
> Then we used 'rb-site upgrade' command to migrate.
> We go following error:
>
> Review Board cannot update your database. There is a discrepancy between
> the state of your database and what Review Board expects.
>
> This could be caused by manual changes to your database schema,
> corruption, an incomplete upgrade, or missing database upgrade history
> (stored in the django_project_version, django_evolution, and
> django_migrations tables).
>
> upon checking the site-upgrade-failure.log, I see this error:
>
> Database upgrade failure log
> Time: 2023-11-02 21:09:17.700299 UTC
>
> Database
> 
>
> !! Failed to fetch connection params: '<' not supported between instances
> of 'type' and 'type'
>
> I would appreciate any help. I really appreciate any help you can provide.
>
> Thanks
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/reviewboard/1e626ce7-6e28-4364-94e8-beb36069e508n%40googlegroups.com
> 
> .
>

-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/CAE7Vndm-FvO4D%2BWsGrTmLh10Dp8JLfRNNqv77j18GH402c8Cfw%40mail.gmail.com.

ReviewBoard upgrade database migration issue

2023-11-02 Thread From Boston

Hello,

We are currently at Review Board 3.0.19.2. We are trying to update to the 
5.0.6 version.

We were able to install 5.0.6 and make it work following the instructions.
Then we dumped MySQL data from 3 to 5.

Then we used 'rb-site upgrade' command to migrate.
We go following error:

Review Board cannot update your database. There is a discrepancy between 
the state of your database and what Review Board expects.

This could be caused by manual changes to your database schema, 
corruption, an incomplete upgrade, or missing database upgrade history 
(stored in the django_project_version, django_evolution, and
django_migrations tables).

upon checking the site-upgrade-failure.log, I see this error:

Database upgrade failure log
Time: 2023-11-02 21:09:17.700299 UTC

Database


!! Failed to fetch connection params: '<' not supported between instances 
of 'type' and 'type'

I would appreciate any help. I really appreciate any help you can provide.

Thanks

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/1e626ce7-6e28-4364-94e8-beb36069e508n%40googlegroups.com.

Re: How to install ReviewBoard from github source code?

2023-11-02 Thread David Trowbridge

Hi,

We do have a guide for this at
https://www.notion.so/reviewboard/Getting-Started-da208d46de1d47d8b38e8b5ddcb3dd44

That said, I highly recommend that you use the extension framework to make
any "adjustments" you need, rather than modify Review Board itself. Custom
patches make it very difficult to perform any upgrades in the future, and
make it hard for us to diagnose or assist with any issues you may
encounter. Documentation for that can be found at
https://www.reviewboard.org/docs/manual/latest/extending/

David

On Thu, Nov 2, 2023 at 9:35 AM Work Bot  wrote:

> Hi David,
>
> I rethink & planned my requirements and I think I do need to build from
> source because I need to work on Review Board itself, adjusting multiple
> things. In that case, can you point me to a place that I can follow to
> build & install from your Review Board source code?
>
> Thanks so much!
>
> On Monday, October 30, 2023 at 7:08:47 PM UTC-4 David Trowbridge wrote:
>
>> You can use pip to install a specific version:
>>
>> pip3 install ReviewBoard==5.0.5
>>
>> Building from source is a much more complicated thing, and would only be
>> necessary if you were working on Review Board itself.
>>
>> David
>>
>> On Mon, Oct 30, 2023 at 5:01 PM Work Bot  wrote:
>>
>>> Yes, I plan to install a specific version of RB (for example 5.0.5)
>>> instead of the latest one. I think I figured out a workaround through
>>> python setup.py file,
>>>
>>> On Thursday, October 12, 2023 at 2:34:15 PM UTC-4 David Trowbridge wrote:
>>>
 Hi,

 Is there a reason why you're looking to install from the git repository
 instead of the published releases? The install documentation you linked to
 should be the correct process for most people.

 David

 On Thu, Oct 12, 2023 at 12:30 PM Work Bot  wrote:

> Hi,
>
> I am trying to find instructions to install ReviewBoard 5 on a Linux
> machine through source code. For instance, I want to clone/download
> ReviewBoard from following links:
> - GitHub - reviewboard/reviewboard: An extensible and friendly code
> review tool for projects and companies of all sizes.
> 
> - Index of /releases/ReviewBoard/5.0/
> 
> and install them accordingly.
>
> However, I can only find this (Installing on Linux | Review Board
> latest Documentation | Review Board
> )
> instruction which tells me to install through "*pip3 install
> ReviewBoard"*.
>
> Are there any other more information that can help me success the
> installation process? Thanks!
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google
> Groups "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to reviewboard...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/reviewboard/b2f3368c-b97b-4993-9949-01e6ee847e8fn%40googlegroups.com
> 
> .
>
 --
>>> Supercharge your Review Board with Power Pack:
>>> https://www.reviewboard.org/powerpack/
>>> Want us to host Review Board for you? Check out RBCommons:
>>> https://rbcommons.com/
>>> Happy user? Let us know! https://www.reviewboard.org/users/
>>> ---
>>> You received this message because you are subscribed to the Google
>>> Groups "Review Board Community" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to reviewboard...@googlegroups.com.
>>>
>> To view this discussion on the web visit
>>> https://groups.google.com/d/msgid/reviewboard/b28408e0-b4f1-4950-8745-2abe7e6fe780n%40googlegroups.com
>>> 
>>> .
>>>
>> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
>

Re: Review Board Ticket #5012: requests to /api/... do not use public server name but private IP address

2023-11-02 Thread Heroic Albeit

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/5012/
--

New update by HeroicAlbeit
For Beanbag, Inc. > Review Board > Ticket #5012


Reply:

to get some more insight and rule out the browser I use curl to do the 
above failed request with correct ``.

what I get is a JSON body that contains (many) wrong URLs with 
`http://` like so:

```
$ curl -H 'cookie: csrftoken=; rbsessionid;' 
'https:///api/review-requests/3/draft/?api_format=json=html=raw=depends_on%2Ctarget_people%2Ctarget_groups'
{"draft": {"branch": "", "bugs_closed": [], "changedescription": "", 
"changedescription_text_type": "html", "commit_id": null, "depends_on": [], 
"description": "", "description_text_type": "html", "extra_data": {}, "id": 3, 
"last_updated": "2023-11-02T07:22:25Z", "links": {"delete": {"href": 
"http:///api/review-requests/3/draft/", "method": 
"DELETE"} ... "submitter": {"href": "http:///api/users/admin/", "method": "GET", "title": "admin"} ...
```

looks like the `/api/` part is not using the configured server name?

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard-issues/20231102174528.23595.23908%40ip-10-1-54-209.ec2.internal.

Re: How to install ReviewBoard from github source code?

2023-11-02 Thread Work Bot

Thanks! I will spend some time on these two docs.

On Thursday, November 2, 2023 at 11:54:58 AM UTC-4 David Trowbridge wrote:

> Hi,
>
> We do have a guide for this at 
> https://www.notion.so/reviewboard/Getting-Started-da208d46de1d47d8b38e8b5ddcb3dd44
>
> That said, I highly recommend that you use the extension framework to make 
> any "adjustments" you need, rather than modify Review Board itself. Custom 
> patches make it very difficult to perform any upgrades in the future, and 
> make it hard for us to diagnose or assist with any issues you may 
> encounter. Documentation for that can be found at 
> https://www.reviewboard.org/docs/manual/latest/extending/
>
> David
>
> On Thu, Nov 2, 2023 at 9:35 AM Work Bot  wrote:
>
>> Hi David,
>>
>> I rethink & planned my requirements and I think I do need to build from 
>> source because I need to work on Review Board itself, adjusting multiple 
>> things. In that case, can you point me to a place that I can follow to 
>> build & install from your Review Board source code?
>>
>> Thanks so much!
>>
>> On Monday, October 30, 2023 at 7:08:47 PM UTC-4 David Trowbridge wrote:
>>
>>> You can use pip to install a specific version:
>>>
>>> pip3 install ReviewBoard==5.0.5
>>>
>>> Building from source is a much more complicated thing, and would only be 
>>> necessary if you were working on Review Board itself.
>>>
>>> David
>>>
>>> On Mon, Oct 30, 2023 at 5:01 PM Work Bot  wrote:
>>>
 Yes, I plan to install a specific version of RB (for example 5.0.5) 
 instead of the latest one. I think I figured out a workaround through 
 python setup.py file,

 On Thursday, October 12, 2023 at 2:34:15 PM UTC-4 David Trowbridge 
 wrote:

> Hi,
>
> Is there a reason why you're looking to install from the git 
> repository instead of the published releases? The install documentation 
> you 
> linked to should be the correct process for most people.
>
> David
>
> On Thu, Oct 12, 2023 at 12:30 PM Work Bot  
> wrote:
>
>> Hi, 
>>
>> I am trying to find instructions to install ReviewBoard 5 on a Linux 
>> machine through source code. For instance, I want to clone/download 
>> ReviewBoard from following links: 
>> - GitHub - reviewboard/reviewboard: An extensible and friendly code 
>> review tool for projects and companies of all sizes. 
>> 
>> - Index of /releases/ReviewBoard/5.0/ 
>> 
>> and install them accordingly.
>>
>> However, I can only find this (Installing on Linux | Review Board 
>> latest Documentation | Review Board 
>> )
>>  
>> instruction which tells me to install through "*pip3 install 
>> ReviewBoard"*.
>>
>> Are there any other more information that can help me success the 
>> installation process? Thanks!
>>
>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google 
>> Groups "Review Board Community" group.
>> To unsubscribe from this group and stop receiving emails from it, 
>> send an email to reviewboard...@googlegroups.com.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/reviewboard/b2f3368c-b97b-4993-9949-01e6ee847e8fn%40googlegroups.com
>>  
>> 
>> .
>>
> -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google 
 Groups "Review Board Community" group.
 To unsubscribe from this group and stop receiving emails from it, send 
 an email to reviewboard...@googlegroups.com.

>>> To view this discussion on the web visit 
 https://groups.google.com/d/msgid/reviewboard/b28408e0-b4f1-4950-8745-2abe7e6fe780n%40googlegroups.com
  
 
 .

>>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know!

Re: How to install ReviewBoard from github source code?

2023-11-02 Thread Work Bot

Hi David,

I rethink & planned my requirements and I think I do need to build from 
source because I need to work on Review Board itself, adjusting multiple 
things. In that case, can you point me to a place that I can follow to 
build & install from your Review Board source code?

Thanks so much!

On Monday, October 30, 2023 at 7:08:47 PM UTC-4 David Trowbridge wrote:

> You can use pip to install a specific version:
>
> pip3 install ReviewBoard==5.0.5
>
> Building from source is a much more complicated thing, and would only be 
> necessary if you were working on Review Board itself.
>
> David
>
> On Mon, Oct 30, 2023 at 5:01 PM Work Bot  wrote:
>
>> Yes, I plan to install a specific version of RB (for example 5.0.5) 
>> instead of the latest one. I think I figured out a workaround through 
>> python setup.py file,
>>
>> On Thursday, October 12, 2023 at 2:34:15 PM UTC-4 David Trowbridge wrote:
>>
>>> Hi,
>>>
>>> Is there a reason why you're looking to install from the git repository 
>>> instead of the published releases? The install documentation you linked to 
>>> should be the correct process for most people.
>>>
>>> David
>>>
>>> On Thu, Oct 12, 2023 at 12:30 PM Work Bot  wrote:
>>>
 Hi, 

 I am trying to find instructions to install ReviewBoard 5 on a Linux 
 machine through source code. For instance, I want to clone/download 
 ReviewBoard from following links: 
 - GitHub - reviewboard/reviewboard: An extensible and friendly code 
 review tool for projects and companies of all sizes. 
 
 - Index of /releases/ReviewBoard/5.0/ 
 
 and install them accordingly.

 However, I can only find this (Installing on Linux | Review Board 
 latest Documentation | Review Board 
 )
  
 instruction which tells me to install through "*pip3 install 
 ReviewBoard"*.

 Are there any other more information that can help me success the 
 installation process? Thanks!

 -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google 
 Groups "Review Board Community" group.
 To unsubscribe from this group and stop receiving emails from it, send 
 an email to reviewboard...@googlegroups.com.
 To view this discussion on the web visit 
 https://groups.google.com/d/msgid/reviewboard/b2f3368c-b97b-4993-9949-01e6ee847e8fn%40googlegroups.com
  
 
 .

>>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "Review Board Community" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com.
>>
> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/reviewboard/b28408e0-b4f1-4950-8745-2abe7e6fe780n%40googlegroups.com
>>  
>> 
>> .
>>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/25138e50-89a4-4320-a3ec-619e83038724n%40googlegroups.com.

Review Board Ticket #5012: requests to /api/... do not use public server name but private IP address

2023-11-02 Thread Heroic Albeit

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/5012/
--

New ticket #5012 by HeroicAlbeit
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect

--
requests to /api/... do not use public server name but private IP address
==

# What version are you running?

6.0

in docker image 45ada0a9f402

this is a new setup with the nginx+gunicorn setup method and a "API Gateway" on
Oracle Cloud in front of the nginx port.

The "API Gateway" is setup to route `https:///`
to `http://:8080/`, where 8080 is the exposed
nginx port. This works, as I can login.

# What's the URL of the page containing the problem?

`https:///r/3/`

this page shows up, but the "Diff" tab is missing and I am unable to change
fields of this request, such as Summary or Description.

Using Debug Console of the browser reveals an error, see below.

# What steps will reproduce the problem?
1. create a new review request, ie. by uploading a patch
2. browse the request
3. not the missing Diff tab
4. inspect browser debug console

# What is the expected output? What do you see instead?

the Diff tab would be there

editing Fields such as Summary would work

no errors in browser console

# What operating system are you using? What browser?

the instance uses Ubuntu 22.04.3 LTS on ARM processor

however, Reviewboard itself runs as above mentioned Docker image, pulling the
ARM sha256.

# Please provide any additional information below.

the error on debug console is this:

```
3rdparty-base.min.js:1 Mixed Content: The page at 'https:///r/3/' was loaded over HTTPS, but requested an insecure XMLHttpRequest
endpoint 'http:///api/review-requests/3/draft/?api_format=json=html=raw=depends_on%2Ctarget_people%2Ctarget_groups'.
This request has been blocked; the content must be served over HTTPS.
```

this is absolutely correct and can not work, even if the browser would not
block it, since `` is not routed on the internet.

also note that port 8080 is missing in ``; this tells me
the API Gateway is not involved as it is setup to always send to this port.

looking at the Network tab in the browser debug tool shows a Request Initiator
chain looking like this:

1. `https:///r/3/`
2. `https:///static/lib/js/3rdparty-base.min.js`
3. `http:///api/review-requests/3/draft/?api_format=json=html=raw=depends_on%2Ctarget_people%2Ctarget_groups`

the Request call stack for this is rather long and I can't copy-paste it.

the nginx.conf setup follows the Admin Manual, with the essential part being:
```
location / {
proxy_pass http://reviewboard;
proxy_redirect off;
proxy_set_header Host $host;
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
proxy_set_header X-Forwarded-Port $server_port;
proxy_set_header X-Forwarded-Proto $scheme;
proxy_set_header X-Forwarded-Ssl off;
proxy_set_header X-Real-IP $remote_addr;

client_max_body_size10m;
client_body_buffer_size 128k;
proxy_connect_timeout 90;
proxy_send_timeout 90;
proxy_read_timeout 90;
proxy_headers_hash_max_size 512;
proxy_buffer_size 4k;
proxy_buffers 4 32k;
proxy_busy_buffers_size 64k;
proxy_temp_file_write_size 64k;
}
```

This handles login/logout and many other things such as configuring, while some
(?) `/api/` requests dont ever reach this nginx since the browser gets told to
send these using the ``.

The Server name in General Settings is correctly set to ``
- I guess login would not be impossible otherwise.

--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/reviewboard-issues/20231102142420.23594.27586%40ip-10-1-54-209.ec2.internal.

Re: The Python module "subvertpy" is not installed.

2023-11-02 Thread Christian Hammond

I’m so sorry for the lack of response. We do have a Premium Support forum
for support contract customers, where we’re a bit more hands-on with
complex issues, and have been pretty busy there these past few weeks.

It looks like the install was successful, so I’m not entirely sure what may
be going wrong. It still sounds like it’s not being used for some reason.
Are there any Apache or Review Board server logs that reference PySVN in
any way?

Bitnami’s environment is a bit custom, and we don’t have much insight into
how it chooses to do things.

As a check, can you look for the settings_local.py file and just make sure
it doesn’t reference subvertpy in any way?

Christian

-- 
Christian Hammond
President/CEO of Beanbag
Makers of Review Board


On Wed, Nov 1, 2023 at 11:50 JC Anderson  wrote:

> Is there a better forum for discussing installation issues?
>
> Thanks
> Chris
>
> On Monday, October 30, 2023 at 1:45:46 PM UTC-5 JC Anderson wrote:
>
>> I must be installing it wrong.  Does the install process I did look ok?
>>
>> Thanks
>> Chris
>>
>> On Thursday, October 26, 2023 at 1:29:39 PM UTC-5 JC Anderson wrote:
>>
>>> root@debian:/opt/bitnami# source
>>> /opt/bitnami/reviewboard/venv/bin/activate
>>> (venv) root@debian:/opt/bitnami# python /opt/bitnami/pysvn_install.py
>>> Looking up latest PySVN version...
>>> Downloading PySVN 1.9.20...
>>> Building PySVN...
>>> Processing /tmp/tmpmqdhm70x.pysvn-install/pysvn-1.9.20
>>>   Preparing metadata (setup.py) ... done
>>> Building wheels for collected packages: pysvn
>>>   Building wheel for pysvn (setup.py) ... done
>>>   Created wheel for pysvn:
>>> filename=pysvn-1.9.20-cp38-cp38-linux_x86_64.whl size=736343
>>> sha256=6cc30b8cc648896617273a767a69a7286f5a18c75bb1a662072a1d3a5567e1d6
>>>   Stored in directory:
>>> /root/.cache/pip/wheels/89/4a/32/870d0959e91d5f2c0b06836f41dc5fad01782ecf05ac85aa68
>>> Successfully built pysvn
>>> Installing collected packages: pysvn
>>>   Attempting uninstall: pysvn
>>> Found existing installation: pysvn 1.9.20
>>> Uninstalling pysvn-1.9.20:
>>>   Successfully uninstalled pysvn-1.9.20
>>> Successfully installed pysvn-1.9.20
>>>
>>> [notice] A new release of pip is available: 23.2.1 -> 23.3.1
>>> [notice] To update, run: pip install --upgrade pip
>>>
>>> PySVN is installed.
>>> (venv) root@debian:/opt/bitnami# bash ctlscript.sh restart
>>> restarting services...
>>> (venv) root@debian:/opt/bitnami#
>>>
>>> On Wednesday, October 25, 2023 at 10:29:02 PM UTC-5 Christian Hammond
>>> wrote:
>>>
 Hi Chris,

 That error is confusing and we've fixed it for Review Board 6 (by
 removing Subvertpy support — that project is barely maintained anymore).
 It's only mentioning Subvertpy because it was the last installed SVN
 implementation it tried to scan for.

 If you're getting that error, then PySVN didn't actually install, or
 install into the right Python environment. Can you show me how you tried
 installing it in Bitnami?

 I'd have expected Bitnami to have had this installed by default.

 Christian


 On Tue, Oct 24, 2023 at 11:53 AM JC Anderson 
 wrote:

> I'm new to the ReviewBoard community.
> I'm trying to get the Bitnami Debian vm version (5.0.6) up and running
> for subversion.
> I've installed pysvn using the RB install script and restarted the vm.
> Trying to add a svn repo gives me this error:
>
> *The Python module "subvertpy" is not installed. You may need to
> restart the server after installing it.*
>
> Any ideas on how to troubleshoot?
>
> Thanks
> Chris
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google
> Groups "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to reviewboard...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/reviewboard/13c0d007-121a-4dda-8f52-87a97508f573n%40googlegroups.com
> 
> .
>


 --
 Christian Hammond
 President/CEO of Beanbag 
 Makers of Review Board 

>>> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "Review Board

Re: Unable to add Trello integration

Re: RB v6 "The following reviews are not valid []" when clicking "Publish"

Re: Issues configuring ReviewBoard with local git repos

Issues configuring ReviewBoard with local git repos

Re: ReviewBoard upgrade database migration issue

ReviewBoard upgrade database migration issue

Re: How to install ReviewBoard from github source code?

Re: Review Board Ticket #5012: requests to /api/... do not use public server name but private IP address

Re: How to install ReviewBoard from github source code?

Re: How to install ReviewBoard from github source code?

Review Board Ticket #5012: requests to /api/... do not use public server name but private IP address

Re: The Python module "subvertpy" is not installed.

12 matches

Site Navigation

Mail list logo

Footer information