Re: Is Review Board mostly useful in offline code review?

2011-09-29 Thread Jeff Andros
This is how we started using reviewboard: we would use it more as meeting notes during a conference room code review. We progressed through that by everyone reviewing the code and leaving notes, then meeting in the conference room to go over them, but dropped the face to face part shortly

Re: Installing ReviewBoard in Ubuntu 10.04

2010-09-07 Thread Jeff Andros
You've tried following the steps here? http://www.reviewboard.org/docs/manual/dev/admin/installation/linux/ http://www.reviewboard.org/docs/manual/dev/admin/installation/linux/I don't know that there's anything different enough in Ubuntu 10.4 that would make these instructions not work. --Jeff

Re: Multiple diffs in the same review request

2010-05-07 Thread Jeff Andros
How is this different from the update diff option that's currently there? On Fri, May 7, 2010 at 5:00 PM, Andrew aschwa...@gmail.com wrote: Hi guys. I've been playing with the multiple revisions support in ReviewBoard. I was wondering what people think about these two suggestions: 1. It

Re: What does ship it and starred review request mean?

2010-01-21 Thread Jeff Andros
We use Ship it is a marker from the reviewers that they believe the code is ready to be committed (shipping the changed code, as in to customers) Some times the reviewer will want the original author to make the changes, and re-post the code (if the changes are sufficiently minor, we normally skip

Re: Love Dont Cost a Thing clip

2010-01-18 Thread Jeff Andros
I thought these were moderated now? On Mon, Jan 18, 2010 at 6:12 AM, Press Centre sybleheb...@gmail.com wrote: Love Don't Cost a Thing clip special edition with Naked Jennifer Lopez! Just look! http://duuit.com/-jenifer -- Want to help the Review Board project? Donate today at

Re: Error 500 Logging on New Review Request

2009-08-03 Thread Jeff Andros
I don't remember exactly how to set I up, but there's an additional logging switch in reviewboard, I don't know if it'll help, but I know christian has mentioned it a few times. You can check the list archive for how to set this, or christian normally responds about 1pm PDT. Hth,

Re: Error 500 Logging on New Review Request

2009-08-03 Thread Jeff Andros
, Aug 3, 2009 at 1:13 PM, Jeff Andros j...@bigredtj.com wrote: I don't remember exactly how to set I up, but there's an additional logging switch in reviewboard, I don't know if it'll help, but I know christian has mentioned it a few times. You can check the list archive for how to set

Re: backup and restore SQLite DB

2009-07-16 Thread Jeff Andros
not to be a pain, but does the web user also have write access to the directory that the SQLite file resides in? it needs to create a couple of temp files in that directory for indices and such. --Jeff 2009/7/16 Pravin Nadarajoo ramp...@gmail.com Hi there, I've just installed the new stable

Re: backup and restore SQLite DB

2009-07-16 Thread Jeff Andros
and restore SQLite DB Thanks for your reply Jeff. I left the permissions of the DB file as 644. Will just try 777 for now and see what happens. Will write here again. Thanks Pravin On Jul 17, 2:21 am, Jeff Andros j...@bigredtj.com wrote: not to be a pain, but does the web user also have write

Re: stuck with install/config

2009-07-01 Thread Jeff Andros
You sound pretty new to debian style apache management, so here goes. Yeah, you'll either need to shut off the default site, or configure reviewboard as a vhost. Shutting off default is probably the easiest. You shouldn't have to remove it, there's a management script that will do that for

Re: What functionality does the Subversion repo connection provide in RB?

2009-07-01 Thread Jeff Andros
Reviewboard displays the files in a two column view. It pulls the base file from the repo, displays that on the left column, applies the diff, then displays the results on the right column. This way you've got the entire file to look over as you're reviewing it, not just the parts that have

Re: rb-site install - Review Board is taking a nap

2009-06-25 Thread Jeff Andros
I've yet to do an install like that, and someone else may correct me, but normally that message means that the apache user does not have write access to bothr the sqlite file and the folder that contains it. Try tracking that down and changing the permissions/owner. --Jeff 2009/6/25 Eric P

Re: ReviewBoard General Inquiries

2009-05-25 Thread Jeff Andros
I'm not really sure why this is an issue, but all uploads to reviewboard are via diff. If you use the post-review tool, you never have to see/touch/smell the diff at all, you just deal with the review, and your VCS's revision specs. Even though you're uploading a diff, reviewboard goes out to

Re: Using the demo

2009-02-17 Thread Jeff Andros
diff headers for reviewboard are a bit different... the server needs to know not only the path to the file, but also the revision it was generated from... that's how it looks up the base code. as I understand it, svn diff might give you the right headers, but I'm not sure... we use p4.

Re: Newbie question: setup problems

2009-01-08 Thread Jeff Andros
I had this problem too... make sure your web user has permissions not only on the sqlite file, but on the directory it resides in as well. Jeff O|||O 2009/1/8 Chris Clark chris.cl...@ingres.com Phil wrote: .Sqlite3 is complaining that it cannot open the database file.

Re: diff view - looking to do full file reviews not a diff between two version

2008-10-16 Thread Jeff Andros
--Christian or Dave-- as an enhancement, how hard would it be to set auto expand as either a user or global setting? Jeff O|||O Help me and the Leukemia and Lymphoma society fight blood cancers: http://pages.teamintraining.org/dm/tucson08/jandros On Thu, Oct 16, 2008 at 10:17 AM, Jeff Andros [EMAIL

Re: diff view - looking to do full file reviews not a diff between two version

2008-10-16 Thread Jeff Andros
There are two ways to do this: 1. if you manually diff your current file against a file that doesn't exist (there may be a flag you need to set on your diff program), it will generate a diff against a new file, then you just need to adjust the diff header to make it right... we've got a simple