Re: RBTools Ticket #4819: "rbt post" is broken (will not accept Perforce changelist number) in 1.0.2 under Python 3.7.3
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4819/ -- New update by c0d3h4x0r For Beanbag, Inc. > RBTools > Ticket #4819 Reply: My employer's "get off of Python 2.7" initiative is still blocked by the inability of the latest publicly-available version of rbtools to work under Python 3.7.3. When will a new public release finally be issued so that we can safely pick up the fix for this? -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20191107191436.4961.15879%40ip-10-1-54-209.ec2.internal.
Re: RBTools Ticket #4819: "rbt post" is broken (will not accept Perforce changelist number) in 1.0.2 under Python 3.7.3
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4819/ -- New update by c0d3h4x0r For Beanbag, Inc. > RBTools > Ticket #4819 Reply: Awesome chipx86, thank you! Is there a way I can be notified when the next release (containing this fix) is officially available? -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20190822002620.3380.8481%40ip-10-1-54-209.ec2.internal.
Re: RBTools Ticket #4819: "rbt post" is broken (will not accept Perforce changelist number) in 1.0.2 under Python 3.7.3
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4819/ -- New update by c0d3h4x0r For Beanbag, Inc. > RBTools > Ticket #4819 Reply: This issue has been tagged "NeedInfo" for a long time now. What additional information is actually needed? You should have all the information you need to repro this and work on fixing it. This is blocking Python migration work at my company because we can't remove obsolete versions of Python from our engineering workstations due to `rbt` still not working correctly with the latest version of Python. Please treat this issue as ultra-high priority, especially given the impending Python 2.7.x end-of-life date rapidly approaching on 1/1/2020. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20190820174941.8159.23388%40ip-10-1-54-209.ec2.internal.
RBTools Ticket #4819: "rbt post" is broken (will not accept Perforce changelist number) in 1.0.2 under Python 3.7.3
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4819/ -- New ticket #4819 by c0d3h4x0r For Beanbag, Inc. > RBTools Status: New Tags: Priority:Medium, Type:Defect -- "rbt post" is broken (will not accept Perforce changelist number) in 1.0.2 under Python 3.7.3 == # What version are you running? RBTools==1.0.2 # What steps will reproduce the problem? 1. Locally apply the code fix I described in ticket 4818. 2. cd into the root of an existing Perforce workspace with a file opened for "p4 edit" under a numbered CL. 3. rbt post # What is the expected output? What do you see instead? Expected: It should work. Actual: ``` CRITICAL: Path 1802276 does not match a valid Perforce path. ``` # What operating system are you using? Windows 10 Enterprise 64-bit # Attach the debug out from the command. ``` >>> RBTools 1.0.2 >>> Python 3.7.3 (v3.7.3:ef4ec6ed12, Mar 25 2019, 22:22:05) [MSC v.1916 64 bit >>> (AMD64)] >>> Running on Windows-10-10.0.16299-SP0 >>> Home = C:\Users\kkelly\AppData\Roaming >>> Current directory = D:\p4\depot\teams\near >>> Command line: rbt post --debug 1802276 >>> Running: tf vc help >>> Checking for a Bazaar repository... >>> Unable to execute "bzr help": skipping Bazaar >>> Checking for a ClearCase repository... >>> Unable to execute "cleartool help": skipping ClearCase >>> Checking for a CVS repository... >>> Unable to execute "cvs": skipping CVS >>> Checking for a Git repository... >>> Running: git rev-parse --git-dir >>> Command exited with rc 128: ['git', 'rev-parse', '--git-dir'] fatal: not a git repository (or any of the parent directories): .git --- >>> Checking for a Mercurial repository... >>> Unable to execute "hg --help": skipping Mercurial >>> Checking for a Perforce repository... >>> Running: p4 info >>> Running: diff --version >>> Repository info: Path: dvp4edgepl009.tsi.lan:1666, Base path: None, >>> Supports changesets: True >>> Checking for a Plastic repository... >>> Unable to execute "cm version": skipping Plastic >>> Checking for a Subversion repository... >>> Running: svn --non-interactive info >>> Command exited with rc 1: ['svn', '--non-interactive', 'info'] >>> Checking for a Team Foundation Server repository... >>> Unable to execute "tf help": skipping TFS >>> Making HTTP GET request to http://reviewboard/api/ >>> Running: p4 info Traceback (most recent call last): File "c:\python37\lib\runpy.py", line 193, in _run_module_as_main "__main__", mod_spec) File "c:\python37\lib\runpy.py", line 85, in _run_code exec(code, run_globals) File "C:\Python37\Scripts\rbt.exe__main__.py", line 9, in File "c:\python37\lib\site-packages\rbtools\commands\main.py", line 120, in main command.run_from_argv([RB_MAIN, command_name] + args) File "c:\python37\lib\site-packages\rbtools\commands__init__.py", line 725, in run_from_argv exit_code = self.main(*args) or 0 File "c:\python37\lib\site-packages\rbtools\commands\post.py", line 806, in main extra_args=extra_args) File "c:\python37\lib\site-packages\rbtools\clients\perforce.py", line 729, in diff return self._path_diff(extra_args, exclude_patterns) File "c:\python37\lib\site-packages\rbtools\clients\perforce.py", line 1470, in _path_diff % path) rbtools.clients.errors.SCMError: Path 1802276 does not match a valid Perforce path. ``` # Please provide any additional information below. I tried upgrading my p4.exe command-line client to the latest (Rev. P4/NTX64/2019.1/1796703 (2019/04/30)), but that did not help. -- -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
RBTools Ticket #4818: "rbt post" fails with TypeError under Python 3.7.3 on Windows 10 x64
--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4818/
--
New ticket #4818 by c0d3h4x0r
For Beanbag, Inc. > RBTools
Status: New
Tags: Priority:Medium, Type:Defect
--
"rbt post" fails with TypeError under Python 3.7.3 on Windows 10 x64
==
# What version are you running?
RBTools==1.0.2
# What steps will reproduce the problem?
1. Install 32-bit Python 3.7.3 on Windows 10 x64.
2. pip install rbtools==1.0.2
3.
3. rbt post default
# What is the expected output? What do you see instead?
Expected: it should just work.
Actual:
ERROR: Could not load SCM Client "tfs"
Traceback (most recent call last):
File "c:\python37\lib\site-packages\rbtools\clients__init__.py", line 736, in
load_scmclients
client = ep.load()(config=config, options=options)
File "c:\python37\lib\site-packages\rbtools\clients\tfs.py", line 979, in
__init__
none_on_ignored_error=True)
File "c:\python37\lib\site-packages\rbtools\utils\process.py", line 145, in
execute
for key, value in six.iteritems(new_env)
File "c:\python37\lib\site-packages\rbtools\utils\process.py", line 145, in
for key, value in six.iteritems(new_env)
TypeError: string argument without an encoding
CRITICAL: string argument without an encoding
# What operating system are you using?
Windows 10 Enterprise 64-bit
# Attach the debug out from the command.
```
>>> RBTools 1.0.2
>>> Python 3.7.3 (v3.7.3:ef4ec6ed12, Mar 25 2019, 22:22:05) [MSC v.1916 64 bit
>>> (AMD64)]
>>> Running on Windows-10-10.0.16299-SP0
>>> Home = C:\Users\kkelly\AppData\Roaming
>>> Current directory = D:\p4\depot\teams\near
>>> Command line: rbt post --debug default
>>> Running: tf vc help
ERROR: Could not load SCM Client "tfs"
Traceback (most recent call last):
File "c:\python37\lib\site-packages\rbtools\clients__init__.py", line 736, in
load_scmclients
client = ep.load()(config=config, options=options)
File "c:\python37\lib\site-packages\rbtools\clients\tfs.py", line 979, in
__init__
none_on_ignored_error=True)
File "c:\python37\lib\site-packages\rbtools\utils\process.py", line 145, in
execute
for key, value in six.iteritems(new_env)
File "c:\python37\lib\site-packages\rbtools\utils\process.py", line 145, in
for key, value in six.iteritems(new_env)
TypeError: string argument without an encoding
>>> Checking for a Bazaar repository...
>>> Unable to execute "bzr help": skipping Bazaar
>>> Checking for a ClearCase repository...
>>> Unable to execute "cleartool help": skipping ClearCase
>>> Checking for a CVS repository...
>>> Unable to execute "cvs": skipping CVS
>>> Checking for a Git repository...
>>> Running: git rev-parse --git-dir
Traceback (most recent call last):
File "c:\python37\lib\runpy.py", line 193, in _run_module_as_main
"__main__", mod_spec)
File "c:\python37\lib\runpy.py", line 85, in _run_code
exec(code, run_globals)
File "C:\Python37\Scripts\rbt.exe__main__.py", line 9, in
File "c:\python37\lib\site-packages\rbtools\commands\main.py", line 120, in
main
command.run_from_argv([RB_MAIN, command_name] + args)
File "c:\python37\lib\site-packages\rbtools\commands__init__.py", line 725,
in run_from_argv
exit_code = self.main(*args) or 0
File "c:\python37\lib\site-packages\rbtools\commands\post.py", line 756, in
main
client_name=self.options.repository_type)
File "c:\python37\lib\site-packages\rbtools\commands__init__.py", line 754,
in initialize_scm_tool
client_name=client_name)
File "c:\python37\lib\site-packages\rbtools\clients__init__.py", line 789, in
scan_usable_client
repository_info = tool.get_repository_info()
File "c:\python37\lib\site-packages\rbtools\clients\git.py", line 250, in
get_repository_info
ignore_errors=True).rstrip('\n')
File "c:\python37\lib\site-packages\rbtools\clients\git.py", line 1225, in
_execute
return execute(cmdline, cwd=self._git_toplevel, *args, **kwargs)
File "c:\python37\lib\site-packages\rbtools\utils\process.py", line 145, in
execute
for key, value in six.iteritems(new_env)
File "c:\python37\lib\site-packages\rbtools\utils\process.py", line 145, in
for key, value in six.iteritems(new_env)
TypeError: string argument without an encoding
```
# Please provide any additional information below.
This looks to be a code defect in rbtools. In
C:\Python37\lib\site-packages\rbtools\utils\process.py, line 144, change the
two usages of "six.binary_type" to "six.text_type" instead, and then this issue
is resolved.
--
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To
