Did this enhancement ever get added or someone start working on it? On Wednesday, February 1, 2012 at 4:44:56 AM UTC-5, Christian Hammond wrote: > > Depending on how you do it, yeah, we'll accept it. Seems like a good > addition. > > What I'd request is that you add new optional functions to the AuthBackend > classes (reviewboard/accounts/backends.py). There should be some function > for requesting an avatar image for a user. Should return a URL and > width/height if available. The default implementation would return the > gravatar. > > The Profile class (accounts/models.py) should have a function for > returning the avatar as HTML. It would talk to the auth backend to get it. > > The HTML would then use this function in the Profile class, instead of > calling into gravatars. > > Then, if the LDAP field for the pictures is in any way standard (not just > specific to your install), the LDAPBackend (and ActiveDirectoryBackend if > relevant?) should return the profile from the server if available, and fall > back to the default implementation otherwise. > > Christian > > -- > Christian Hammond - chi...@chipx86.com <javascript:> > Review Board - http://www.reviewboard.org > VMware, Inc. - http://www.vmware.com > > > 2012/2/1 Michael Zhilin <miz...@gmail.com <javascript:>> > >> Hi, >> >> As I understand it's question of avatar caching. But in our company we >> have another issue in our company. Pictures are stored in LDAP and we have >> plan to develop patch to support it. Could you please check if it's >> acceptable for you? >> >> Thank you, >> Michael Zhilin | Research & Development | www.NetCracker.com >>>> >> Accelerating Business Transformation >> >> On Feb 1, 2012, at 10:17 AM, Christian Hammond <chi...@chipx86.com >> <javascript:>> wrote: >> >> Hi, >> >> Review Board's only avatar method today is gravatars. There are no >> current plans to implement a secondary system. What I'd be willing to >> accept is a setting for turning on/off gravatars, but we'd probably need a >> patch for it. >> >> Christian >> >> -- >> Christian Hammond - chi...@chipx86.com <javascript:> >> Review Board - http://www.reviewboard.org >> VMware, Inc. - http://www.vmware.com >> >> >> 2012/1/30 深圳手机(王) <8257...@qq.com <javascript:>> >> >>> It seems the user's picture are download from : *www.gravate.com* >>> <http://www.google.com.hk/search?hl=zh-CN&gbv=2&gs_sm=s&gs_upl=470532l470532l0l471313l1l1l0l0l0l0l0l0ll0l0&q=www.gravate.com&spell=1&sa=X>, >>> >>> but I don't want to downlad the picture from this website because our >>> network is not so good. I want to down load all the pictures from local >>> server, such as http://RBserver. >>> How can I do? >>> >>> -- >>> Want to help the Review Board project? Donate today at >>> http://www.reviewboard.org/donate/ >>> Happy user? Let us know at http://www.reviewboard.org/users/ >>> -~----------~----~----~----~------~----~------~--~--- >>> To unsubscribe from this group, send email to >>> reviewboard...@googlegroups.com <javascript:> >>> For more options, visit this group at >>> http://groups.google.com/group/reviewboard?hl=en >> >> >> -- >> Want to help the Review Board project? Donate today at >> http://www.reviewboard.org/donate/ >> Happy user? Let us know at http://www.reviewboard.org/users/ >> -~----------~----~----~----~------~----~------~--~--- >> To unsubscribe from this group, send email to >> reviewboard...@googlegroups.com <javascript:> >> For more options, visit this group at >> http://groups.google.com/group/reviewboard?hl=en >> >> -- >> Want to help the Review Board project? Donate today at >> http://www.reviewboard.org/donate/ >> Happy user? Let us know at http://www.reviewboard.org/users/ >> -~----------~----~----~----~------~----~------~--~--- >> To unsubscribe from this group, send email to >> reviewboard...@googlegroups.com <javascript:> >> For more options, visit this group at >> http://groups.google.com/group/reviewboard?hl=en >> > >
-- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
