Re: Group permissions not getting applied to users in the group
opened a ticket: https://hellosplat.com/s/beanbag/tickets/4857/ On Thursday, 9 January 2020 16:40:26 UTC-8, manoj m wrote: > > Thanks for taking a look. > > On Thursday, 2 January 2020 02:59:57 UTC-8, Christian Hammond wrote: >> >> Hi Manoj, >> >> It does seem that this is broken. I'm working on a fix, but it won't go >> into 2.5. That version series is no longer being supported outside of a >> support contract, with the exception of security issues. I'll have a fix in >> for 3.0.16. >> >> Christian >> >> On Sun, Dec 8, 2019 at 10:20 PM manoj m wrote: >> >>> bump.. >>> >>> On Monday, 2 December 2019 09:56:02 UTC-8, manoj m wrote: >>>> >>>> Hello, >>>> >>>> I have a user U1 added to a group G1 and G1 has "Can change status" >>>> permission >>>> for a review request but the user doesn't see "Close" menu. >>>> >>>> If I add this permission explicitly to the user then the "Close" menu >>>> gets populated as expected. >>>> >>>> we are on 2.5.9 version. >>>> >>>> Any help is appreciated >>>> >>>> Thanks. >>>> >>> -- >>> Supercharge your Review Board with Power Pack: >>> https://www.reviewboard.org/powerpack/ >>> Want us to host Review Board for you? Check out RBCommons: >>> https://rbcommons.com/ >>> Happy user? Let us know! https://www.reviewboard.org/users/ >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "Review Board Community" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to revie...@googlegroups.com. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/reviewboard/714c0290-3e80-408e-be97-e5d0971439a4%40googlegroups.com >>> >>> <https://groups.google.com/d/msgid/reviewboard/714c0290-3e80-408e-be97-e5d0971439a4%40googlegroups.com?utm_medium=email_source=footer> >>> . >>> >> >> >> -- >> Christian Hammond >> President/CEO of Beanbag <https://www.beanbaginc.com/> >> Makers of Review Board <https://www.reviewboard.org/> >> > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/df5df291-3f62-47d7-bc8d-33840e6e5025%40googlegroups.com.
Re: Group permissions not getting applied to users in the group
Thanks for taking a look. On Thursday, 2 January 2020 02:59:57 UTC-8, Christian Hammond wrote: > > Hi Manoj, > > It does seem that this is broken. I'm working on a fix, but it won't go > into 2.5. That version series is no longer being supported outside of a > support contract, with the exception of security issues. I'll have a fix in > for 3.0.16. > > Christian > > On Sun, Dec 8, 2019 at 10:20 PM manoj m > > wrote: > >> bump.. >> >> On Monday, 2 December 2019 09:56:02 UTC-8, manoj m wrote: >>> >>> Hello, >>> >>> I have a user U1 added to a group G1 and G1 has "Can change status" >>> permission >>> for a review request but the user doesn't see "Close" menu. >>> >>> If I add this permission explicitly to the user then the "Close" menu >>> gets populated as expected. >>> >>> we are on 2.5.9 version. >>> >>> Any help is appreciated >>> >>> Thanks. >>> >> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google Groups >> "Review Board Community" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to revie...@googlegroups.com . >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/reviewboard/714c0290-3e80-408e-be97-e5d0971439a4%40googlegroups.com >> >> <https://groups.google.com/d/msgid/reviewboard/714c0290-3e80-408e-be97-e5d0971439a4%40googlegroups.com?utm_medium=email_source=footer> >> . >> > > > -- > Christian Hammond > President/CEO of Beanbag <https://www.beanbaginc.com/> > Makers of Review Board <https://www.reviewboard.org/> > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/50f46691-35ce-405b-9196-995538a08e8c%40googlegroups.com.
Re: Group permissions not getting applied to users in the group
bump.. On Monday, 2 December 2019 09:56:02 UTC-8, manoj m wrote: > > Hello, > > I have a user U1 added to a group G1 and G1 has "Can change status" > permission > for a review request but the user doesn't see "Close" menu. > > If I add this permission explicitly to the user then the "Close" menu gets > populated as expected. > > we are on 2.5.9 version. > > Any help is appreciated > > Thanks. > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/714c0290-3e80-408e-be97-e5d0971439a4%40googlegroups.com.
Group permissions not getting applied to users in the group
Hello, I have a user U1 added to a group G1 and G1 has "Can change status" permission for a review request but the user doesn't see "Close" menu. If I add this permission explicitly to the user then the "Close" menu gets populated as expected. we are on 2.5.9 version. Any help is appreciated Thanks. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/b3bdb192-27b5-441b-8528-43bd630068fb%40googlegroups.com.
Re: Open bug link in new tab
You are right, CMD+click will achieve the same thing but it's one more thing to remember. When there are multiple links in review say -- multiple bug IDs, design docs, log link it's easy to forget. IMO this will improve user experience may be a toggle in user profile "Open links in new tab" would be really helpful. On Tuesday, 16 July 2019 13:12:05 UTC-7, Christian Hammond wrote: > > Hi, > > Browsers have the ability to open links in new tabs generally through a > key combination (like Command-click on Mac, alt-click on Windows, middle > click on Linux). You should be able to do this here. > > The bug report you noticed is actually about something different. In the > early days of Review Board, we had a link at the top of every page to > report a Review Board bug to our issue tracker, and that bug report was > requesting that to open in a new tab. It wasn't about bug IDs you have > filed on the review request. > > Christian > > On Tue, Jul 16, 2019 at 9:52 AM manoj m > > wrote: > >> Hello, >> >> Is there a way to tell reviewboard to open new links in a new tab? >> >> >> I found this very old ticket marked as WontFix: >> https://hellosplat.com/s/beanbag/tickets/592/ >> >> But I think it's worth revisiting. >> >> >> Thanks >> >> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google Groups >> "Review Board Community" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to revie...@googlegroups.com . >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/reviewboard/7840ffa4-827e-46c0-9e36-3299d3546e01%40googlegroups.com >> >> <https://groups.google.com/d/msgid/reviewboard/7840ffa4-827e-46c0-9e36-3299d3546e01%40googlegroups.com?utm_medium=email_source=footer> >> . >> For more options, visit https://groups.google.com/d/optout. >> > > > -- > Christian Hammond > President/CEO of Beanbag <https://www.beanbaginc.com/> > Makers of Review Board <https://www.reviewboard.org/> > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/33453096-7dab-497a-bf1f-aaee9730f682%40googlegroups.com.
Open bug link in new tab
Hello, Is there a way to tell reviewboard to open new links in a new tab? I found this very old ticket marked as WontFix: https://hellosplat.com/s/beanbag/tickets/592/ But I think it's worth revisiting. Thanks -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/7840ffa4-827e-46c0-9e36-3299d3546e01%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: RB default reviewer group not getting updated
Hello, Is there a way to enable the "Default Reviewer" hook irrespective of review request state? We don't use RB for any sensitive patches. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
RB default reviewer group not getting updated
Hello, If an user uploads a new diff to an already published review request the default groups doesn't get updated. Is this expected? On the contrary, an unpublished review requests gets updated properly. Thanks -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: ReviewBoard 3.0 is too slow
FWIW we have a large installation of reviewboard as well and it was running MyISAM engine. We upgraded from 1.X some to 2.0 recently and also moved to Innodb which has row level locking. This is what we did: 1. Turned off foreign key constraints 2. Ran alter table query on on all tables and change the engine to innodb 3. Ran the Reviewboard update 4. Turned on the key constraints again. Needless to say we scheduled a downtime for this and also backed up the data . On Friday, 27 April 2018 03:50:29 UTC-7, Hema wrote: > > Is there any way that we can migrate only the open review requests or the > review requests created over a specific period of time? > > Regards, > Hema. > > On Fri, Apr 27, 2018 at 9:56 AM, Hemapriya > wrote: > >> Thanks for the \G tip. I wasn't aware of it. >> >> MySQL [ReviewBoard]> SELECT COUNT(binary_hash) FROM >> diffviewer_filediffdata\G >> *** 1. row *** >> COUNT(binary_hash): 4216198 >> 1 row in set (0.00 sec) >> >> The above select query doesn't take even a second. Where else could be >> the issue? >> >> By the way, please let me know if you have any recommendation of mysql >> version, engine type,... that we need to use for ReviewBoard. >> >> Thanks, >> Hema. >> >> On Fri, Apr 27, 2018 at 3:04 AM, Christian Hammond < >> chri...@beanbaginc.com > wrote: >> >>> An upgrade might help, but I'm not sure whether it'll solve the issue. >>> >>> I want to narrow down whether it's traversal over the index that's >>> slowing down some of our lookups. How long does this take? (If the answer >>> is more than a couple minutes, Control-C it). >>> >>> SELECT COUNT(binary_hash) FROM diffviewer_filediffdata; >>> >>> By the way, using \G instead of ; at the end of a statement will result >>> in more readable output for e-mail (doesn't rely on fixed-width text). >>> Useful trick. >>> >>> Christian >>> >>> On Thu, Apr 26, 2018 at 2:33 AM, Hemapriya >> > wrote: >>> We created a copy of the actual database and working on it. Once it works perfect, we'll upgrade to ReviewBoard3.0 in production environment. Here are the requested detail. MySQL [ReviewBoard]> SHOW INDEXES FROM diffviewer_filediffdata; +-++--+--+-+---+-+--++--++-+ | Table | Non_unique | Key_name | Seq_in_index | Column_name | Collation | Cardinality | Sub_part | Packed | Null | Index_type | Comment | +-++--+--+-+---+-+--++--++-+ | diffviewer_filediffdata | 0 | PRIMARY |1 | binary_hash | A | 4216198 | NULL | NULL | | BTREE | | +-++--+--+-+---+-+--++--++-+ 1 row in set (1.18 sec) MySQL [ReviewBoard]> EXPLAIN EXTENDED SELECT COUNT(binary_hash) FROM diffviewer_filediffdata; ++-+---+--+---+--+-+--+--+--+--+ | id | select_type | table | type | possible_keys | key | key_len | ref | rows | filtered | Extra| ++-+---+--+---+--+-+--+--+--+--+ | 1 | SIMPLE | NULL | NULL | NULL | NULL | NULL| NULL | NULL | NULL | Select tables optimized away | ++-+---+--+---+--+-+--+--+--+--+ 1 row in set, 1 warning (0.03 sec) MySQL [ReviewBoard]> ANALYZE TABLE diffviewer_filediffdata; +--+-+--+--+ | Table| Op | Msg_type | Msg_text | +--+-+--+--+ | RAT_ReviewBoard3.diffviewer_filediffdata | analyze | status | OK | +--+-+--+--+ 1 row in set (5 min 23.74 sec) Do you think upgrading mysql to a higher version will help here? Regards, Hemapriya. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to
Re: Reviewboard not detecting custom pygments
1. I'm trying to install a pygments file for a custom file type 2. Its installed under /usr/lib/python2.7/site-pacakges/customPygment/__init__.py with following content: class customLexer( CppLexer ): name = "custom files" aliases = [ "custom" ] filenames = [ '*.custom' ] That's all nothing fancy. In reviewboard any *.custom file is getting treated as python file not sure why. On Wednesday, 20 June 2018 12:23:18 UTC-7, Christian Hammond wrote: > > Hi, > > I’ll need to know more about what you’re trying to do and what changes > you’ve made, and how you’ve installed the custom one. Can you provide more > detail about this? > > Christian > > > On Wed, Jun 20, 2018 at 11:28 manoj m > > wrote: > >> Any pointers on debugging this would help :) >> >> >> On Friday, 8 June 2018 16:55:29 UTC-7, manoj m wrote: >>> >>> Hello, >>> >>> I’m running reviewboard 2.5.9 with a custom pygment installed. >>> >>> Following command produce correct syntax highlighted html output but >>> same file in Reviewboard fails to highlight properly >>> >>> http://pygments.org/docs/quickstart/ >>> >>> pygmentize -f html -O full -o test.html test.custom >>> >>> Is there something extra that needs to be done on reviewboard side? >>> >>> Thanks! >>> >>> >> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google Groups >> "Review Board Community" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to reviewboard...@googlegroups.com . >> For more options, visit https://groups.google.com/d/optout. >> > -- > -- > Christian Hammond > President/CEO of Beanbag > Makers of Review Board > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Reviewboard not detecting custom pygments
Any pointers on debugging this would help :) On Friday, 8 June 2018 16:55:29 UTC-7, manoj m wrote: > > Hello, > > I’m running reviewboard 2.5.9 with a custom pygment installed. > > Following command produce correct syntax highlighted html output but same > file in Reviewboard fails to highlight properly > > http://pygments.org/docs/quickstart/ > > pygmentize -f html -O full -o test.html test.custom > > Is there something extra that needs to be done on reviewboard side? > > Thanks! > > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Multiple memcache behavior
For others in similar situation: I used this <https://github.com/quipo/memcache-mover> tool to copy over all the keys to new bigger memcache instance and pointed Reviewboard to that. On Thursday, 14 June 2018 07:29:24 UTC-7, manoj m wrote: > > Hello, > > Context: Our RB is using one memcache and eviction rate seems to be high. > I was thinking of adding one more. Is this recommended or I should go with > one bigger memcache? > > Goal: Increase memcache size with minimum disruption > > Question: > > 1. What happens If the key is present in only one memcached instance? > 2. What happens If one of the memcached is full? > 3. Is there a way to replicate the data to new bigger memcached and retire > the old smaller one? > > I couldn't find anything related to this in docs, sorry If I missed it. > > > Thanks > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Multiple memcache behavior
Hello, Context: Our RB is using one memcache and eviction rate seems to be high. I was thinking of adding one more. Is this recommended or I should go with one bigger memcache? Goal: Increase memcache size with minimum disruption Question: 1. What happens If the key is present in only one memcached instance? 2. What happens If one of the memcached is full? 3. Is there a way to replicate the data to new bigger memcached and retire the old smaller one? I couldn't find anything related to this in docs, sorry If I missed it. Thanks -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Reviewboard not detecting custom pygments
Hello, I’m running reviewboard 2.5.9 with a custom pygment installed. Following command produce correct syntax highlighted html output but same file in Reviewboard fails to highlight properly http://pygments.org/docs/quickstart/ pygmentize -f html -O full -o test.html test.custom Is there something extra that needs to be done on reviewboard side? Thanks! -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Question about muting a review request
Thanks David! I think the docs should be explicit about this because it says mute functionality is like most email clients and it's not. Gmail muted conversations gets "un-muted" if the recipient is added explicitly. On Monday, 4 June 2018 12:03:44 UTC-7, David Trowbridge wrote: > > If it's muted, you won't see any updates regardless of what happens in > those updates. > > -David > > On Mon, Jun 4, 2018 at 10:38 AM manoj m > > wrote: > >> Hello, >> >> I went through the documentation here: >> https://www.reviewboard.org/docs/releasenotes/reviewboard/2.5/#archive-and-mute-review-requests >> >> >> But what is not clear to me is what happens if on a muted review request >> someone adds me explicitly? Will I see the update? >> >> Thanks, >> Manoj >> >> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google Groups >> "Review Board Community" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to reviewboard...@googlegroups.com . >> For more options, visit https://groups.google.com/d/optout. >> > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
