Re: Absolute links in reply mails

2015-08-13 Thread Zach 
Hey Chris,

I posted a new issue to the google group, is that what you were asking for?

Thanks for the quick response.

-Zach

On Wednesday, August 12, 2015 at 3:54:57 PM UTC-4, Christian Hammond wrote:

 Hi Zach,

 Can you file a bug report with a repro case to help us track this? It 
 otherwise will just get lost in the mailing list.

 Thanks :)

 Christian

 -- 
 Christian Hammond - chi...@chipx86.com javascript:
 Review Board - https://www.reviewboard.org
 Beanbag, Inc. - https://www.beanbaginc.com

 On Wed, Aug 12, 2015 at 11:39 AM, Zach zac...@gmail.com javascript: 
 wrote:

 Hey Chris,

 We are actually having this issue again in reviewboard 2.0.18, except 
 with file uploads.

 The src attribute of the image contains a relative link, the same as it 
 is when you visit the actual review request (but the other attributes are 
 different), eg: 

 img class=modified-image 
 src=/media/uploaded/files/2015/08/11/aecc3e18-0af0-45de-95a2-4530a7b1b8f9__BANHAMMER_400x100.png
  width=38 
 height=62 alt=banned

 -Zach


 On Thursday, March 4, 2010 at 3:37:57 PM UTC-5, Paul wrote:

 My users are complaining because reply mails that have comments to
 lines of code end up with relative URLs rather than absolute URLs.

 e.g.
 a href=/r/42/diff/1/?file=173#file173line549 style=color: black;
 font-weight: bold; text-decoration: underline;/ops/configuration/
 cfengine/inputs/cf.main/a

 I wrote the following patch which I expected to fix this, but it
 didn't work. Any ideas on where I should look next?

 diff -ur ReviewBoard-1.5beta1-orig/reviewboard/templates/notifications/
 email_diff_comment_fragment.html ReviewBoard-1.5beta1/reviewboard/
 templates/notifications/email_diff_comment_fragment.html
 --- ReviewBoard-1.5beta1-orig/reviewboard/templates/notifications/
 email_diff_comment_fragment.html  2010-02-14 13:25:13.0
 -0800
 +++ ReviewBoard-1.5beta1/reviewboard/templates/notifications/
 email_diff_comment_fragment.html   2010-03-03 15:07:13.363661209 -0800
 @@ -5,7 +5,7 @@
   thead
tr
 th colspan=4 bgcolor=#F0F0F0 style=border-bottom: 1px solid
 #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;
 -a href={{comment.get_absolute_url}} style=color: black; font-
 weight: bold; text-decoration:
 underline;{{comment.filediff.dest_file}}/a
 +a href={{domain_method}}://{{domain}}
 {{comment.get_absolute_url}} style=color: black; font-weight: bold;
 text-decoration: underline;{{comment.filediff.dest_file}}/a
  span style=font-weight: normal;
  {% if comment.interfilediff %}
   (Diff revisions {{comment.filediff.diffset.revision}} -
 {{comment.interfilediff.diffset.revision}})
 diff -ur ReviewBoard-1.5beta1-orig/reviewboard/templates/notifications/
 reply_email.html ReviewBoard-1.5beta1/reviewboard/templates/
 notifications/reply_email.html
 --- ReviewBoard-1.5beta1-orig/reviewboard/templates/notifications/
 reply_email.html  2010-02-14 13:25:13.0 -0800
 +++ ReviewBoard-1.5beta1/reviewboard/templates/notifications/
 reply_email.html   2010-03-03 15:05:28.383660132 -0800
 @@ -38,7 +38,7 @@

table bgcolor=#f0f0f0 cellpadding=5 cellspacing=5
 style=border: 1px solid #c0c0c0; margin-bottom: 10px
 tr
 -tda href={{comment.screenshot.get_absolute_url}}
 style=color: black; font-weight: bold; font-size:
 9pt;{{comment.screenshot.image.name|basename}}/a/td
 + tda href={{domain_method}}://{{domain}}
 {{comment.screenshot.get_absolute_url}} style=color: black; font-
 weight: bold; font-size: 9pt;{{comment.screenshot.image.name|
 basename}}/a/td
 /tr
 tr
  tda href={{domain_method}}://{{domain}}
 {{comment.screenshot.get_absolute_url}}img src={{domain_method}}://
 {{domain}}{{comment.get_image_url}} style=border: 1px black solid;
 alt={{comment.screenshot.caption}}/a/td
 diff -ur ReviewBoard-1.5beta1-orig/reviewboard/templates/notifications/
 review_email.html ReviewBoard-1.5beta1/reviewboard/templates/
 notifications/review_email.html
 --- ReviewBoard-1.5beta1-orig/reviewboard/templates/notifications/
 review_email.html 2010-02-14 13:25:13.0 -0800
 +++ ReviewBoard-1.5beta1/reviewboard/templates/notifications/
 review_email.html  2010-03-03 15:07:57.651160670 -0800
 @@ -15,7 +15,7 @@
  {% for comment in review.screenshot_comments.all %}
  table bgcolor=#f0f0f0 cellpadding=5 cellspacing=5
 style=border: 1px solid #c0c0c0; margin-bottom: 10px
   tr
 -  tda href={{comment.screenshot.get_absolute_url}} style=color:
 black; font-weight: bold; font-size:
 9pt;{{comment.screenshot.image.name|basename}}/a/td
 +   tda href={{domain_method}}://{{domain}}
 {{comment.screenshot.get_absolute_url}} style=color: black; font-
 weight: bold; font-size: 9pt;{{comment.screenshot.image.name|
 basename}}/a/td
   /tr
   tr
tda href={{domain_method}}://{{domain}}
 {{comment.screenshot.get_absolute_url}}img src={{domain_method}}://
 {{domain}}{{comment.get_image_url}} style=border: 1px black solid;
 alt={{comment.screenshot.caption}}/a/td

 --

Re: Absolute links in reply mails

2015-08-13 Thread Christian Hammond 
Sorry, no, we need it posted on httpd://www.reviewboard.org/bugs/

Thanks!

Christian


On Thursday, August 13, 2015, Zach zach...@gmail.com wrote:

 Hey Chris,

 I posted a new issue to the google group, is that what you were asking for?

 Thanks for the quick response.

 -Zach

 On Wednesday, August 12, 2015 at 3:54:57 PM UTC-4, Christian Hammond wrote:

 Hi Zach,

 Can you file a bug report with a repro case to help us track this? It
 otherwise will just get lost in the mailing list.

 Thanks :)

 Christian

 --
 Christian Hammond - chi...@chipx86.com
 Review Board - https://www.reviewboard.org
 Beanbag, Inc. - https://www.beanbaginc.com

 On Wed, Aug 12, 2015 at 11:39 AM, Zach zac...@gmail.com wrote:

 Hey Chris,

 We are actually having this issue again in reviewboard 2.0.18, except
 with file uploads.

 The src attribute of the image contains a relative link, the same as it
 is when you visit the actual review request (but the other attributes are
 different), eg:

 img class=modified-image 
 src=/media/uploaded/files/2015/08/11/aecc3e18-0af0-45de-95a2-4530a7b1b8f9__BANHAMMER_400x100.png
  width=38
 height=62 alt=banned

 -Zach


 On Thursday, March 4, 2010 at 3:37:57 PM UTC-5, Paul wrote:

 My users are complaining because reply mails that have comments to
 lines of code end up with relative URLs rather than absolute URLs.

 e.g.
 a href=/r/42/diff/1/?file=173#file173line549 style=color: black;
 font-weight: bold; text-decoration: underline;/ops/configuration/
 cfengine/inputs/cf.main/a

 I wrote the following patch which I expected to fix this, but it
 didn't work. Any ideas on where I should look next?

 diff -ur ReviewBoard-1.5beta1-orig/reviewboard/templates/notifications/
 email_diff_comment_fragment.html ReviewBoard-1.5beta1/reviewboard/
 templates/notifications/email_diff_comment_fragment.html
 --- ReviewBoard-1.5beta1-orig/reviewboard/templates/notifications/
 email_diff_comment_fragment.html  2010-02-14 13:25:13.0
 -0800
 +++ ReviewBoard-1.5beta1/reviewboard/templates/notifications/
 email_diff_comment_fragment.html   2010-03-03 15:07:13.363661209 -0800
 @@ -5,7 +5,7 @@
   thead
tr
 th colspan=4 bgcolor=#F0F0F0 style=border-bottom: 1px solid
 #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;
 -a href={{comment.get_absolute_url}} style=color: black; font-
 weight: bold; text-decoration:
 underline;{{comment.filediff.dest_file}}/a
 +a href={{domain_method}}://{{domain}}
 {{comment.get_absolute_url}} style=color: black; font-weight: bold;
 text-decoration: underline;{{comment.filediff.dest_file}}/a
  span style=font-weight: normal;
  {% if comment.interfilediff %}
   (Diff revisions {{comment.filediff.diffset.revision}} -
 {{comment.interfilediff.diffset.revision}})
 diff -ur ReviewBoard-1.5beta1-orig/reviewboard/templates/notifications/
 reply_email.html ReviewBoard-1.5beta1/reviewboard/templates/
 notifications/reply_email.html
 --- ReviewBoard-1.5beta1-orig/reviewboard/templates/notifications/
 reply_email.html  2010-02-14 13:25:13.0 -0800
 +++ ReviewBoard-1.5beta1/reviewboard/templates/notifications/
 reply_email.html   2010-03-03 15:05:28.383660132 -0800
 @@ -38,7 +38,7 @@

table bgcolor=#f0f0f0 cellpadding=5 cellspacing=5
 style=border: 1px solid #c0c0c0; margin-bottom: 10px
 tr
 -tda href={{comment.screenshot.get_absolute_url}}
 style=color: black; font-weight: bold; font-size:
 9pt;{{comment.screenshot.image.name|basename}}/a/td
 + tda href={{domain_method}}://{{domain}}
 {{comment.screenshot.get_absolute_url}} style=color: black; font-
 weight: bold; font-size: 9pt;{{comment.screenshot.image.name|
 basename}}/a/td
 /tr
 tr
  tda href={{domain_method}}://{{domain}}
 {{comment.screenshot.get_absolute_url}}img src={{domain_method}}://
 {{domain}}{{comment.get_image_url}} style=border: 1px black solid;
 alt={{comment.screenshot.caption}}/a/td
 diff -ur ReviewBoard-1.5beta1-orig/reviewboard/templates/notifications/
 review_email.html ReviewBoard-1.5beta1/reviewboard/templates/
 notifications/review_email.html
 --- ReviewBoard-1.5beta1-orig/reviewboard/templates/notifications/
 review_email.html 2010-02-14 13:25:13.0 -0800
 +++ ReviewBoard-1.5beta1/reviewboard/templates/notifications/
 review_email.html  2010-03-03 15:07:57.651160670 -0800
 @@ -15,7 +15,7 @@
  {% for comment in review.screenshot_comments.all %}
  table bgcolor=#f0f0f0 cellpadding=5 cellspacing=5
 style=border: 1px solid #c0c0c0; margin-bottom: 10px
   tr
 -  tda href={{comment.screenshot.get_absolute_url}} style=color:
 black; font-weight: bold; font-size:
 9pt;{{comment.screenshot.image.name|basename}}/a/td
 +   tda href={{domain_method}}://{{domain}}
 {{comment.screenshot.get_absolute_url}} style=color: black; font-
 weight: bold; font-size: 9pt;{{comment.screenshot.image.name|
 basename}}/a/td
   /tr
   tr
tda href={{domain_method}}://{{domain}}
 {{comment.screenshot.get_absolute_url}}img src={{domain_method}}://

Re: Absolute links in reply mails

2015-08-13 Thread Zach 
Posted to https://code.google.com/p/reviewboard/issues/detail?id=3944

On Thursday, August 13, 2015 at 2:52:18 PM UTC-4, Christian Hammond wrote:

 Sorry, no, we need it posted on httpd://www.reviewboard.org/bugs/

 Thanks!

 Christian


 On Thursday, August 13, 2015, Zach zac...@gmail.com javascript: wrote:

 Hey Chris,

 I posted a new issue to the google group, is that what you were asking 
 for?

 Thanks for the quick response.

 -Zach

 On Wednesday, August 12, 2015 at 3:54:57 PM UTC-4, Christian Hammond 
 wrote:

 Hi Zach,

 Can you file a bug report with a repro case to help us track this? It 
 otherwise will just get lost in the mailing list.

 Thanks :)

 Christian

 -- 
 Christian Hammond - chi...@chipx86.com
 Review Board - https://www.reviewboard.org
 Beanbag, Inc. - https://www.beanbaginc.com

 On Wed, Aug 12, 2015 at 11:39 AM, Zach zac...@gmail.com wrote:

 Hey Chris,

 We are actually having this issue again in reviewboard 2.0.18, except 
 with file uploads.

 The src attribute of the image contains a relative link, the same as it 
 is when you visit the actual review request (but the other attributes are 
 different), eg: 

 img class=modified-image 
 src=/media/uploaded/files/2015/08/11/aecc3e18-0af0-45de-95a2-4530a7b1b8f9__BANHAMMER_400x100.png
  width=38 
 height=62 alt=banned

 -Zach


 On Thursday, March 4, 2010 at 3:37:57 PM UTC-5, Paul wrote:

 My users are complaining because reply mails that have comments to
 lines of code end up with relative URLs rather than absolute URLs.

 e.g.
 a href=/r/42/diff/1/?file=173#file173line549 style=color: black;
 font-weight: bold; text-decoration: underline;/ops/configuration/
 cfengine/inputs/cf.main/a

 I wrote the following patch which I expected to fix this, but it
 didn't work. Any ideas on where I should look next?

 diff -ur ReviewBoard-1.5beta1-orig/reviewboard/templates/notifications/
 email_diff_comment_fragment.html ReviewBoard-1.5beta1/reviewboard/
 templates/notifications/email_diff_comment_fragment.html
 --- ReviewBoard-1.5beta1-orig/reviewboard/templates/notifications/
 email_diff_comment_fragment.html  2010-02-14 13:25:13.0
 -0800
 +++ ReviewBoard-1.5beta1/reviewboard/templates/notifications/
 email_diff_comment_fragment.html   2010-03-03 15:07:13.363661209 -0800
 @@ -5,7 +5,7 @@
   thead
tr
 th colspan=4 bgcolor=#F0F0F0 style=border-bottom: 1px solid
 #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;
 -a href={{comment.get_absolute_url}} style=color: black; font-
 weight: bold; text-decoration:
 underline;{{comment.filediff.dest_file}}/a
 +a href={{domain_method}}://{{domain}}
 {{comment.get_absolute_url}} style=color: black; font-weight: bold;
 text-decoration: underline;{{comment.filediff.dest_file}}/a
  span style=font-weight: normal;
  {% if comment.interfilediff %}
   (Diff revisions {{comment.filediff.diffset.revision}} -
 {{comment.interfilediff.diffset.revision}})
 diff -ur ReviewBoard-1.5beta1-orig/reviewboard/templates/notifications/
 reply_email.html ReviewBoard-1.5beta1/reviewboard/templates/
 notifications/reply_email.html
 --- ReviewBoard-1.5beta1-orig/reviewboard/templates/notifications/
 reply_email.html  2010-02-14 13:25:13.0 -0800
 +++ ReviewBoard-1.5beta1/reviewboard/templates/notifications/
 reply_email.html   2010-03-03 15:05:28.383660132 -0800
 @@ -38,7 +38,7 @@

table bgcolor=#f0f0f0 cellpadding=5 cellspacing=5
 style=border: 1px solid #c0c0c0; margin-bottom: 10px
 tr
 -tda href={{comment.screenshot.get_absolute_url}}
 style=color: black; font-weight: bold; font-size:
 9pt;{{comment.screenshot.image.name|basename}}/a/td
 + tda href={{domain_method}}://{{domain}}
 {{comment.screenshot.get_absolute_url}} style=color: black; font-
 weight: bold; font-size: 9pt;{{comment.screenshot.image.name|
 basename}}/a/td
 /tr
 tr
  tda href={{domain_method}}://{{domain}}
 {{comment.screenshot.get_absolute_url}}img src={{domain_method}}://
 {{domain}}{{comment.get_image_url}} style=border: 1px black solid;
 alt={{comment.screenshot.caption}}/a/td
 diff -ur ReviewBoard-1.5beta1-orig/reviewboard/templates/notifications/
 review_email.html ReviewBoard-1.5beta1/reviewboard/templates/
 notifications/review_email.html
 --- ReviewBoard-1.5beta1-orig/reviewboard/templates/notifications/
 review_email.html 2010-02-14 13:25:13.0 -0800
 +++ ReviewBoard-1.5beta1/reviewboard/templates/notifications/
 review_email.html  2010-03-03 15:07:57.651160670 -0800
 @@ -15,7 +15,7 @@
  {% for comment in review.screenshot_comments.all %}
  table bgcolor=#f0f0f0 cellpadding=5 cellspacing=5
 style=border: 1px solid #c0c0c0; margin-bottom: 10px
   tr
 -  tda href={{comment.screenshot.get_absolute_url}} style=color:
 black; font-weight: bold; font-size:
 9pt;{{comment.screenshot.image.name|basename}}/a/td
 +   tda href={{domain_method}}://{{domain}}
 {{comment.screenshot.get_absolute_url}} style=color: black; font-
 weight: bold; font-size:

Re: Absolute links in reply mails

2015-08-12 Thread Zach 
Hey Chris,

We are actually having this issue again in reviewboard 2.0.18, except with 
file uploads.

The src attribute of the image contains a relative link, the same as it is 
when you visit the actual review request (but the other attributes are 
different), eg: 

img class=modified-image 
src=/media/uploaded/files/2015/08/11/aecc3e18-0af0-45de-95a2-4530a7b1b8f9__BANHAMMER_400x100.png
 width=38 
height=62 alt=banned

-Zach

On Thursday, March 4, 2010 at 3:37:57 PM UTC-5, Paul wrote:

 My users are complaining because reply mails that have comments to
 lines of code end up with relative URLs rather than absolute URLs.

 e.g.
 a href=/r/42/diff/1/?file=173#file173line549 style=color: black;
 font-weight: bold; text-decoration: underline;/ops/configuration/
 cfengine/inputs/cf.main/a

 I wrote the following patch which I expected to fix this, but it
 didn't work. Any ideas on where I should look next?

 diff -ur ReviewBoard-1.5beta1-orig/reviewboard/templates/notifications/
 email_diff_comment_fragment.html ReviewBoard-1.5beta1/reviewboard/
 templates/notifications/email_diff_comment_fragment.html
 --- ReviewBoard-1.5beta1-orig/reviewboard/templates/notifications/
 email_diff_comment_fragment.html  2010-02-14 13:25:13.0
 -0800
 +++ ReviewBoard-1.5beta1/reviewboard/templates/notifications/
 email_diff_comment_fragment.html   2010-03-03 15:07:13.363661209 -0800
 @@ -5,7 +5,7 @@
   thead
tr
 th colspan=4 bgcolor=#F0F0F0 style=border-bottom: 1px solid
 #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;
 -a href={{comment.get_absolute_url}} style=color: black; font-
 weight: bold; text-decoration:
 underline;{{comment.filediff.dest_file}}/a
 +a href={{domain_method}}://{{domain}}
 {{comment.get_absolute_url}} style=color: black; font-weight: bold;
 text-decoration: underline;{{comment.filediff.dest_file}}/a
  span style=font-weight: normal;
  {% if comment.interfilediff %}
   (Diff revisions {{comment.filediff.diffset.revision}} -
 {{comment.interfilediff.diffset.revision}})
 diff -ur ReviewBoard-1.5beta1-orig/reviewboard/templates/notifications/
 reply_email.html ReviewBoard-1.5beta1/reviewboard/templates/
 notifications/reply_email.html
 --- ReviewBoard-1.5beta1-orig/reviewboard/templates/notifications/
 reply_email.html  2010-02-14 13:25:13.0 -0800
 +++ ReviewBoard-1.5beta1/reviewboard/templates/notifications/
 reply_email.html   2010-03-03 15:05:28.383660132 -0800
 @@ -38,7 +38,7 @@

table bgcolor=#f0f0f0 cellpadding=5 cellspacing=5
 style=border: 1px solid #c0c0c0; margin-bottom: 10px
 tr
 -tda href={{comment.screenshot.get_absolute_url}}
 style=color: black; font-weight: bold; font-size:
 9pt;{{comment.screenshot.image.name|basename}}/a/td
 + tda href={{domain_method}}://{{domain}}
 {{comment.screenshot.get_absolute_url}} style=color: black; font-
 weight: bold; font-size: 9pt;{{comment.screenshot.image.name|
 basename}}/a/td
 /tr
 tr
  tda href={{domain_method}}://{{domain}}
 {{comment.screenshot.get_absolute_url}}img src={{domain_method}}://
 {{domain}}{{comment.get_image_url}} style=border: 1px black solid;
 alt={{comment.screenshot.caption}}/a/td
 diff -ur ReviewBoard-1.5beta1-orig/reviewboard/templates/notifications/
 review_email.html ReviewBoard-1.5beta1/reviewboard/templates/
 notifications/review_email.html
 --- ReviewBoard-1.5beta1-orig/reviewboard/templates/notifications/
 review_email.html 2010-02-14 13:25:13.0 -0800
 +++ ReviewBoard-1.5beta1/reviewboard/templates/notifications/
 review_email.html  2010-03-03 15:07:57.651160670 -0800
 @@ -15,7 +15,7 @@
  {% for comment in review.screenshot_comments.all %}
  table bgcolor=#f0f0f0 cellpadding=5 cellspacing=5
 style=border: 1px solid #c0c0c0; margin-bottom: 10px
   tr
 -  tda href={{comment.screenshot.get_absolute_url}} style=color:
 black; font-weight: bold; font-size:
 9pt;{{comment.screenshot.image.name|basename}}/a/td
 +   tda href={{domain_method}}://{{domain}}
 {{comment.screenshot.get_absolute_url}} style=color: black; font-
 weight: bold; font-size: 9pt;{{comment.screenshot.image.name|
 basename}}/a/td
   /tr
   tr
tda href={{domain_method}}://{{domain}}
 {{comment.screenshot.get_absolute_url}}img src={{domain_method}}://
 {{domain}}{{comment.get_image_url}} style=border: 1px black solid;
 alt={{comment.screenshot.caption}}/a/td



-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Absolute links in reply mails

2015-08-12 Thread Christian Hammond 
Hi Zach,

Can you file a bug report with a repro case to help us track this? It
otherwise will just get lost in the mailing list.

Thanks :)

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com

On Wed, Aug 12, 2015 at 11:39 AM, Zach zach...@gmail.com wrote:

 Hey Chris,

 We are actually having this issue again in reviewboard 2.0.18, except with
 file uploads.

 The src attribute of the image contains a relative link, the same as it is
 when you visit the actual review request (but the other attributes are
 different), eg:

 img class=modified-image 
 src=/media/uploaded/files/2015/08/11/aecc3e18-0af0-45de-95a2-4530a7b1b8f9__BANHAMMER_400x100.png
  width=38
 height=62 alt=banned

 -Zach


 On Thursday, March 4, 2010 at 3:37:57 PM UTC-5, Paul wrote:

 My users are complaining because reply mails that have comments to
 lines of code end up with relative URLs rather than absolute URLs.

 e.g.
 a href=/r/42/diff/1/?file=173#file173line549 style=color: black;
 font-weight: bold; text-decoration: underline;/ops/configuration/
 cfengine/inputs/cf.main/a

 I wrote the following patch which I expected to fix this, but it
 didn't work. Any ideas on where I should look next?

 diff -ur ReviewBoard-1.5beta1-orig/reviewboard/templates/notifications/
 email_diff_comment_fragment.html ReviewBoard-1.5beta1/reviewboard/
 templates/notifications/email_diff_comment_fragment.html
 --- ReviewBoard-1.5beta1-orig/reviewboard/templates/notifications/
 email_diff_comment_fragment.html  2010-02-14 13:25:13.0
 -0800
 +++ ReviewBoard-1.5beta1/reviewboard/templates/notifications/
 email_diff_comment_fragment.html   2010-03-03 15:07:13.363661209 -0800
 @@ -5,7 +5,7 @@
   thead
tr
 th colspan=4 bgcolor=#F0F0F0 style=border-bottom: 1px solid
 #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;
 -a href={{comment.get_absolute_url}} style=color: black; font-
 weight: bold; text-decoration:
 underline;{{comment.filediff.dest_file}}/a
 +a href={{domain_method}}://{{domain}}
 {{comment.get_absolute_url}} style=color: black; font-weight: bold;
 text-decoration: underline;{{comment.filediff.dest_file}}/a
  span style=font-weight: normal;
  {% if comment.interfilediff %}
   (Diff revisions {{comment.filediff.diffset.revision}} -
 {{comment.interfilediff.diffset.revision}})
 diff -ur ReviewBoard-1.5beta1-orig/reviewboard/templates/notifications/
 reply_email.html ReviewBoard-1.5beta1/reviewboard/templates/
 notifications/reply_email.html
 --- ReviewBoard-1.5beta1-orig/reviewboard/templates/notifications/
 reply_email.html  2010-02-14 13:25:13.0 -0800
 +++ ReviewBoard-1.5beta1/reviewboard/templates/notifications/
 reply_email.html   2010-03-03 15:05:28.383660132 -0800
 @@ -38,7 +38,7 @@

table bgcolor=#f0f0f0 cellpadding=5 cellspacing=5
 style=border: 1px solid #c0c0c0; margin-bottom: 10px
 tr
 -tda href={{comment.screenshot.get_absolute_url}}
 style=color: black; font-weight: bold; font-size:
 9pt;{{comment.screenshot.image.name|basename}}/a/td
 + tda href={{domain_method}}://{{domain}}
 {{comment.screenshot.get_absolute_url}} style=color: black; font-
 weight: bold; font-size: 9pt;{{comment.screenshot.image.name|
 basename}}/a/td
 /tr
 tr
  tda href={{domain_method}}://{{domain}}
 {{comment.screenshot.get_absolute_url}}img src={{domain_method}}://
 {{domain}}{{comment.get_image_url}} style=border: 1px black solid;
 alt={{comment.screenshot.caption}}/a/td
 diff -ur ReviewBoard-1.5beta1-orig/reviewboard/templates/notifications/
 review_email.html ReviewBoard-1.5beta1/reviewboard/templates/
 notifications/review_email.html
 --- ReviewBoard-1.5beta1-orig/reviewboard/templates/notifications/
 review_email.html 2010-02-14 13:25:13.0 -0800
 +++ ReviewBoard-1.5beta1/reviewboard/templates/notifications/
 review_email.html  2010-03-03 15:07:57.651160670 -0800
 @@ -15,7 +15,7 @@
  {% for comment in review.screenshot_comments.all %}
  table bgcolor=#f0f0f0 cellpadding=5 cellspacing=5
 style=border: 1px solid #c0c0c0; margin-bottom: 10px
   tr
 -  tda href={{comment.screenshot.get_absolute_url}} style=color:
 black; font-weight: bold; font-size:
 9pt;{{comment.screenshot.image.name|basename}}/a/td
 +   tda href={{domain_method}}://{{domain}}
 {{comment.screenshot.get_absolute_url}} style=color: black; font-
 weight: bold; font-size: 9pt;{{comment.screenshot.image.name|
 basename}}/a/td
   /tr
   tr
tda href={{domain_method}}://{{domain}}
 {{comment.screenshot.get_absolute_url}}img src={{domain_method}}://
 {{domain}}{{comment.get_image_url}} style=border: 1px black solid;
 alt={{comment.screenshot.caption}}/a/td

 --
 Supercharge your Review Board with Power Pack:
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons:
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 ---
 You received this

Absolute links in reply mails

2010-03-04 Thread Paul 
My users are complaining because reply mails that have comments to
lines of code end up with relative URLs rather than absolute URLs.

e.g.
a href=/r/42/diff/1/?file=173#file173line549 style=color: black;
font-weight: bold; text-decoration: underline;/ops/configuration/
cfengine/inputs/cf.main/a

I wrote the following patch which I expected to fix this, but it
didn't work. Any ideas on where I should look next?

diff -ur ReviewBoard-1.5beta1-orig/reviewboard/templates/notifications/
email_diff_comment_fragment.html ReviewBoard-1.5beta1/reviewboard/
templates/notifications/email_diff_comment_fragment.html
--- ReviewBoard-1.5beta1-orig/reviewboard/templates/notifications/
email_diff_comment_fragment.html  2010-02-14 13:25:13.0
-0800
+++ ReviewBoard-1.5beta1/reviewboard/templates/notifications/
email_diff_comment_fragment.html   2010-03-03 15:07:13.363661209 -0800
@@ -5,7 +5,7 @@
  thead
   tr
th colspan=4 bgcolor=#F0F0F0 style=border-bottom: 1px solid
#C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;
-a href={{comment.get_absolute_url}} style=color: black; font-
weight: bold; text-decoration:
underline;{{comment.filediff.dest_file}}/a
+a href={{domain_method}}://{{domain}}
{{comment.get_absolute_url}} style=color: black; font-weight: bold;
text-decoration: underline;{{comment.filediff.dest_file}}/a
 span style=font-weight: normal;
 {% if comment.interfilediff %}
  (Diff revisions {{comment.filediff.diffset.revision}} -
{{comment.interfilediff.diffset.revision}})
diff -ur ReviewBoard-1.5beta1-orig/reviewboard/templates/notifications/
reply_email.html ReviewBoard-1.5beta1/reviewboard/templates/
notifications/reply_email.html
--- ReviewBoard-1.5beta1-orig/reviewboard/templates/notifications/
reply_email.html  2010-02-14 13:25:13.0 -0800
+++ ReviewBoard-1.5beta1/reviewboard/templates/notifications/
reply_email.html   2010-03-03 15:05:28.383660132 -0800
@@ -38,7 +38,7 @@

   table bgcolor=#f0f0f0 cellpadding=5 cellspacing=5
style=border: 1px solid #c0c0c0; margin-bottom: 10px
tr
-tda href={{comment.screenshot.get_absolute_url}}
style=color: black; font-weight: bold; font-size:
9pt;{{comment.screenshot.image.name|basename}}/a/td
+ tda href={{domain_method}}://{{domain}}
{{comment.screenshot.get_absolute_url}} style=color: black; font-
weight: bold; font-size: 9pt;{{comment.screenshot.image.name|
basename}}/a/td
/tr
tr
 tda href={{domain_method}}://{{domain}}
{{comment.screenshot.get_absolute_url}}img src={{domain_method}}://
{{domain}}{{comment.get_image_url}} style=border: 1px black solid;
alt={{comment.screenshot.caption}}/a/td
diff -ur ReviewBoard-1.5beta1-orig/reviewboard/templates/notifications/
review_email.html ReviewBoard-1.5beta1/reviewboard/templates/
notifications/review_email.html
--- ReviewBoard-1.5beta1-orig/reviewboard/templates/notifications/
review_email.html 2010-02-14 13:25:13.0 -0800
+++ ReviewBoard-1.5beta1/reviewboard/templates/notifications/
review_email.html  2010-03-03 15:07:57.651160670 -0800
@@ -15,7 +15,7 @@
 {% for comment in review.screenshot_comments.all %}
 table bgcolor=#f0f0f0 cellpadding=5 cellspacing=5
style=border: 1px solid #c0c0c0; margin-bottom: 10px
  tr
-  tda href={{comment.screenshot.get_absolute_url}} style=color:
black; font-weight: bold; font-size:
9pt;{{comment.screenshot.image.name|basename}}/a/td
+   tda href={{domain_method}}://{{domain}}
{{comment.screenshot.get_absolute_url}} style=color: black; font-
weight: bold; font-size: 9pt;{{comment.screenshot.image.name|
basename}}/a/td
  /tr
  tr
   tda href={{domain_method}}://{{domain}}
{{comment.screenshot.get_absolute_url}}img src={{domain_method}}://
{{domain}}{{comment.get_image_url}} style=border: 1px black solid;
alt={{comment.screenshot.caption}}/a/td

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Absolute links in reply mails

2010-03-04 Thread Christian Hammond 
That patch should work, provided the correct variables are passed to the
template renderer. I don't know if they are.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Thu, Mar 4, 2010 at 12:37 PM, Paul psarm...@gmail.com wrote:

 My users are complaining because reply mails that have comments to
 lines of code end up with relative URLs rather than absolute URLs.

 e.g.
 a href=/r/42/diff/1/?file=173#file173line549 style=color: black;
 font-weight: bold; text-decoration: underline;/ops/configuration/
 cfengine/inputs/cf.main/a

 I wrote the following patch which I expected to fix this, but it
 didn't work. Any ideas on where I should look next?

 diff -ur ReviewBoard-1.5beta1-orig/reviewboard/templates/notifications/
 email_diff_comment_fragment.html ReviewBoard-1.5beta1/reviewboard/
 templates/notifications/email_diff_comment_fragment.html
 --- ReviewBoard-1.5beta1-orig/reviewboard/templates/notifications/
 email_diff_comment_fragment.html  2010-02-14 13:25:13.0
 -0800
 +++ ReviewBoard-1.5beta1/reviewboard/templates/notifications/
 email_diff_comment_fragment.html   2010-03-03 15:07:13.363661209 -0800
 @@ -5,7 +5,7 @@
  thead
   tr
th colspan=4 bgcolor=#F0F0F0 style=border-bottom: 1px solid
 #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;
 -a href={{comment.get_absolute_url}} style=color: black; font-
 weight: bold; text-decoration:
 underline;{{comment.filediff.dest_file}}/a
 +a href={{domain_method}}://{{domain}}
 {{comment.get_absolute_url}} style=color: black; font-weight: bold;
 text-decoration: underline;{{comment.filediff.dest_file}}/a
 span style=font-weight: normal;
  {% if comment.interfilediff %}
  (Diff revisions {{comment.filediff.diffset.revision}} -
 {{comment.interfilediff.diffset.revision}})
 diff -ur ReviewBoard-1.5beta1-orig/reviewboard/templates/notifications/
 reply_email.html ReviewBoard-1.5beta1/reviewboard/templates/
 notifications/reply_email.html
 --- ReviewBoard-1.5beta1-orig/reviewboard/templates/notifications/
 reply_email.html  2010-02-14 13:25:13.0 -0800
 +++ ReviewBoard-1.5beta1/reviewboard/templates/notifications/
 reply_email.html   2010-03-03 15:05:28.383660132 -0800
 @@ -38,7 +38,7 @@

   table bgcolor=#f0f0f0 cellpadding=5 cellspacing=5
 style=border: 1px solid #c0c0c0; margin-bottom: 10px
tr
 -tda href={{comment.screenshot.get_absolute_url}}
 style=color: black; font-weight: bold; font-size:
 9pt;{{comment.screenshot.image.name|basename}}/a/td
 + tda href={{domain_method}}://{{domain}}
 {{comment.screenshot.get_absolute_url}} style=color: black; font-
 weight: bold; font-size: 9pt;{{comment.screenshot.image.name|
 basename}}/a/td
/tr
tr
 tda href={{domain_method}}://{{domain}}
 {{comment.screenshot.get_absolute_url}}img src={{domain_method}}://
 {{domain}}{{comment.get_image_url}} style=border: 1px black solid;
 alt={{comment.screenshot.caption}}/a/td
 diff -ur ReviewBoard-1.5beta1-orig/reviewboard/templates/notifications/
 review_email.html ReviewBoard-1.5beta1/reviewboard/templates/
 notifications/review_email.html
 --- ReviewBoard-1.5beta1-orig/reviewboard/templates/notifications/
 review_email.html 2010-02-14 13:25:13.0 -0800
 +++ ReviewBoard-1.5beta1/reviewboard/templates/notifications/
 review_email.html  2010-03-03 15:07:57.651160670 -0800
 @@ -15,7 +15,7 @@
  {% for comment in review.screenshot_comments.all %}
  table bgcolor=#f0f0f0 cellpadding=5 cellspacing=5
 style=border: 1px solid #c0c0c0; margin-bottom: 10px
  tr
 -  tda href={{comment.screenshot.get_absolute_url}} style=color:
 black; font-weight: bold; font-size:
 9pt;{{comment.screenshot.image.name|basename}}/a/td
 +   tda href={{domain_method}}://{{domain}}
 {{comment.screenshot.get_absolute_url}} style=color: black; font-
 weight: bold; font-size: 9pt;{{comment.screenshot.image.name|
 basename}}/a/td
  /tr
  tr
   tda href={{domain_method}}://{{domain}}
 {{comment.screenshot.get_absolute_url}}img src={{domain_method}}://
 {{domain}}{{comment.get_image_url}} style=border: 1px black solid;
 alt={{comment.screenshot.caption}}/a/td

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at