Re: block files to show in diff?

2013-03-29 Thread Christian Hammond
Hi,

What version of Review Board are you using? More recent versions should be a 
lot faster with larger files.

Christian


On Mar 29, 2013, at 7:28, ferenc.eng...@gmail.com wrote:

 Hi all,
 
 In our project, the language PO files of the project are stored together with 
 the project source in the same repo. The PO files' size are 1MB each, and we 
 have 12 such PO files. Our process requires that the new strings going into 
 PO files must be reviewed, so at least one of the PO files must be shown on 
 the rev. board.
 
 The problem is, that although the diff itself is small (containing only the 
 new strings), the total size of 12 x 1MB of these PO files cause performance 
 problems. The best would be if reviewboard would support on-demand loading of 
 the files when showing the diff -- i.e., until the user does not want to 
 check the diff in a particular file, it should not load that file. The second 
 best would be if I could block 11 out of the 12 files to not show up on the 
 review board.
 
 I was thinking on playing with the binary flag of the files, but I need the 
 textual merge inside the SCM, naturally.
 
 Do you have any idea how to handle this situation?
 
 We are using reviewboard with mercurial SCM.
 
 Thanks a lot,
 Ferenc
 -- 
 Want to help the Review Board project? Donate today at 
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to 
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at 
 http://groups.google.com/group/reviewboard?hl=en
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/groups/opt_out.
  
  

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




Re: block files to show in diff?

2013-03-29 Thread ferenc . engard
It's version 1.5.5, but I see no chance to upgrade it in the foreseeable 
future. Big company, slow company. :(

The newer versions do not load the big files by default?

On Friday, March 29, 2013 8:49:25 PM UTC+1, Christian Hammond wrote:

 Hi,

 What version of Review Board are you using? More recent versions should be 
 a lot faster with larger files.

 Christian


 On Mar 29, 2013, at 7:28, ferenc...@gmail.com javascript: wrote:

 Hi all,

 In our project, the language PO files of the project are stored together 
 with the project source in the same repo. The PO files' size are 1MB 
 each, and we have 12 such PO files. Our process requires that the new 
 strings going into PO files must be reviewed, so at least one of the PO 
 files must be shown on the rev. board.

 The problem is, that although the diff itself is small (containing only 
 the new strings), the total size of 12 x 1MB of these PO files cause 
 performance problems. The best would be if reviewboard would support 
 on-demand loading of the files when showing the diff -- i.e., until the 
 user does not want to check the diff in a particular file, it should not 
 load that file. The second best would be if I could block 11 out of the 12 
 files to not show up on the review board.

 I was thinking on playing with the binary flag of the files, but I need 
 the textual merge inside the SCM, naturally.

 Do you have any idea how to handle this situation?

 We are using reviewboard with mercurial SCM.

 Thanks a lot,
 Ferenc

 -- 
 Want to help the Review Board project? Donate today at 
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to 
 reviewboard...@googlegroups.com javascript:
 For more options, visit this group at 
 http://groups.google.com/group/reviewboard?hl=en
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/groups/opt_out.
  
  



-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




Re: block files to show in diff?

2013-03-29 Thread Christian Hammond
They do load them, but there's a lot of optimizations around large files. RB 
should easily be able to handle multi-MB files.

Christian


On Mar 29, 2013, at 14:53, ferenc.eng...@gmail.com wrote:

 It's version 1.5.5, but I see no chance to upgrade it in the foreseeable 
 future. Big company, slow company. :(
 
 The newer versions do not load the big files by default?
 
 On Friday, March 29, 2013 8:49:25 PM UTC+1, Christian Hammond wrote:
 
 Hi,
 
 What version of Review Board are you using? More recent versions should be a 
 lot faster with larger files.
 
 Christian
 
 
 On Mar 29, 2013, at 7:28, ferenc...@gmail.com wrote:
 
 Hi all,
 
 In our project, the language PO files of the project are stored together 
 with the project source in the same repo. The PO files' size are 1MB each, 
 and we have 12 such PO files. Our process requires that the new strings 
 going into PO files must be reviewed, so at least one of the PO files must 
 be shown on the rev. board.
 
 The problem is, that although the diff itself is small (containing only the 
 new strings), the total size of 12 x 1MB of these PO files cause 
 performance problems. The best would be if reviewboard would support 
 on-demand loading of the files when showing the diff -- i.e., until the 
 user does not want to check the diff in a particular file, it should not 
 load that file. The second best would be if I could block 11 out of the 12 
 files to not show up on the review board.
 
 I was thinking on playing with the binary flag of the files, but I need the 
 textual merge inside the SCM, naturally.
 
 Do you have any idea how to handle this situation?
 
 We are using reviewboard with mercurial SCM.
 
 Thanks a lot,
 Ferenc
 -- 
 Want to help the Review Board project? Donate today at 
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to 
 reviewboard...@googlegroups.com
 For more options, visit this group at 
 http://groups.google.com/group/reviewboard?hl=en
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com.
 For more options, visit https://groups.google.com/groups/opt_out.
 
 -- 
 Want to help the Review Board project? Donate today at 
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to 
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at 
 http://groups.google.com/group/reviewboard?hl=en
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/groups/opt_out.
  
  

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.