diff between updates?
Hi, I'm a new user to RB. I submitted a cr request, published it, and someone gave me some comments. I took some of those and updated my working copy. Then submitted an update diff (using post-review -r number). Is there a way to see the changes I made after between the two submits? This would be a really great feature to have, and I'd be surprised if it weren't there. Daniel --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: diff between updates?
Click View Diff. There should be a list of revisions posted. The second row is for showing differences between two revisions (the current one and whichever one you select). These can be commented on like normal diffs. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Tue, Jul 14, 2009 at 1:39 PM, Daniel Wong allyourc...@gmail.com wrote: Hi, I'm a new user to RB. I submitted a cr request, published it, and someone gave me some comments. I took some of those and updated my working copy. Then submitted an update diff (using post-review -r number). Is there a way to see the changes I made after between the two submits? This would be a really great feature to have, and I'd be surprised if it weren't there. Daniel --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: diff between updates?
Thanks. One of my colleagues showed me that after I sent this message. Unfortunately, I ran into problems with some files. As best as I can figure, those files files either: 1. had no diff between r1 and r2, or 2. there was a diff between base and r2 but no diff between base and r1. We're using an older version of RB (I'm told it was installed in Dec), so upgrading will probably fix the problem. On Jul 14, 2:11 pm, Christian Hammond chip...@chipx86.com wrote: Click View Diff. There should be a list of revisions posted. The second row is for showing differences between two revisions (the current one and whichever one you select). These can be commented on like normal diffs. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Tue, Jul 14, 2009 at 1:39 PM, Daniel Wong allyourc...@gmail.com wrote: Hi, I'm a new user to RB. I submitted a cr request, published it, and someone gave me some comments. I took some of those and updated my working copy. Then submitted an update diff (using post-review -r number). Is there a way to see the changes I made after between the two submits? This would be a really great feature to have, and I'd be surprised if it weren't there. Daniel --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: diff between updates?
A lot of fixes for interdiffs have gone in since December. If you hit any major issues with 1.0, we'll be glad to take a look at it for a point release. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Tue, Jul 14, 2009 at 2:31 PM, Daniel Wong allyourc...@gmail.com wrote: Thanks. One of my colleagues showed me that after I sent this message. Unfortunately, I ran into problems with some files. As best as I can figure, those files files either: 1. had no diff between r1 and r2, or 2. there was a diff between base and r2 but no diff between base and r1. We're using an older version of RB (I'm told it was installed in Dec), so upgrading will probably fix the problem. On Jul 14, 2:11 pm, Christian Hammond chip...@chipx86.com wrote: Click View Diff. There should be a list of revisions posted. The second row is for showing differences between two revisions (the current one and whichever one you select). These can be commented on like normal diffs. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Tue, Jul 14, 2009 at 1:39 PM, Daniel Wong allyourc...@gmail.com wrote: Hi, I'm a new user to RB. I submitted a cr request, published it, and someone gave me some comments. I took some of those and updated my working copy. Then submitted an update diff (using post-review -r number). Is there a way to see the changes I made after between the two submits? This would be a really great feature to have, and I'd be surprised if it weren't there. Daniel --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
