Re: Change in LDAP authentication behavior in 1.7.14 breaks environments that don't allow anonymous searches

2013-11-14 Thread Daniel Kan
David, Sorry for the massive delay! I've finally posted it at https://reviews.reviewboard.org/r/4953/. On Friday, October 18, 2013 1:51:59 AM UTC-7, David Trowbridge wrote: Daniel, I'd suggest making a quick clone of the reviewboard repository, making your change, and then posting your

Re: Change in LDAP authentication behavior in 1.7.14 breaks environments that don't allow anonymous searches

2013-10-18 Thread David Trowbridge
Daniel, I'd suggest making a quick clone of the reviewboard repository, making your change, and then posting your diff against the reviewboard repository by either creating a diff manually (git diff --full-index) or using rbt post. -David On Tue, Oct 15, 2013 at 4:57 PM, Daniel Kan

Re: Change in LDAP authentication behavior in 1.7.14 breaks environments that don't allow anonymous searches

2013-10-15 Thread Daniel Kan
David, Sure, although I'm not sure how to post a bare diff there without specifying a repository. Is that possible? Thanks! On Thursday, September 26, 2013 2:43:43 PM UTC-7, David Trowbridge wrote: Would you mind submitting your change to http://reviews.reviewboard.org/ ? Thanks! -David

Re: Change in LDAP authentication behavior in 1.7.14 breaks environments that don't allow anonymous searches

2013-09-26 Thread David Trowbridge
Would you mind submitting your change to http://reviews.reviewboard.org/ ? Thanks! -David On Tue, Sep 24, 2013 at 7:32 PM, Daniel Kan danielk...@gmail.com wrote: I am using RB 1.7.x with an LDAP authentication backend and it's been working fine up through 1.7.13. With 1.7.14, the

Change in LDAP authentication behavior in 1.7.14 breaks environments that don't allow anonymous searches

2013-09-24 Thread Daniel Kan
I am using RB 1.7.x with an LDAP authentication backend and it's been working fine up through 1.7.13. With 1.7.14, the authentication mechanism no longer works in my environment. After some digging, it appears that there was a change in reviewboard/accounts/backends.py to search anonymously

Re: Change in LDAP authentication behavior in 1.7.14 breaks environments that don't allow anonymous searches

2013-09-24 Thread Eric Johnson
I found that it was easiest to simply copy the code from the authenticator closest to what I want,ed and then customize as needed. Then select the new authenticator as your custom option. Eric On Sep 24, 2013, at 4:32 PM, Daniel Kan danielk...@gmail.com wrote: I am using RB 1.7.x with an