Looks like a fine fix. Can you post this on reviews.reviewboard.org?
Thanks!
-David
On Wed, Sep 9, 2015 at 10:33 AM Alexey Neyman
wrote:
> FWIW, converting an iterator to list explicitly seems to help. Changed
> this line:
>
> return
FWIW, converting an iterator to list explicitly seems to help. Changed this
line:
return json.dumps(review_ui.serialize_comments(
file_attachment.get_comments()))
to this
return json.dumps(list(review_ui.serialize_comments(
file_attachment.get_comments(
no crash
This is actually already fixed for 2.0.20, unless I missed something big.
Planning a release in the next few days.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - https://www.reviewboard.org
Beanbag, Inc. - https://www.beanbaginc.com
On Wed, Sep 9, 2015 at 11:58 AM, David
Hi all,
We have a "Something broke (Error 500)" while trying to access one of the
review requests. I am pretty sure it was displayed fine previously at some
point, but at some point stopped working. I suspect the 2.0.19 update is
the culprit, as this last call in the stack trace