I also hit this problem when using SVN 1.10.
and have created a bug ticket:
https://hellosplat.com/s/beanbag/tickets/4750/
In additional to the display issue,
rbt patch also would incorrectly patching the regular text file (if change
contains binary file),
and resulting svn property conflicts for the regular text file.
Rick
On Thursday, September 27, 2018 at 11:55:46 AM UTC-7, Kevin Yu wrote:
>
> Hi,
>
> I noticed when I upgraded Subversion to 1.10, Reviewboard stopped
> displaying binary files on Diff GUI.
>
>Index: /abc/branches/3.x/3.0/trunk/cooked/basepkgs/abc.pkg
>
>
> ===
>
> Cannot display: file marked as a binary type.
>
> svn:mime-type = application/octet-stream
>
>
>
> Property changes on:
> cooked/basepkgs/abc.pkg
>
> ___
>
> Added: svn:mime-type
>
> ## -0,0 +1 ##
>
> +application/octet-stream
>
> \ No newline at end of property
>
>
>
> From SVN 1.9 "rbt diff" output, I have:
>
>
>
> Index: /abc/branches/3.x/3.0/trunk/cooked/basepkgs/abc.pkg
>
> ===
>
> Cannot display: file marked as a binary type.
>
> svn:mime-type = application/octet-stream
>
> Index:
> /abc/branches/3.x/3.0/trunk/cooked/basepkgs/abc.pkg
>
> ===
>
> ---
> /abc/branches/3.x/3.0/trunk/cooked/basepkgs/abc.pkg (nonexistent)+++
> /abc/branches/3.x/3.0/trunk/cooked/basepkgs/abc.pkg (working copy)
>
>
>
> Property changes on:
> cooked/basepkgs/abc.pkg
>
> ___
>
> Added: svn:mime-type
>
> ## -0,0 +1 ##
>
> +application/octet-stream
>
> \ No newline at end of property
>
> In this case, abc.pkg would not show up on the Diff GUI. I suspect it has
> to do with the binary format change in diff in SVN 1.10.2.
>
--
Supercharge your Review Board with Power Pack:
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons:
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
