Ok.
It looks like I found the issue.
I am doing query on incorrect table..
Let me try this out.
On Jan 29, 2:22 pm, Christian Hammond chip...@chipx86.com wrote:
Hi,
I'd love to provide a patch, except I don't think Review Board is broken.
This works fine from what I can tell, and the code
so, what is the diff between ship_it and shipit_count?
If there is at-least one ship it marked, the value of ship_it should
not be one?
I understand that ship_it is providing 0 or 1 only. It is not the
actual count.
Just want to understand why if the review is approved, ship_it is
still zero?
ship_it is a flag on a review indicating whether or not that particular
review says that the review request is, in the reviewer's opinion, ready to
be shipped.
shipit_count on the Review Request is a counter of the total number of
reviews made on that review request where ship_it=1.
If the
Chris.
Here is what happening.
Reviewer mark the review Ship It.
In the night, I generate the report saying how many reviews are
apprved or how many are pending etc.
I create the query and get the data of SHIP IT counter:
my $query =
SELECT r1.id, submitter_id, r2.username, r2.first_name,
Hi,
I'd love to provide a patch, except I don't think Review Board is broken.
This works fine from what I can tell, and the code has not changed since we
introduced it.
I'm not convinced the query is correct, though. That ship_it column is not a
counter. It's a boolean flag, meaning that you'll
Hello,
For one of our user, he does have active account and when he approves
the review, the ship it counter is still zero.
Why this is happening?
When I debug this, I found that the user did logged in RB today but in
the Submitters list, it is showing his last login as 2009-12-17.
Is this
So, they click Ship It, publish the review, and you see the review with the
Ship It but you don't see that on the dashboard?
This sounds like the code for bumping up the Ship It counter
(ReviewRequest.increment_ship_it in reviewboard/reviews/models.py) is not
working correctly. What database are
