Hi Bruce,
You may have seen a couple other threads today on the list about Mercurial and
issues with revisions. Based on those, and the testing you’ve done, do you
think this patch would fix those issues?
Christian
--
Christian Hammond - christ...@beanbaginc.com
Review Board -
Christian,
No, my patch (also posted at https://reviews.reviewboard.org/r/5965/) only
appears to fix the problem with parent diffs: I've had users complaining
today both that valid patches won't upload or that the diff viewer doesn't
work for existing reviews (FileNotFoundError: The file
I think the following should fix the problem: if we can't fetch a file
using the revision recorded in the diff, try using the base commit id
instead:
diff --git a/reviewboard/scmtools/models.py b/reviewboard/scmtools/models.py
index 7f1dd43..820814b 100644
--- a/reviewboard/scmtools/models.py
+++
In 1.7, it was possible to generate a review request of the topmost
changeset patch1 - e.g.:
hg qapplied
patch1
patch2
patch3
patch4
... by creating a diff of patch2-patch4 and uploading it via the web
interface as the parent diff. How do I do the same in 2.x using 'rbt
post'? Uploading the
I don’t know of anything on the RB side that would have changed here. It should
just accept what’s given by the client. Were you able to do it before with
RBTools?
If you’re just trying to post the top-most commit, then (at least with Git)
you’d do:
$ rbt post HEAD
Replace HEAD with
I don't know if it used to work with RBTools, but people have said it used
to work with 'hg postreview -m qparent'.
Running 'rbt post tip' or 'rbt post --parent=qparent tip' results in Review
Board saying it can't display the diff where there are changes in a file
which also has changes in other
