Re: post-review error with svn and gnu diffutils (new review with an added binary file)

2010-08-23 Thread Timothy Pinet
Thanks for the suggestion. I downloaded rbtools 0.2 stable from http://github.com/reviewboard/rbtools, made my changes to postreview.py, and reinstalled the package using python setup.py install at the rbtool root. In postreview.py I changed the svn diff --diff-cmd=diff to svn diff

Re: post-review error with svn and gnu diffutils (new review with an added binary file)

2010-08-20 Thread Timothy Pinet
In which file does reviewboard invoke the svn diff --diff-cmd=diff command? I have been looking but can not find it. I then thought that you probably call the pysvn lib for this. I checked the pysvn documentation (http://pysvn.tigris.org/docs/ pysvn_prog_ref.html#pysvn_client_diff) and there is a

Re: post-review error with svn and gnu diffutils (new review with an added binary file)

2010-08-20 Thread Chris Clark
Timothy Pinet wrote: In which file does reviewboard invoke the svn diff --diff-cmd=diff command? I have been looking but can not find it. I then thought that you probably call the pysvn lib for this. I checked the pysvn documentation (http://pysvn.tigris.org/docs/

Re: post-review error with svn and gnu diffutils (new review with an added binary file)

2010-08-20 Thread Timothy Pinet
I wanted to check post-review however since I am on Windows my Python26\Scripts\post-review.exe is a compiled executable and not a python file. Would it be enough to grab the post-review.py from the repo and delete the exe? Thanks, Tim On Aug 20, 12:54 pm, Chris Clark chris.cl...@ingres.com

Re: post-review error with svn and gnu diffutils (new review with an added binary file)

2010-08-20 Thread Chris Clark
Timothy Pinet wrote: I wanted to check post-review however since I am on Windows my Python26\Scripts\post-review.exe is a compiled executable and not a python file. Would it be enough to grab the post-review.py from the repo and delete the exe? Not with the current version. There are a few

Re: post-review error with svn and gnu diffutils (new review with an added binary file)

2010-08-19 Thread Timothy Pinet
Alternatively, the diffutils docs (http://www.gnu.org/software/hello/ manual/diff.html#Binary) state: Differing binary files are considered to cause trouble because the resulting diff output does not capture all the differences. This trouble causes diff to exit with status 2. However, this

RE: post-review error with svn and gnu diffutils (new review with an added binary file)

2010-08-19 Thread Timothy Pinet
In which file would I look to remove the param? I am using a Windows environment. Thanks, Tim From: reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com] On Behalf Of Christian Hammond Sent: August-19-10 8:43 PM To: reviewboard@googlegroups.com Subject: Re: post-review error

post-review error with svn and gnu diffutils (new review with an added binary file)

2010-08-18 Thread tpinet
Good day! I am encountering an error when using post-review with a changeset range in a very particular scenario. I am using Subversion as my repo. There were a group of new files (one was a binary image) svn added to the repository in one of the changesets. When svn attempts its diff all of the