some post-review requests succeed, some fail -- same repository user
Hi, everyone,
For the same review board instance, same repository, same user, I get
post-review errors for some review requests, but not for others. (I
have included debug output below.)
It seems like everything goes well until the actual uploading of the
diff. Then it fails with a Network connection closed unexpectedly
error message.
But as far as I can tell, there's no difference in the two requests
besides the contents of the diff itself. The diffs themselves are
accurate.
The errors are consistent: Creating a review request from certain
revisions always fails, but from other revisions always succeeds.
I have dumped and examined the http requests with tcpdump, and I
couldn't see any difference in the requests besides the actual content
of the diffs. I didn't notice any special content in the failing
request (i.e., no special characters or binary data).
Hoping somebody can help!
Sincerely,
Rob
=
Here's debug output for a failure:
/usr/local/bin/post-review --server=http://.com/ --summary=[cmp]
Checkin #33714 by robin --submit-as=robin --username=Otto --
password= --repository-url=svn+ssh://r...@.com/cmp --revision-
range=33713:33714 --description-file=description.txt --debug
svn info svn+ssh://r...@.com/cmp
diff --version
repository info: Path: svn+ssh://r...@.com/cmp, Base path: /, Supports
changesets: False
svn diff --diff-cmd=diff svn+ssh://r...@.com/cmp/@33713
svn+ssh://r...@.com/cmp/@33714
Looking for '.com /' cookie in /home/robc/.post-review-cookies.txt
Loaded valid cookie -- no login required
HTTP GETting /api/json/repositories/
HTTP GETting /api/json/repositories/1/info/
Got API Error 210 (HTTP code 200): There was an error fetching extended
information for this repository.
Error data: {u'stat': u'fail', u'err': {u'msg': u'There was an error
fetching extended information for this repository.', u'code': 210}}
HTTP GETting /api/json/repositories/2/info/
Got API Error 210 (HTTP code 200): There was an error fetching extended
information for this repository.
Error data: {u'stat': u'fail', u'err': {u'msg': u'There was an error
fetching extended information for this repository.', u'code': 210}}
HTTP GETting /api/json/repositories/3/info/
Got API Error 210 (HTTP code 200): There was an error fetching extended
information for this repository.
Error data: {u'stat': u'fail', u'err': {u'msg': u'There was an error
fetching extended information for this repository.', u'code': 210}}
HTTP GETting /api/json/repositories/4/info/
Got API Error 210 (HTTP code 200): There was an error fetching extended
information for this repository.
Error data: {u'stat': u'fail', u'err': {u'msg': u'There was an error
fetching extended information for this repository.', u'code': 210}}
Attempting to create review request on svn+ssh://r...@.com/cmp for None
Submitting the review request as robin
HTTP POSTing to http://.com/api/json/reviewrequests/new/:
{'repository_path': 'svn+ssh://r...@.com/cmp', 'submit_as': 'robin'}
Review request created
Attempting to set field 'summary' to '[cmp] Checkin #33714 by robin' for
review request '47'
HTTP POSTing to http://.com/api/json/reviewrequests/47/draft/set/:
{'summary': '[cmp] Checkin #33714 by robin'}
Attempting to set field 'description' to 'r33714 | robin | 2010-06-03
07:37:10 -0400 (Thu, 03 Jun 2010) | 1 line
Changed paths:
M /channels//-main/trunk/solr/-schema.xml
Added a field to store major groups **REVIEW**
' for review request '47'
HTTP POSTing to http://.com/api/json/reviewrequests/47/draft/set/:
{'description': 'r33714 | robin | 2010-06-03 07:37:10 -0400 (Thu, 03 Jun
2010) | 1 line\nChanged paths:\n M
/channels//-main/trunk/solr/-schema.xml\n\nAdded a field to
store major groups **REVIEW**\n'}
Uploading diff, size: 985
HTTP POSTing to http://.com/api/json/reviewrequests/47/diff/new/:
{'basedir': '/'}
Got API Error 105 (HTTP code 200): One or more fields had errors
Error data: {u'fields': {u'path': [u'Network connection closed
unexpectedly']}, u'stat': u'fail', u'err': {u'msg': u'One or more fields
had errors', u'code': 105}}
Error uploading diff
The generated diff file was empty. This usually means no files were
modified in this change.
Try running with --output-diff and --debug for more information.
Your review request still exists, but the diff is not attached.
=
And here's a success:
/usr/local/bin/post-review --server=http://.com/ --summary=[cmp]
Checkin #33715 by robin --submit-as=robin --username=Otto --
password= --repository-url=svn+ssh://r...@.com/cmp --revision-
range=33714:33715 --description-file=description.txt --debug
svn info svn+ssh://r...@.com/cmp
diff --version
repository info: Path: svn+ssh://r...@.com/cmp, Base path: /, Supports
changesets: False
svn diff --diff-cmd=diff svn+ssh://r...@.com/cmp/@33714
Re: some post-review requests succeed, some fail -- same repository user
Sounds like something is failing when Review Board talks to the repository.
This is a Subversion repository? What happens if you do a `svn cat` on that
file with that revision from the Review Board server?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Thu, Jun 3, 2010 at 9:18 AM, Robert Cabacungan
robert.cabacun...@gmail.com wrote:
Hi, everyone,
For the same review board instance, same repository, same user, I get
post-review errors for some review requests, but not for others. (I
have included debug output below.)
It seems like everything goes well until the actual uploading of the
diff. Then it fails with a Network connection closed unexpectedly
error message.
But as far as I can tell, there's no difference in the two requests
besides the contents of the diff itself. The diffs themselves are
accurate.
The errors are consistent: Creating a review request from certain
revisions always fails, but from other revisions always succeeds.
I have dumped and examined the http requests with tcpdump, and I
couldn't see any difference in the requests besides the actual content
of the diffs. I didn't notice any special content in the failing
request (i.e., no special characters or binary data).
Hoping somebody can help!
Sincerely,
Rob
=
Here's debug output for a failure:
/usr/local/bin/post-review --server=http://.com/ --summary=[cmp]
Checkin #33714 by robin --submit-as=robin --username=Otto --
password= --repository-url=svn+ssh://r...@.com/cmp --revision-
range=33713:33714 --description-file=description.txt --debug
svn info svn+ssh://r...@.com/cmp
diff --version
repository info: Path: svn+ssh://r...@.com/cmp, Base path: /,
Supports changesets: False
svn diff --diff-cmd=diff svn+ssh://r...@.com/cmp/@33713
svn+ssh://r...@.com/cmp/@33714
Looking for '.com /' cookie in /home/robc/.post-review-cookies.txt
Loaded valid cookie -- no login required
HTTP GETting /api/json/repositories/
HTTP GETting /api/json/repositories/1/info/
Got API Error 210 (HTTP code 200): There was an error fetching extended
information for this repository.
Error data: {u'stat': u'fail', u'err': {u'msg': u'There was an error
fetching extended information for this repository.', u'code': 210}}
HTTP GETting /api/json/repositories/2/info/
Got API Error 210 (HTTP code 200): There was an error fetching extended
information for this repository.
Error data: {u'stat': u'fail', u'err': {u'msg': u'There was an error
fetching extended information for this repository.', u'code': 210}}
HTTP GETting /api/json/repositories/3/info/
Got API Error 210 (HTTP code 200): There was an error fetching extended
information for this repository.
Error data: {u'stat': u'fail', u'err': {u'msg': u'There was an error
fetching extended information for this repository.', u'code': 210}}
HTTP GETting /api/json/repositories/4/info/
Got API Error 210 (HTTP code 200): There was an error fetching extended
information for this repository.
Error data: {u'stat': u'fail', u'err': {u'msg': u'There was an error
fetching extended information for this repository.', u'code': 210}}
Attempting to create review request on svn+ssh://r...@.com/cmp for
None
Submitting the review request as robin
HTTP POSTing to http://.com/api/json/reviewrequests/new/:
{'repository_path': 'svn+ssh://r...@.com/cmp', 'submit_as': 'robin'}
Review request created
Attempting to set field 'summary' to '[cmp] Checkin #33714 by robin'
for review request '47'
HTTP POSTing to http://.com/api/json/reviewrequests/47/draft/set/:
{'summary': '[cmp] Checkin #33714 by robin'}
Attempting to set field 'description' to 'r33714 | robin | 2010-06-03
07:37:10 -0400 (Thu, 03 Jun 2010) | 1 line
Changed paths:
M /channels//-main/trunk/solr/-schema.xml
Added a field to store major groups **REVIEW**
' for review request '47'
HTTP POSTing to http://.com/api/json/reviewrequests/47/draft/set/:
{'description': 'r33714 | robin | 2010-06-03 07:37:10 -0400 (Thu, 03 Jun
2010) | 1 line\nChanged paths:\n M
/channels//-main/trunk/solr/-schema.xml\n\nAdded a field to
store major groups **REVIEW**\n'}
Uploading diff, size: 985
HTTP POSTing to http://.com/api/json/reviewrequests/47/diff/new/:
{'basedir': '/'}
Got API Error 105 (HTTP code 200): One or more fields had errors
Error data: {u'fields': {u'path': [u'Network connection closed
unexpectedly']}, u'stat': u'fail', u'err': {u'msg': u'One or more fields had
errors', u'code': 105}}
Error uploading diff
The generated diff file was empty. This usually means no files were
modified in this change.
Try running with --output-diff and --debug for more information.
Your review request still exists, but the diff is not attached.
=
And here's a success:
/usr/local/bin/post-review
Re: some post-review requests succeed, some fail -- same repository user
I get:
svn: Network connection closed unexpectedly
Thank you! I kept debugging the post-review side of it, but it looks
like something's wrong from the server's perspective.
Thanks a lot!
Rob
On Jun 3, 1:50 pm, Christian Hammond chip...@chipx86.com wrote:
Sounds like something is failing when Review Board talks to the repository.
This is a Subversion repository? What happens if you do a `svn cat` on that
file with that revision from the Review Board server?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Thu, Jun 3, 2010 at 9:18 AM, Robert Cabacungan
robert.cabacun...@gmail.com wrote:
Hi, everyone,
For the same review board instance, same repository, same user, I get
post-review errors for some review requests, but not for others. (I
have included debug output below.)
It seems like everything goes well until the actual uploading of the
diff. Then it fails with a Network connection closed unexpectedly
error message.
But as far as I can tell, there's no difference in the two requests
besides the contents of the diff itself. The diffs themselves are
accurate.
The errors are consistent: Creating a review request from certain
revisions always fails, but from other revisions always succeeds.
I have dumped and examined the http requests with tcpdump, and I
couldn't see any difference in the requests besides the actual content
of the diffs. I didn't notice any special content in the failing
request (i.e., no special characters or binary data).
Hoping somebody can help!
Sincerely,
Rob
=
Here's debug output for a failure:
/usr/local/bin/post-review --server=http://.com/--summary=[cmp]
Checkin #33714 by robin --submit-as=robin --username=Otto --
password= --repository-url=svn+ssh://r...@.com/cmp --revision-
range=33713:33714 --description-file=description.txt --debug
svn info svn+ssh://r...@.com/cmp
diff --version
repository info: Path: svn+ssh://r...@.com/cmp, Base path: /,
Supports changesets: False
svn diff --diff-cmd=diff svn+ssh://r...@.com/cmp/@33713
svn+ssh://r...@.com/cmp/@33714
Looking for '.com /' cookie in /home/robc/.post-review-cookies.txt
Loaded valid cookie -- no login required
HTTP GETting /api/json/repositories/
HTTP GETting /api/json/repositories/1/info/
Got API Error 210 (HTTP code 200): There was an error fetching extended
information for this repository.
Error data: {u'stat': u'fail', u'err': {u'msg': u'There was an error
fetching extended information for this repository.', u'code': 210}}
HTTP GETting /api/json/repositories/2/info/
Got API Error 210 (HTTP code 200): There was an error fetching extended
information for this repository.
Error data: {u'stat': u'fail', u'err': {u'msg': u'There was an error
fetching extended information for this repository.', u'code': 210}}
HTTP GETting /api/json/repositories/3/info/
Got API Error 210 (HTTP code 200): There was an error fetching extended
information for this repository.
Error data: {u'stat': u'fail', u'err': {u'msg': u'There was an error
fetching extended information for this repository.', u'code': 210}}
HTTP GETting /api/json/repositories/4/info/
Got API Error 210 (HTTP code 200): There was an error fetching extended
information for this repository.
Error data: {u'stat': u'fail', u'err': {u'msg': u'There was an error
fetching extended information for this repository.', u'code': 210}}
Attempting to create review request on svn+ssh://r...@.com/cmp for
None
Submitting the review request as robin
HTTP POSTing tohttp://.com/api/json/reviewrequests/new/:
{'repository_path': 'svn+ssh://r...@.com/cmp', 'submit_as': 'robin'}
Review request created
Attempting to set field 'summary' to '[cmp] Checkin #33714 by robin'
for review request '47'
HTTP POSTing tohttp://.com/api/json/reviewrequests/47/draft/set/:
{'summary': '[cmp] Checkin #33714 by robin'}
Attempting to set field 'description' to 'r33714 | robin | 2010-06-03
07:37:10 -0400 (Thu, 03 Jun 2010) | 1 line
Changed paths:
M /channels//-main/trunk/solr/-schema.xml
Added a field to store major groups **REVIEW**
' for review request '47'
HTTP POSTing tohttp://.com/api/json/reviewrequests/47/draft/set/:
{'description': 'r33714 | robin | 2010-06-03 07:37:10 -0400 (Thu, 03 Jun
2010) | 1 line\nChanged paths:\n M
/channels//-main/trunk/solr/-schema.xml\n\nAdded a field to
store major groups **REVIEW**\n'}
Uploading diff, size: 985
HTTP POSTing tohttp://.com/api/json/reviewrequests/47/diff/new/:
{'basedir': '/'}
Got API Error 105 (HTTP code 200): One or more fields had errors
Error data: {u'fields': {u'path': [u'Network connection closed
unexpectedly']}, u'stat': u'fail', u'err': {u'msg': u'One or more fields had
