Re: Issue 3474 in reviewboard: Missing OK/Cancel buttons when editing summary

2014-07-10 Thread reviewboard
Updates: Labels: Usability Comment #2 on issue 3474 by trowb...@gmail.com: Missing OK/Cancel buttons when editing summary http://code.google.com/p/reviewboard/issues/detail?id=3474 This does seem to be a usability issue that keeps popping up. -- You received this message because

Re: Issue 3456 in reviewboard: Following clicking publish an erroroneous message stating a description is required is displayed

2014-07-10 Thread reviewboard
Comment #3 on issue 3456 by trowb...@gmail.com: Following clicking publish an erroroneous message stating a description is required is displayed http://code.google.com/p/reviewboard/issues/detail?id=3456 I think the issue is that you're not saving any of the fields. We had some code that

Re: Issue 3456 in reviewboard: Following clicking publish an erroroneous message stating a description is required is displayed

2014-07-10 Thread reviewboard
Comment #4 on issue 3456 by trowb...@gmail.com: Following clicking publish an erroroneous message stating a description is required is displayed http://code.google.com/p/reviewboard/issues/detail?id=3456 Also, can you check the javascript console in your browser and the reviewboard log for

Re: Issue 3442 in reviewboard: Cycle in Depends On causes Review Request Drafts to lock out of publishing

2014-07-10 Thread reviewboard
Updates: Status: PendingReview Owner: trowb...@gmail.com Labels: Project-Djblets Component-API Comment #1 on issue 3442 by trowb...@gmail.com: Cycle in Depends On causes Review Request Drafts to lock out of publishing

Re: Issue 3451 in reviewboard: Server Error when viewing specific diff

2014-07-10 Thread reviewboard
Updates: Status: PendingReview Owner: trowb...@gmail.com Labels: Component-ChangeDescriptions Comment #3 on issue 3451 by trowb...@gmail.com: Server Error when viewing specific diff http://code.google.com/p/reviewboard/issues/detail?id=3451 (No comment was entered for

Re: Issue 3456 in reviewboard: Following clicking publish an erroroneous message stating a description is required is displayed

2014-07-10 Thread reviewboard
Comment #5 on issue 3456 by buffa...@gmail.com: Following clicking publish an erroroneous message stating a description is required is displayed http://code.google.com/p/reviewboard/issues/detail?id=3456 What I have found is that after I click publish, and click X to close the popup dialog,

Re: Issue 3451 in reviewboard: Server Error when viewing specific diff

2014-07-10 Thread reviewboard
Updates: Status: Fixed Comment #4 on issue 3451 by trowb...@gmail.com: Server Error when viewing specific diff http://code.google.com/p/reviewboard/issues/detail?id=3451 Fixed in release-2.0.x (915d270). Thanks! -- You received this message because this project is configured to send

Re: Issue 3435 in reviewboard: Example crontab shows deprecated index rb-site command

2014-07-10 Thread reviewboard
Updates: Status: PendingReview Owner: trowb...@gmail.com Labels: Project-ReviewBoard Component-RB-Site Comment #2 on issue 3435 by trowb...@gmail.com: Example crontab shows deprecated index rb-site command http://code.google.com/p/reviewboard/issues/detail?id=3435 (No

Re: Issue 3459 in reviewboard: Failed to get repository information( rb 2.1 alpha 0 (dev))

2014-07-10 Thread reviewboard
Updates: Status: NeedInfo Comment #1 on issue 3459 by trowb...@gmail.com: Failed to get repository information( rb 2.1 alpha 0 (dev)) http://code.google.com/p/reviewboard/issues/detail?id=3459 I don't see anything reviewboard-specific in here. Can you confirm that the credentials

Re: Issue 3427 in reviewboard: ValueError: too many values to unpack when upload a pdf file

2014-07-10 Thread reviewboard
Comment #4 on issue 3427 by trowb...@gmail.com: ValueError: too many values to unpack when upload a pdf file http://code.google.com/p/reviewboard/issues/detail?id=3427 Something about those mimetypes is also very wrong. text/text/application/pdf is not a correctly-formatted mimetype. --

Re: Issue 3428 in reviewboard: 'rbt post' should report review id if it creates the review but fails to finish updating it

2014-07-10 Thread reviewboard
Updates: Status: PendingReview Owner: trowb...@gmail.com Labels: Project-RBTools Component-RBTools Comment #1 on issue 3428 by trowb...@gmail.com: 'rbt post' should report review id if it creates the review but fails to finish updating it

Re: Issue 3369 in reviewboard: When I try to add file to a review request, It sends request to download a file file-attachments. If we save, find or close the download file, the upload gets aborted

2014-07-10 Thread reviewboard
Updates: Status: Incomplete Comment #4 on issue 3369 by trowb...@gmail.com: When I try to add file to a review request, It sends request to download a file file-attachments. If we save, find or close the download file, the upload gets aborted. I have attached the file given for

Re: Issue 3376 in reviewboard: RBTools 0.6 - UnicodeEncodeError with ISO-8859-15

2014-07-10 Thread reviewboard
Updates: Status: Incomplete Comment #7 on issue 3376 by trowb...@gmail.com: RBTools 0.6 - UnicodeEncodeError with ISO-8859-15 http://code.google.com/p/reviewboard/issues/detail?id=3376 (No comment was entered for this change.) -- You received this message because this project is

Re: Issue 3393 in reviewboard: Interdiffs are incorrect when new files are added

2014-07-10 Thread reviewboard
Updates: Status: Incomplete Comment #2 on issue 3393 by trowb...@gmail.com: Interdiffs are incorrect when new files are added http://code.google.com/p/reviewboard/issues/detail?id=3393 (No comment was entered for this change.) -- You received this message because this project is

Re: Issue 3386 in reviewboard: Comments on PNG images don't show the image.

2014-07-10 Thread reviewboard
Updates: Status: SetupIssue Comment #8 on issue 3386 by trowb...@gmail.com: Comments on PNG images don't show the image. http://code.google.com/p/reviewboard/issues/detail?id=3386 (No comment was entered for this change.) -- You received this message because this project is

Re: Issue 3398 in reviewboard: Error displaying this diff

2014-07-10 Thread reviewboard
Comment #7 on issue 3398 by trowb...@gmail.com: Error displaying this diff http://code.google.com/p/reviewboard/issues/detail?id=3398 Are the contents of the file that it's trying to patch what you expect? Sometimes hosting services will return an HTTP 200 but the contents will be a random

Re: Issue 3403 in reviewboard: Getting Something Broke error from the server Active Directory authentication with correct password.

2014-07-10 Thread reviewboard
Comment #7 on issue 3403 by trowb...@gmail.com: Getting Something Broke error from the server Active Directory authentication with correct password. http://code.google.com/p/reviewboard/issues/detail?id=3403 I'm not sure when exactly filter_format was introduced (python-ldap isn't great

Re: Issue 3474 in reviewboard: Single-line inline editors without OK/Cancel are confusing for users

2014-07-10 Thread reviewboard
Updates: Summary: Single-line inline editors without OK/Cancel are confusing for users Comment #3 on issue 3474 by trowb...@gmail.com: Single-line inline editors without OK/Cancel are confusing for users http://code.google.com/p/reviewboard/issues/detail?id=3474 (No comment was entered

Re: Issue 3474 in reviewboard: Single-line inline editors without OK/Cancel are confusing for users

2014-07-10 Thread reviewboard
Comment #4 on issue 3474 by trowb...@gmail.com: Single-line inline editors without OK/Cancel are confusing for users http://code.google.com/p/reviewboard/issues/detail?id=3474 Issue 3454 has been merged into this issue. -- You received this message because this project is configured to send

Re: Issue 3454 in reviewboard: Editing caption for uploaded files does not work properly

2014-07-10 Thread reviewboard
Updates: Status: Duplicate Mergedinto: 3474 Comment #4 on issue 3454 by trowb...@gmail.com: Editing caption for uploaded files does not work properly http://code.google.com/p/reviewboard/issues/detail?id=3454 I'm going to merge this into a more general bug -- You received

Re: Issue 3446 in reviewboard: ReviewRequestFieldsHook and email notfications

2014-07-10 Thread reviewboard
Updates: Labels: Project-ReviewBoard Component-Extensions Component-EMail Comment #3 on issue 3446 by trowb...@gmail.com: ReviewRequestFieldsHook and email notfications http://code.google.com/p/reviewboard/issues/detail?id=3446 (No comment was entered for this change.) -- You

Re: Issue 3452 in reviewboard: RR updated altough no changes made / warn when no changes are made

2014-07-10 Thread reviewboard
Updates: Labels: Component-ChangeDescriptions EasyFix Comment #1 on issue 3452 by trowb...@gmail.com: RR updated altough no changes made / warn when no changes are made http://code.google.com/p/reviewboard/issues/detail?id=3452 (No comment was entered for this change.) -- You

Re: Issue 3411 in reviewboard: favicon not shown in diff view

2014-07-10 Thread reviewboard
Updates: Status: ThirdParty Comment #2 on issue 3411 by trowb...@gmail.com: favicon not shown in diff view http://code.google.com/p/reviewboard/issues/detail?id=3411 This definitely seems to be a bug in Firefox. Other browsers handle this correctly. -- You received this message

Re: Issue 3411 in reviewboard: favicon not shown in diff view

2014-07-10 Thread reviewboard
Comment #3 on issue 3411 by bruce.c...@gmail.com: favicon not shown in diff view http://code.google.com/p/reviewboard/issues/detail?id=3411 Apparently Firefox by default limits favicon sizes to 1KB - see the browser.chrome.image_icon.max_size setting (and

Re: Issue 3411 in reviewboard: favicon not shown in diff view

2014-07-10 Thread reviewboard
Comment #4 on issue 3411 by trowb...@gmail.com: favicon not shown in diff view http://code.google.com/p/reviewboard/issues/detail?id=3411 Huh, interesting. I wonder if there's a way to crush the .ico files to be smaller. If not, we should probably just cut the cord to the past and switch

Re: Issue 3411 in reviewboard: favicon not shown in diff view

2014-07-10 Thread reviewboard
Updates: Status: New Comment #5 on issue 3411 by trowb...@gmail.com: favicon not shown in diff view http://code.google.com/p/reviewboard/issues/detail?id=3411 (No comment was entered for this change.) -- You received this message because this project is configured to send all

Issue 3475 in reviewboard: Make the format/layout used in _extract_commit_message() customizable

2014-07-10 Thread reviewboard
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 3475 by bruce.c...@gmail.com: Make the format/layout used in _extract_commit_message() customizable http://code.google.com/p/reviewboard/issues/detail?id=3475 What version are you running? RBTools 0.6.2 Describe the