Issue 559 in reviewboard: Posting a new diff against a discarded changeset should create a new review request
Issue 559: Posting a new diff against a discarded changeset should create a new review request http://code.google.com/p/reviewboard/issues/detail?id=559 Comment #7 by trowbrds: After discussing this with Christian, I'm going to say that we're not going to change this behavior. If you change the diff on an existing changeset, even if previous review requests are discarded, you may want that history available. If you're making a completely unrelated change, it's appropriate to create a new changeset for it. Issue attribute updates: Status: WontFix -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 559 in reviewboard: Posting a new diff against a discarded changeset should create a new review request
Issue 559: Posting a new diff against a discarded changeset should create a new review request http://code.google.com/p/reviewboard/issues/detail?id=559 Comment #8 by amordkov: Please note that, as per comment #2, the title of the bug should be Posting a new diff against a changeset for which a review request was previously discarded should create a new review request (I don't think I have perms to change the title). It is bad UI to have a 'Discard' button which saves state. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 559 in reviewboard: Posting a new diff against a discarded changeset should create a new review request
Issue 559: Posting a new diff against a discarded changeset should create a new review request http://code.google.com/p/reviewboard/issues/detail?id=559 Comment #9 by chipx86: I may be changing Discard down the road but that's just a label. It's not the same as deleting (admins actually have a special Delete button they can use). We do not destroy history, ever, and so Discard doesn't actually delete anything. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 581 in reviewboard: Dashboard defaults to Incoming Reviews, not last viewed box
Issue 581: Dashboard defaults to Incoming Reviews, not last viewed box http://code.google.com/p/reviewboard/issues/detail?id=581 Comment #2 by trowbrds: Keeping state like this is tricky unless we plumb it through the views somehow. It's really easy for things to get weird if you're working with multiple open windows (bugzilla, anyone?). I wonder if this wouldn't be necessary with batch operations. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 598 in reviewboard: Enhancement: Editing the people field to add reviewers should look at both the user id and First/Last names
Issue 598: Enhancement: Editing the people field to add reviewers should look at both the user id and First/Last names http://code.google.com/p/reviewboard/issues/detail?id=598 Comment #2 by trowbrds: (No comment was entered for this change.) Issue attribute updates: Status: Confirmed -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 581 in reviewboard: Dashboard defaults to Incoming Reviews, not last viewed box
Issue 581: Dashboard defaults to Incoming Reviews, not last viewed box http://code.google.com/p/reviewboard/issues/detail?id=581 Comment #3 by chipx86: Or just store a cookie and return the appropriate view based on that value, making it work like a query parameter. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 559 in reviewboard: Posting a new diff against a discarded changeset should create a new review request
Issue 559: Posting a new diff against a discarded changeset should create a new review request http://code.google.com/p/reviewboard/issues/detail?id=559 Comment #10 by amordkov: I think it's not uncommon for a developer to want to really 'discard' diffs that they had uploaded, so that reviewers would not be presented with multiple revisions of a changeset when only the last one is the one that the developer wished to publish. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
