Issue 687 in reviewboard: Can't edit change description

2008-10-13 Thread codesite-noreply

Issue 687: Can't edit change description
http://code.google.com/p/reviewboard/issues/detail?id=687

New issue report by cuviper:
*NOTE: Do not post confidential information in this bug report.*

What's the URL of the page containing the problem?
/r/id/

What steps will reproduce the problem?
1. Publish a review
2. Change a field and hit enter to save it
3. Try to enter a change description

What is the expected output? What do you see instead?
The change description field appears, but it is not editable.  There's no
pencil icon, and the field itself is just an empty pre/pre

What operating system are you using? What browser?
Firefox 3 and IE6 behave the same.

Please provide any additional information below.

I noticed this snippet in the templates/reviews/review_detail.html:

264 {% if entry.changedesc %}
265   registerEditor('changedescription', true, true);
266 {% endif %}

If I don't have a changedesc yet, then this field doesn't get registered as
an editor.  Later the draft-banner will get shown, but this field is still
just a pre.

I think either the conditional code above needs to be called always, or
else showDraftBanner needs to enable changedescription when it's called.


Issue attributes:
Status: New
Owner: 
Labels: Type-Defect Priority-Medium

-- 
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 640 in reviewboard: Admin-Settings-General-Site Settings-Server adds an extra slash to the end of the url.

2008-10-13 Thread codesite-noreply

Issue 640: Admin-Settings-General-Site Settings-Server adds an extra  
slash to the end of the url.
http://code.google.com/p/reviewboard/issues/detail?id=640

Comment #3 by chipx86:
Fixed in r1531.


Issue attribute updates:
Status: Fixed
Owner: chipx86
Labels: -Priority-Medium Priority-Critical Component-Settings  
Milestone-Release1.0

-- 
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 592 in reviewboard: Clicking: Report bug in reviewboard should open the link in a new window.

2008-10-13 Thread codesite-noreply

Issue 592: Clicking: Report bug in reviewboard should open the link in a  
new window.
http://code.google.com/p/reviewboard/issues/detail?id=592

Comment #3 by chipx86:
The new UI rewrite won't let you navigate a page without confirming, if you  
have an
unsaved textbox somewhere. So the worry is now gone. However, I think  
adding little
new window icons next to Report Bug and such would work to address this.



-- 
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---