Issue 2258 in reviewboard: Allow to postreview read a patch from stdin without --diff-file=-

2011-08-25 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 2258 by albert.n...@gmail.com: Allow to postreview read a patch  
from stdin without --diff-file=-

http://code.google.com/p/reviewboard/issues/detail?id=2258

Using version 0.3.2 executing post-review in a pipe will still force the  
user to use --diff-file=- and act as if it was not in a pipe. That can be  
easily solved by detecting that post-review is being executed in a pipe.


The attached patch fixes the problem. Note that it also removes the  
requirement for the authentication details to be specified in the command  
line.


The patch is useful for us because it allows us to use all the power  
of 'git diff' for uploading the patches.


Attachments:
postreview.diff  771 bytes

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2258 in reviewboard: Allow to postreview read a patch from stdin without --diff-file=-

2011-08-25 Thread reviewboard


Comment #1 on issue 2258 by albert.n...@gmail.com: Allow to postreview read  
a patch from stdin without --diff-file=-

http://code.google.com/p/reviewboard/issues/detail?id=2258

Updated patch.

Attachments:
postreview.diff  771 bytes

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.