Issue 2338 in reviewboard: post-review --revision-range does not work for clearcase
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 2338 by drenna...@gmail.com: post-review --revision-range does
not work for clearcase
http://code.google.com/p/reviewboard/issues/detail?id=2338
* NOTE: Do not post confidential information in this bug report. *
* If you need immediate support, please contact*
* reviewbo...@googlegroups.com *
What version are you running?
RBTools 0.3.4
What's the URL of the page containing the problem?
n/a
What steps will reproduce the problem?
..try with a single revision..
post-review
--revision-range=/vobs/foo/test.py@@/main/mydev/2:/vobs/foo/test.py@@/main/mydev/3
--output-diff
...or multiple revisions..
post-review
--revision-range=/vobs/foo/test.py@@/main/mydev/2:/vobs/foo/test.py@@/main/mydev/3;/vobs/foo/test2.py@@/main/mydev/1:/vobs/foo/test2.py@@/main/mydev/3
--output-diff
What is the expected output? What do you see instead?
Instead of the diffs being generated I get an error saying
There don't seem to be any diffs!
What operating system are you using? What browser?
Centos 5
Please provide any additional information below.
The problem is the diff_between_revisions code in the ClearCaseClient.
According to the docs at
http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/ the
format of --revision-range should be STARTREV:ENDREV
However the code is splitting based on ';' not ':'
1485 def diff_between_revisions(self, revision_range, args,
repository_info):
1486 Performs a diff between passed revisions or branch.
1487
1488 # Convert revision range to list of:
1489 # (previous version, current version) tuples
1490 revision_range = revision_range.split(';')
1491 changeset = zip(revision_range[0::2], revision_range[1::2])
1492
1493 return (self.do_diff(changeset)[0], None)
The other thing is the docs don't mention how to format --revision-range
for more than one revision. Doing
--revision-range=fileAOLDREV:fileANEWREV:fileBOLDREV:fileBNEWREV works but
looks odd.
As a workaround for this bug I have to use ';' to separate the revisions..
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2339 in reviewboard: QPID-3532 Fix the blocking of JMS operations when failover happens
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2339 by alex.ruf...@gmail.com: QPID-3532 Fix the blocking of JMS operations when failover happens http://code.google.com/p/reviewboard/issues/detail?id=2339 https://issues.apache.org/jira/browse/QPID-3532 describes some issues with non-blocking behaviour of 0-10 client failover. This patch makes the 0-10 client hold the failover mutex during the failover. It also alters the Address resolution code to allow resolving addresses after failover and adds some more failover tests (inc ADDR based ones). Additionally, it makes the failover process notify any waiters in the session to abort and let failover proceed as they would otherwise prevent the failover from occurring until they timed out after 60 seconds. This work does not go as far as we would like but still represents a functional improvement to failover. Additional improvements to the client locking model (such as an introduction a single connection lock) will require further iteration. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2340 in reviewboard: Reviewboard posts wrong Diff URL in notification emails
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2340 by goliat...@gmail.com: Reviewboard posts wrong Diff URL in notification emails http://code.google.com/p/reviewboard/issues/detail?id=2340 What version are you running? 1.6.1 What's the URL of the page containing the problem? http://mail.kde.org/pipermail/kde-utils-devel/2011-October/000668.html What steps will reproduce the problem? 1. Make sure, email notification for review requests is enabled 2. Create Review Request What is the expected output? What do you see instead? Reviewboard sends an Email to the configured address containing an url to a diff view. This URL reads: http://git.reviewboard.kde.org/r/102785/diff/diff which gives a 404 error. The URL should read http://git.reviewboard.kde.org/r/102785/diff instead. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2341 in reviewboard: post-review doesn't handle multiple repositories based on the same vob (clearcase)
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 2341 by drenna...@gmail.com: post-review doesn't handle multiple
repositories based on the same vob (clearcase)
http://code.google.com/p/reviewboard/issues/detail?id=2341
What version are you running?
RBTools 0.3.4
What's the URL of the page containing the problem?
n/a
What steps will reproduce the problem?
1. Create 2 repositories A and B based on Clearcase (A followed by B).
Where A and B are based on the same vob however due to the project
configuration (Clearcase UCM) A and B are comprised of different components
found in the same vob.
2. Perform a post-review where the code is only accessible via B.
post-review --revision-range=..etc.. server=..etc..
What is the expected output? What do you see instead?
I expected success, however what I got was..
Got API Error 207 (HTTP code 400): The file was not found in the
repository
Error data:
{'stat': 'fail', 'file': '/view/..etc..@@/main/blah/1', 'err':
{'msg': 'The file was not found in the repository', 'code':
207}, 'revision': '/main/blah/1'
What operating system are you using? What browser?
CentOS 5
Please provide any additional information below.
What I found is the code is picking the repository based on the vob uuid.
So in my case both repositories are a match base on vob uuid, so that's not
enough. It picked the first matching repository (A) when in fact B was the
one I needed to use.
I worked around this by introducing a --repository-name option which takes
the repository name as listed in the reviewboard ui.
--- a/postreview.py
+++ b/postreview.py
@@ -296,6 +296,10 @@ class ClearCaseRepositoryInfo(RepositoryInfo):
if not info or uuid != info['uuid']:
continue
+if options.repository_name and \
+ options.repository_name != repository['name']:
+continue
+
debug('Matching repository uuid:%s with path:%s' %(uuid,
info['repopath']))
return ClearCaseRepositoryInfo(info['repopath'],
@@ -3834,6 +3838,9 @@ def parse_options(args):
paths outside the view). For git, this
specifies
the origin url of the current repository,
overriding the origin url supplied by the git
client.)
+parser.add_option(--repository-name,
+ dest=repository_name, default=None,
+ help=the name for a repository for creating a
diff )
parser.add_option(-d, --debug,
action=store_true, dest=debug, default=DEBUG,
help=display debug output)
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2340 in reviewboard: Reviewboard posts wrong Diff URL in notification emails
Updates: Status: NeedInfo Comment #1 on issue 2340 by chip...@gmail.com: Reviewboard posts wrong Diff URL in notification emails http://code.google.com/p/reviewboard/issues/detail?id=2340 Hmm, we haven't noticed this in our deployments. We use Django to tell us the location of the diff, which should always be a valid path. Do you have any customizations of templates anywhere? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2322 in reviewboard: Unable to post reviews with post-review (0.3.4): can not log in into Reviewboard (1.6.1)
Comment #7 on issue 2322 by teki...@gmail.com: Unable to post reviews with post-review (0.3.4): can not log in into Reviewboard (1.6.1) http://code.google.com/p/reviewboard/issues/detail?id=2322 Workaround: copy the cookie from the browser. A script for OSX: #!/usr/bin/python import plistlib import os import time HOME=os.environ[HOME] COOKIES=plistlib.readPlist(HOME + /Library/Cookies/Cookies.plist) rbs = [x for x in COOKIES if x[Name] == rbsessionid] f = open(HOME + /.post-review-cookies.txt, w) f.write(# Netscape HTTP Cookie File # http://www.netscape.com/newsref/std/cookie_spec.html # This is a generated file! Do not edit. ) for rb in rbs: f.write(%s\tFALSE\t%s\tFALSE\t%d\t%s\t%s\n % (rb[Domain], rb[Path], int(time.mktime(rb[Expires].timetuple())), rb[Name], rb[Value])) f.close() -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
